Tuesday, May 22nd, 2012, 00:03 UTC | ||
[00:03:00] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[00:07:12] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has quit (Ping timeout: 252 seconds) | |
[00:07:55] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
[00:09:12] | brfransen (brfransen!~brfransen@64.179.142.146) has quit () | |
[00:10:05] | brfransen (brfransen!~brfransen@64.179.142.146) has joined #mythtv | |
[00:13:08] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[00:13:43] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[00:34:33] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[00:41:20] | joki (joki!~joki@p54865BB5.dip.t-dialin.net) has quit (Ping timeout: 260 seconds) | |
[00:42:21] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
[00:43:01] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has quit (Ping timeout: 248 seconds) | |
[00:43:12] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
[00:50:10] | joki (joki!~joki@p54865BB5.dip.t-dialin.net) has joined #mythtv | |
[01:00:58] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[01:17:04] | amejia_ (amejia_!~andres@xbmc/staff/amejia) has quit (Quit: Konversation terminated!) | |
[01:18:02] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[01:22:33] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
[01:24:34] | Seeker` (Seeker`!~cjo20@unaffiliated/seeker) has quit (Ping timeout: 252 seconds) | |
[01:25:59] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[01:35:56] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Quit: Body blow! Body blow!) | |
[01:39:29] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[01:43:21] | danielk22 (danielk22!~danielk@96.57.9.142) has quit (Quit: Leaving.) | |
[01:49:00] | ** jya where is danielk22 when you need him ? ** | |
[01:50:28] | jya: | sphery: I'm happy with not stopping on error ; most of the time, simply running the upgrade over would work just fine |
[01:51:01] | jya: | and a few times in the past I added some tables manually so I could test a master version against a stable backend |
[01:51:44] | sphery: | jya: I'm changing it to DROP TABLE IF EXISTS...; CREATE TABLE...; (without IF NOT EXISTS) |
[01:52:01] | jya: | yeah that's fine |
[01:52:11] | jya: | though I'd prefer to drop mysql totally :) |
[01:52:27] | jya: | that's where time and effort should go |
[01:52:32] | sphery: | but any failed DB upgrade is a very bad thing--users should always restore pre-upgrade backup--because there's not transaction support/usage to protect the integrity of the schema/data |
[01:52:56] | sphery: | I'm all for dropping it for embedded mysql |
[01:53:32] | jya: | actually, what I'd really like is dropping the need for an external database , even when embedded in the backend, for settings affecting the frontend only |
[01:54:43] | jya: | doesn't add anything, only means it's a pain to run a myth client on its own… like I run mythavtest for testing. the only settings it ever retrieves are for purely local ones (audio settings, video profile settings etc..) why require an external access to retrieve the settings |
[01:54:57] | jya: | and I see thats the way Torc went: I fully agree with that design decision |
[01:55:22] | jya: | local settings are just that… local |
[02:13:06] | jya: | Beirdo: are you there? |
[02:17:57] | joki (joki!~joki@p54865BB5.dip.t-dialin.net) has quit (Ping timeout: 248 seconds) | |
[02:18:13] | joki (joki!~joki@p54865BB5.dip.t-dialin.net) has joined #mythtv | |
[02:26:27] | Seeker` (Seeker`!~cjo20@host109-154-188-207.range109-154.btcentralplus.com) has joined #mythtv | |
[02:26:27] | Seeker` (Seeker`!~cjo20@unaffiliated/seeker) has joined #mythtv | |
[02:26:27] | Seeker` (Seeker`!~cjo20@host109-154-188-207.range109-154.btcentralplus.com) has quit (Changing host) | |
[02:51:24] | jya: | ah.. I think I know where the problem come from.. |
[02:53:30] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 244 seconds) | |
[02:54:21] | Beirdo: | yeah, I'm here, kinda |
[02:55:12] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
[02:59:16] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[03:03:14] | jya: | Beirdo: I have the h264 decoder crashing here… It's on a SSE3 function, the issue is with the destination buffer not being 16 bytes aligned. |
[03:04:19] | jya: | I have the gutfeel that the problem is in the read ahead buffer, that is allocated with a simple malloc... |
[03:04:47] | jya: | problem is that it crashes differently between fixes/0.25 (16 bytes aligned issue) and master... |
[03:05:25] | jya: | I'll track the fixes/0.25 issue first ; because finding where a buffer is initialised is easier than finding where we write too much into it |
[03:06:43] | Beirdo: | that would be the problem, yes |
[03:07:11] | Beirdo: | it needs to use the libav aligned mallocs or this will happen |
[03:07:14] | jya: | weird that it's not more of a problem if the fix is that simple |
[03:07:24] | Beirdo: | surprised we never hit that before (often) |
[03:08:07] | Beirdo: | unless it's an issue with being at a weird offset within the buffer that only hits for some files |
[03:08:11] | jya: | tbh, the video I'm trying only plays fine in VLC, not even mplayer plays it properly, though it doesn't crash |
[03:08:26] | jya: | they are all mpeg-ts I found using the hls player |
[03:09:30] | jya: | and of course, suddenly everything is playing back fine… sigh… i hate those alignment issue |
[03:11:35] | jya: | rha… I can't reproduce the crash now :( |
[03:13:40] | Beirdo: | but of course |
[03:19:46] | jya: | looking at the avformatdecoder.cpp code in fixes/0.25 |
[03:19:56] | jya: | this doesn't make sense to me.. |
[03:20:05] | jya: | line 4352 … |
[03:21:41] | Beirdo: | what doesn't make sense about { |
[03:21:42] | Beirdo: | ? |
[03:21:44] | jya: | https://github.com/MythTV/mythtv/blob/fixes/0 . . . er.cpp#L4352 |
[03:21:50] | jya: | so we free, then delete? |
[03:22:55] | jya: | shouldn't a packet be created and initialised with av_new_packet ? |
[03:23:39] | jya: | ah never mmind… I see what's going on.. so the problem is elsewhere ... |
[03:23:45] | Beirdo: | k |
[03:23:54] | Beirdo: | sorry, I was looking at master |
[03:24:17] | jya: | Beirdo: it was just happening that I could reproduce the problem more easily with fixes/0.25 |
[03:24:28] | jya: | but of course, it's a pure coincidence as it's an alignment issue |
[03:25:05] | jya: | it's the line chroma_op(dest_cr, src_cr, h->mb_uvlinesize, chroma_height, mx&7, my&7); in libavcodec/h264.c |
[03:25:19] | jya: | src_cr isn't always aligned |
[03:25:28] | jya: | now, need to find where that memory come from |
[03:25:40] | Beirdo: | bonne chance :) |
[03:25:42] | jya: | it's value is src_cr= pic->data[2] + (mx>>3) + (my>>3)*h->mb_uvlinesize; |
[03:25:59] | jya: | which would indicate that there's no way to guarantee it will be 16 bytes aligned |
[03:26:14] | jya: | except that you can't use SSE3 code in that part |
[03:43:34] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
[04:08:40] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
[04:23:48] | jya: | Beirdo: looks like the bug I'm seeing in h264, has been fixed in April... |
[04:23:53] | jya: | another resync ? :) |
[04:24:50] | Beirdo: | ummm, no |
[04:25:07] | Beirdo: | we can cherry pick if we have to |
[04:25:21] | Beirdo: | but one sync per release is the norm :) |
[04:25:32] | Beirdo: | and it's a buttload of work to do a full sync |
[04:33:53] | ThisNewGuy1 (ThisNewGuy1!~doug@pool-74-102-15-78.nwrknj.fios.verizon.net) has quit (Ping timeout: 252 seconds) | |
[04:40:16] | jya: | Beirdo: it's only been 2 months… and the h264 decoder has changed significantly since.. cherry-picking is going to be a pain… as for being the norm … I'm all for trying new things |
[04:40:39] | jya: | anyhow, going to do here a full resync, and see if that fixes my crash |
[04:40:50] | jya: | and we'll assess from there |
[04:42:59] | jya: | I see that you've kept files that aren't in ffmpeg anymore… like x86/cpuid.c |
[04:45:30] | jya: | actually, quite a fair amount of dsp/sse code in x86 … any particular reasons you kept that code ? they all predate the ffmpeg resync in 2010 ! |
[04:45:58] | Beirdo (Beirdo!~gjhurlbu@mythtv/developer/beirdo) has quit (Ping timeout: 265 seconds) | |
[04:46:03] | Beirdo (Beirdo!~gjhurlbu@mythtv/developer/beirdo) has joined #mythtv | |
[04:47:05] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Read error: Operation timed out) | |
[04:50:17] | jya: | Beirdo: I'm pretty sure some of the changes you roll back after the merge are not correct |
[04:53:47] | Beirdo: | well, compile a list of suspect ones, and we should go over em |
[04:54:54] | jya: | Like I see some of the backports to the AAC decoder |
[04:54:59] | jya: | I added those |
[04:55:22] | jya: | so that pretty much re-applied the backports on top of a more recent version |
[04:55:43] | jya: | I'm now wondering how many there are like this we overlooked |
[05:04:35] | tris (tris!tristan@camel.ethereal.net) has quit (Ping timeout: 256 seconds) | |
[05:11:39] | tris (tris!tristan@camel.ethereal.net) has joined #mythtv | |
[05:30:14] | jya: | Beirdo: ok, I've gone through all the patches that were re-applied in libavcodec… should be all good now... |
[05:31:41] | Beirdo: | cool |
[05:41:15] | jya: | like libmythmpeg2 uses libavcodec/x86/mmx.h ; |
[05:41:39] | jya: | but mythmpeg2 include its own mmx.h , that is actually more recent, and for the function used is identical |
[05:43:30] | jya: | Beirdo: I'm surprised you had to use the UINT64_C macro, in dsputil.h ; ULL should have done it |
[05:44:23] | Beirdo: | not for 32bit |
[05:44:30] | Beirdo: | well, it should have |
[05:44:36] | jya: | wouldn't compile ? |
[05:44:36] | Beirdo: | but consistenct... |
[05:44:49] | Beirdo: | wouldn't compile without a change, correct |
[05:44:54] | jya: | ULL is the standard C definition for an unisgned long long |
[05:45:04] | jya: | with the UL only yes , I agree |
[05:45:09] | jya: | but ULL should have |
[05:45:18] | jya: | should be reported to ffmpeg folks too |
[05:45:27] | Beirdo: | it should, yes |
[05:45:36] | jya: | have you tried with ULL ? |
[05:46:21] | ThisNewGuy (ThisNewGuy!~doug@pool-173-70-145-208.nwrknj.fios.verizon.net) has joined #mythtv | |
[05:46:32] | Beirdo: | no |
[05:47:03] | Beirdo: | they already have the macro, no need to redo it yet again |
[05:47:30] | jya: | just trying to keep the changes to a minimum |
[05:47:43] | jya: | one letter being better than 8 :) |
[05:47:46] | Beirdo: | either way is a change |
[06:05:18] | Steve-Goodey (Steve-Goodey!~steve@host86-160-32-127.range86-160.btcentralplus.com) has joined #mythtv | |
[06:10:15] | Steve-Goodey (Steve-Goodey!~steve@host86-160-32-127.range86-160.btcentralplus.com) has quit (Remote host closed the connection) | |
[06:17:25] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
[06:18:35] | Goga777 (Goga777!~Goga777@2.95.226.252) has joined #mythtv | |
[06:38:24] | highzeth (highzeth!~hz@hoiseth.no) has quit (Ping timeout: 250 seconds) | |
[06:52:54] | caelor_afk is now known as caelor | |
[07:00:53] | caelor: | Beirdo, a couple of days ago natanojl queried PlaybackSock::GetMaxBitrate(int) using SendReceiveStringList(strlist, 2) – changeset 1508085eb changed GET_MAX_BITRATE to return 64bit rather than 2x 32bit, so I think it should be SendReceiveStringList(strlist, 1) |
[07:03:15] | caelor: | A similar call in RemoteEncoder::GetMaxBitrate was changed to SendReceiveStringList(strlist, 1). I can raise a ticket if you'd like, but hopefully it's trivial and shouldn't need one. |
[07:23:56] | rsiebert (rsiebert!~quassel@g229053226.adsl.alicedsl.de) has joined #mythtv | |
[07:24:24] | rsiebert_ (rsiebert_!~quassel@g226061128.adsl.alicedsl.de) has quit (Ping timeout: 246 seconds) | |
[07:38:50] | MythBuild: | build #3810 of master-linux-64bit is complete: Failure [4failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/3810 blamelist: Jean-Yves Avenard <jyavenard@mythtv.org > |
[07:46:17] | MythBuild: | build #2595 of master-freebsd-64bit is complete: Failure [4failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2595 blamelist: Jean-Yves Avenard <jyavenard@mythtv.org > |
[07:51:45] | MythBuild: | build #3543 of master-linux-32bit is complete: Failure [4failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/3543 blamelist: Jean-Yves Avenard <jyavenard@mythtv.org > |
[07:51:46] | natanojl: | caelor: I can commit it later today unless Bei rdo or someone else beat me to it |
[07:53:33] | caelor: | natanojl, I've not tested the change, this is all from reading the code, but I agree with your assessment. I'm not the ML reporter, but have been seeing the same error in the logs. |
[07:54:14] | caelor: | if I had chance at the moment, I'd compile my own build with the change in and test, but it'd take me some time to transition from the mythbuntu builds I'm currently using to my own builds. |
[07:55:49] | caelor: | At the moment, the only way I could confirm it fixes is my issue is to wait until it gets reflected in the mythbuntu 0.25-fixes builds. I do plan to move to building my own packages though, so I can test little bugfixes like this. |
[07:56:22] | jya: | ah… I should have tried the plugins :) |
[07:57:04] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 260 seconds) | |
[07:59:02] | caelor is now known as caelor_ | |
[08:24:26] | aloril (aloril!~aloril@84.249.126.153) has quit (Ping timeout: 265 seconds) | |
[08:28:35] | Goga777 (Goga777!~Goga777@2.95.226.252) has quit (Remote host closed the connection) | |
[08:37:33] | aloril (aloril!~aloril@dsl-tkubrasgw3-fe7ef900-153.dhcp.inet.fi) has joined #mythtv | |
[08:50:34] | highzeth (highzeth!~hz@hoiseth.no) has joined #mythtv | |
[08:51:43] | MythBuild: | build #2515 of master-linux-ppc is complete: Failure [4failed compile core] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2515 blamelist: Jean-Yves Avenard <jyavenard@mythtv.org > |
[08:53:13] | MythBuild: | build #3811 of master-linux-64bit is complete: Success [3build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/3811 |
[08:58:07] | MythBuild: | build #2596 of master-freebsd-64bit is complete: Success [3build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2596 |
[08:59:49] | MythBuild: | build #3544 of master-linux-32bit is complete: Success [3build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/3544 |
[09:28:39] | MythBuild: | build #2516 of master-linux-ppc is complete: Success [3build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2516 |
[09:57:10] | aloril (aloril!~aloril@dsl-tkubrasgw3-fe7ef900-153.dhcp.inet.fi) has quit (Ping timeout: 260 seconds) | |
[10:05:01] | mike|2 (mike|2!~mike@c-98-232-220-158.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
[10:05:52] | mike|2 (mike|2!~mike@c-98-232-220-158.hsd1.or.comcast.net) has joined #mythtv | |
[10:10:22] | aloril (aloril!~aloril@84.249.126.153) has joined #mythtv | |
[10:49:57] | mzanetti (mzanetti!~mzanetti@server1.muehlhaeuser.de) has quit (Excess Flood) | |
[11:07:54] | aleprovencio (aleprovencio!~xand@189.5.207.15) has joined #mythtv | |
[11:08:05] | aleprovencio (aleprovencio!~xand@189.5.207.15) has left #mythtv () | |
[11:16:13] | cattelan (cattelan!~cattelan@c-66-41-26-220.hsd1.mn.comcast.net) has quit (Ping timeout: 244 seconds) | |
[11:50:17] | mzanetti (mzanetti!~mzanetti@server1.muehlhaeuser.de) has joined #mythtv | |
[11:50:19] | mzanetti (mzanetti!~mzanetti@server1.muehlhaeuser.de) has quit (Excess Flood) | |
[11:54:41] | andreax (andreax!~andreaz@p54BF3D5A.dip.t-dialin.net) has joined #mythtv | |
[12:03:41] | cattelan (cattelan!~cattelan@c-66-41-26-220.hsd1.mn.comcast.net) has joined #mythtv | |
[12:15:39] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Quit: Leaving) | |
[12:28:16] | aloril (aloril!~aloril@84.249.126.153) has quit (Ping timeout: 272 seconds) | |
[12:35:09] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has joined #mythtv | |
[12:40:52] | aloril (aloril!~aloril@dsl-tkubrasgw3-fe7ef900-153.dhcp.inet.fi) has joined #mythtv | |
[12:50:34] | Beirdo (Beirdo!~gjhurlbu@mythtv/developer/beirdo) has quit (Ping timeout: 245 seconds) | |
[12:50:40] | Beirdo (Beirdo!~gjhurlbu@linode.beirdo.ca) has joined #mythtv | |
[12:50:40] | Beirdo (Beirdo!~gjhurlbu@linode.beirdo.ca) has quit (Changing host) | |
[12:50:40] | Beirdo (Beirdo!~gjhurlbu@mythtv/developer/beirdo) has joined #mythtv | |
[12:55:39] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
[13:05:35] | Vernon_at_work (Vernon_at_work!~singv003@lightcloud.verns.net) has joined #mythtv | |
[13:12:39] | mzanetti (mzanetti!~mzanetti@server1.muehlhaeuser.de) has joined #mythtv | |
[13:22:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[13:37:51] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
[13:38:28] | stichnot: | stuartm: I have a MythUIImage *mui and its corresponding MythImage *mi. I want to rescale it by calling mi->Resize(newSize), but then it redisplays with the correct size but at the upper-left corner. What should I be doing to keep it in roughly the same place? |
[13:54:12] | jwhite (jwhite!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has quit (Remote host closed the connection) | |
[14:09:38] | stuartm: | stichnot: so you want to centre it within the area of the mythUIImage? Good question, there's currently no 'centre' option for images, but I can certainly see uses for it – since I assume you're talking about subtitles atm where you control the image placement you could physically move it using SetPosition() |
[14:10:21] | stuartm: | e.g. x + (originalWidth – newWidth) |
[14:12:38] | stuartm: | i.e. that might work as a quick fix, and I can see about adding an alignment option for images so that all you need to do is SetAlignment(AlignAllCenter); or <align>allcenter</align> instead |
[14:27:45] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has quit (Quit: Coyote finally caught me) | |
[14:29:34] | Peps (Peps!~MiNT@li186-230.members.linode.com) has joined #mythtv | |
[14:36:12] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
[14:43:07] | jya: | I've spent the last 4 hours wondering why with my ffmpeg resync I get a grey screen when playing a h264 video… turned out to be what seems another llvm bug.. when I add any -O (-Os, -O1, .. 3) then it works fine |
[14:44:14] | stichnot: | stuartm: this is coming up when adjusting the av subtitle zoom setting. I'm trying to give instant feedback by rescaling any currently displayed subtitles, instead of making the user wait for the next subtitle to appear. Basically I'd like the top-left value to be the same, but it seems to reset to (0,0) using the above. |
[14:45:02] | stichnot: | It's not easy to just regenerate the subtitle, since without more major changes, the source information has been consumed and freed. |
[14:48:15] | gigem: | sphery: In 0.25, title *and* seriesid are used for scheduling. See commit 02f646ac . |
[14:53:20] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
[14:56:09] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
[14:57:44] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has quit (Remote host closed the connection) | |
[14:58:22] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has joined #mythtv | |
[15:07:32] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 250 seconds) | |
[15:11:42] | superm1 (superm1!u4318@ubuntu/member/superm1) has quit (Remote host closed the connection) | |
[15:12:05] | XDS2010_ (XDS2010_!u1218@gateway/web/irccloud.com/x-bzpmxytozgukbfqv) has quit (Remote host closed the connection) | |
[15:25:25] | sphery: | gigem: yeah, the "not generally" was a(n over-)simplification because I didn't want to look up the details since I was thinking it got dialed back from the proposed, "use seriesid instead of title," and because IIRC, it's a filter that you enable (and is not used by default) |
[15:31:57] | superm1 (superm1!u4318@ubuntu/member/superm1) has joined #mythtv | |
[15:44:21] | Chutt (Chutt!~ijr@cpe-24-29-225-175.neo.res.rr.com) has quit (Read error: Connection reset by peer) | |
[15:49:55] | sphery: | stuartm: based on a #-users question ( http://irc.mythtv.org/ircLog/channel/1/2012-05-22:15:15:15 ), I was looking at the autoexpire code ( http://code.mythtv.org/cgit/mythtv/tree/mytht . . . ire.cpp#n286 ), and it seems to me that for users with DeletedMaxAge > 0, we may be expiring Live TV (short, then normal), then expiring Deleted shows that were deleted DeletedMaxAge days ago or more, then expiring episodes over max, ... |
[15:50:01] | sphery: | ... then expiring normal recordings--where expiring normal recordings means that we leave episodes deleted recently (less than DeletedMaxAge days ago) and expire not-yet-deleted episodes, instead, when we need more space |
[15:50:44] | sphery: | Am I reading that wrong, or do we need to add an iteration of expiring any remaining/"new" Deleted episodes to AutoExpire::ExpireRecordings() |
[15:51:43] | sphery: | (before we delete normal recordings) |
[15:57:54] | Goga777 (Goga777!~Goga777@2.95.14.175) has joined #mythtv | |
[15:58:01] | Goga777 (Goga777!~Goga777@2.95.14.175) has quit (Read error: Connection reset by peer) | |
[16:00:09] | seeker (seeker!~seeker@unaffiliated/seeker) has joined #mythtv | |
[16:02:49] | sphery: | stuartm: Oh, and BTW, I'm not blaming you for this bug--as, if it is a bug, it's been there as long as "Auto-expire instead of delete" and DeletedMaxAge--but I'm just hoping to get a 2nd read from someone who's looked at that code before. And, FWIW, I think getting rid of the "Auto-expire instead of delete" setting is a great thing--it's uncovered long-standing bugs that users report and we haven't been able to find (such as the inability to ... |
[16:02:55] | sphery: | ... delete recordings with missing files)--that I could never duplicate depite a /lot/ of trying because I didn't think to look at it from the "other" side of the setting. |
[16:03:50] | sphery: | and, possibly this one--which may explain several reports of weirdness with auto-expire |
[16:03:57] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
[16:10:25] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[16:10:29] | joki (joki!~joki@p54865BB5.dip.t-dialin.net) has quit (Ping timeout: 248 seconds) | |
[16:10:37] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
[16:11:19] | joki (joki!~joki@p54863034.dip.t-dialin.net) has joined #mythtv | |
[16:14:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[16:14:37] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
[16:15:02] | zombor__ (zombor__!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has joined #mythtv | |
[16:15:28] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
[16:18:36] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Ping timeout: 250 seconds) | |
[16:20:47] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
[16:20:54] | zombor__ is now known as zombor | |
[16:20:55] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has quit (Changing host) | |
[16:20:55] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[16:21:19] | Steve-Goodey (Steve-Goodey!~steve@host86-160-32-127.range86-160.btcentralplus.com) has joined #mythtv | |
[16:36:07] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
[16:45:56] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Remote host closed the connection) | |
[16:48:54] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 245 seconds) | |
[16:50:34] | seeker (seeker!~seeker@unaffiliated/seeker) has quit (Ping timeout: 245 seconds) | |
[16:59:56] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[17:00:12] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
[17:06:00] | jya: | Beirdo: I went through the whole configure, resyncing with the ffmpeg version as of the time of your resync |
[17:06:10] | jya: | If you could please have a quick review of it |
[17:06:11] | jya: | http://pastebin.com/sjSz9W2g |
[17:07:24] | jya: | Basically, I looked at each difference, then checked through git blame when it was added. if it was added during a ffmpeg sync and isn't used anymore: removed it. If it was added during a ffmpeg sync, and didn't get modify since and was modified in the ffmpeg's configure: then I use ffmpeg. |
[17:08:34] | jya: | Then what I did is try to put all mythtv modifications into a concentrated area so the diff between ffmpet's original one and ours is a small as possible. |
[17:09:06] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 244 seconds) | |
[17:14:21] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
[17:16:04] | Beirdo: | bad |
[17:16:25] | Beirdo: | you removed the checks for disabling python/perl/php bindings in mythtv's configure |
[17:16:48] | Beirdo: | please redo that file |
[17:17:17] | Beirdo: | oooh |
[17:17:24] | Beirdo: | nvm. it was moved further down |
[17:17:53] | jya: | yes.. as I said, I moved all the tests functions we added so they are all together |
[17:18:34] | jya: | and checked the generated config.mak and config.h ; all the options that were there before are detected just the same, except for the new constant that we missed earlier |
[17:19:38] | jya: | BTW, with that patch, applying the full diff between your last resync, and ffmpeg as of today, is a breeze |
[17:19:50] | Beirdo: | not sure that the PPC changes are correct |
[17:20:11] | Beirdo: | do we not need subarch at all anymore? |
[17:20:47] | jya: | the ppc test in the current configure didn't change since jannau sync in 2009 |
[17:21:06] | Beirdo: | true. I see they changed that around some. :) |
[17:21:40] | jya: | just happened that no one dare to touch it since ;) |
[17:22:00] | Beirdo: | or missed it |
[17:22:04] | Beirdo: | :) |
[17:22:11] | jya: | probably… |
[17:22:25] | Beirdo: | well, it looks OK on the surface anyways. |
[17:22:41] | jya: | oh, I didn't touch any of the cygwin / windows bit |
[17:22:43] | Beirdo: | we'll have to try it of course, expect oddness :) |
[17:23:00] | jya: | well, I figure.. better doing it now than later |
[17:23:41] | Beirdo: | earlier in the release cycle, the better |
[17:23:57] | Beirdo: | more time to soak in and find the niggling issues :) |
[17:24:02] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has quit (Remote host closed the connection) | |
[17:24:24] | jya: | I wonder if that change that commented out some stuff, is still valid |
[17:24:24] | jya: | https://github.com/MythTV/mythtv/commit/05c74 . . . e6c20cd0fcf7 |
[17:24:32] | jya: | also from 2009 |
[17:24:43] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has joined #mythtv | |
[17:24:56] | jya: | it commented out check_cflags -Werror=implicit-function-declaration for ticket #8830 |
[17:24:56] | ** MythLogBot http://code.mythtv.org/trac/ticket/8830 ** | |
[17:25:03] | Beirdo: | hmm |
[17:25:27] | Beirdo: | we should try putting the warnings back up (temporarily) and see how bad it is |
[17:25:59] | jya: | i guess it would quickly show in the mingw buildbot |
[17:26:15] | Beirdo: | exactly :) |
[17:26:35] | jya: | right… tomorrow I'll commit that and try |
[17:26:40] | Beirdo: | and once we have massive spew, we can determine if we want to shut it back off |
[17:26:59] | jya: | and then I'll also push my short ffmpeg resync, it fixes most of the h264 issues I've been seeing rtying my hls player |
[17:27:01] | Beirdo: | or maybe ffmpeg cleaned up their code :) |
[17:27:22] | Beirdo: | sure. If it's good to go and tested, of course |
[17:27:32] | Beirdo: | you doing a full sync, or partial? |
[17:27:38] | jya: | was a very simple one this time, git diff hash1 HEAD |
[17:27:42] | jya: | and patch |
[17:27:52] | jya: | it's a full one. |
[17:28:09] | jya: | it did break playback of h264, all I got was a grey screen |
[17:28:17] | jya: | but I was happy, it didn't crash anymore |
[17:28:23] | Beirdo: | OK. please be sure to mark the SHA1 of the source in the commit message |
[17:28:36] | Beirdo: | it breaks playback? |
[17:28:39] | jya: | and it turned out, the grey screen is due to compiling the cabac code with -O3 |
[17:28:39] | Beirdo: | heh |
[17:28:43] | jya: | and suddenly, all worked |
[17:28:48] | jya: | damn llvm |
[17:29:04] | Beirdo: | yeah, use a real compiler :) (ducks and runs) |
[17:29:20] | jya: | in the current code |
[17:29:44] | jya: | the cabac stuff after a while , will output a pointer that is 32 bits only (64 bits machine) |
[17:29:52] | jya: | this cause an access exception |
[17:30:05] | jya: | actually, no.. 16 bits pointer |
[17:30:15] | jya: | compile with -O3: no issue |
[17:30:17] | jya: | so weird |
[17:30:46] | jya: | and as my knowledge of SSE assembly is just as good as my chinese.. |
[17:31:14] | Beirdo: | hehe |
[17:31:28] | Beirdo: | anyways, I gotta head to an all-day meeting |
[17:31:32] | Beirdo: | have fun :) |
[17:31:38] | jya: | gotta head to bed |
[17:33:17] | jwhite_ (jwhite_!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has joined #mythtv | |
[17:46:55] | stuartm: | sphery: right, that should be "else\nExpireQuickDeleted();" instead |
[17:48:09] | stuartm: | no wait, that is right ... |
[17:48:46] | sphery: | right, I think RunExpirer() is correct... |
[17:49:30] | sphery: | I think we just need to add a new section to ExpireRecordings() to preferentially expire "new" deleted shows before expiring any not-deleted shows |
[17:51:03] | sphery: | so, somewhere around http://code.mythtv.org/cgit/mythtv/tree/mytht . . . ire.cpp#n508 |
[17:51:08] | stuartm: | I need a minute to catch up :) |
[17:52:27] | sphery: | it seems the code now assumes that that if we've gotten to the ExpireRecordings() and are expiring because of not enough space, we have already removed all of the Deleted recordings, but with DeletedMaxAge (which has always existed as long as Auto-expire instead of delete), that's not necessarily the case |
[17:57:45] | stuartm: | yeah, I think I'm with you now |
[17:58:14] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has joined #mythtv | |
[17:58:19] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
[17:58:26] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has quit (Changing host) | |
[17:58:26] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[17:58:29] | stuartm: | tbh I know this code about as well as you do, I only touched upon the parts I needed to modify and didn't even look at the rest :) |
[17:58:57] | sphery: | hehe, yeah, understood |
[18:03:03] | stuartm: | I can maybe find a moment to look at it tonight, but it sounds like you've got a handle on things and probably don't need me slowing you down :) |
[18:04:14] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
[18:08:03] | sphery: | stuartm: actually, now I'm thinking that's not the case... AutoExpire::FillExpireList() in AutoExpire::ExpireRecordings() on L426 seems to put all the deleted programs first, then does the auto-expire priority for other recordings stuff, and in the "not enough space" section, we're iterating over the expirelist, so it should get normal deleted (even if new) recordings first |
[18:08:49] | sphery: | therefore, either the user was wrong or it may be that deletepending race condition that you found a while back |
[18:12:12] | sphery: | stuartm: the deletepending race condition can occur for users who are not using slow deletes and is rare with normal usage; however, because of the bug in the DeletedMaxAge update, users who had tens or hundreds of deleted recordings and who updated before https://github.com/MythTV/mythtv/commit/abfced82 seem to be triggering the race on a huge scale due to hitting the maximum number of MySQL connections when it tries to all of a sudden delete ... |
[18:12:18] | sphery: | ... hundreds of recordings |
[18:13:52] | sphery: | which means that there's a good chance that many users have many (even hundreds of) GB of orphaned recordings in the deletepending state that MythTV is not actually going to show or delete... it's possible all of discernica's recordings are deletepending/orphaned and so it's just deleting the new recordings because it thinks the others are being deleted |
[18:14:40] | sphery: | wagnerrp: do you still have the update for http://www.mythtv.org/wiki/Find_orphans.py that handles deletepending=1 recordings? Perhaps we should get that posted and recommend any user who had enabled "Auto-expire instead of delete" run it? |
[18:16:08] | wagnerrp: | actually, i have a significant rewrite i need to clean up and push |
[18:16:16] | wagnerrp: | ill see if i can get that done today |
[18:16:40] | wagnerrp: | if i still have the version youre talking about, it would be on github |
[18:18:04] | sphery: | Yeah, I think you had it on github and were waiting to put it on the wiki for some 0.25 stuff or something... Thanks for working on it... It will likely clean up a lot of garbage for users. |
[18:24:57] | dekarl (dekarl!~dekarl@p4FE85369.dip.t-dialin.net) has joined #mythtv | |
[18:30:53] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has quit (Read error: Connection reset by peer) | |
[18:31:53] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has joined #mythtv | |
[18:57:48] | kenni (kenni!~kenni@mythtv/developer/kenni) has quit (Quit: leaving) | |
[19:12:43] | XDS2010_ (XDS2010_!u1218@gateway/web/irccloud.com/x-tcuxxghznsbacmge) has joined #mythtv | |
[19:30:16] | sphery: | stuartm: FWIW, Captain_Murdoch found the bug in the expirer, and it should be a straightforward fix and backport. (But it was much deeper than I had thought. :) Thanks for helping. |
[19:37:16] | Captain_Murdoch: | sphery, pushed to master and fixes. |
[19:37:53] | sphery: | thx |
[19:38:34] | Captain_Murdoch: | were there any tickets specific to this? I glanced through a bunch but didnt' see any open ones regarding it. |
[19:43:04] | sphery: | no open ones that I know of. Only one I can remember that was likely the same issue is #7936 (and I just put a comment on that one) |
[19:43:04] | ** MythLogBot http://code.mythtv.org/trac/ticket/7936 ** | |
[19:43:33] | sphery: | but it's been reported several times--can't remember if the others were tickets or just mailing list |
[19:54:23] | Captain_Murdoch: | pushed to 0.24 fixes as well. |
[20:19:15] | MythBuild: | build #2519 of master-linux-ppc is complete: Failure [4failed compile core] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2519 blamelist: Chris Pinkham <cpinkham@mythtv.org > |
[20:41:50] | petefunk: | . |
[20:42:52] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
[20:44:13] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has quit (Quit: Ex-Chat) | |
[21:07:26] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 252 seconds) | |
[21:16:28] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
[21:17:31] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
[21:18:04] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[21:32:01] | brfransen (brfransen!~brfransen@64.179.142.146) has quit () | |
[21:34:19] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Ping timeout: 252 seconds) | |
[21:37:05] | dekarl: | sphery: here's a patch to allow matching EIT events without looking at ONID or TID, it just needs the part that figures out the channel id from the channel number in the active scan. http://paste.ubuntu.com/1001869/ <- written to spec without even trying to compile :D |
[21:38:07] | brfransen (brfransen!~brfransen@64.179.142.146) has joined #mythtv | |
[21:38:51] | stuarta: | interesting |
[21:39:46] | dekarl: | we still need onid/tid for interactive TV stuff or to handle the DVB-S "one transport has all the EIT of all transports" use case |
[21:40:24] | Steve-Goodey (Steve-Goodey!~steve@host86-160-32-127.range86-160.btcentralplus.com) has quit (Remote host closed the connection) | |
[21:42:49] | dekarl: | another improvement would be the case of EITa(ctive) with target service_id == currently tuned service_id without looking at the dtv_mplex table so we can handle EIT from IPTV/HLS streams, too |
[21:42:56] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 244 seconds) | |
[21:45:43] | andreax (andreax!~andreaz@p54BF3D5A.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
[21:46:28] | dekarl: | jya: ^- if you notice EIT data on a HLS stream, that might be something to play with ;) |
[22:12:13] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
[22:12:25] | jya_ (jya_!~jyavenard@120.148.99.165) has joined #mythtv | |
[22:12:25] | jya_ (jya_!~jyavenard@120.148.99.165) has quit (Changing host) | |
[22:12:25] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[22:12:32] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
[22:12:48] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[22:13:28] | jya__ (jya__!~jyavenard@120.148.99.165) has joined #mythtv | |
[22:13:29] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
[22:13:30] | jya__ (jya__!~jyavenard@120.148.99.165) has quit (Changing host) | |
[22:13:30] | jya__ (jya__!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[22:14:16] | jya__ (jya__!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
[22:14:46] | jya_ (jya_!~jyavenard@120.148.99.165) has joined #mythtv | |
[22:14:46] | jya_ (jya_!~jyavenard@120.148.99.165) has quit (Changing host) | |
[22:14:46] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[22:15:36] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
[22:16:05] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[22:16:20] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
[22:16:47] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[22:17:04] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
[22:22:19] | Unhelpful (Unhelpful!~quassel@rockbox/developer/Unhelpful) has quit (Quit: No Ping reply in 180 seconds.) | |
[22:22:36] | Unhelpful (Unhelpful!~quassel@rockbox/developer/Unhelpful) has joined #mythtv | |
[22:22:46] | dekarl is now known as dekarl_zZz | |
[22:32:53] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
[22:47:38] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Ping timeout: 244 seconds) | |
[23:02:27] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
[23:10:34] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has quit (Quit: Coyote finally caught me) | |
[23:11:45] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
[23:19:01] | stichnot: | sphery: Are you planning to have multi-bookmark support for 0.26? No rush, but if not, I'm inclined to close #8631, reduce my ticket count, and fill in the last missing bit later. |
[23:19:01] | ** MythLogBot http://code.mythtv.org/trac/ticket/8631 ** | |
[23:20:51] | sphery: | stichnot: multi-bookmark, yes, but not sure about the revamped progress bar |
[23:21:17] | stichnot: | ok, thanks. In that case, I'll wait and see what happens. |
[23:22:57] | sphery: | that said, your making me think of both multi-bookmark and the new progress bar made me think of how nice it would be able to show the bookmarks in the progress bar, too :) |
[23:23:26] | sphery: | I really need to get some of this stuff done! |
[23:23:47] | stichnot: | :) |
[23:31:30] | stichnot_ (stichnot_!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
[23:33:00] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 256 seconds) | |
[23:34:19] | stichnot_ is now known as stichnot | |
[23:36:40] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
[23:37:05] | stichnot: | sphery: yes, I would like to see all kinds of marks in the progress bar, but I have no idea how to make that pleasing... |
[23:39:19] | sphery: | hehe, yeah, I think I'll start with making it possible to show them, then letting themers come up with the how/whether to |
[23:42:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[23:56:12] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[23:57:08] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 245 seconds) |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.