| Wednesday, September 4th, 2013, 18:30 UTC | ||
| [18:30:43] | gigem: | peper03: When the title check is done for all duplicate checking, MySQL can use an index to efficiently check only those cases where the titles match. When the title check is moved down to be done along with the subtitle and description checks when programids can't be used, MySQL inefficiently checks all cases, including those where the titles don't match. It might be possible to rewrite the checks to use a |
| [18:30:45] | gigem: | subquery or multiple queries, but I've never tried it. |
| [18:32:49] | peper03: | gigem: Ok, so it's because of an index. That makes sense. Would it not be possible to create an index for the programids? (my SQL and DB knowledge is just enough to be dangerous so be gentle with me :) ) |
| [18:45:53] | peper03: | gigem: With that patch, I got 1.57 check compared to 0.11 without. Doesn't actually appear to have prevented the 2nd recording though. |
| [18:56:50] | peper03: | stuartm, stuarta: Any objections to cherry-picking the additional fixups into 0.26? |
| [18:57:50] | stuarta: | peper03: nope |
| [18:58:01] | stuarta: | you break it you get to keep both pieces |
| [18:58:03] | stuarta: | :) |
| [18:58:29] | peper03: | I think I've got some glue here somewhere for all eventualities :) |
| [18:59:08] | peper03: | I guess it makes sense to cherry-pick the previous UK fixup changes too. |
| [19:00:52] | stuarta: | i thought i'd already done some of those |
| [19:01:38] | stuarta: | oh and if you fancy playing with fixups some more, there are currently episode data in subtitles. eg episodes of chuggington, postman pat etc :) |
| [19:01:46] | ** stuarta runs off for dinner ** | |
| [19:01:51] | peper03: | I was thinking specifically of [5ee73af] (https://github.com/MythTV/mythtv/commit/5ee73af) |
| [19:02:46] | peper03: | If I can get my head around it, I'll have a look :) "Choo Choo!" |
| [19:06:28] | stuartm: | peper03: you'll need to include the one I committed a few days ago |
| [19:06:49] | stuartm: | won't be a clean merge otherwise |
| [19:07:12] | stuartm: | ah, you already said as much (working through scrollback) |
| [19:08:05] | cesman (cesman!~cesman@pdpc/supporter/professional/cesman) has quit (Quit: Konversation terminated!) | |
| [19:08:28] | peper03: | stuartm: Yep :) Is the 'Cherry-picked from...' important in the commit message? I thought it got added automatically, but it doesn't seem to want to here... |
| [19:08:45] | stuartm: | need to use -x to append that |
| [19:10:09] | stuartm: | peper03: it's not vital but it's useful to have that just for reference |
| [19:10:17] | sphery: | peper03: We have a programid index (programid, starttime)... I think what gigem is saying is that the patch causes the scheduler to have to compare things that wouldn't normally be compared... Instead of only comparing programids among the 2 episodes of Under the Dome in the listings, it's comparing the programids of those 2 Under the Dome episodes with the programids of all 500 episodes matched by any other recording rule you have. The ... |
| [19:10:24] | sphery: | ... index on title just makes it easy for it to find only the Under the Dome episodes and ignore all the other differently-titled episodes when it's only comparing those with the same title. |
| [19:10:58] | stuartm: | seriesid? |
| [19:11:19] | stuartm: | btw, does Under the Dome get any better? |
| [19:12:50] | sphery: | don't think we have a seriesid index, and I haven't read the patch (and probably wouldn't understand it well enough) to know whether it's only comparing programids without looking at title if seriesid is the same |
| [19:12:54] | gigem: | peper03: Sphery's right. When an index won't apply to every case, MySQL resorts to performing the entire subtitle and description check on every combination even if they all have programids. |
| [19:13:55] | peper03: | sphery, gigem: Ok, that makes it clearer. Thanks. |
| [19:14:01] | stuartm: | second and third episodes just seem to waste any tension created in that first episode/pilot, acting isn't great and I'm not really sure what purpose the sub-plots introduced serve and they really aren't working to build out the characters |
| [19:14:51] | gigem: | I don't think a seriesid index would help either. As I stated earlier, it would probably take multiple or a complicated subquery to do it efficiently. |
| [19:15:10] | sphery: | stuartm: yeah, I was enjoying Dome early and hoped it would go somewhere, but I'm starting to yearn for a new season of "real" (non-summer) shows |
| [19:15:13] | stuartm: | never the less, you figure there must be an interesting twist/reveal coming and that it's just taking way too long getting there |
| [19:15:53] | sphery: | gigem: yeah, I'd think it would require some major changes since basically everything else in the scheduler is title based |
| [19:15:55] | stuartm: | feels like something that probably would have worked better as a mini-series |
| [19:16:45] | sphery: | stuartm: definitely... seems they're running out of storyline (even having to introduce new people into the series saying she was hiding out) |
| [19:17:06] | gigem: | Yep. Oh, and peper03, that patch was merely meant as an example, I didn't check it for accuracy. |
| [19:17:52] | peper03: | gigem: Ok. No problem. Now I know what's going on and why, I can sleep again :) |
| [19:17:55] | taylorr (taylorr!~taylorr@unaffiliated/elmojo) has quit (Ping timeout: 245 seconds) | |
| [19:18:56] | sphery: | dekarl / stuartm : btw, I think you guys might know much better than I what this guy is looking to get http://www.gossamer-threads.com/lists/mythtv/users/551497#551497 ... Is that VISUALIMPAIR audioprop? |
| [19:20:03] | sphery: | I replied saying that if the info is in the SD/TMS data and we're not currently storing it, we should be: http://www.mythtv.org/pipermail/mythtv-users/ . . . /352782.html , but I don't know enough to know what exactly "Descriptive Video Service"/"Audio Description" would mean |
| [19:28:57] | stuarta: | peper03: it's actually in the program octonauts :) |
| [19:29:07] | stuartm: | sphery: sounds like that's what he's looking for and we should be able to use it for scheduling, but at least in the UK we're not able to actually use it – here it's carried as a secondary audio channel which needs to be decoded and combined with the primary |
| [19:30:48] | taylorr (taylorr!~taylorr@unaffiliated/elmojo) has joined #mythtv | |
| [19:31:15] | stuartm: | although it's not strictly what he was asking, see Recording Priorities, second page, "Audio described priority" for setting a higher priority on AD recordings |
| [19:32:02] | stuarta: | that goes back to the priority adjustments based on flags we talked about ages ago. ie. HD program priorities etc |
| [19:32:04] | stuartm: | no icon for it in the UI though ... |
| [19:33:09] | peper03: | stuartm: I thought it was already combined. I've been bitten a couple of times when I've watched a recording with something other than Myth and suddenly found someone reading the opening credits to me. |
| [19:33:15] | stuartm: | but VISUALIMPAIR is the flag in question, it's parsed from EIT but not xmltv (since I'm not aware of xmltv supporting it) |
| [19:34:14] | stuartm: | peper03: not on freeview, but some channels on freesat do combine it because Sky boxes don't have the tech to decode both simultaneously – it wastes bandwidth though so the Freeview spec requires hardware to have that ability |
| [19:34:29] | peper03: | It was a problem before I got my production box up and running and tried to use DLNA in the TV to play recordings. It would only ever use the first channel, which was audio description. |
| [19:34:31] | peper03: | Ah ok. |
| [19:35:43] | stuartm: | not quite sure what we're doing for upnp, whether we send the entire TS unmodified or filter it |
| [19:36:47] | stuartm: | descriptors for AD are there in the mpeg headers so we could in theory filter that stream out when sending to upnp devices, or even when recording |
| [19:39:42] | peper03: | I don't really know anything about the specification. I vaguely recall reading that only one audio channel was supported. Using it made me want to put my foot through the TV, though. FFWD was only about 1.5x normal speed. Took nearly as long to skip over the pre-roll stuff to get to the kids' programmes as it did to watch them! |
| [19:40:35] | peper03: | Also, I think my TV didn't like Myth. I had to run some other server. |
| [19:44:21] | stuartm: | yeah, I'm learning that 'DLNA' compliant doesn't really mean much, a server/client can be DLNA compliant and still unable to talk to another DLNA compliant device, DLNA basically says in parts "Here's what you must support at a minimum, but if you want to do something proprietary on top then that's OK too" |
| [19:46:53] | peper03: | I think I looked at the FFWD thing and found it is implement in the client. It seems like the client basically requests playback from a certain point and then jumps forward a bit and requests playback from there etc. So there didn't appear to be anything that could be done about it on the server :( |
| [19:47:21] | stuartm: | the spec has a very Microsoft feel to it ... compromised would be a good way to describe and it's huge – over 800 pages long just to describe the DLNA parts, it already assumes you've read the upnp spec back to front and front to back |
| [19:47:51] | peper03: | The best things I ever did for my nerves was to disconnect the Ethernet cable from the TV. All the network stuff on it was sh&te. |
| [19:55:59] | peper03: | stuarta: Don't see any episode information. |
| [20:35:32] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has joined #mythtv | |
| [21:08:59] | NightMonkey (NightMonkey!~NightrMon@64.124.185.45) has joined #mythtv | |
| [21:08:59] | NightMonkey (NightMonkey!~NightrMon@64.124.185.45) has quit (Changing host) | |
| [21:08:59] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [21:09:50] | NightMonkey_ (NightMonkey_!~NightrMon@64.124.185.45) has joined #mythtv | |
| [21:17:29] | SteveGoodey (SteveGoodey!~steve@109.158.215.102) has quit (Quit: Konversation terminated!) | |
| [21:22:50] | stuarta: | hmmm, dvb-t or dvb-s data? |
| [21:23:00] | Jordack (Jordack!~Jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [21:24:03] | stuarta: | hmmm, all my afternoon octonauts have the series data in the subtitle |
| [21:25:29] | stuarta: | all dvb-s btw |
| [21:26:45] | skd5aner (skd5aner!~skd5aner@50-90-5-146.res.bhn.net) has joined #mythtv | |
| [21:46:09] | danielk22 (danielk22!~danielk@exchange.wgen.net) has left #mythtv () | |
| [22:06:18] | knightr: | stuartm, will we hhave, for sure, another RC? |
| [22:06:40] | natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has quit (Ping timeout: 245 seconds) | |
| [22:08:18] | stuartm: | knightr: hard to say, we've not had many bug reports so far so there doesn't seem to be need for one yet |
| [22:08:27] | stuartm: | (yet) |
| [22:09:48] | stuartm: | depends on how invasive the fixes for reported bugs are, if they need the extra testing or not |
| [22:30:37] | ** stuarta tries being a user and setting up f19 as his mythtv dev box ** | |
| [22:34:43] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 264 seconds) | |
| [22:42:57] | knightr: | stuartm, thank you... |
| [22:44:11] | ** knightr uses f19 for his dev box... (actually just upgraded from f18...) ** | |
| [22:52:56] | stuarta: | that particular box had suffered a *lot* of bitrot and become unusable for many things, so it was time to clear it all out and rebuild |
| [22:53:24] | stuarta: | the fact that the cpu and gpu are antiques doesn't help much either |
| [22:54:40] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [22:55:32] | knightr: | I still have a Pentium II in use here (not for MythTV duty though...) |
| [22:55:53] | knightr: | (and before that Pentium (1) 233s... |
| [22:55:56] | knightr: | ) |
| [22:57:00] | knightr: | if I could find the time I still have my file server and my PBX to rebuild... |
| [22:57:52] | knightr: | (the file server does other duties as well though which were delegated to another PC for now...) |
| [22:58:29] | knightr: | (only partially though, I really need to reinstall Nagios...) |
| [22:59:11] | knightr: | gotta go, have to do my bike ride before it gets too dark... |
| [23:00:18] | tonsofpcs: | knightr: I had a P2 in use here. I replaced it with a Q6600 because it saved me more in power in a year and a half than the cost of the full PC |
| [23:44:55] | skd5aner: | stuartm: from -users: <DonkeyHotei> ok, i decided to give mythfrontend a try. i'm in the setup wizard, at the video config screen, clicked Test Standard Definition, and it downloads a video sample over and over in a loop. how do i get out of this? Esc does nothing |
| [23:52:43] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 264 seconds) | |
| Thursday, September 5th, 2013 | ||
| [00:20:44] | dmfrey (dmfrey!~dmfrey@65-78-98-83.c3-0.smt-ubr1.atw-smt.pa.cable.rcn.com) has joined #mythtv | |
| [00:28:12] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [00:39:48] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [00:57:20] | cesman (cesman!~cesman@pool-108-23-186-248.lsanca.fios.verizon.net) has joined #mythtv | |
| [00:57:20] | cesman (cesman!~cesman@pool-108-23-186-248.lsanca.fios.verizon.net) has quit (Changing host) | |
| [00:57:20] | cesman (cesman!~cesman@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [01:08:03] | Chutt (Chutt!~ijr@cpe-76-190-199-73.neo.res.rr.com) has quit (Ping timeout: 260 seconds) | |
| [01:09:32] | Chutt (Chutt!~ijr@cpe-76-190-199-73.neo.res.rr.com) has joined #mythtv | |
| [02:17:24] | dmfrey (dmfrey!~dmfrey@65-78-98-83.c3-0.smt-ubr1.atw-smt.pa.cable.rcn.com) has quit (Quit: Ex-Chat) | |
| [02:18:51] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Quit: Body blow! Body blow!) | |
| [02:19:11] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [02:19:52] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Remote host closed the connection) | |
| [02:21:29] | NightMonkey_ (NightMonkey_!~NightrMon@64.124.185.45) has quit (Quit: Body blow! Body blow!) | |
| [02:28:01] | nyloc (nyloc!~quassel@p3EE2C0C9.dip0.t-ipconnect.de) has joined #mythtv | |
| [02:31:47] | stichnot (stichnot!~stichnot@adsl-68-127-103-225.dsl.pltn13.pacbell.net) has joined #mythtv | |
| [02:31:47] | stichnot (stichnot!~stichnot@adsl-68-127-103-225.dsl.pltn13.pacbell.net) has quit (Changing host) | |
| [02:31:47] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [02:32:39] | _nyloc_ (_nyloc_!~quassel@p3EE2D56E.dip0.t-ipconnect.de) has quit (Ping timeout: 276 seconds) | |
| [02:44:19] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 260 seconds) | |
| [02:44:47] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [03:02:42] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [03:25:40] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Ping timeout: 264 seconds) | |
| [03:26:58] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [03:29:52] | joki (joki!~joki@p54863355.dip0.t-ipconnect.de) has quit (Ping timeout: 264 seconds) | |
| [03:34:29] | joki (joki!~joki@p54863EB1.dip0.t-ipconnect.de) has joined #mythtv | |
| [04:13:48] | knightr: | stuartm, jpabq I might need your help to update a theme for 0.27... |
| [04:23:23] | kamamam (kamamam!62c4feb9@gateway/web/freenode/ip.98.196.254.185) has quit (Ping timeout: 250 seconds) | |
| [05:03:29] | stichnot_ (stichnot_!~stichnot@adsl-68-127-103-225.dsl.pltn13.pacbell.net) has joined #mythtv | |
| [05:04:35] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 245 seconds) | |
| [05:04:38] | stichnot_ is now known as stichnot | |
| [05:52:02] | dekarl: | sphery: stuartm: seems you're right. not descriptive audio in xmltv |
| [05:57:09] | SteveGoodey (SteveGoodey!~steve@host109-158-215-102.range109-158.btcentralplus.com) has joined #mythtv | |
| [05:58:10] | brfransen (brfransen!~brfransen@64.179.169.226) has quit (Read error: Connection reset by peer) | |
| [05:58:47] | brfransen (brfransen!~brfransen@64.179.169.226) has joined #mythtv | |
| [06:07:44] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
| [06:09:06] | SteveGoodey (SteveGoodey!~steve@host109-158-215-102.range109-158.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [06:10:28] | OldEnK (OldEnK!~OldEnK@63-152-105-163.cdrr.qwest.net) has joined #mythtv | |
| [06:34:17] | OldEnK (OldEnK!~OldEnK@63-152-105-163.cdrr.qwest.net) has left #mythtv ("Leaving") | |
| [06:44:02] | dekarl1 (dekarl1!~dekarl@p4FCEE72A.dip0.t-ipconnect.de) has joined #mythtv | |
| [06:44:40] | dekarl (dekarl!~dekarl@p4FCEE0A2.dip0.t-ipconnect.de) has quit (Ping timeout: 260 seconds) | |
| [08:00:03] | Merlin83b (Merlin83b!~Daniel@office.34sp.com) has joined #mythtv | |
| [08:42:35] | CeilingKitten (CeilingKitten!~CeilingKi@206-248-165-145.dsl.teksavvy.com) has quit (Read error: Connection reset by peer) | |
| [08:42:47] | CeilingKitten (CeilingKitten!~CeilingKi@206-248-165-145.dsl.teksavvy.com) has joined #mythtv | |
| [08:55:24] | peper03: | stuarta: Seems like a regression. I see the episode data in the subtitle on 0.27 but 0.26-fixes works fine. |
| [08:59:10] | peper03: | stuartm, knightr: Regarding blockers – there's the issue I mentioned a couple of days ago – http://irc.mythtv.org/ircLog/channel/4/2013-09-03:19:26:33&nb sp;– don't know whether that's considered a blocker, but it's nasty as the only way out is to kill mythfrontend |
| [08:59:20] | peper03: | jya: ^^ |
| [09:00:57] | stuarta: | peper03: no it's a change by the broadcaster |
| [09:04:44] | peper03: | stuarta: Has it only just changed? I only kicked my dev box to always update EIT data last night, so until then I had no guide data. The production box, obviously, already had data. |
| [09:05:50] | peper03: | How does the guide data get updated using EIT? If programme data changes after it's already been added to the DB, does the DB not get updated? |
| [09:07:57] | stuartm: | it should be updated |
| [09:18:00] | dekarl1 (dekarl1!~dekarl@p4FCEE72A.dip0.t-ipconnect.de) has quit (Ping timeout: 240 seconds) | |
| [09:26:24] | peper03: | Is there a way to see the raw EIT data received by Myth (-v eit doesn't seem to output much regardless of the loglevel) or do I need to run dvbsnoop? |
| [09:28:11] | stuarta: | peper03: dvbsnoop has the raw data, there is also a tv_grab_dvb floating around which grabs eit data and presents it in tvgrab format |
| [09:30:09] | peper03: | stuarta: Is the raw data readable? I seem to remember it's compressed. |
| [09:31:25] | stuarta: | peper03: depends, dvb-t no, dvb-s might be encoded |
| [09:32:24] | peper03: | I only have dvb-s. I guess I'll have to play a bit :) |
| [09:32:27] | stuarta: | hence tv_grab_dvb is worth a shot |
| [09:32:38] | stuarta: | tbh, try it and see |
| [09:32:45] | peper03: | will do. |
| [09:32:49] | stuarta: | dvbsnoop is pretty good at decoding stuff |
| [09:34:20] | peper03: | I've only used it once or twice and I don't think I knew what I was doing then. Have to sort out what parameters I need etc. Don't really want to drown in EIT data for all programmes on all channels. |
| [09:34:46] | stuarta: | no, but dvbsnoop can't really split it down at that level |
| [09:35:07] | stuarta: | best you can get is filtering specific tables so you just get eit |
| [09:52:23] | stuarta: | peper03: i also find it useful to use the count option to dvbsnoop, to limit the number of packets, as well as -nph (no print hex) |
| [09:52:45] | stuarta: | redirecting to a file, gives me something i can look through easily |
| [09:54:14] | peper03: | stuarta: Just got 'tv_grab_dvb_plus' and compiled it but it always times out. Made sure I'd tuned the receiver with szap but no luck :( Even with debug output turned all the way up, nothing to indicate what's going wrong. |
| [09:54:29] | peper03: | Do you have the filter parameters to hand for dvbsnoop? |
| [09:55:54] | peper03: | I tried the EIT example on the dvbsnoop site before but it did nothing (dvbsnoop -n 10 -crc -td -f 0x50 -m 0xff -nph -pd 3 0x12) |
| [10:01:19] | stuarta: | lose the '-f 0x50 -m 0xff' for now |
| [10:01:58] | stuarta: | better to have too much data than not enough |
| [10:04:13] | peper03: | At the moment, I'm getting nothing no matter what I try. szap works fine, so I don't think anything is holding the device open... Odd. |
| [10:04:51] | stuarta: | oh, you need to have something running to hold the channel open |
| [10:05:35] | peper03: | Ah. Will szap do? |
| [10:05:42] | stuarta: | it should do iirc |
| [10:06:03] | stuarta: | so szap to a channel that should have data, like bbc news |
| [10:06:13] | stuarta: | and dvbsnoop in another window |
| [10:07:28] | stuarta: | it's been at least 18months since i last did this :) |
| [10:08:36] | peper03: | I think the last time I tried I didn't get any further than this, so at least it's progress :) Looks like I'm getting *something* at least now. |
| [10:10:58] | stuarta: | \o/ |
| [10:12:39] | peper03: | Without the hexdump, there's nothing usable (other than effectively "packet found"). With hexdump, yikes! |
| [10:15:02] | peper03: | Looks like tv_grab_dvb_plus is better, but it seems to stop quite quickly. |
| [10:17:46] | peper03: | But of the few results returned, nearly all of them have "x/y" at the beginning of the subtitle. Is that how it's normally done, or is that what's changed? |
| [10:19:49] | peper03: | Ah yes, seems to be how it's normally done. |
| [10:20:18] | stuarta: | no, that's what changed. it used to be at the end of the description exclusively |
| [10:22:20] | peper03: | Oh, ok. I just noticed that the channels I just added to the fixups have it at the beginning whereas those that had always been in have it parsed correctly. |
| [10:30:15] | stuarta: | peper03: it's not the channels you added to the fixups, i first noticed it 3–4 weeks back |
| [10:35:36] | peper03: | stuarta: I meant I thought that was why it is was always done like that. Looking at the code now. At first glance, I don't see why m_ukSeries isn't catching it. Perhaps I need to add some more local tracing to see exactly what it's got as input. |
| [10:56:46] | stuarta: | sorry was in a bit of a meeting. lemme find the test patch i wrote which for some reason didn't work |
| [10:57:02] | stuarta: | it may be that the regexp isn't right for what they are putting in the subtitle |
| [10:58:25] | stuarta: | peper03: http://fpaste.org/37267/13783786/ |
| [10:58:50] | peper03: | I tried it with an online regexp tester and it seemed to work fine, so my guess is that the input data that we're working with is different (e.g. it only checks the 'title' field) |
| [10:59:18] | peper03: | At what point does the subtitle field get filled? |
| [10:59:50] | peper03: | Is that defined in the EIT spec or pieced together by the fixups? |
| [11:01:14] | stuarta: | iirc, there isn't a subtitle in the eit spec |
| [11:01:30] | stuarta: | there is only short and extended descriptions. |
| [11:01:48] | stuarta: | so part of the work of the fixup, is to mangle the subtitle out of the description |
| [11:02:20] | stuarta: | i think you are onto something. i may be applying that regexp before the subtitle has actually been generated, so it might be a bit more complex |
| [11:03:31] | peper03: | Yep, I think so. I added a line to dump the title and subtitle and the subtitle is always empty but I've found a programme that ends up with the data in the subtitle, so it's presumably comming from the description. |
| [11:03:54] | peper03: | s/comming/coming/ |
| [11:04:03] | stuarta: | yes, that's what the fixup does further down |
| [11:04:32] | stuarta: | i really need to refactor that fixup and break it up some |
| [11:04:46] | stuarta: | lemme find the blob |
| [11:07:18] | stuarta: | yep, that patch will never work as the subtitle is still empty at that point |
| [11:08:28] | stuarta: | so we start creating the subtitle here https://github.com/MythTV/mythtv/blob/master/ . . . xup.cpp#L806 |
| [11:12:55] | peper03: | Presumably using that regex on the description outright is a bit risky as it'll pick 'x/y' out anywhere. |
| [11:15:16] | stuarta: | yes, so it's going to need a new regexp tied to the start of the description |
| [11:16:28] | stuarta: | "^\\d+/\\d+\\." should be a good start, though you will need to put the regexp capturing brackets in |
| [11:21:50] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has quit (Ping timeout: 264 seconds) | |
| [11:22:10] | peper03: | Looking at my 0.26 box, the data for Octonauts for Thursday of next week (i.e. +7 days, so must have been added today) is correctly parsed... |
| [11:23:08] | stuarta: | hmmm |
| [11:24:14] | stuarta: | i've updated prod to 0.27 and i see it there |
| [11:27:02] | peper03: | I see it on 0.27 too (although not that episode yet, I cleared everything out again). I do see it on 0.26 but only on those channels that didn't have the fixups applied. That why I suspected it was a regression. |
| [11:27:15] | peper03: | But I've not compared the code. |
| [11:28:18] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
| [11:28:54] | peper03: | You said you've seen it for the last three or four weeks. When did you upgrade your production box to 0.27? |
| [11:29:15] | stuarta: | about then. have you been doing a truncate eit_cache; in the database when restarting testing? |
| [11:29:29] | stuarta: | i normally truncate eit_cache; truncate program; |
| [11:32:50] | stuarta: | right, i can respin that patch |
| [11:34:24] | peper03: | No, I just did program. |
| [11:35:13] | peper03: | The only difference I can see is from [af0d12c] (https://github.com/MythTV/mythtv/commit/af0d12c), but that shouldn't stop it the part numbers being parsed and stored. |
| [11:36:00] | peper03: | And that regexp is already being applied to the description. |
| [11:37:38] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has quit (Ping timeout: 256 seconds) | |
| [11:39:09] | stuarta: | ah you need to do eit_cache, since that is what stop is updating data for programs it's seen before |
| [11:40:20] | stuarta: | *stops it |
| [11:40:27] | stuarta: | rebuilding patch v2 |
| [11:42:48] | stuarta: | http://fpaste.org/37277/38135413/ |
| [11:44:20] | stuarta: | actually the normal m_ukSeries regexp should match it |
| [11:44:48] | peper03: | It's already in. Just below the bit you added. |
| [11:44:56] | stuarta: | yeah, so it should work |
| [11:45:06] | stuarta: | my patch should do nothing |
| [11:57:02] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has joined #mythtv | |
| [12:19:22] | stuarta: | okay, so the dvb-t channels are right, now waiting for the dvb-s channels |
| [12:24:58] | peper03: | I think I need to clear everything out again. I've got an episode of 'Doctor Who' that's correct, and another from the previous day that hasn't had the subtitle filled. Both on the same channel. |
| [12:29:37] | peper03: | http://pastebin.com/cZZ8k3rp |
| [12:33:19] | stuarta: | interesting. my prod database gets the same results |
| [12:33:51] | stuarta: | my dev backend (with the new version of the patch) gets it right |
| [12:34:23] | peper03: | The patch that should do nothing? |
| [12:34:48] | stuarta: | oh ffs. now i know what is happening |
| [12:35:50] | stuarta: | http://fpaste.org/37286/13783845/ |
| [12:35:57] | stuarta: | see if you can see what is happening |
| [12:37:55] | stuarta: | peper03: clue, look at partnumber/parttotal |
| [12:38:49] | stuarta: | while you think about it, i'll write patch v3 |
| [12:41:18] | peper03: | It's parsing the partnumber/total ok, so it's not that. It's got to be where it's trying to move the subtitle out of the description... |
| [12:44:29] | stuarta: | https://github.com/MythTV/mythtv/blob/master/ . . . xup.cpp#L778 |
| [12:44:45] | stuarta: | it never removes it from the description |
| [12:45:02] | stuarta: | so it gets promoted to the subtitle, breaking stuff |
| [12:46:00] | peper03: | That was what I pointed out earlier – http://irc.mythtv.org/ircLog/channel/4/2013-09-05:11:35:13 |
| [12:46:31] | peper03: | Don't quite get though why one episode gets a subtitle and the other doesn.t |
| [12:47:11] | stuarta: | there are some length restrictions on subtitles, we've previously had whole descriptions being stuffed into subtitle |
| [12:47:27] | stuarta: | so we limit the amount promoted to subtitle to fix this |
| [12:47:59] | jya: | peper03: easy way to prevent it would be to add a test checking if we're on a dvd menu before opening the OSD.. |
| [12:47:59] | peper03: | Ah, ok. So because the subtitle is now too long, it's left where it is. |
| [12:48:26] | jya: | having said that, i'm not sure why you would have to be in a loop when you're within a still frame |
| [12:48:29] | stuarta: | http://fpaste.org/37293/78385297/ much nicer |
| [12:51:05] | stuarta: | peper03: yep, you got it |
| [12:53:30] | peper03: | jya: We effectively need to poll for changes in the selected menu item. It might be possible to return from DVDRingBuffer and, in effect, move the loop outside it. Not sure how much overhead that would create. We could probably keep it from going outside of AvFormatDecoderDVD. |
| [12:55:37] | peper03: | stuarta: Yes. It certainly looks ugly at the beginning of the subtitle but I guess it's debatable about whether it should or shouldn't be left in the description. |
| [12:58:07] | stuarta: | i don't want it there, but somebody raised a ticket asking for it to be put back, and so it got patched, can't remember who by |
| [12:59:24] | peper03: | jya: Usually we only return from DVDRingBuffer when we have a frame of one form or another. ffmpeg gets upset if you don't do it (tends to throw away cached data) but it's probably do-able in this case. I already return once, right at the beginning of a still frame, so I can probably tweak it some more. I'll try to look later. |
| [12:59:58] | jya: | peper03: i have no DVD drive here, so I'll have no way to test |
| [13:00:17] | jya: | unless you have a iso file I could use to reproduce the issue |
| [13:01:52] | peper03: | jya: LangSPU_16x9.iso from the DVD samples repository should do it. |
| [13:03:14] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has quit (Ping timeout: 264 seconds) | |
| [13:03:49] | jya: | do you want me to look into it or you will ? |
| [13:04:12] | jya: | having said that, preventing the OSD plain and simple seems to just be a work around to a design issue |
| [13:04:35] | jya: | there would be menu item that should be accessible even within a menu |
| [13:06:01] | peper03: | If all else fails, we can look at preventing the OSD but getting it to return from the ringbuffer would be better and it's probably better if I look at that. It'll help refresh my memory again :) |
| [13:10:45] | danielk22 (danielk22!~danielk@exchange.wgen.net) has joined #mythtv | |
| [13:11:48] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has joined #mythtv | |
| [13:16:23] | stuarta: | ffs. my mini has locked up again. why does this happen since going to f19 ?? |
| [13:42:42] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has quit (Ping timeout: 264 seconds) | |
| [13:43:11] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has joined #mythtv | |
| [13:47:58] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [13:48:56] | dekarl (dekarl!~dekarl@p4FCEEFE4.dip0.t-ipconnect.de) has joined #mythtv | |
| [13:52:22] | knightr: | how is mythscreenwizard supposed to behave when in a window, with a not very old checkout of master it completly locked up... |
| [14:44:37] | stuarta: | peper03: my latest patch works fine, committing |
| [14:47:21] | dblain (dblain!~dblain@mythtv/developer/dblain) has quit (Ping timeout: 256 seconds) | |
| [15:06:15] | stichnot (stichnot!~stichnot@adsl-68-127-103-225.dsl.pltn13.pacbell.net) has quit (Ping timeout: 245 seconds) | |
| [15:06:34] | resprout (resprout!4b497bc8@gateway/web/freenode/ip.75.73.123.200) has joined #mythtv | |
| [15:12:48] | jpabq: | knightr: is that the wizard used to adjust the GUI dimensions? If so, I believe it was wagnerrp_ that was trying to make that work better. |
| [15:13:20] | knightr: | jpabq, yep it is... |
| [15:14:01] | jpabq: | Been a long time since I have tried to use it. |
| [15:14:50] | knightr: | I am not sure why but Myth is not entirely full screen since I updated a few packages and changed my TV and I think I had to play with that in the past so I wanted to make sure everything was reset... |
| [15:15:08] | knightr: | but it froze up when I tried... |
| [15:16:00] | knightr: | (it's not the only thing that froze up but I don't have the latest version so naybe I tried something else that was fixed...) |
| [15:18:13] | jpabq: | I believe you can reset the GUI offsets in the Setup->Appearance menu. |
| [15:19:40] | knightr: | jpabq, thank you, I'll most definitely try it... |
| [15:20:28] | knightr: | jpabq, is there an exhaustive list of what was change theme-wise between version (apart from the release notes)? I want to see if I can figure out how to fix a theme that has become unmaintained... |
| [15:20:50] | knightr: | (and that I unfortunately made translatable before I learned that...) |
| [15:22:11] | knightr: | (I always run master so it was always seen as available there...) |
| [15:25:13] | resprout (resprout!4b497bc8@gateway/web/freenode/ip.75.73.123.200) has quit (Quit: Page closed) | |
| [15:36:21] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [15:52:03] | jpabq: | knightr: I tried to include 'why' I was making a change to Steppes in the commit. I could send you the change log, if that would help. |
| [15:54:04] | jpabq: | knightr: most of the changes were due to the new notification-ui.xml that jya added. He was good about sending emails to the themers mailing list outlining what changes needed made to a theme. |
| [15:54:14] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has quit (Ping timeout: 264 seconds) | |
| [15:55:19] | knightr: | jpabq, that could help, thank you... |
| [15:55:49] | knightr: | looks like the theme was not even made available for 0.26 so it's not one but two versions of updates to apply to it... |
| [15:56:33] | jpabq: | In addition to the notification stuff, I see that I made changes because of [ea54bba385] and [f8d29ecf5] |
| [15:57:13] | resprout (resprout!~remerson@c-75-73-123-200.hsd1.mn.comcast.net) has joined #mythtv | |
| [15:57:55] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [15:58:17] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [15:58:20] | knightr: | The worst problem I seem to have with it is that it complains about some sort of dependency problem (I don't have the exact message, looks like I forgot to run mythfrontend with the appropriate switches to have it logs the error messages... |
| [15:58:38] | jpabq: | Ouch. I made a LOT more changes for 0.26 than I did for 0.27. Most of them were just tweaks that had nothing to do with mythui code changes. |
| [15:58:45] | jpabq: | -v gui |
| [16:01:13] | jpabq: | Upgrading a theme all the way from 0.25 to 0.27 will be a lot of work. Are you sure you are not better off just reverting your changes, and leave it alone? |
| [16:02:20] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has joined #mythtv | |
| [16:02:37] | knightr: | jpabq, they have already worked on it and a lot of them have already submitted their translations, I have to try... |
| [16:05:07] | knightr: | not everything breaks but there are at least a few places that do.. |
| [16:05:22] | resprout (resprout!~remerson@c-75-73-123-200.hsd1.mn.comcast.net) has left #mythtv () | |
| [16:06:14] | knightr: | AFAICT, not everything was themed, it relies a lot on the default theme... |
| [16:08:50] | stichnot (stichnot!~stichnot@207.198.105.23) has joined #mythtv | |
| [16:08:50] | stichnot (stichnot!~stichnot@207.198.105.23) has quit (Changing host) | |
| [16:08:50] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [16:08:59] | knightr: | you have 33 XML files, this theme has 14... |
| [16:10:41] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has quit (Quit: FabriceMG) | |
| [16:13:32] | rsiebert (rsiebert!~quassel@g224248062.adsl.alicedsl.de) has joined #mythtv | |
| [16:15:00] | rsiebert_ (rsiebert_!~quassel@e179169222.adsl.alicedsl.de) has quit (Ping timeout: 245 seconds) | |
| [16:17:22] | jpabq: | Okay, then it might not be too bad. |
| [16:18:24] | jpabq: | I honestly don't use any of the 'plugins'. Every time I have to fix Steppes for a plugin, I have to install it, and then remember how to use it ;-) |
| [16:19:37] | knightr: | :-) |
| [16:19:53] | knightr: | looks like at least one of the files was edited under Windows, it had CRs in addition to LFs at the end of lines... |
| [16:22:22] | rsiebert (rsiebert!~quassel@g224248062.adsl.alicedsl.de) has quit (Read error: Connection reset by peer) | |
| [16:22:44] | rsiebert (rsiebert!~quassel@g225052019.adsl.alicedsl.de) has joined #mythtv | |
| [16:28:07] | knightr: | jpabq, looks like I am going to have some fun nonetheless but I'll try to fix it one screen at a time... |
| [16:28:55] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Ping timeout: 260 seconds) | |
| [16:29:08] | knightr: | I will have to choose another theme to check whether my freeze in the screen wizard was related to its use, looks like that is themed as well... |
| [16:30:25] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 245 seconds) | |
| [16:30:27] | IReboot (IReboot!~doug@CPE10bf48e67915-CM78cd8e7e342d.cpe.net.cable.rogers.com) has joined #mythtv | |
| [16:37:44] | natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has joined #mythtv | |
| [16:53:18] | Merlin83b (Merlin83b!~Daniel@office.34sp.com) has quit (Quit: Leaving) | |
| [16:53:44] | Jordack (Jordack!~Jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [17:20:10] | SteveGoodey (SteveGoodey!~steve@host109-158-215-102.range109-158.btcentralplus.com) has joined #mythtv | |
| [17:44:03] | DJDan (DJDan!~djdan@115-64-177-188.static.tpgi.com.au) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.