| Thursday, April 11th, 2024, 01:01 UTC | ||
| [01:01:41] | peterbennett (peterbennett!~peter@216.208.179.90) has joined #mythtv | |
| [01:10:50] | peterbennett (peterbennett!~peter@216.208.179.90) has quit (Ping timeout: 256 seconds) | |
| [01:21:53] | peterbennett (peterbennett!~peter@216.208.179.90) has joined #mythtv | |
| [01:46:18] | peterbennett (peterbennett!~peter@216.208.179.90) has quit (Ping timeout: 252 seconds) | |
| [07:10:19] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d81:ed01:7a84:3cff:fedf:a99) has joined #mythtv | |
| [11:53:49] | SteveGoodey (SteveGoodey!~steve@host86-133-222-21.range86-133.btcentralplus.com) has joined #mythtv | |
| [12:24:20] | mad_enz (mad_enz!~mad_enz@2607:f2c0:e241:fe84:34ba:ad5c:18c3:c6a1) has quit (Remote host closed the connection) | |
| [13:04:30] | peterbennett (peterbennett!~peter@216.208.179.90) has joined #mythtv | |
| [13:09:13] | mad_enz (mad_enz!~mad_enz@24-246-32-138.cable.teksavvy.com) has joined #mythtv | |
| [13:14:19] | peterbennett (peterbennett!~peter@216.208.179.90) has quit (Ping timeout: 272 seconds) | |
| [13:20:57] | peterbennett (peterbennett!~peter@216.208.179.90) has joined #mythtv | |
| [13:40:00] | peterbennett (peterbennett!~peter@216.208.179.90) has quit (Ping timeout: 260 seconds) | |
| [14:17:37] | hampton: | That code is still in a double up until it is converted into a std::chrono type, and the template operates on both floats and doubles. (std::is_floating_point is true for both floats and doubles.) The conversion is direct from double to std::chrono. |
| [14:19:06] | hampton: | Using std::chrono you declare up front the precision you are interested in. That's why m_curTime is declared to be type std::chrono::milliseconds. If you are really interested in sub-millisecond times, that should be declared to be type |
| [14:20:46] | hampton: | to be type std::chrono::microseconds. In that case, the rest of the code that deals with video/audio/subtitle timestamps would probably also need to change to std::chrono::microseconds. |
| [14:21:34] | hampton: | The specific line you're looking at should probably be "m_curTime += millisecondsFromFloat(duration);" or "m_curTime += millisecondsFromFloat(duration*1000);" since m_curTime is in milliseconds. |
| [14:22:59] | hampton: | I can do a mass rename of the functions if we have better names. I can also add a function that takes a float/double time in seconds and returns a std::chrono::millisecond variable, which is what you were expecting from the original function. |
| [15:27:03] | peterbennett (peterbennett!~peter@216.208.179.90) has joined #mythtv | |
| [15:50:45] | peterbennett (peterbennett!~peter@216.208.179.90) has quit (Ping timeout: 272 seconds) | |
| [17:00:13] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d81:ed01:7a84:3cff:fedf:a99) has quit (Quit: Konversation terminated!) | |
| [17:06:25] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d81:ed01:7a84:3cff:fedf:a99) has joined #mythtv | |
| [18:40:50] | vqueiroz (vqueiroz!uid340368@id-340368.hampstead.irccloud.com) has joined #mythtv | |
| [20:49:40] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d81:ed01:7a84:3cff:fedf:a99) has quit (Quit: Konversation terminated!) | |
| [21:03:09] | warpme (warpme!~warpme@84-10-100-139.static.chello.pl) has joined #mythtv | |
| [21:07:28] | stuartm (stuartm!~gbee@mythtv/developer/stuartm) has quit (Ping timeout: 268 seconds) | |
| [21:25:18] | warpme (warpme!~warpme@84-10-100-139.static.chello.pl) has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) | |
| [21:30:37] | SteveGoodey (SteveGoodey!~steve@host86-133-222-21.range86-133.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [22:32:22] | peterbennett (peterbennett!~peter@216.208.179.90) has joined #mythtv | |
| [22:43:35] | peterbennett (peterbennett!~peter@216.208.179.90) has quit (Ping timeout: 252 seconds) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.