Sunday, January 9th, 2022, 00:17 UTC | ||
[00:17:15] | peper03_ (peper03_!~peper03@mythtv/developer/peper03) has joined #mythtv | |
[00:18:25] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 256 seconds) | |
[00:20:41] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has quit (Ping timeout: 256 seconds) | |
[00:33:15] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[00:33:15] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[01:42:25] | MythBuild: | Build [#307](https://code.mythtv.org/buildbot/#builders/204/builds/307) of `clazy-master` 3completed successfully. |
[01:45:42] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[02:25:22] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
[02:26:38] | peper03_ (peper03_!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 256 seconds) | |
[03:35:38] | DevMythNotifyBot: | pull_request synchronize by ulmus-scott, "Minor cleanup to audio code": https://github.com/MythTV/mythtv/pull/443 |
[04:10:30] | peper03_ (peper03_!~peper03@mythtv/developer/peper03) has joined #mythtv | |
[04:12:02] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 256 seconds) | |
[07:11:34] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[09:49:08] | SteveGoodey (SteveGoodey!~steve@2a00:23c5:7d83:6501:fa68:6631:5ed6:d871) has joined #mythtv | |
[10:39:24] | ircs (ircs!~ircs@2-111-85-72-cable.dk.customer.tdc.net) has joined #mythtv | |
[10:52:20] | ircs (ircs!~ircs@2-111-85-72-cable.dk.customer.tdc.net) has quit (Read error: Connection reset by peer) | |
[13:55:56] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[13:55:56] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[14:38:03] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161467-cust2666.vm29.cable.virginm.net) has joined #mythtv | |
[14:38:03] | paul-h (paul-h!~paul@mythtv/developer/paul-h) has joined #mythtv | |
[14:38:03] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161467-cust2666.vm29.cable.virginm.net) has quit (Changing host) | |
[14:38:03] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v paul-h | |
[14:52:32] | DevMythNotifyBot: | COMMIT: billmeek pushed 1 commit(s) to branch master: https://github.com/MythTV/mythtv/compare/a4f2 . . . a1e72a209bfa |
[14:52:32] | DevMythNotifyBot: | issue closed by billmeek, "Suspicious websites in "AllowedOriginsList"": https://github.com/MythTV/mythtv/issues/453 |
[15:03:32] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[15:28:58] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[15:28:58] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[16:14:00] | paul-h: | Maybe we should just add a MythCenterCLASSIC theme to the themes repo and hope if something does break someone will step up to fix it |
[16:14:42] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[16:14:46] | paul-h: | It's not as though themes need changing that often these anyway |
[16:29:20] | DevMythNotifyBot: | issue assigned by linuxdude42, "Recording watching progress on recordings list": https://github.com/MythTV/mythtv/issues/331 |
[16:29:27] | DevMythNotifyBot: | issue milestoned by linuxdude42, "Recording watching progress on recordings list": https://github.com/MythTV/mythtv/issues/331 |
[16:29:54] | DevMythNotifyBot: | issue labeled by linuxdude42, "Recording watching progress on recordings list": https://github.com/MythTV/mythtv/issues/331 Labels: "task:developer" |
[16:49:32] | Warped (Warped!~Warped@user/warped) has quit (Quit: We Gone! Bye Bye) | |
[16:51:12] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[17:09:10] | stuarta: | evening |
[17:10:18] | stuarta: | paul-h: i've been contemplating if we need a concept of theme compatibility version (or similar name) as the theme "api" hasn't fundamentally changed for several versions and all we are doing is repackaging the same themes over and over again |
[17:14:06] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[17:40:39] | paul-h: | stuarta: yeah something like that could work. At the moment often what I need to do is commit a change to the themes master branch and then cherry-pick it to any earlier branches since they usually need the same changes |
[17:40:53] | stuarta: | yeah exactly |
[17:41:07] | stuarta: | feature development in themes has definitely stopped |
[17:42:28] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[17:42:28] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[17:42:40] | paul-h: | What brought it up was the discussion with David on the developers list about adding some new stuff to the Watch Recording screen :) |
[17:42:55] | stuarta: | i caught up with that eventually :-) |
[17:47:39] | paul-h: | Is the $ sign here just part of the name or is there some other meaning m_hostname$!: Observable<MythHostName>; |
[17:49:39] | stuarta: | it's a convention that indicates it's an observable, versus a normal variable |
[17:50:04] | stuarta: | a convention from Angular, thought it would be good practice to follow them |
[17:51:22] | stuarta: | in case you hadn't worked it out, the data for the observable comes from the service |
[17:52:01] | stuarta: | in this case html/backend/src/app/services/myth.service.ts |
[17:53:01] | stuarta: | i like the way angular has designed this service interface |
[17:53:07] | stuarta: | it's clean, and typed as well |
[17:54:17] | stuarta: | back to your question the $ is technically part of the variable name, but as mentioned it's a convention |
[17:57:53] | paul-h: | Thanks so it's just a naming convention I was just curious I found info on the ! meaning the variable should never be null or undefined but nothing about the $ |
[17:58:27] | stuarta: | yup, i ran into it when looking into writing the services |
[17:58:51] | stuarta: | btw. hope you have been using angular to create the templates for the components you write? |
[17:59:00] | stuarta: | very handy |
[18:00:35] | paul-h: | The ng cli you mean |
[18:00:50] | paul-h: | ng create component |
[18:00:52] | stuarta: | yup |
[18:01:01] | stuarta: | ng is short for angular |
[18:01:12] | stuarta: | devs clearly don't like typing much |
[18:01:15] | stuarta: | :-p |
[18:06:46] | Warped (Warped!~Warped@user/warped) has joined #mythtv | |
[18:07:11] | paul-h: | I've added a new GetConnectionInfo() in MythService which uses the /Myth/GetConnectionInfo endpoint |
[18:07:22] | stuarta: | cool |
[18:07:32] | stuarta: | did you find the interfaces definition for the service? |
[18:08:04] | stuarta: | that sets up all the datatype for the interface |
[18:10:41] | paul-h: | I added it to mirror what you have done for the other GetHostName and GetTimeZone |
[18:11:29] | stuarta: | that's pretty much it. i like that visual studio then does autocompletion when coding because it knows the types |
[18:12:09] | paul-h: | Also added some demo output in home like you have but for Version, Protocol etc just to prove it works |
[18:12:17] | DevMythNotifyBot: | issue opened by KungFuJesus, "Allow usage of experimental DVB mmap API": https://github.com/MythTV/mythtv/issues/454 |
[18:12:36] | stuarta: | yep, that's the best way to implement the skeleton, then it can be fleshed out as you go |
[18:13:05] | stuarta: | i'm quite liking angular. to the point where i think i'll go back and redo the frontend web app in it |
[18:14:27] | paul-h: | Just struggling to do the POST version to push the connection data the other way I figure it out |
[18:15:01] | stuarta: | oh that... lemme check |
[18:15:19] | stuarta: | prob a property on the call |
[18:16:15] | stuarta: | right, so where the existing services have this.httpClient.get<...> you should be able to do this.httpClient.post<...> |
[18:17:22] | stuarta: | https://angular.io/guide/http#sending-data-to-a-server |
[18:19:26] | stuarta: | https://angular.io/api/common/http/HttpClient#post |
[18:19:53] | stuarta: | it's basically .post(url, body, options) |
[18:20:52] | stuarta: | i'll have to do something similar when implenting the guide data part, as that needs body options to the get to provide the start and end time etc |
[18:22:05] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[18:59:17] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has joined #mythtv | |
[19:08:37] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[19:08:37] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[19:30:45] | zbot` (zbot`!~limnoria@2601:647:4802:4c3:222:4dff:fe51:6728) has quit (Remote host closed the connection) | |
[19:33:23] | zbot (zbot!~limnoria@2601:647:4802:4c3:222:4dff:fe51:6728) has joined #mythtv | |
[19:46:51] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[20:36:38] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[20:36:38] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[20:48:41] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[20:59:23] | amessina (amessina!~amessina@user/amessina) has joined #mythtv | |
[21:07:21] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has quit (Ping timeout: 256 seconds) | |
[21:24:45] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has joined #mythtv | |
[21:37:44] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[21:38:25] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[21:38:25] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[21:42:35] | amessina (amessina!~amessina@user/amessina) has quit (Remote host closed the connection) | |
[22:10:42] | SteveGoodey (SteveGoodey!~steve@2a00:23c5:7d83:6501:fa68:6631:5ed6:d871) has quit (Quit: Konversation terminated!) | |
[22:47:05] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[23:32:59] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has quit (Ping timeout: 256 seconds) |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.