| Friday, November 27th, 2020, 00:12 UTC | ||
| [00:12:34] | Warped (Warped!~Warped@unaffiliated/warped) has quit (Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]) | |
| [00:41:35] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [02:11:18] | markspieth2 (markspieth2!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [02:11:28] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [02:11:28] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [02:36:37] | davic (davic!uid473656@gateway/web/irccloud.com/x-weoaqlphfxdxetge) has quit (Quit: Connection closed for inactivity) | |
| [03:14:47] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [03:14:47] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [03:31:13] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [03:33:31] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [03:33:31] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [03:48:08] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [04:28:23] | Warped (Warped!~Warped@unaffiliated/warped) has joined #mythtv | |
| [04:40:30] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Quit: Konversation terminated!) | |
| [04:42:03] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [05:22:50] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Remote host closed the connection) | |
| [06:03:09] | Guest56777 (Guest56777!maliutamat@gateway/shell/matrix.org/x-cctqpnplwukvbfoa) has quit (Changing host) | |
| [06:03:10] | Guest56777 (Guest56777!maliutamat@unaffiliated/maliuta) has joined #mythtv | |
| [06:03:10] | Guest56777 (Guest56777!maliutamat@gateway/shell/matrix.org/x-cctqpnplwukvbfoa) has joined #mythtv | |
| [06:03:10] | Guest56777 (Guest56777!maliutamat@unaffiliated/maliuta) has quit (Changing host) | |
| [06:30:01] | peterbennett (peterbennett!~pi@mythtv/developer/peterbennett) has quit (Quit: WeeChat 2.3) | |
| [06:32:12] | peterbennett (peterbennett!~pi@c-75-67-203-208.hsd1.ma.comcast.net) has joined #mythtv | |
| [06:32:13] | peterbennett (peterbennett!~pi@c-75-67-203-208.hsd1.ma.comcast.net) has quit (Changing host) | |
| [06:32:13] | peterbennett (peterbennett!~pi@mythtv/developer/peterbennett) has joined #mythtv | |
| [06:32:13] | Mode for #mythtv by ChanServ!ChanServ@services. : +v peterbennett | |
| [07:31:12] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [07:38:27] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [07:38:27] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [07:52:00] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has joined #mythtv | |
| [07:57:04] | markk_: | stuarta: my original point last night re API/sugarcoating was nothing more than wrapping a css/html template (?) around a service description for presentation purposes. something that I've done before with jqueryui (fairly straightforward) – not so sure how it works with materializecss/svelte |
| [08:06:22] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [08:06:22] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [08:35:20] | stuarta: | markk_: right, you mean for the html endpoints? |
| [08:37:13] | stuarta: | in case you missed it last night, the xslt we already have, is the sugar coating for the xml to make it display nice in the browser -> https://www.w3schools.com/xml/xml_xslt.asp |
| [08:38:39] | stuarta: | markk_: the way i see it, is if we make sure all the existing endpoints continue to return what they do today (ie, xml/json depending on headers) then we are all good from the webserver perspective |
| [08:38:48] | stuarta: | (i'm glossing over upnp here) |
| [08:39:52] | stuarta: | then we can work on ensuring the non compliant endpoints (ie. status) are made compliant, and plug any gaps left by stuff currently done through qsp |
| [08:42:20] | stuarta: | json doesn't need anything wrapping around it, just xml, which we already have |
| [08:42:35] | stuarta: | and tbh, the web view of the xml is mainly for developers these days |
| [08:44:35] | stuarta: | although it is useful for finding out what endpoints are available, and what might need passing in to make them function |
| [08:44:50] | stuarta: | even when pulling json responses |
| [08:49:16] | markk_: | stuarta: agreed on all of that:) what I'm currently 'struggling' with is the custom/compound types returned by some existing services. so I think part of the serialiser complexity is down to return these types – which need to be serialised correctly – especially for the wsdl side. |
| [08:50:08] | markk_: | in a nutshell – wsdl seems to be driving a lot of code/complexity. |
| [08:50:23] | stuarta: | biab, have to take car to garage |
| [08:50:57] | markk_: | but the real issue for me is replicating those return types – to ensure the consistency from old to new. |
| [09:22:16] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has quit (Ping timeout: 240 seconds) | |
| [09:27:36] | stuarta: | yeah that's the hard part |
| [10:07:39] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has joined #mythtv | |
| [10:10:59] | stuarta: | markk_: are we generating the wsdl on the fly? |
| [10:12:28] | markk_: | stuarta: yes – it's all dynamic. introspection of QObject essentially. |
| [10:12:48] | stuarta: | ugh |
| [10:14:03] | markk_: | stuarta: I think I'll have to replicate some of the current approach to get the custom return types to work. not worried about it so much for the frontend service – as I doubt anyone is using it and I want to bring it in line with changes to state management in the player code. |
| [10:14:07] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [10:14:24] | markk_: | on the upside – should ensure we can keep wsdl functionality |
| [10:14:36] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [10:15:12] | stuarta: | there isn't much in the frontend web services |
| [10:16:23] | markk_: | yeah – but it's where I started, is simple to deal with and it will apply to the more complicated backend services |
| [10:17:03] | stuarta: | exact same reason i ended up doing the frontend web app first |
| [10:45:25] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [11:03:27] | markk_: | bah – this is a nightmare:) |
| [11:18:46] | stuarta: | is there anyway we can help? |
| [11:19:04] | stuarta: | ie. is it sufficiently compartmentalized that the web server bit can be added to a branch? |
| [11:23:22] | markk_: | stuarta: I'm getting there. but so much extra code to support compound types when the api would probably be better by just returning simple types in the first place... |
| [11:26:41] | stuarta: | what compound types are there that need explicit handling? |
| [11:29:49] | markk_: | stuarta: in the frontend for example: https://github.com/MythTV/mythtv/blob/master/ . . . ontend.h#L18 |
| [11:29:58] | markk_: | that type is implemented in: https://github.com/MythTV/mythtv/blob/master/ . . . tendStatus.h |
| [11:30:06] | markk_: | but it doesn't really add any value |
| [11:31:13] | stuarta: | ah i see, it's a compound type which wraps the actual data |
| [11:31:30] | markk_: | and then we have to explicitly handle the serialisation of the each QObject* subclass |
| [11:32:40] | markk_: | well – not explicitly for each type – but we can't just call QJsonDocument::fromVariant() for example |
| [11:35:37] | stuarta: | ah i think this might explain why the json response is wrapped in a top level name "FrontendStatus" https://paste.centos.org/view/5ff4d8e3 |
| [11:36:17] | stuarta: | reading about json/xml capabilities in Qt, i read somewhere that the top level name is taken from the object's class name |
| [11:39:14] | markk_: | stuarta: yes – all sorts of custom typenames and names in play for various services – which is i think again the wsdl tail wagging the dog :) if you compare the json and xml responses – I'm not sure they are technically the same either (i.e. if you de-serialise them, the resulting data structure is not the same) |
| [11:41:02] | stuarta: | having said that, json fundamentally doesn't care, because they are generally key/value pairs (even if the value is then another key/value pair or an array etc) |
| [11:41:27] | stuarta: | you can mix the output up and still be able to utilize the same data |
| [11:43:30] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Read error: Connection reset by peer) | |
| [11:43:39] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [11:43:40] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [11:44:40] | markk_: | stuarta: yes – I guess you're right – json is more fluid whereas xml probably needs the types to be explicitly provided |
| [11:46:30] | stuarta: | that's my understanding |
| [11:48:59] | markk_: | oh – just found where in the code we were using the DESIGNABLE property. hrm – there must be some broken stuff somewhere |
| [11:50:12] | stuarta: | i'm sure there is plenty |
| [11:50:20] | blahdodo (blahdodo!~blahdodo@69.172.160.6) has quit (Quit: Bye bye) | |
| [11:50:21] | stuarta: | this codebase is very krufty |
| [11:55:54] | blahdodo (blahdodo!~blahdodo@69.172.160.6) has joined #mythtv | |
| [12:51:35] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [12:51:35] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [13:09:25] | davic (davic!uid473656@gateway/web/irccloud.com/x-hdondcbjgknixwtp) has joined #mythtv | |
| [13:12:44] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has quit (Ping timeout: 256 seconds) | |
| [13:56:10] | bill6502 (bill6502!~bill@205.178.34.90) has joined #mythtv | |
| [14:00:30] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has joined #mythtv | |
| [14:02:53] | hampton: | So not that the source is on github, is applying a patch truly as simple as clicking "rebase and merge"? |
| [14:13:57] | markk_: | hampton: ?? locally or on github? |
| [14:19:02] | hampton: | on github |
| [14:22:18] | markk_: | hampton: assuming you are talking about prs – then yes, should be. though if it goes wrong, blame someone else :) |
| [14:23:10] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [14:23:27] | bill6502: | markk_: not sure this is on-point, but: re DESIGNABLE, https://code.mythtv.org/trac/changeset/82ffe9d36cf |
| [14:28:08] | markk_: | bill6502: I realised the problem with that commit earlier; David used the designable flag as a filter for properties that should be exposed via the services API. |
| [14:28:10] | markk_: | https://github.com/MythTV/mythtv/blob/master/ . . . zer.cpp#L115 |
| [14:28:35] | markk_: | so I think there are now various extra elements returned from calls to services APIs |
| [14:29:00] | markk_: | not really an issue – but something to be aware of |
| [14:29:35] | hampton: | Interesing. isDesignalbe wouldn't show up in a search for DESIGNABLE. |
| [14:29:52] | ** hampton needs to get back to working on Qt6 support ** | |
| [14:30:12] | markk_: | (I'm assuming the isDesignable call is defaulting to returning true – otherwise many of the service api's would be broken) |
| [14:31:27] | hampton: | The DESIGNABLE attribute indicates whether the property should be visible in the property editor of GUI design tool (e.g., Qt Designer). Most properties are DESIGNABLE (default true). Instead of true or false, you can specify a boolean member function. |
| [14:33:12] | hampton: | The Qt6 doc says the same thing, but I could have sworn it threw a ton of errors last summer when I was trying to compile with qt6. |
| [14:34:30] | stuarta: | hampton: yep it is |
| [14:37:12] | stuarta: | ^^^ the PR's that is. 1 click merge |
| [14:37:25] | stuarta: | did it with the fix for osx media monitor the other day |
| [14:41:58] | hampton: | Ah, found it. The issue was that in Qt5, DESIGNABLE could take a function name instead of just true/false. It Qt6 it can only be true/false. The default is true. |
| [14:43:03] | hampton: | Bill's commit removed a lot of redundantly assigning true, and some places that used the function SerializeDetails, which iirc always returned true. |
| [14:43:45] | hampton: | Gotta run... |
| [14:52:13] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has quit (Ping timeout: 260 seconds) | |
| [15:27:55] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [15:34:47] | madder_enz (madder_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [15:35:06] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has joined #mythtv | |
| [15:35:31] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Read error: Connection reset by peer) | |
| [15:56:53] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [15:56:53] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [16:09:32] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Ping timeout: 260 seconds) | |
| [16:36:22] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [16:58:02] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [16:59:53] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [17:00:28] | madder_enz (madder_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Ping timeout: 246 seconds) | |
| [17:01:22] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has joined #mythtv | |
| [17:41:03] | hampton: | markk_: Got a question for you. Any idea why tv_play.cpp has a bunch of calls to DoSeek(m_playerContext.m_jumptime * 60, ...). Best I can tell, m_jumptime is in seconds (assigned at playercontext.cpp:529) and DoSeek takes a first argument of seconds. |
| [17:55:15] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [18:03:16] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [18:03:16] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [18:07:18] | SteveJGoodey (SteveJGoodey!~quassel@2a00:23c5:7d83:6501:2930:7bc0:a47b:b7b3) has joined #mythtv | |
| [18:07:18] | Mode for #mythtv by ChanServ!ChanServ@services. : +v SteveJGoodey | |
| [18:34:17] | SteveJGoodey (SteveJGoodey!~quassel@2a00:23c5:7d83:6501:2930:7bc0:a47b:b7b3) has quit (Ping timeout: 272 seconds) | |
| [18:36:13] | markk_ (markk_!~mark@host86-150-127-252.range86-150.btcentralplus.com) has quit (Ping timeout: 264 seconds) | |
| [19:09:17] | stuarta: | hampton: at a guess, that might be the skip amount when using right/left arrow |
| [19:33:27] | jpabq (jpabq!~quassel@mythtv/developer/jpabq) has joined #mythtv | |
| [19:33:27] | Mode for #mythtv by ChanServ!ChanServ@services. : +v jpabq | |
| [19:39:47] | markk_ (markk_!uid459905@gateway/web/irccloud.com/x-tbwqhhmojcvdkmbj) has joined #mythtv | |
| [20:01:11] | SteveJGoodey (SteveJGoodey!~quassel@2a00:23c5:7d83:6501:e5be:9035:742d:bb12) has joined #mythtv | |
| [20:01:11] | Mode for #mythtv by ChanServ!ChanServ@services. : +v SteveJGoodey | |
| [21:12:37] | SteveJGoodey (SteveJGoodey!~quassel@2a00:23c5:7d83:6501:e5be:9035:742d:bb12) has quit (Ping timeout: 272 seconds) | |
| [21:22:30] | ElmerFudd (ElmerFudd!~le@jagular.dk) has quit (Ping timeout: 256 seconds) | |
| [21:22:53] | ElmerFudd (ElmerFudd!~le@jagular.dk) has joined #mythtv | |
| [21:24:27] | ** hampton facepalms ** | |
| [21:24:57] | hampton: | right/left arrow for me are 30s/5s. Up/down arrow is 10m/10m. |
| [21:25:24] | hampton: | Duh, we do have a jump time defined in minutes. They aren't all defined in seconds. |
| [21:27:27] | hampton: | I've been staring off and on for the last two days at three jump timing variables defined as 'int' thinking they were all supposed to be seconds. |
| [21:28:33] | scilib (scilib!~libsci@unaffiliated/libsci) has joined #mythtv | |
| [21:28:51] | hampton: | This is exactly why I think I should continue converting away from int/int64_t/uint64_t/long/long long/unsigned long/long to the explicitly named variable types std::chrono::minutes/std::chrono::seconds/std::chrono::milliseconds. |
| [21:29:52] | libsci (libsci!~libsci@unaffiliated/libsci) has quit (Ping timeout: 256 seconds) | |
| [21:38:57] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [21:39:30] | knowledgejunkie (knowledgejunkie!~knowledge@cpc77018-warw18-2-0-cust959.3-2.cable.virginm.net) has quit (Ping timeout: 256 seconds) | |
| [21:39:36] | knowledgejunkie (knowledgejunkie!~knowledge@cpc77018-warw18-2-0-cust959.3-2.cable.virginm.net) has joined #mythtv | |
| [21:54:18] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Ping timeout: 260 seconds) | |
| [21:57:16] | hampton: | Not to mention using a float for seconds as well. :-/ |
| [22:00:27] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [22:04:11] | xris (xris!~xris@mythtv/developer/xris) has quit (Quit: Goodbye.) | |
| [23:09:08] | markk_ (markk_!uid459905@gateway/web/irccloud.com/x-tbwqhhmojcvdkmbj) has quit (Quit: Connection closed for inactivity) | |
| [23:59:16] | bill6502 (bill6502!~bill@205.178.34.90) has left #mythtv () | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.