| Wednesday, November 25th, 2020, 00:46 UTC | ||
| [00:46:47] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Quit: Konversation terminated!) | |
| [01:04:12] | davic (davic!uid473656@gateway/web/irccloud.com/x-cpklqwlqvbjigobz) has quit (Quit: Connection closed for inactivity) | |
| [03:21:30] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [03:23:29] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [03:23:30] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [04:37:48] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [04:38:21] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [04:38:21] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [06:30:00] | peterbennett (peterbennett!~pi@mythtv/developer/peterbennett) has quit (Quit: WeeChat 2.3) | |
| [06:31:44] | markspieth2 (markspieth2!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [06:31:44] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth2 | |
| [06:32:02] | peterbennett (peterbennett!~pi@2601:183:100:b4:8f20:bbe4:c401:b4d9) has joined #mythtv | |
| [06:32:04] | peterbennett (peterbennett!~pi@2601:183:100:b4:8f20:bbe4:c401:b4d9) has quit (Changing host) | |
| [06:32:04] | peterbennett (peterbennett!~pi@mythtv/developer/peterbennett) has joined #mythtv | |
| [06:32:05] | Mode for #mythtv by ChanServ!ChanServ@services. : +v peterbennett | |
| [06:34:00] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [07:03:29] | markspieth2 (markspieth2!~yaaic@mythtv/developer/markspieth) has quit (Read error: Connection reset by peer) | |
| [07:03:38] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [07:03:38] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [07:26:51] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [07:26:51] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [07:34:53] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has joined #mythtv | |
| [07:42:16] | markk_: | sturta: looking better :) still falls over looking for /Frontend/GetStatus on the main page (haven't tracked that down) – but I'm almost ready with services part of the new code – so will point it to new when ready. |
| [07:42:30] | markk_: | stuarta: ^^ |
| [08:22:51] | markk_: | stuarta: I think you hinted at this a few days ago – is there a reason the json serialiser uses custom code rather than just calling QJsonDocument ? |
| [08:30:59] | stuarta: | markk_: i had been wondering the same thing, although i don't believe QJsonDocument does the necessary escaping |
| [08:31:35] | stuarta: | markk_: you should at least be able to see it just with "loading..." where it wants data |
| [08:31:55] | stuarta: | also the xml serializer hand cranks xml |
| [08:35:02] | markk_: | stuarta: so when is the escaping necessary? (i.e. how can I test easily) |
| [08:38:05] | stuarta: | https://github.com/MythTV/mythtv/blob/master/ . . . zer.cpp#L228 |
| [08:38:25] | stuarta: | https://www.freeformatter.com/json-escape.html |
| [08:45:14] | markk_: | hrm – I'm hoping we can get rid of libmythservicecontracts |
| [09:02:33] | stuarta: | i've never really been clear on why we have them |
| [09:04:58] | markk_: | well – not needed with the new code – which hadn't dawned on me until this morning:) |
| [09:05:31] | davic (davic!uid473656@gateway/web/irccloud.com/x-duqkffckfzhpdddk) has joined #mythtv | |
| [09:38:40] | knowledgejunkie (knowledgejunkie!~knowledge@cpc77018-warw18-2-0-cust959.3-2.cable.virginm.net) has quit (Ping timeout: 256 seconds) | |
| [09:48:23] | stuarta: | bah qjsondocument needs to be assembled from qjsonobject's and qjsonarrays |
| [09:48:33] | stuarta: | so there is still some need for a serializer |
| [09:48:57] | stuarta: | it however should be possible to use the Qt classes rather than hand cranking it |
| [09:52:56] | stuarta: | markk_: yay, it does to the escaping |
| [09:55:00] | stuarta: | https://paste.centos.org/view/cddd58c2 |
| [09:55:32] | stuarta: | should be able to make that into a test case |
| [09:56:44] | stuarta: | that doesn't paste the XON/XOFF chars properly |
| [09:56:48] | ** stuarta cleans up ** | |
| [10:01:02] | knowledgejunkie (knowledgejunkie!~knowledge@cpc77018-warw18-2-0-cust959.3-2.cable.virginm.net) has joined #mythtv | |
| [10:01:50] | stuarta: | markk_: updated version https://paste.centos.org/view/f889c308 |
| [10:03:07] | stuarta: | markk_: do you want me to take a look at the json serializer and replacing it with QJsonDocument??? |
| [10:04:27] | markk_: | stuarta: funnily enough I've just done it – and you have just saved me 10 minutes trying to find out why it doesn't work:) |
| [10:04:36] | stuarta: | hah |
| [10:04:48] | stuarta: | and you have a test case too :-p |
| [10:05:14] | stuarta: | for bonus points, xmlserializer is even worse :-p |
| [10:09:37] | stuarta: | but, tbh, right now i only care for json |
| [10:12:06] | blahdodo (blahdodo!~blahdodo@69.172.160.6) has quit (Ping timeout: 256 seconds) | |
| [10:21:06] | blahdodo (blahdodo!~blahdodo@69.172.160.6) has joined #mythtv | |
| [11:31:57] | zbot (zbot!~supybot@2601:647:4802:4c3:222:4dff:fe51:6728) has quit (Ping timeout: 260 seconds) | |
| [11:38:32] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has quit (Ping timeout: 272 seconds) | |
| [11:52:51] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has joined #mythtv | |
| [12:26:45] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Ping timeout: 240 seconds) | |
| [12:28:15] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [13:13:25] | zbot (zbot!~supybot@2601:647:4802:4c3:222:4dff:fe51:6728) has joined #mythtv | |
| [13:32:20] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has quit (Ping timeout: 265 seconds) | |
| [13:55:08] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has joined #mythtv | |
| [15:33:31] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has quit (Ping timeout: 246 seconds) | |
| [15:34:25] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Ping timeout: 240 seconds) | |
| [15:36:19] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [15:47:18] | stuarta: | hampton: any idea why the checks on this failed? https://github.com/MythTV/mythtv/pull/287 |
| [16:10:21] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has joined #mythtv | |
| [16:29:05] | markk_: | stuarta: that is a github security fix issue. I updated master – must have forgotten fixes |
| [16:39:55] | stuarta: | ah cool |
| [16:52:48] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [16:59:39] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [16:59:39] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [17:25:10] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has quit (Ping timeout: 246 seconds) | |
| [17:46:53] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has joined #mythtv | |
| [18:30:27] | hampton: | I'm glad mark knew what that was, because I wouldn't have had a clue. |
| [18:46:35] | stuarta: | hampton: i wasn't sure if it was you or markk_ so glad he knows what needs to be fixed |
| [18:53:31] | ** hampton is looking at replacing uint64_t and 'long long' with std::chrono::seconds and std::chrono::milliseconds as appropriate ** | |
| [18:53:52] | hampton: | I didn't realize just how many time values are scattered throughout the code base. |
| [18:54:25] | hampton: | Did find one spot where three of four function overrides returned milliseconds and the last returned seconds. |
| [18:55:45] | hampton: | Now looking at a function where an one argument might be a position or a time, and the return is also a position or a time depending on the values of two other arguments to that function. |
| [18:55:54] | hampton: | Actually several functions like this. |
| [18:55:59] | ** hampton sighs ** | |
| [18:56:11] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has quit (Quit: rebooting) | |
| [18:56:17] | MythNotifyBot (MythNotifyBot!~cinch@2a02:390:790f:1:7210:6fff:feca:576c) has quit (Remote host closed the connection) | |
| [18:59:28] | MythNotifyBot (MythNotifyBot!~cinch@2a02:390:790f:1:7210:6fff:feca:576c) has joined #mythtv | |
| [19:10:31] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has quit (Ping timeout: 246 seconds) | |
| [19:25:45] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [19:28:19] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [19:28:20] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [19:40:20] | stuarta (stuarta!~stuarta@2a02:390:790f:1:7210:6fff:feca:576c) has joined #mythtv | |
| [19:40:20] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has joined #mythtv | |
| [19:40:20] | stuarta (stuarta!~stuarta@2a02:390:790f:1:7210:6fff:feca:576c) has quit (Changing host) | |
| [19:40:20] | Mode for #mythtv by ChanServ!ChanServ@services. : +v stuarta | |
| [20:03:48] | hampton (hampton!~dhampton@mythtv/developer/hampton) has quit (Ping timeout: 260 seconds) | |
| [20:17:31] | hampton (hampton!~dhampton@static-68-134-82-17.bltmmd.fios.verizon.net) has joined #mythtv | |
| [20:18:00] | hampton (hampton!~dhampton@static-68-134-82-17.bltmmd.fios.verizon.net) has quit (Changing host) | |
| [20:18:01] | hampton (hampton!~dhampton@mythtv/developer/hampton) has joined #mythtv | |
| [20:18:01] | Mode for #mythtv by ChanServ!ChanServ@services. : +v hampton | |
| [20:22:00] | hampton: | Fun, the code also uses float to represent seconds. |
| [20:59:53] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has joined #mythtv | |
| [21:22:52] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [21:30:00] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 246 seconds) | |
| [21:33:28] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [21:33:28] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [21:40:42] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Read error: Connection reset by peer) | |
| [21:40:51] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [21:40:51] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [21:54:36] | madder_enz (madder_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has joined #mythtv | |
| [21:54:36] | mad_enz (mad_enz!~mad_enz@cpe00508b114c3e-cmf0f249d13d30.cpe.net.cable.rogers.com) has quit (Ping timeout: 240 seconds) | |
| [22:37:12] | davic (davic!uid473656@gateway/web/irccloud.com/x-duqkffckfzhpdddk) has quit (Quit: Connection closed for inactivity) | |
| [23:30:08] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [23:36:43] | markk_ (markk_!~mark@host86-172-134-211.range86-172.btcentralplus.com) has quit (Ping timeout: 260 seconds) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.