Monday, June 22nd, 2020, 02:20 UTC | ||
[02:20:14] | blahdodo (blahdodo!~blahdodo@69.172.190.84) has quit (Read error: Connection reset by peer) | |
[02:23:47] | blahdodo (blahdodo!~blahdodo@69.172.190.84) has joined #mythtv | |
[02:25:17] | Guest80643 (Guest80643!maliutamat@gateway/shell/matrix.org/x-xxkfoorneqdaxpwl) has quit (Changing host) | |
[02:25:18] | Guest80643 (Guest80643!maliutamat@unaffiliated/maliuta) has joined #mythtv | |
[02:25:18] | Guest80643 (Guest80643!maliutamat@unaffiliated/maliuta) has quit (Changing host) | |
[02:25:18] | Guest80643 (Guest80643!maliutamat@gateway/shell/matrix.org/x-xxkfoorneqdaxpwl) has joined #mythtv | |
[02:25:21] | Guest80643 is now known as Maliuta | |
[02:26:26] | blahdodo (blahdodo!~blahdodo@69.172.190.84) has quit (Read error: Connection reset by peer) | |
[02:51:26] | hampton: | jpabq: Can you look at the warnings in https://code.mythtv.org/buildbot/#/builders/188/builds/34&nbs p;? They're all related to your HEVCParser changes. |
[03:36:48] | blahdodo (blahdodo!~blahdodo@69.172.190.84) has joined #mythtv | |
[04:11:25] | jpabq: | hampton: will do. Not sure what it means by "4 padding bytes, where 0 is optimal", though. |
[06:16:55] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
[06:16:55] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
[07:50:10] | RokLobsta (RokLobsta!~Dirkka@121-200-12-5.79c80c.mel.nbn.aussiebb.net) has quit (Quit: Leaving) | |
[08:09:20] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 245 seconds) | |
[08:09:46] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[08:09:46] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
[08:15:39] | SteveGoodey (SteveGoodey!~steve@host86-145-34-0.range86-145.btcentralplus.com) has joined #mythtv | |
[08:15:39] | Mode for #mythtv by ChanServ!ChanServ@services. : +v SteveGoodey | |
[08:36:50] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 245 seconds) | |
[08:37:00] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[08:37:00] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
[09:26:09] | markk_ (markk_!~mark@host86-167-132-162.range86-167.btcentralplus.com) has joined #mythtv | |
[09:47:11] | markk_: | anyone have a view on the cpp check portability error (https://code.mythtv.org/cppcheck/) -> https://code.mythtv.org/cgit/mythtv/tree/myth . . . media.h#n191 |
[09:47:45] | markk_: | I think it should return m_Device.data() |
[10:05:25] | stuarta: | how is it used? first one i've checked is really trying to take a pointer to the object represented by the class |
[10:09:22] | stuarta: | hmm, it's in the event handling wrapper, not the device class itself |
[10:10:30] | stuarta: | ah, so it's trying to pull the device from the delivered event |
[10:11:07] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 276 seconds) | |
[10:11:50] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[10:11:50] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
[10:13:14] | markk_ (markk_!~mark@host86-167-132-162.range86-167.btcentralplus.com) has quit (Ping timeout: 240 seconds) | |
[10:18:14] | Warped (Warped!~Warped@unaffiliated/warped) has quit (Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]) | |
[10:59:50] | hampton: | jpabq: Fields in a structure are aligned on their natural boundaries. Looking at HEVCShortTermRefPicSet there's one byte of padding before abs_delta_rps_minus1, and I suspect three before UsedByCurrPicS0. (A uint8_t can normally be any alignment, but since its an array I suspect it getting 4 byte alignment.) |
[10:59:53] | hampton: | I've not see clang-tidy that picky before. The other padding warnings I've seen (only three so far), were things like 50 or 120 bytes of wasted space in a structure. Maybe the structure padding complaints are based on a ratio of the size of the structure? I'm curious now. |
[12:49:01] | jpabq: | I was asking too much of my H.265 encoder. Lowering the requested bitrate solved the missing frame issue. |
[12:49:55] | jpabq: | hampton: Once upon a time, I knew that. I just have not bothered to think about it in years. |
[12:52:32] | jpabq: | Considering one of my "pet peeves" is when people use post-increment when a pre-increment is "more efficient" (unless the compiler fixes it), I am embarrassed that I forgot about that. |
[12:55:34] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 276 seconds) | |
[13:05:15] | Warped (Warped!~Warped@unaffiliated/warped) has joined #mythtv | |
[13:24:44] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[13:24:45] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
[14:25:43] | warpme_: | guys: i'm building current master and build builds ok on gcc9.3 machine but fails on gcc5.3 with error like this: |
[14:25:47] | warpme_: | https://www.irccloud.com/pastebin/nbJPjSHy/ |
[14:25:59] | warpme_: | is this expected? |
[14:35:42] | jpabq: | warpme_: Does gcc5.3 support c++17? Hampton is probably the best person to answer your question, but my guess is that that compiler is too old. |
[14:37:42] | jpabq: | warpme_: Actually, those don't look like c++ issues, so that is probably not it. |
[14:53:22] | stuarta: | i've never understood the justification for pre increment being more efficient than post increment |
[14:53:52] | stuarta: | to me there is a logical difference, inc the use, versus use then inc, they are logically different |
[14:54:13] | stuarta: | *inc then use |
[14:54:57] | stuarta: | warpme_: almost certain gcc-5.3 won't support c++17 |
[14:55:03] | hampton: | gcc 5.3 is too old for c++17 support. I think you need at least gcc7. |
[14:56:15] | hampton: | (suse15 has gcc 7.5 and it compiles fine.) |
[14:57:19] | warpme_: | ough so do i need upgrade my backend OS? oh no :-(. it is rock stable and runs hell of other things. If thing is about gcc upgrade – then may You please point me to exact commit i need to revert to get compilation on gcc5? |
[14:57:43] | stuarta: | what the heck are you using that is so damn old? |
[14:58:23] | warpme_: | because runs hell of other things ROCK stable (including wine stuff, etc) |
[14:58:42] | hampton: | You shouldn't need to upgrade the os, just the compiler. |
[14:59:10] | warpme_: | right. what i afraid is dependencies i.e. glibc.... |
[14:59:28] | warpme_: | is->are |
[14:59:31] | hampton: | I was just thinking that. |
[15:00:24] | warpme_: | and believe private extensions in glibc are nightmare to manage.... |
[15:00:38] | warpme_: | believe -> believe me |
[15:00:46] | hampton: | I have several more commits queued that use C+17 features, so its not just that one change that's going to need a newer compiler. |
[15:29:39] | warpme_: | ok stage1 for gcc7.5.0 finished ok. finger crossed for stage2/3.... |
[16:09:49] | hampton: | Any reason why mythplugins/configure doesn't just pull the location of qmake from the output of mythtv/configure? |
[17:00:39] | markk_ (markk_!~mark@host86-167-132-162.range86-167.btcentralplus.com) has joined #mythtv | |
[17:38:31] | markk_: | hampton: forgot to ask – does the vulkan configure change work for you? |
[17:40:58] | hampton: | Doesn't compile for me with fedora stock qt 5.14, but does compile with my locally built qt 5.15. Only needed a single include added. Will commit that change later. |
[17:41:40] | jpabq: | stuarta: way back when I was in college, I took a compiler writing course. For post increment, you must save the value of the variable for use by the "expression" before you increment it. With pre increment, you don't need to save its value first. That being said, since so many people use post-increment even when they don't need to, I am assuming compilers look for that and optimze away the need to save the value. |
[18:02:47] | stuarta: | jpabq: now that is an explanation that makes sense |
[18:11:35] | tgm4883 (tgm4883!uid23806@gateway/web/irccloud.com/x-fntpepzhwtujttrd) has joined #mythtv | |
[18:40:54] | markk_ (markk_!~mark@host86-167-132-162.range86-167.btcentralplus.com) has quit (Ping timeout: 240 seconds) | |
[19:34:25] | jpabq: | hampton: Let me know when another tidy report is ready, and I will make another pass. |
[20:21:19] | tgm4883 (tgm4883!uid23806@gateway/web/irccloud.com/x-fntpepzhwtujttrd) has quit (Quit: Connection closed for inactivity) | |
[20:29:43] | stuarta: | hampton: you seen this question? https://forum.mythtv.org/viewtopic.php?f=6&t=3872 |
[20:53:33] | hampton: | jpabq: Runs at 2am utc every night (that there's a new commit.) |
[20:53:45] | hampton: | stuarta: Nope. I'll respond. |
[20:53:48] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
[20:59:10] | stuarta: | we can force a tidy run if needed |
[21:00:15] | stuarta: | well, technically "rebuild", force didn't work last time i tried it |
[21:08:14] | stuarta: | MythBuild: force build tidy-master now |
[21:08:14] | MythBuild: | Force build successfully requested. |
[21:08:23] | stuarta: | sheesh, it does work |
[21:26:43] | SteveGoodey (SteveGoodey!~steve@host86-145-34-0.range86-145.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
[22:32:40] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 245 seconds) | |
[22:36:52] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[22:36:53] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
[22:44:29] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Read error: Connection reset by peer) | |
[22:51:46] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[22:51:46] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
[23:09:49] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Read error: Connection reset by peer) | |
[23:14:30] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
[23:14:30] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.