| Tuesday, April 19th, 2016, 01:36 UTC | ||
| [01:36:13] | joki (joki!~joki@p5486121E.dip0.t-ipconnect.de) has quit (Ping timeout: 250 seconds) | |
| [01:42:35] | joki (joki!~joki@p548615DE.dip0.t-ipconnect.de) has joined #mythtv | |
| [01:44:30] | arescorpio (arescorpio!~arescorpi@140-31-245-190.fibertel.com.ar) has joined #mythtv | |
| [01:45:05] | mad_enz (mad_enz!~mad_enz@CPE00508b114c3e-CM00fc8d50aef0.cpe.net.fido.ca) has quit (Ping timeout: 268 seconds) | |
| [01:56:38] | mad_enz (mad_enz!~mad_enz@2607:f090:488d:8d:585:5074:32da:e338) has joined #mythtv | |
| [02:21:17] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 250 seconds) | |
| [02:26:09] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [02:29:01] | Roklobster (Roklobster!~Dirkka@ppp118-209-235-102.lns20.mel8.internode.on.net) has quit (Ping timeout: 252 seconds) | |
| [02:35:31] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has joined #mythtv | |
| [02:43:01] | mad_enz (mad_enz!~mad_enz@2607:f090:488d:8d:585:5074:32da:e338) has quit (Ping timeout: 250 seconds) | |
| [02:44:26] | mad_enz (mad_enz!~mad_enz@CPE00508b114c3e-CM00fc8d50aef0.cpe.net.fido.ca) has joined #mythtv | |
| [02:50:43] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has quit (Ping timeout: 244 seconds) | |
| [02:55:57] | dmfrey (dmfrey!~dmfrey@65-78-126-51.c3-0.smt-ubr1.atw-smt.pa.cable.rcn.com) has quit (Ping timeout: 246 seconds) | |
| [03:20:37] | SteveGoodey (SteveGoodey!~steve@host5-81-230-128.range5-81.btcentralplus.com) has joined #mythtv | |
| [03:45:44] | bill6502 (bill6502!~bill@24-148-53-32.c3-0.alc-ubr1.chi-alc.il.cable.rcn.com) has left #mythtv () | |
| [04:15:39] | SteveGoodey (SteveGoodey!~steve@host5-81-230-128.range5-81.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [04:17:16] | rhpot1991 (rhpot1991!~rhpot1991@ubuntu/member/rhpot1991) has quit (Ping timeout: 264 seconds) | |
| [04:20:11] | rhpot1991 (rhpot1991!~rhpot1991@2600:3c03:e000:19b::1) has joined #mythtv | |
| [04:20:11] | rhpot1991 (rhpot1991!~rhpot1991@2600:3c03:e000:19b::1) has quit (Changing host) | |
| [04:20:11] | rhpot1991 (rhpot1991!~rhpot1991@ubuntu/member/rhpot1991) has joined #mythtv | |
| [04:44:27] | brfransen (brfransen!~brfransen@71.11.51.80) has quit (Ping timeout: 260 seconds) | |
| [04:56:45] | arescorpio (arescorpio!~arescorpi@140-31-245-190.fibertel.com.ar) has quit (Quit: Leaving.) | |
| [05:17:51] | kc (kc!~Casper@unaffiliated/kc) has quit (Remote host closed the connection) | |
| [05:19:32] | kc (kc!~Casper@unaffiliated/kc) has joined #mythtv | |
| [05:22:06] | brfransen (brfransen!~brfransen@71.11.51.80) has joined #mythtv | |
| [06:11:23] | mad_enz (mad_enz!~mad_enz@CPE00508b114c3e-CM00fc8d50aef0.cpe.net.fido.ca) has quit (Ping timeout: 250 seconds) | |
| [06:20:33] | Tobbe5178 (Tobbe5178!~asdf@h55n9-sv-a13.ias.bredband.telia.com) has joined #mythtv | |
| [06:43:07] | lomion0815 (lomion0815!~markus@178-191-247-150.adsl.highway.telekom.at) has joined #mythtv | |
| [07:29:18] | Warped (Warped!~Warped@unaffiliated/warped) has quit (Quit: ChatZilla 0.9.92 [Firefox 45.0.2/20160407164938]) | |
| [07:34:38] | SteveGoodey (SteveGoodey!~steve@host5-81-230-128.range5-81.btcentralplus.com) has joined #mythtv | |
| [07:42:04] | Warped (Warped!~Warped@unaffiliated/warped) has joined #mythtv | |
| [07:59:35] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has joined #mythtv | |
| [08:02:38] | willcooke (willcooke!~willcooke@willcooke.plus.com) has joined #mythtv | |
| [08:02:38] | willcooke (willcooke!~willcooke@willcooke.plus.com) has quit (Changing host) | |
| [08:02:38] | willcooke (willcooke!~willcooke@ubuntu/member/willcooke) has joined #mythtv | |
| [08:10:42] | Merlin83b (Merlin83b!~Daniel@office.34sp.com) has joined #mythtv | |
| [08:10:57] | lautriv_ (lautriv_!~lautriv@funtoo/user/lautriv) has quit (Ping timeout: 246 seconds) | |
| [08:12:46] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has quit (Remote host closed the connection) | |
| [08:23:48] | lautriv_ (lautriv_!~lautriv@x4e32503d.dyn.telefonica.de) has joined #mythtv | |
| [08:23:48] | lautriv_ (lautriv_!~lautriv@funtoo/user/lautriv) has joined #mythtv | |
| [08:23:48] | lautriv_ (lautriv_!~lautriv@x4e32503d.dyn.telefonica.de) has quit (Changing host) | |
| [09:00:18] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
| [09:02:11] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 250 seconds) | |
| [09:14:51] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has joined #mythtv | |
| [09:56:15] | letifosiferrari (letifosiferrari!~letifosif@lns-bzn-27-82-248-51-250.adsl.proxad.net) has joined #mythtv | |
| [09:57:21] | letifosiferrari (letifosiferrari!~letifosif@lns-bzn-27-82-248-51-250.adsl.proxad.net) has quit (Remote host closed the connection) | |
| [09:57:48] | letifosiferrari (letifosiferrari!~letifosif@216.207.42.140) has joined #mythtv | |
| [10:12:21] | dekarl1 is now known as dekarl | |
| [10:25:45] | SteveGoodey (SteveGoodey!~steve@host5-81-230-128.range5-81.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [10:34:22] | stuarta: | i might have to start writing the unit tests for this rails code soon |
| [11:19:47] | Roklobster: | like you don't have enough to do |
| [11:22:25] | stuarta: | hah |
| [12:05:42] | mad_enz (mad_enz!~mad_enz@CPE00508b114c3e-CM00fc8d50aef0.cpe.net.fido.ca) has joined #mythtv | |
| [12:21:04] | letifosiferrari (letifosiferrari!~letifosif@216.207.42.140) has quit (Read error: Connection reset by peer) | |
| [12:21:35] | letifosiferrari (letifosiferrari!~letifosif@216.207.42.140) has joined #mythtv | |
| [12:40:56] | dmfrey (dmfrey!~dmfrey@68.170.18.123) has joined #mythtv | |
| [12:44:09] | letifosi_ (letifosi_!~letifosif@lns-bzn-27-82-248-51-250.adsl.proxad.net) has joined #mythtv | |
| [12:44:16] | letifosi_ (letifosi_!~letifosif@lns-bzn-27-82-248-51-250.adsl.proxad.net) has quit (Remote host closed the connection) | |
| [12:44:43] | letifosi_ (letifosi_!~letifosif@216.207.42.140) has joined #mythtv | |
| [12:45:43] | letifosiferrari (letifosiferrari!~letifosif@216.207.42.140) has quit (Ping timeout: 250 seconds) | |
| [12:50:16] | stuarta: | Roklobster: writing unit tests is a learning exercise in doing things the right way |
| [12:50:27] | stuarta: | and it might even prove my code works ;-) |
| [12:51:53] | Roklobster: | yeah good code is 10% actual code and 90% testing code |
| [13:23:51] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has quit (Ping timeout: 250 seconds) | |
| [13:24:00] | stuarta (stuarta!~stuarta@callisto.squashedfrog.net) has joined #mythtv | |
| [13:24:00] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has joined #mythtv | |
| [13:24:00] | stuarta (stuarta!~stuarta@callisto.squashedfrog.net) has quit (Changing host) | |
| [13:25:20] | stuarta: | hmpf. something in the usb/dvb stack locked up the kernel again |
| [13:30:57] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has quit (Quit: Leaving) | |
| [14:22:39] | coling (coling!~colin@cpc8-sgyl36-2-0-cust443.18-2.cable.virginm.net) has joined #mythtv | |
| [14:30:04] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Read error: Connection reset by peer) | |
| [14:40:46] | dmfrey (dmfrey!~dmfrey@68.170.18.123) has quit (Read error: Connection reset by peer) | |
| [15:16:13] | gedakc (gedakc!~gedakc@d162-157-118-249.abhsia.telus.net) has joined #mythtv | |
| [15:30:44] | ** stuarta builds a linux kernel for the first time in years.... ** | |
| [15:33:44] | SteveGoodey (SteveGoodey!~steve@host5-81-230-128.range5-81.btcentralplus.com) has joined #mythtv | |
| [16:08:48] | ** stuarta slays some FUD ** | |
| [16:36:43] | Merlin83b (Merlin83b!~Daniel@office.34sp.com) has quit (Quit: Leaving) | |
| [17:20:11] | gedakc (gedakc!~gedakc@d162-157-118-249.abhsia.telus.net) has quit (Quit: Leaving) | |
| [17:30:24] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
| [17:38:11] | cbovy (cbovy!~cbovy@2001:470:1f15:ff2:39b8:2094:fdc6:79dd) has joined #mythtv | |
| [17:56:28] | cbovy: | mythweb is using deprecated PHP functions if using PHP7 (xenial 16.04). I've created patch #12731. Anyone willing to review/test? Quite essential for xenial to if you want to have the FlowPlayer working. |
| [17:56:28] | ** MythLogBot http://code.mythtv.org/trac/ticket/12731 ** | |
| [18:03:50] | dekarl: | cbovy: using mysql 5.7? #12713 we can cross-review |
| [18:03:50] | ** MythLogBot http://code.mythtv.org/trac/ticket/12713 ** | |
| [18:04:43] | cbovy: | dekarl: yes, 5.7.11. Let me look into that. |
| [18:06:17] | cbovy: | dekarl: i did change it to 'sql_mode=NO_ENGINE_SUBSTITUTION', but will revert that and try the patch. |
| [18:17:52] | cbovy: | dekarl: I'm not able to get the Listings working, even if commit 659c0f390 is applied. Still complaining about GROUP BY error. |
| [18:21:42] | dekarl: | can you paste it? either to the ticket or a random pastebin |
| [18:22:49] | cbovy: | channel.chanid should be added to GROUP BY. Now it is only added to ORDER BY |
| [18:24:34] | cbovy: | dekarl: this is the first query which fails: http://pastebin.com/fZMA81pi |
| [18:26:00] | dekarl: | cbovy: that doesn't make sense, its in a aggregate function MIN() |
| [18:26:48] | dekarl: | doh |
| [18:26:59] | dekarl: | that should be ORDER BY MIN(channel.chanid) |
| [18:32:07] | cbovy: | ok, changed that. Now the next SQL statement fails: http://pastebin.com/cLUTMkay |
| [18:42:51] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Ping timeout: 250 seconds) | |
| [18:44:23] | stuarta: | maybe i should bite the bullet and upgrade my xenial backend to mysql-5.7 |
| [18:45:31] | stuarta: | cbovy: is it only mythweb that breaks, or the backend too? |
| [18:46:23] | cbovy: | stuarta: I haven't seen any issues with backend so far. just issues with mythweb with mysql-5.7 and mythweb with PHP7. |
| [18:53:54] | earthw0rm (earthw0rm!~biggaz@host-78-144-56-2.as13285.net) has joined #mythtv | |
| [18:55:27] | stuarta: | we fixed quite a few php7 issues for arch linux |
| [18:56:44] | stuarta: | mainly mysql interface conversions |
| [18:57:53] | gedakc (gedakc!~gedakc@d162-157-118-249.abhsia.telus.net) has joined #mythtv | |
| [19:05:20] | cbovy: | it looks to me that all queries with GROUP BY should be rewritten somehow, although I'm not a Mysql expert... |
| [19:12:47] | CyberJacob is now known as zz_CyberJacob | |
| [19:22:26] | cbovy: | dekarl: when I remove the 'GROUP BY' clause from programs.php (line 132), Listings show up. |
| [19:25:47] | gedakc: | cbovy: 'GROUP BY' is needed in SQL fro aggregate functions like MAX(), SUM(), etc. See https://dev.mysql.com/doc/refman/5.7/en/group-by-functions.html |
| [19:25:55] | gedakc: | What SQL statement are you looking at? |
| [19:28:11] | cbovy: | gedakc: this statement fails on mysql 5.7: http://pastebin.com/cLUTMkay |
| [19:29:11] | cbovy: | question is: is GROUP BY required in this statement? If so, we need to rewrite the statement correctly. If not required, remove GROUP BY and Listings show up in Mythweb (on mysql 5.7). |
| [19:30:55] | gedakc: | If 'GROUP BY' was required, then I would expect an error when executing the SQL statement.... |
| [19:31:30] | gedakc: | It looks to me like the SQL statement DOES NOT contain any aggregate functions. |
| [19:32:26] | gedakc: | Do you see any issues with the data returned when you remove the 'GROUP BY'? |
| [19:32:34] | cbovy: | no, not at first sight. |
| [19:32:39] | gedakc: | For example duplicate rows? |
| [19:33:14] | cbovy: | No duplicate rows, at least in my situation. |
| [19:34:52] | gedakc: | My SQL skills might be a little rusty, but looking at the SQL query alone, I can't see a reason for having the 'GROUP BY'. Ideally someone more familiar with this part of the code would comment. |
| [19:37:21] | gedakc: | If the 'GROUP BY' is required, then often one can work around this issue by adding an aggregate function to the field causing the issue. |
| [19:37:31] | cbovy: | I've now removed it and things seems to work, until I hit another mysql 5.7 issue. :-) When all sorted, I'll compile a patch. |
| [19:38:20] | gedakc: | Do you have any NULL values in 'mythconverg.program.endtime'? |
| [19:38:59] | gedakc: | For example "SELECT * FROM program WHERE endtime is NULL;" |
| [19:40:34] | cbovy: | nope. |
| [19:41:04] | gedakc: | Hmm... I'm going to fire up a MythTV VM to see what columns are in the table. |
| [19:45:01] | gedakc: | On my mythconverg 0.27.x database the program.endtime column is marked NOT NULL so no NULLs are allowed. |
| [19:45:57] | gedakc: | Only two columns are listed as permitted to be NULL. Those are originalairdate and generic. |
| [19:48:00] | gedakc: | It looks like program.endtime is referred to in the 'WHERE' clause. |
| [19:48:22] | gedakc: | You might work around the problem by adding a UNIX_TIMESTAMP function similar to program.starttime. |
| [19:48:56] | gedakc: | ... hmm... maybe something simpler.... |
| [19:49:14] | tmkt (tmkt!~david@76.9.206.238) has quit (Quit: leaving) | |
| [19:49:21] | gedakc: | Try adding program.endtime to the end of the 'GROUP BY' list. |
| [19:51:40] | cbovy: | the problem is the program.*. That means you need to add every column in program.* to the GROUP BY. Remove GROUP BY seems to work. |
| [19:53:03] | gedakc: | It does seem unusual to use a wildcard like that in the SQL statement. Are the columns referred to in later on portions of the code? |
| [19:53:29] | gedakc: | The reason I suggested adding program.endtime was because I saw it in the WHERE clause. |
| [19:53:30] | cbovy: | yes, probably not all, but a lot. |
| [19:55:44] | gedakc: | Can you try adding the column just to see what happens? |
| [19:57:03] | cbovy: | yes, let me try. I think I've tried that before and it 'asked' for another program.something value to be added. |
| [19:57:25] | gedakc: | That |
| [19:58:08] | gedakc: | That's possible, meaning it wants all columns in the GROUP BY. Of course if we're not using aggregate functions then I agree that the GROUP BY is probably not required. |
| [19:59:01] | gedakc: | There might be a change in behaviour with the version of MYSQL you are testing with. |
| [20:00:20] | willcooke (willcooke!~willcooke@ubuntu/member/willcooke) has quit (Quit: Do your hobbies) | |
| [20:01:11] | cbovy: | verified: it now needs program.title :-) |
| [20:01:26] | cbovy: | yes, this has changed in 5.7. |
| [20:02:42] | gedakc: | Since there are no aggregate functions, I personally would feel comfortable removing the GROUP BY. If order is important, you could add the other columns from the GROUP BY to the ORDER BY clause. |
| [20:04:06] | gedakc: | Thanks for testing. :-) |
| [20:04:25] | cbovy: | ok. let me fix the rest and get a patch out for testing. |
| [20:05:27] | gedakc: | ok. I'll leave you to it. Thanks again for humouring me. |
| [20:05:27] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has joined #mythtv | |
| [20:07:18] | cbovy: | you're welcome. :-) |
| [20:09:50] | cbovy: | btw, does 'Never record' in mythweb works properly in non 5.7 situation? When I click Never Record in fixes/0.27, the recording stills shows up as to be recorded. |
| [20:13:02] | stuarta: | cbovy: i have a suspicion it doesn't |
| [20:14:02] | cbovy: | stuarta: it just returns the page, with nothing changed? |
| [20:14:15] | stuarta: | last i tried it, let me try again now |
| [20:15:12] | stuarta: | oh, it worked. |
| [20:16:14] | LePetomane (LePetomane!~Dirkka@ppp118-209-94-188.lns20.mel4.internode.on.net) has joined #mythtv | |
| [20:16:48] | cbovy: | I've selected a single program to record in (near) future, then went to Upcoming Recording and click never record. The page reloads and the recording is still there. If I click Don't Record, it disappears. |
| [20:18:14] | Roklobotomy (Roklobotomy!~Dirkka@ppp118-209-128-112.lns20.mel8.internode.on.net) has joined #mythtv | |
| [20:19:24] | Roklobster (Roklobster!~Dirkka@ppp118-209-82-152.lns20.mel4.internode.on.net) has quit (Ping timeout: 268 seconds) | |
| [20:21:31] | LePetomane (LePetomane!~Dirkka@ppp118-209-94-188.lns20.mel4.internode.on.net) has quit (Ping timeout: 252 seconds) | |
| [20:36:16] | cbovy: | dekarl: updated your ticket with a patch. |
| [20:40:11] | cbovy (cbovy!~cbovy@2001:470:1f15:ff2:39b8:2094:fdc6:79dd) has quit (Quit: Leaving) | |
| [20:40:47] | SteveGoodey (SteveGoodey!~steve@host5-81-230-128.range5-81.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [20:41:51] | gedakc (gedakc!~gedakc@d162-157-118-249.abhsia.telus.net) has quit (Quit: Leaving) | |
| [21:06:54] | letifosi_ (letifosi_!~letifosif@216.207.42.140) has quit (Ping timeout: 246 seconds) | |
| [21:37:41] | Tobbe5178 (Tobbe5178!~asdf@h55n9-sv-a13.ias.bredband.telia.com) has quit (Read error: Connection reset by peer) | |
| [21:53:46] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [21:57:55] | lomion0815 (lomion0815!~markus@178-191-247-150.adsl.highway.telekom.at) has quit (Remote host closed the connection) | |
| [22:01:23] | coling (coling!~colin@cpc8-sgyl36-2-0-cust443.18-2.cable.virginm.net) has quit (Ping timeout: 276 seconds) | |
| [22:14:44] | stuarta: | if only refactoring mythtv code was as easy as refactoring rails code |
| [22:23:34] | earthw0rm (earthw0rm!~biggaz@host-78-144-56-2.as13285.net) has quit (Ping timeout: 240 seconds) | |
| [22:56:17] | stuarta: | reviewing my own ticket on the services api, i see that mythtv-setup is actually doing a POST request when searching, which i need to add support for |
| [23:00:21] | Roklobotomy (Roklobotomy!~Dirkka@ppp118-209-128-112.lns20.mel8.internode.on.net) has quit (Ping timeout: 268 seconds) | |
| [23:28:46] | coling (coling!~colin@cpc8-sgyl36-2-0-cust443.18-2.cable.virginm.net) has joined #mythtv | |
| [23:33:47] | n1cky (n1cky!~sielicki@104.236.246.142) has joined #mythtv | |
| [23:45:38] | n1cky (n1cky!~sielicki@104.236.246.142) has left #mythtv () | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.