Monday, April 13th, 2015, 00:04 UTC | ||
[00:04:10] | knightr: | tgm4883, can I use Thomas Mashos <thomas@mashos.com > as author or would you like me to use another address? |
[00:07:16] | knightr: | by the way, once it is committed you should be able to close the pull request yourself since you are the author... I can't because github is too ... to offer proper granularity and you need write access or be the author or a pull request to close it (or something like that...) |
[00:10:38] | knightr: | I hope that author address was ok with you because that's the one I ended up using... |
[00:11:03] | knightr: | https://code.mythtv.org/cgit/packaging/commit . . . e5981d3a3b43 |
[00:16:30] | tgm4883: | knightr: yea that address is fine |
[00:16:34] | tgm4883: | that's the one I use |
[00:16:44] | knightr: | perfect, thank you! |
[00:17:57] | tgm4883: | knightr: was there a fixes/0.27 commit in there too? |
[00:18:12] | tgm4883: | or maybe I need to do separate pull requests for different branches, I bet that is the case |
[00:18:24] | knightr: | nope, but it's not a problem, give me a sec... |
[00:18:36] | tgm4883: | knightr: https://github.com/MythTV/packaging/pull/53 |
[00:18:52] | tgm4883: | it's just a cherry-pick of one commit |
[00:18:57] | knightr: | tgm4883, no need.. |
[00:18:59] | knightr: | exactly.. |
[00:19:07] | knightr: | I would have done it on my side... |
[00:19:27] | knightr: | those pull requests are pita for most of us since we can't close them... |
[00:20:13] | tgm4883: | ah |
[00:24:33] | tgm4883: | knightr: I've closed both pull requests. Just let me know when that other one gets done and I'll push a build |
[00:32:16] | knightr: | tgm4883, https://code.mythtv.org/cgit/packaging/commit . . . 1ef343531246 |
[00:32:31] | tgm4883: | knightr: awesome, thank you |
[00:33:02] | knightr: | you are welcome and thank you for closing the pull requests! ;-) |
[02:14:55] | arescorpio (arescorpio!~arescorpi@51-255-114-200.fibertel.com.ar) has joined #mythtv | |
[02:54:32] | stichnot: | dekarl: I was thinking of working on #11713 soon, hopefully you're OK with it |
[02:54:32] | ** MythLogBot http://code.mythtv.org/trac/ticket/11713 ** | |
[03:50:25] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
[03:54:07] | fetzerch_ (fetzerch_!~quassel@unaffiliated/fetzerch) has quit (Ping timeout: 255 seconds) | |
[04:47:07] | andreaz (andreaz!~andre_000@p5DD15164.dip0.t-ipconnect.de) has quit (Read error: Connection reset by peer) | |
[04:57:25] | Tobbe5178 (Tobbe5178!~asdf@2001:2002:51e3:5f22:159c:4410:7865:8925) has joined #mythtv | |
[05:36:27] | arescorpio (arescorpio!~arescorpi@51-255-114-200.fibertel.com.ar) has quit (Excess Flood) | |
[05:42:46] | dekarl: | I have tgm4883's fork as a remote and just "git pull tgm4883 master" which pulls and merges, then "git push". That also gets rid of the pull request automatically :) https://code.mythtv.org/trac/wiki/GitHubPullRequests |
[05:43:52] | dekarl: | Works well if contributions consisting of multiple commits are on their own feature branch. |
[05:48:11] | dekarl: | stuarta, trac appears to change links to irc.mythtv.org from http to https, which doesn't work :( e.g. the link to the discussion at https://code.mythtv.org/trac/ticket/11713 |
[05:49:20] | dekarl: | stichnot: sure, I fixed the link to the chatlog. stu artm had some hints wrt the implementation |
[06:10:12] | kurre2 (kurre2!~tomimo@xdsl-83-150-88-111.nebulazone.fi) has joined #mythtv | |
[06:16:40] | FabriceMG (FabriceMG!~Thunderbi@LCaen-656-1-100-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
[06:47:02] | joki (joki!~joki@p5B36E0BE.dip0.t-ipconnect.de) has quit (Ping timeout: 272 seconds) | |
[06:51:13] | joki (joki!~joki@p5B36CF1C.dip0.t-ipconnect.de) has joined #mythtv | |
[07:02:43] | SteveGoodey (SteveGoodey!~steve@host81-147-66-153.range81-147.btcentralplus.com) has joined #mythtv | |
[07:05:57] | kurre2 (kurre2!~tomimo@xdsl-83-150-88-111.nebulazone.fi) has quit (Remote host closed the connection) | |
[07:20:54] | kurre2 (kurre2!~tomimo@xdsl-83-150-88-111.nebulazone.fi) has joined #mythtv | |
[08:12:51] | Merlin83b (Merlin83b!~Daniel@office.34sp.com) has joined #mythtv | |
[08:31:55] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
[08:33:56] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 240 seconds) | |
[10:56:40] | henkpoley (henkpoley!~henkpoley@poley.xs4all.nl) has joined #mythtv | |
[11:00:37] | henkpoley: | stuartm: do you happen to know if this patch was later extended to auto-switch between DVB-T/T2 and DVB-C ? As needed with DVBSky T680C & Technotrend CT2–4650 CI – https://code.mythtv.org/trac/ticket/12342 |
[11:06:43] | henkpoley: | Oddly enough that primary patch does not even appear to be applied at https://github.com/MythTV/mythtv/blob/master/ . . . til.cpp#L432 |
[11:08:49] | henkpoley: | Nor at: https://code.mythtv.org/trac/browser/mythtv/m . . . til.cpp#L432 |
[11:09:15] | stuartm: | because it hasn't been committed yet |
[11:09:53] | stuartm: | and no, I'm not aware of a followup patch from David |
[11:10:52] | henkpoley: | Probably not from him no |
[11:11:39] | henkpoley: | But a while ago I mentioned here that my car doesn’t auto switch between T and C (or defaults to T) |
[11:12:00] | henkpoley: | So someone (maybe you) said to patch in C <-> T switching code |
[11:12:22] | henkpoley: | Just dropped by to see if any of that landed in 0.28 already |
[11:12:52] | henkpoley: | Should I add a remark at the Trac ticket? |
[11:13:56] | stuartm: | sure |
[11:14:47] | henkpoley: | OK |
[11:30:16] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 240 seconds) | |
[11:33:55] | SteveGoodey (SteveGoodey!~steve@host81-147-66-153.range81-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
[11:40:40] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
[11:42:43] | rich0_ (rich0_!~quassel@gentoo/developer/rich0) has joined #mythtv | |
[11:45:39] | bas-t (bas-t!~bas-t@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
[11:45:48] | rich0 (rich0!~quassel@gentoo/developer/rich0) has quit (Ping timeout: 264 seconds) | |
[11:46:10] | bas-t (bas-t!~bas-t@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Client Quit) | |
[11:46:53] | bas-t (bas-t!~bas-t@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
[11:47:49] | bas-t (bas-t!~bas-t@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Client Quit) | |
[12:09:27] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 256 seconds) | |
[12:27:16] | moparisthebest (moparisthebest!~mitb@unaffiliated/moparisthebest) has quit (Ping timeout: 240 seconds) | |
[12:30:35] | peper03: | paul-h: I guess you were thinking of #12061 |
[12:30:35] | ** MythLogBot http://code.mythtv.org/trac/ticket/12061 ** | |
[12:32:00] | moparisthebest (moparisthebest!~mitb@unaffiliated/moparisthebest) has joined #mythtv | |
[12:34:35] | peper03: | It's a little hard to understand the description but I'm fairly sure that's a different issue. I think she's saying that opening the miniplayer (presumably via a key mapping) is causing playback to stop and 'resume' at a different position in the playlist. |
[12:44:09] | peper03: | I can't reproduce it either. |
[13:20:40] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
[13:21:56] | dmfrey (dmfrey!~dmfrey@208.5.237.2) has joined #mythtv | |
[13:23:52] | henkpoley (henkpoley!~henkpoley@poley.xs4all.nl) has quit (Quit: henkpoley) | |
[13:31:12] | dmfrey (dmfrey!~dmfrey@208.5.237.2) has quit (Quit: Ex-Chat) | |
[13:35:27] | FabriceMG1 (FabriceMG1!~Thunderbi@LCaen-656-1-100-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
[13:35:32] | FabriceMG (FabriceMG!~Thunderbi@LCaen-656-1-100-212.w80-11.abo.wanadoo.fr) has quit (Write error: Broken pipe) | |
[14:43:00] | rhpot199` is now known as rhpot1991 | |
[14:55:51] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 250 seconds) | |
[15:01:20] | henkpoley (henkpoley!~henkpoley@poley.xs4all.nl) has joined #mythtv | |
[15:01:30] | henkpoley (henkpoley!~henkpoley@poley.xs4all.nl) has quit (Client Quit) | |
[15:14:46] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
[15:19:01] | urlgrey (urlgrey!~urlgrey@199-116-73-2.sfo1.office.zencoderdns.net) has joined #mythtv | |
[15:21:56] | FabriceMG1 (FabriceMG1!~Thunderbi@LCaen-656-1-100-212.w80-11.abo.wanadoo.fr) has quit (Quit: FabriceMG1) | |
[15:55:41] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 246 seconds) | |
[16:25:42] | SteveGoodey (SteveGoodey!~steve@host81-147-66-153.range81-147.btcentralplus.com) has joined #mythtv | |
[16:33:55] | stichnot (stichnot!stichnot@mythtv/developer/stichnot) has joined #mythtv | |
[17:07:55] | peper03: | stuartm: Any idea what's going on here (or more importantly, why)? http://pastebin.com/kdStiJkP |
[17:09:06] | peper03: | If you start MythFrontend from MythWelcome and hit OK again just before MythFrontend appears, the key press is queued until after MythFrontend terminates but isn't processed until about 800ms after MythWelcome has regained focus. |
[17:09:40] | peper03: | 800ms seems a long time. |
[17:10:37] | peper03: | Is there any way of discarding pending key press events? |
[17:20:30] | Merlin83b (Merlin83b!~Daniel@office.34sp.com) has quit (Quit: Leaving) | |
[17:33:47] | paul-h (paul-h!~Paul@94.12.145.61) has joined #mythtv | |
[17:39:22] | paul-h: | peper03: yeah different issue |
[17:40:27] | paul-h: | just trying to reproduce your issue so it works as expected in the main player but not if playing in the background |
[17:44:19] | paul-h: | peper03: go ahead and commit your fix it looks good to me |
[17:57:58] | knightr (knightr!~Nicolas@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
[17:58:32] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
[18:00:13] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 256 seconds) | |
[18:10:23] | ** tgm4883 sighs ** | |
[18:10:25] | tgm4883: | https://github.com/MythTV/packaging/pull/54 |
[18:10:38] | tgm4883: | More packaging bug fixes from the move to qt5 |
[18:12:25] | peper03: | paul-h: Ok, done. Thanks. |
[18:31:32] | dekarl1 is now known as dekarl | |
[18:34:56] | dekarl: | tgm4883: can you merge origin/master, then continue work? Somehow the history looks strange now :) https://github.com/MythTV/packaging/commits/master |
[18:35:20] | tgm4883: | dekarl: yea let me work it out |
[18:37:09] | cybrNaut (cybrNaut!cybrNaut@unaffiliated/cybrnaut) has joined #mythtv | |
[18:37:09] | cybrNaut (cybrNaut!cybrNaut@unaffiliated/cybrnaut) has quit (Excess Flood) | |
[18:38:39] | cybrNaut (cybrNaut!cybrNaut@unaffiliated/cybrnaut) has joined #mythtv | |
[18:38:40] | cybrNaut (cybrNaut!cybrNaut@unaffiliated/cybrnaut) has quit (Excess Flood) | |
[18:39:08] | cybrNaut (cybrNaut!cybrNaut@2001:0:53aa:64c:203d:157c:bcca:66c4) has joined #mythtv | |
[18:40:28] | cybrNaut (cybrNaut!cybrNaut@2001:0:53aa:64c:203d:157c:bcca:66c4) has quit (Changing host) | |
[18:40:28] | cybrNaut (cybrNaut!cybrNaut@unaffiliated/cybrnaut) has joined #mythtv | |
[18:48:09] | tgm4883: | dekarl: so what I usually do after you merge one of my pull requests is "git fetch upstream master" then continue working. Is this not right? |
[18:51:54] | dekarl: | tgm4883: its only part. fetch does not merge, but pull does fetch+merge |
[18:52:11] | tgm4883: | dekarl: ah, so I should do pull instead. |
[18:52:24] | dekarl: | aye, pull or fetch+merge |
[18:53:46] | dekarl: | also if you open a pull request and then push new commits to that branch, the commits will be appended to the pull request, which may or may not be what you intend |
[18:54:04] | tgm4883: | yea I noticed that. It's pretty much what I intend |
[18:54:15] | tgm4883: | anything I push to the branch should be going to alcor |
[18:55:34] | dekarl: | having separate feature branches makes sense when the branch/pull requests has a life time > 1 day ;) |
[18:55:57] | dekarl: | and if there are parallel developments |
[18:56:18] | tgm4883: | yea I can see how that would be necessary for mythtv, but for just our packaging |
[18:56:52] | tgm4883: | considering there are only 1–2 of us doing packaging work and they are usually micro changes we should just commit to alcor |
[19:04:16] | dekarl: | true, just trying to keep the concepts straight. Maybe it'll come in handy with themes or whatever |
[20:03:49] | andreaz (andreaz!~andre_000@p5DD15164.dip0.t-ipconnect.de) has joined #mythtv | |
[20:15:30] | stuartm: | dblain: you might find #12426 interesting |
[20:15:30] | ** MythLogBot http://code.mythtv.org/trac/ticket/12426 ** | |
[20:22:28] | stichnot (stichnot!stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 245 seconds) | |
[20:36:58] | stichnot (stichnot!stichnot@mythtv/developer/stichnot) has joined #mythtv | |
[20:51:13] | cybrNaut (cybrNaut!cybrNaut@unaffiliated/cybrnaut) has quit (Ping timeout: 245 seconds) | |
[20:53:39] | cybrNaut (cybrNaut!cybrNaut@2001:0:53aa:64c:203d:157c:bcca:66c4) has joined #mythtv | |
[21:02:43] | SteveGoodey (SteveGoodey!~steve@host81-147-66-153.range81-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
[21:11:50] | tgm4883: | dekarl: I really feel at some point I'm going to get there with 0.28 qt5 building https://github.com/MythTV/packaging/pull/56 |
[21:13:50] | dekarl: | tgm4883: feel free to pull anytime |
[21:14:26] | dekarl: | Ahh cool. notice that the last commit came in without a "dekarl merged" commit |
[21:14:33] | tgm4883: | dekarl: building now |
[21:15:05] | tgm4883: | dekarl: the last build i386 failed, but amd64 built fine. For some reason, that dependency existed on the amd64 builder, so I'm hopeful this is the final fix I need to make |
[21:15:11] | stuartm: | dekarl: thanks for sorting that out, thought it had been done months ago |
[21:18:23] | stuartm: | or have I misunderstood? Thought tgm4883 had perms to the packaging repo |
[21:18:49] | tgm4883: | stuartm: I do |
[21:19:29] | stuartm: | ok good |
[21:19:42] | stuartm: | only half following today's events |
[21:21:12] | tgm4883: | stuartm: heh |
[21:21:21] | tgm4883: | stuartm: wait, I'm only half paying attention as well |
[21:21:44] | tgm4883: | stuartm: I don't have access to the packaging repo. I do, but I don't as that key has been deleted |
[21:32:30] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
[21:36:23] | Tobbe5178 (Tobbe5178!~asdf@2001:2002:51e3:5f22:159c:4410:7865:8925) has quit (Read error: Connection reset by peer) | |
[21:48:47] | dblain: | stuartm: Looked at the patch in #12426. They are pulling in libmyth/programtypes.cpp into libmythservicecontracts (while still keeping it part of libmyth). |
[21:48:47] | ** MythLogBot http://code.mythtv.org/trac/ticket/12426 ** | |
[21:49:30] | stuartm: | yeah, I thought it was an interesting approach |
[21:49:32] | dblain: | So there will be 2 unique versions now. Not a solution I would have pickted |
[21:50:07] | dblain: | I have a fix for it, just not one you will like, so I was thinking on the problem more. |
[21:51:23] | stuartm: | although I still need to look at the dependencies and work out how it ends up being a circular dependency – perhaps you could enlighten me how come libmyth ends up linking libmythservicecontracts |
[21:52:15] | dblain: | Through other libraries that pulls in libmythservicecontracts. (i.e. libmythupnp) |
[21:53:33] | dblain: | it's not a direct circular dependency... but between 3 libs. |
[21:55:19] | dblain: | My original intent was that libmythservicecontracts would have no dependencies. (it does pull in basic enum's through headers from libmyth, but no code). But once you make RecStatus a class instead of an enum, it needs to pull in the RecStatus::staticMetaObject implenentation to link. |
[21:56:39] | dblain: | The quickest soluton I found was move RecStatus to libmythservicecontracts. The next easiest would be to define a base RecStatus class that only contains the enum, and then implement the lookup methods in a derived class defined in libmyth. |
[21:57:03] | dblain: | Didn't think you would like either of those choices. |
[21:58:42] | dblain: | I was toying with a template approach, but haven't worked out the details yet. Or even proven it will work. |
[22:04:25] | dblain: | stuartm: personally I'd still like the classes defined in libmythservicecontracts be the base classes used in libmyth (well, all of mythtv). The derived classes would add the functionallity that is already there, but then we would not need to copy data around when services are called. But I know it's wishfull thinking. |
[22:08:26] | stuartm: | dblain: not wishful, eventually maybe, but right now we don't need the distraction of a large scale refactoring |
[22:09:50] | paul-h: | It's a nice idea but unlikely to ever get completed |
[22:10:24] | stuartm: | let me think about the RecStatus issue, I actually don't have much problem with moving all the enums into libmythservicecontracts – it's no worse than them being in libmyth which is wrong for a number of reasons |
[22:13:33] | stuartm: | it's late, I've had a long and stressful day, so I'm going to bed – I do want to resume this conversion, hopefully tomorrow but if not, definitely some time this week |
[22:18:43] | dblain: | np. Dinner time for me anyway. Have a good night. |
[22:18:52] | stuartm: | one thing to mention though, the libmyth <> libmythupnp dependency is something I'd like to eliminate |
[22:22:11] | paul-h (paul-h!~Paul@94.12.145.61) has quit (Quit: Konversation terminated!) | |
[22:22:16] | stuartm: | libmyth is meant to be going away anyway, but it's the ssdp backend selection stuff that's the reason for the dependency anyway and we need that, we just need to move it out of a low level lib to somewhere else |
[22:24:22] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Ping timeout: 252 seconds) | |
[22:36:35] | dblain: | stuartm: the ssdp classes are part of the upnp protocol stack, so moving them around might not be the best option. We could make the data available without needing to link to the library. I'd need to think about the choices that are available on all supported platforms. |
[22:42:39] | cybrNaut (cybrNaut!cybrNaut@2001:0:53aa:64c:203d:157c:bcca:66c4) has quit (Ping timeout: 276 seconds) | |
[22:44:40] | cybrNaut (cybrNaut!cybrNaut@2001:0:53aa:64c:203d:157c:bcca:66c4) has joined #mythtv | |
[23:12:54] | stuartm: | I meant moving the stuff that uses the SSDP out of the lib, not the SSDP classes themselves |
[23:28:43] | stichnot (stichnot!stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 245 seconds) | |
[23:29:50] | urlgrey (urlgrey!~urlgrey@199-116-73-2.sfo1.office.zencoderdns.net) has quit (Remote host closed the connection) | |
[23:43:38] | sraue (sraue!~stephan@kodi/staff/sraue) has quit (Ping timeout: 246 seconds) | |
[23:53:56] | sraue (sraue!~stephan@kodi/staff/sraue) has joined #mythtv |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.