| Saturday, April 11th, 2015, 00:01 UTC | ||
| [00:01:56] | Roklobsta (Roklobsta!~Roklobsta@ppp118-209-7-251.lns20.mel4.internode.on.net) has joined #mythtv | |
| [00:02:56] | Roklobsta (Roklobsta!~Roklobsta@ppp118-209-7-251.lns20.mel4.internode.on.net) has quit (Client Quit) | |
| [00:18:14] | stichnot_ (stichnot_!~stichnot@32.150.216.201) has joined #mythtv | |
| [00:20:12] | stichnot_ is now known as stichnot | |
| [00:30:39] | stichnot (stichnot!~stichnot@32.150.216.201) has quit (Ping timeout: 276 seconds) | |
| [01:02:43] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [01:23:37] | gary_buhrmaster (gary_buhrmaster!~gtb@2601:9:4980:1843:222:4dff:fe51:6728) has left #mythtv () | |
| [01:26:53] | cecil_ (cecil_!~cesman@pool-98-119-153-47.lsanca.fios.verizon.net) has quit (Quit: Konversation terminated!) | |
| [02:00:41] | urlgrey (urlgrey!~urlgrey@108-207-0-227.lightspeed.sntcca.sbcglobal.net) has joined #mythtv | |
| [02:02:08] | fetzerch_ (fetzerch_!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [02:04:17] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Ping timeout: 246 seconds) | |
| [02:11:05] | peper03_ (peper03_!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [02:14:54] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 265 seconds) | |
| [02:14:54] | peper03_ is now known as peper03 | |
| [02:21:33] | urlgrey (urlgrey!~urlgrey@108-207-0-227.lightspeed.sntcca.sbcglobal.net) has quit (Remote host closed the connection) | |
| [03:31:50] | andreaz (andreaz!~andre_000@p5DD15164.dip0.t-ipconnect.de) has quit (Read error: Connection reset by peer) | |
| [03:53:03] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [03:53:43] | stichnot: | stuartm: any reason not to make MythUIShape::SetFillBrush(QBrush fill) and void MythUIShape::SetLinePen(QPen pen) take const ref args instead of copying structs? |
| [03:54:07] | stichnot: | (similar to SetCropRect() directly above) |
| [03:56:49] | fetzerch_ (fetzerch_!~quassel@unaffiliated/fetzerch) has quit (Ping timeout: 264 seconds) | |
| [05:57:26] | Roklobsta (Roklobsta!~Roklobsta@ppp118-209-7-251.lns20.mel4.internode.on.net) has joined #mythtv | |
| [06:09:14] | Roklobotomy (Roklobotomy!~Roklobsta@ppp118-209-98-205.lns20.mel4.internode.on.net) has joined #mythtv | |
| [06:11:29] | Roklobsta (Roklobsta!~Roklobsta@ppp118-209-7-251.lns20.mel4.internode.on.net) has quit (Ping timeout: 245 seconds) | |
| [06:45:03] | joki (joki!~joki@p5B36DA39.dip0.t-ipconnect.de) has quit (Ping timeout: 276 seconds) | |
| [06:50:52] | joki (joki!~joki@p5B36C69A.dip0.t-ipconnect.de) has joined #mythtv | |
| [06:58:03] | SteveGoodey (SteveGoodey!~steve@host81-147-66-153.range81-147.btcentralplus.com) has joined #mythtv | |
| [07:36:21] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Remote host closed the connection) | |
| [07:37:47] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [07:48:17] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Remote host closed the connection) | |
| [07:48:43] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [07:50:53] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Remote host closed the connection) | |
| [07:51:09] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [08:00:36] | stuartm: | stichnot: I can't think of one right now |
| [08:23:38] | Roklobotomy: | MFE has been screen blanking in the middle of videos. what can i do to capture information to help debig it? |
| [08:23:42] | Roklobotomy: | or even debug |
| [08:24:18] | Roklobotomy: | using the remote doesn't unblank it but logging in via vnc and wiggling the mouse does |
| [08:31:30] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
| [08:33:56] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 240 seconds) | |
| [08:36:44] | dekarl1: | stichnot: isn't that something that cppcheck should suggest? IIUIC it reduces two copies to one copy. |
| [08:36:49] | dekarl1 is now known as dekarl | |
| [10:30:10] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.) | |
| [10:30:29] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [12:54:07] | andreaz (andreaz!~andre_000@p5DD15164.dip0.t-ipconnect.de) has joined #mythtv | |
| [12:55:45] | stichnot: | dekarl: yeah, no idea why cppcheck and coverity haven't been screaming over this (and probably a few other places) |
| [14:08:37] | dizygoth (dizygoth!~roger@cpc15-stre5-2-0-cust147.1-1.cable.virginm.net) has joined #mythtv | |
| [14:12:51] | dizygoth: | stichnot: Qt uses copy-on-write/implicit sharing so those args are effectively const refs already |
| [14:19:38] | stichnot: | dizygoth: that sounds right for the deep contents of the structs, but the outer container is still being passed by value? (though I guess it's largely a moot point if the outer container is 8 bytes or less) |
| [14:21:34] | stichnot: | but stylistically, my spidey-senses get all atingle when I see structs/classes passed by value |
| [14:58:39] | natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has joined #mythtv | |
| [15:16:56] | dizygoth: | stichnot: AIUI it will pass a pointer just as 'const &QBrush' would. Just a QT semantic nicety... |
| [15:19:13] | dizygoth: | stichnot: Just a question of style. However that's why ccpcheck won't flag it – there's no copying going on. |
| [16:02:55] | natanojl: | stichnot: I added a comment on #12269. Maybe you can take a look since it might be related to your changes in 0529d462? |
| [16:02:55] | ** MythLogBot http://code.mythtv.org/trac/ticket/12269 ** | |
| [16:14:12] | clever: | stichnot: i had a look, QBrush's only field is a QScopedPointer, and QPen only contains a regular pointer, so they are both going to be pretty tiny |
| [16:15:08] | clever: | yeah, both are exactly the same size as a plain pointer |
| [16:18:33] | clever: | only cost i can see is that QBrush has some ref tracking, that const QBrush& wouldnt |
| [16:22:36] | erikswed (erikswed!~Thunderbi@h-42-70.a357.priv.bahnhof.se) has joined #mythtv | |
| [16:22:46] | erikswed (erikswed!~Thunderbi@h-42-70.a357.priv.bahnhof.se) has left #mythtv () | |
| [16:25:01] | stichnot: | OK, I suspected that must be the case. Was too lazy to look up the .h file, instead I get to do U.S. taxes today... |
| [17:06:00] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 252 seconds) | |
| [17:06:37] | dizygoth (dizygoth!~roger@cpc15-stre5-2-0-cust147.1-1.cable.virginm.net) has quit (Quit: Konversation terminated!) | |
| [17:20:17] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [17:25:25] | stichnot: | natanojl: thanks for the analysis, I'll try to absorb all that. You're right that this does sound related to those changes |
| [17:25:45] | stichnot: | though being almost 2 years old, and involving live tv, it's practically gone from my memory :) |
| [17:36:49] | natanojl: | stichnot: I can relate to that :) |
| [17:44:33] | coling (coling!~colin@cpc8-sgyl36-2-0-cust443.18-2.cable.virginm.net) has quit (Ping timeout: 245 seconds) | |
| [17:51:32] | coling (coling!~colin@cpc8-sgyl36-2-0-cust443.18-2.cable.virginm.net) has joined #mythtv | |
| [19:02:08] | esperegu (esperegu!~quassel@ip-213-124-221-209.ip.prioritytelecom.net) has quit (Read error: Connection reset by peer) | |
| [19:03:09] | esperegu (esperegu!~quassel@ip-213-124-221-209.ip.prioritytelecom.net) has joined #mythtv | |
| [19:38:53] | neufeld (neufeld!~user@69-165-173-139.dsl.teksavvy.com) has joined #mythtv | |
| [19:39:00] | neufeld (neufeld!~user@69-165-173-139.dsl.teksavvy.com) has quit (Client Quit) | |
| [19:52:44] | natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has quit (Remote host closed the connection) | |
| [20:17:55] | SteveGoodey (SteveGoodey!~steve@host81-147-66-153.range81-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [21:17:22] | knightr (knightr!~Nicolas@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
| [23:25:08] | tgm4883: | dekarl: I added another fix to this pull request as master builds are currently failing for us https://github.com/MythTV/packaging/pull/49 |
| [23:30:48] | Roklobotomy (Roklobotomy!~Roklobsta@ppp118-209-98-205.lns20.mel4.internode.on.net) has quit (Ping timeout: 245 seconds) | |
| [23:59:04] | Roklobotomy (Roklobotomy!~Roklobsta@ppp118-209-98-205.lns20.mel4.internode.on.net) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.