| Wednesday, August 7th, 2013, 00:06 UTC | ||
| [00:06:06] | knightr_ (knightr_!~knightr@69-165-170-178.dsl.teksavvy.com) has joined #mythtv | |
| [00:06:18] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
| [00:15:06] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [00:56:40] | brfransen (brfransen!~brfransen@64.179.169.226) has quit (Read error: Operation timed out) | |
| [01:17:30] | knightr_ (knightr_!~knightr@69-165-170-178.dsl.teksavvy.com) has quit (Ping timeout: 245 seconds) | |
| [01:29:22] | gigem: | jpabq: I'm pretty sure you just broke manual recordings across time changes with commit 92d4e06e. There's a reason that variable name starts with "l". That calculation must be done in localtime. The reason is a recording scheduled at NN:00 (localtime) in daylight savings time should also start at NN:00 in standard time and vice versa. |
| [01:36:51] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [01:47:07] | MythBuild (MythBuild!~MythBuild@alcor.mythtv.org) has joined #mythtv | |
| [01:47:13] | joki (joki!~joki@p548638DC.dip0.t-ipconnect.de) has quit (Ping timeout: 245 seconds) | |
| [01:54:17] | joki (joki!~joki@p54863150.dip0.t-ipconnect.de) has joined #mythtv | |
| [01:57:46] | gregL (gregL!~greg@cpe-74-76-105-205.nycap.res.rr.com) has quit (Ping timeout: 260 seconds) | |
| [02:00:28] | gregL (gregL!~greg@cpe-74-76-105-205.nycap.res.rr.com) has joined #mythtv | |
| [02:17:18] | nyloc (nyloc!~quassel@pC19F54E6.dip0.t-ipconnect.de) has joined #mythtv | |
| [02:22:07] | _nyloc_ (_nyloc_!~quassel@p4FE4C542.dip0.t-ipconnect.de) has quit (Ping timeout: 268 seconds) | |
| [02:23:38] | wilmoore-misc (wilmoore-misc!~wilmoore@vlandnat.mystrotv.com) has quit (Remote host closed the connection) | |
| [02:26:12] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 240 seconds) | |
| [02:31:19] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [02:49:53] | jpabq: | gigem: That change was to fix it across time changes. Without it, the scheduler refuses to record the /second/ 1am to 2pm block, after the fall time change "falls back an hour". |
| [02:53:56] | jpabq: | I tested it by changing my system time to be midnight on November 3rd. I created manual recording rules for 7am, 8am and 9am UTC. To get the 8am UTC record rule, I had to manually insert in the DB, since the user interface uses local time, and thought I was just putting in a second rule for 2am. |
| [02:54:42] | jpabq: | Sorry, I mean a second rule for 1am. |
| [02:55:35] | jpabq: | Without that change, the scheduler missed the 8am UTC recording. With that change, it does it. |
| [02:56:56] | jpabq: | If that is not the correct way to fix the problem, than I would need your help... |
| [02:59:21] | jpabq: | This is mountain time zone, so on November 3rd 2013: 7am UTC == 1am MST, 8am UTC == 1am MST, 9am UTC == 2am MST |
| [03:03:33] | jya: | paul-h: you too could try with myth 0.26 and see if you have the issue. If not, we can start bisecting the problem |
| [03:04:56] | jpabq: | gigem: If that is not the correct fix, then let me know. Otherwise, I will also fix the var name to not start with an l. |
| [03:14:10] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Quit: Body blow! Body blow!) | |
| [03:30:58] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [03:32:44] | gigem: | jpabq: It is definitely not the correct fix since it causes daily and weekly manual rules to be off by an hour when the time changes. The code relies on QDateTime::addDays() doing the right thing across time changes when done with local time. Frankly, I don't know that there is a good fix. Manual recordings by definition use local time and when local time is ambiguous or invalid (think 2:xx am in the |
| [03:32:45] | gigem: | spring), the results might be surprising. I think the best you might be able to do is have the time spinbox show 2 1:00 ams in the fall and no 2:00 am in the spring. |
| [03:33:07] | stichnot (stichnot!~stichnot@adsl-68-127-28-24.dsl.pltn13.pacbell.net) has joined #mythtv | |
| [03:33:07] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [03:33:07] | stichnot (stichnot!~stichnot@adsl-68-127-28-24.dsl.pltn13.pacbell.net) has quit (Changing host) | |
| [03:41:54] | jpabq: | I thought the whole point of using UTC was to fix this problem. QDateTime::addDays() does not do the right thing with UTC? |
| [03:43:16] | jpabq: | I can see how daily and weekly would still be broken even with this change, in the fall. I don't see why there would be a problem in the spring though, unless QDateTime doesn't work correctly with UTC. |
| [03:47:40] | jpabq: | If manual recordings where UTC "by definition" then that would solve everything. However, I see why you say they are local-time "by definition" from a users perspective. |
| [04:19:25] | wilmoore-misc (wilmoore-misc!~wilmoore@c-67-190-17-108.hsd1.co.comcast.net) has joined #mythtv | |
| [04:20:30] | wilmoore-misc (wilmoore-misc!~wilmoore@c-67-190-17-108.hsd1.co.comcast.net) has quit (Remote host closed the connection) | |
| [04:22:49] | gigem: | addDays() does the right thing in UTC. That's the simple case because there is no DST. However, it also does the right thing in other timezones where there is DST. For example, 2013-11–01 12:00:00 CDT plus 1 day is 2013-11–02 12:00:00 CST. If that same calculation is done in UTC and converted back to local time, however, the result would be 2013-11–02 11:00:00. After giving it some more thought, I think |
| [04:22:51] | gigem: | the time spinbox actually does the right thing and shows 2 1ams and no 2am when appropriate. So if you really want to fix the problem, I think you'll have to have one code path for daily/weekly rules (and accept some times just won't work twice a year) and another path for single/override rules. Personally, I think the switch to UTC was mostly an exercise in hoop jumping. It made some things easier/better |
| [04:22:53] | gigem: | at the expense of other things. I'm biased, though, as the scheduler incurred much of the new pain. |
| [16:21:56] | MythBuild (MythBuild!~MythBuild@alcor.mythtv.org) has joined #mythtv | |
| [16:22:31] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [16:25:32] | knightr: | It's back... |
| [16:25:59] | stuarta: | dekarl: no, you have to tune to a specific channel |
| [16:26:08] | rsiebert_ (rsiebert_!~quassel@e179130219.adsl.alicedsl.de) has joined #mythtv | |
| [16:26:35] | ** stuarta runs away for a while ** | |
| [16:27:01] | knightr: | stuarta, the finally woke up :) |
| [16:27:07] | knightr: | s/the/they |
| [16:28:57] | rsiebert (rsiebert!~quassel@g226063111.adsl.alicedsl.de) has quit (Ping timeout: 264 seconds) | |
| [16:29:55] | SteveGoodey (SteveGoodey!~steve@host86-151-111-43.range86-151.btcentralplus.com) has joined #mythtv | |
| [16:30:21] | yianni (yianni!~yianni@130.43.82.148.dsl.dyn.forthnet.gr) has joined #mythtv | |
| [16:30:34] | yianni (yianni!~yianni@130.43.82.148.dsl.dyn.forthnet.gr) has left #mythtv () | |
| [16:36:26] | knightr: | jpabq, can I borrow your time machine please? :) |
| [16:37:14] | knightr: | (as somebody pointed out in -users your last commit was in 3 months...) |
| [16:38:17] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has quit (Quit: FabriceMG) | |
| [16:38:18] | natanojl: | knightr: He changed the time on his system to test that commit but obviously forget to change it back |
| [16:38:30] | jpabq: | Oops. I was testing a problem with the fall time change. I forgot to reset the system time back. |
| [16:39:10] | stuartm: | commit times should be based on the server rather than the client :/ |
| [16:39:29] | knightr: | natanojl, awwww. I was preferring the time machine version better... :) |
| [16:40:19] | stuartm: | too easy to abuse otherwise, want to bury a malicious commit where people are less likely to notice it? Then just set the time on your machine back a year |
| [16:40:46] | natanojl: | knightr: me too :) |
| [16:41:15] | ** knightr is ROTFL... ** | |
| [16:43:26] | jpabq: | gigem didn't like that commit anyway. With or without that commit, the handling of manual records during a time change will surprise someone... |
| [16:51:47] | Jordack (Jordack!~Jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [17:13:54] | wolfgang (wolfgang!~wolfgang@178-27-129-87-dynip.superkabel.de) has quit (Ping timeout: 264 seconds) | |
| [17:18:06] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has quit (Quit: “The only way to have a friend is to be one.†― Ralph Waldo Emerson) | |
| [17:25:45] | wolfgang (wolfgang!~wolfgang@178-27-129-87-dynip.superkabel.de) has joined #mythtv | |
| [17:31:33] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has joined #mythtv | |
| [17:36:18] | gigem: | jpabq: I've got a better and even uglier fix for the scheduler part. The GUI is another matter, however. |
| [17:37:27] | jpabq: | gigem: I assume you saw that I reverted that commit. I am glad to hear you have a better fix — thanks. |
| [18:14:34] | knightr: | Hi! Do we still have blockers for the beta? |
| [18:17:09] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [18:39:31] | raven_ (raven_!~raven@dslb-178-007-179-089.pools.arcor-ip.net) has joined #mythtv | |
| [18:39:42] | raven_ (raven_!~raven@dslb-178-007-179-089.pools.arcor-ip.net) has left #mythtv ("Verlassend") | |
| [18:54:52] | len_ (len_!~quassel@75-161-179-129.mpls.qwest.net) has joined #mythtv | |
| [19:26:30] | dekarl: | man, I hate magic numbers |
| [19:26:32] | gigem: | jpabq: No, I hadn't noticed until I went to merge. It was no big deal. See the note in the commit message. |
| [19:26:38] | Jasoncullen (Jasoncullen!~AndChat51@222.152.177.50) has quit (Ping timeout: 240 seconds) | |
| [19:26:40] | gigem: | 42? |
| [19:27:06] | dekarl: | close... while 42 is 7*6 it was a 6 instead of a 7 |
| [19:27:23] | gigem: | So close! |
| [19:32:41] | SteveGoodey (SteveGoodey!~steve@host86-151-111-43.range86-151.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [19:36:24] | Steve-Goodey (Steve-Goodey!~steve@host86-151-111-43.range86-151.btcentralplus.com) has joined #mythtv | |
| [19:38:17] | kwmonroe` is now known as kwmonroe | |
| [19:40:28] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [19:40:44] | natanojl: | Captain_Murdoch: stuartm: Looks like a free memory read might occur in MythDownloadManager::downloadFinished(MythDownloadInfo*) when dlInfo is deleted in MythDownloadManager::GetLastModified(QString const&), http://pastebin.com/heC1xQRa |
| [19:41:48] | natanojl: | I got a crash while quickly scrolling through the radio stream list in mythmusic |
| [19:53:34] | paul-h (paul-h!~Paul@176.253.145.244) has quit (Remote host closed the connection) | |
| [19:59:05] | Steve-Goodey (Steve-Goodey!~steve@host86-151-111-43.range86-151.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [20:02:45] | Jasoncullen (Jasoncullen!~AndChat51@210-86-3-98.adsl.xtra.co.nz) has joined #mythtv | |
| [20:03:27] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [20:04:33] | Jasoncullen (Jasoncullen!~AndChat51@210-86-3-98.adsl.xtra.co.nz) has quit (Client Quit) | |
| [20:18:25] | Jordack (Jordack!~Jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit (Quit: I think will give my wife the option tonight; sex or The Last Starfighter in repeat.) | |
| [20:20:10] | stuartm: | Captain_Murdoch: in the event that the download times out, we stop waiting for the download to finish in downloadNow() and switch from blocking to non-blocking, at which point dlinfo can either be deleted from under us by downloadFinished even though we've asked it not to OR as in natanojl's case, we delete dlinfo because we're done with it, even though the download is technically still running in the background |
| [20:20:34] | stuartm: | making dlinfo reference counted may be one solution |
| [20:25:05] | natanojl: | This was on master by the way. I don't know if it exists on 0.26-fixes or earlier |
| [21:05:19] | jpabq: | gigem: thanks for taking care of that. |
| [21:11:18] | bill6502 (bill6502!~bill@205.178.26.43) has quit (Remote host closed the connection) | |
| [21:11:35] | bill6502 (bill6502!~bill@205.178.26.43) has joined #mythtv | |
| [21:34:40] | jheizer (jheizer!~jheizer@c-98-226-220-178.hsd1.il.comcast.net) has quit (Read error: Connection reset by peer) | |
| [21:55:04] | natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has quit (Ping timeout: 264 seconds) | |
| [22:04:35] | nyloc (nyloc!~quassel@pC19F54E6.dip0.t-ipconnect.de) has quit (Ping timeout: 245 seconds) | |
| [22:10:46] | gigem: | jpabq: np, I even found a bug in the previous code in the process. |
| [22:18:31] | bill6502 (bill6502!~bill@205.178.26.43) has left #mythtv () | |
| [23:30:53] | jya: | jpabq: have you looked more into the signalmonitor/recorder/streamhandler as we talked about a few weeks ago? |
| [23:32:30] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 264 seconds) | |
| [23:41:24] | stuarta: | i'm off to bed now, but if alcor runs out of disk space, check it wasn't the DB backup i'm running |
| [23:58:03] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.