| Thursday, February 28th, 2013, 00:01 UTC | ||
| [00:01:30] | Wolfgang (Wolfgang!~Thunderbi@178-27-144-160-dynip.superkabel.de) has quit (Quit: Wolfgang) | |
| [00:15:31] | SteveC (SteveC!~scasey@5e0114c7.bb.sky.com) has joined #mythtv | |
| [00:23:22] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [00:28:54] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 264 seconds) | |
| [00:53:46] | stichnot (stichnot!~stichnot@216.239.45.130) has joined #mythtv | |
| [00:53:46] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [00:53:46] | stichnot (stichnot!~stichnot@216.239.45.130) has quit (Changing host) | |
| [01:00:31] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [01:34:22] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [02:11:22] | stichnot (stichnot!~stichnot@adsl-68-127-102-161.dsl.pltn13.pacbell.net) has joined #mythtv | |
| [02:11:22] | stichnot (stichnot!~stichnot@adsl-68-127-102-161.dsl.pltn13.pacbell.net) has quit (Changing host) | |
| [02:11:22] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [02:30:54] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [02:35:42] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
| [02:58:41] | knightr (knightr!~knightr@69-165-170-178.dsl.teksavvy.com) has joined #mythtv | |
| [02:58:41] | knightr (knightr!~knightr@69-165-170-178.dsl.teksavvy.com) has quit (Changing host) | |
| [02:58:42] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [03:11:41] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@pool-173-48-113-147.bstnma.fios.verizon.net) has quit (Quit: Oh No!!!! ;-)) | |
| [03:18:43] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@pool-173-48-113-147.bstnma.fios.verizon.net) has joined #mythtv | |
| [03:36:33] | peper03 (peper03!~peper03@port-92-203-92-253.dynamic.qsc.de) has quit (Ping timeout: 248 seconds) | |
| [03:36:39] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
| [03:38:30] | danielk221: | jpabq: I'd love to see the log where the scheduler repeatedly sleeps for 0 ms. |
| [03:38:31] | peper03 (peper03!~peper03@port-92-203-12-60.dynamic.qsc.de) has joined #mythtv | |
| [04:05:06] | danielk221 (danielk221!~danielk@96.57.9.142) has quit (Ping timeout: 256 seconds) | |
| [04:19:55] | danielk221 (danielk221!~danielk@exchange.wgen.net) has joined #mythtv | |
| [04:35:05] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Quit: Body blow! Body blow!) | |
| [04:47:29] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has quit (Ping timeout: 248 seconds) | |
| [04:48:56] | fetzerch (fetzerch!~quassel@unaffiliated/fetzerch) has joined #mythtv | |
| [06:26:12] | stichnot: | taylorr, jpabq: AvFormatDecoder::H264PreProcessPkt() recalculates the width and height using m_h264_parser->pictureWidth() and pictureHeight(). This is not really correct because it ignores frame_crop_{left,right,top,bottom}_offset, and in any case the result seems to be already available in stream->codec->{width,height}. E.g. for a 1080i recording, m_h264_parser->pictureHeight()==1088 and... |
| [06:26:13] | stichnot: | ...stream->codec->coded_height==1088, while stream->codec->height==1080 seems to be the value that should be used. |
| [06:29:19] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [06:29:33] | stichnot: | So would you see any problem using stream->codec->{width,height} instead of m_h264_parser->pictureWidth() and pictureHeight()? BTW this is with respect to #11358. |
| [06:29:33] | ** MythLogBot http://code.mythtv.org/trac/ticket/11358 ** | |
| [06:54:01] | jheizer (jheizer!~jheizer@c-98-226-220-178.hsd1.il.comcast.net) has quit (Read error: Connection reset by peer) | |
| [06:54:27] | jheizer (jheizer!~jheizer@c-98-226-220-178.hsd1.il.comcast.net) has joined #mythtv | |
| [07:04:15] | Sharky112065 is now known as Sharky-Sleep | |
| [07:04:59] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [07:08:00] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has joined #mythtv | |
| [07:36:42] | Tobbe5178 (Tobbe5178!~asdf@h186n5-sv-a13.ias.bredband.telia.com) has quit (Read error: Connection reset by peer) | |
| [07:59:12] | dekarl (dekarl!~dekarl@p4FE855D9.dip.t-dialin.net) has quit (Ping timeout: 256 seconds) | |
| [08:00:27] | dekarl (dekarl!~dekarl@p4FCEF77A.dip.t-dialin.net) has joined #mythtv | |
| [08:08:43] | SteveGoodey (SteveGoodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has joined #mythtv | |
| [08:35:05] | Merlin83b (Merlin83b!~Daniel@2a00:1ee0:3:1337:b54f:5022:6101:4229) has joined #mythtv | |
| [08:50:31] | DJDan (DJDan!~djdan@115-64-177-188.static.tpgi.com.au) has joined #mythtv | |
| [09:01:11] | dekarl: | stichnot, that sounds like it might also handle the tricks done in TS 101 547 v1.1.1 (01/12) Annex B to allow a non-3D HDTV to show one picture of side-by-side 3DTV fullscreen on a 2DTV. (just throwing it out as it appears to be using the same video properties to achieve a different effect) |
| [09:31:07] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [09:35:14] | bas-t_ (bas-t_!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [09:35:58] | bas-t_ (bas-t_!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Client Quit) | |
| [09:39:52] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [09:47:56] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [10:05:58] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [10:21:37] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [10:23:32] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
| [10:31:47] | Steve-Goodey (Steve-Goodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has joined #mythtv | |
| [10:36:13] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has quit (Ping timeout: 256 seconds) | |
| [10:50:15] | Captain_Murdoch (Captain_Murdoch!~cpinkham@c-67-183-28-151.hsd1.wa.comcast.net) has joined #mythtv | |
| [10:50:15] | Captain_Murdoch (Captain_Murdoch!~cpinkham@c-67-183-28-151.hsd1.wa.comcast.net) has quit (Changing host) | |
| [10:50:15] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has joined #mythtv | |
| [10:51:40] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [10:54:26] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
| [10:55:29] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has quit (Ping timeout: 256 seconds) | |
| [10:56:49] | Captain_Murdoch (Captain_Murdoch!~cpinkham@c-67-183-28-151.hsd1.wa.comcast.net) has joined #mythtv | |
| [10:56:49] | Captain_Murdoch (Captain_Murdoch!~cpinkham@c-67-183-28-151.hsd1.wa.comcast.net) has quit (Changing host) | |
| [10:56:49] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has joined #mythtv | |
| [11:34:02] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has quit (Ping timeout: 256 seconds) | |
| [11:49:54] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [11:51:38] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [11:55:32] | DJDan (DJDan!~djdan@115-64-177-188.static.tpgi.com.au) has quit (Remote host closed the connection) | |
| [12:06:23] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [12:26:45] | Chutt_ (Chutt_!~ijr@cpe-24-29-225-175.neo.res.rr.com) has joined #mythtv | |
| [12:29:11] | FabriceMG1 (FabriceMG1!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
| [12:31:20] | Seeker`_ (Seeker`_!~cjo20@host109-154-190-19.range109-154.btcentralplus.com) has joined #mythtv | |
| [12:35:45] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has quit (*.net *.split) | |
| [12:35:45] | nephyrin (nephyrin!~neph@nat/mozilla/x-ljrzpqbaajuobbim) has quit (*.net *.split) | |
| [12:35:45] | Seeker` (Seeker`!~cjo20@unaffiliated/seeker) has quit (*.net *.split) | |
| [12:35:45] | Chutt (Chutt!~ijr@cpe-24-29-225-175.neo.res.rr.com) has quit (*.net *.split) | |
| [12:53:18] | Captain_Murdoch (Captain_Murdoch!~cpinkham@c-67-183-28-151.hsd1.wa.comcast.net) has joined #mythtv | |
| [12:53:18] | Captain_Murdoch (Captain_Murdoch!~cpinkham@c-67-183-28-151.hsd1.wa.comcast.net) has quit (Changing host) | |
| [12:53:18] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has joined #mythtv | |
| [13:23:20] | Steve-Goodey (Steve-Goodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [13:23:57] | Steve-Goodey (Steve-Goodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has joined #mythtv | |
| [14:11:41] | IReboot (IReboot!~doug@CPE10bf48e67915-CM78cd8e7e342d.cpe.net.cable.rogers.com) has quit (Quit: Ex-Chat) | |
| [14:13:22] | danielk22 (danielk22!~danielk@exchange.wgen.net) has joined #mythtv | |
| [14:13:33] | taylorr: | stichnot: I don't know much about how to handle the width/height detection – you might want to get an opinion from Daniel and Isaac |
| [14:18:18] | danielk22: | stichnot: The problem is that stream->codec->height and stream->codec->coded_height are updated too late. So if we use those and the frame pixel count increases we end up with a segfault. We need to grab these dimensions in the pre-processing so the buffer we hand to ffmpeg is big enough to fit the frame. |
| [14:30:04] | SteveGoodey (SteveGoodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [14:50:15] | _charly_ (_charly_!kroseneg@sunrise.schmidham.net) has quit (Ping timeout: 260 seconds) | |
| [14:50:15] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Quit: Leaving) | |
| [14:59:00] | stichnot: | danielk22: ok. so basically in H264Parser I need to repeat the logic in https://github.com/MythTV/mythtv/blob/master/ . . . h264.c#L2492 right? |
| [15:02:29] | _charly_ (_charly_!kroseneg@sunrise.schmidham.net) has joined #mythtv | |
| [15:04:12] | IReboot (IReboot!~doug@CPE10bf48e67915-CM78cd8e7e342d.cpe.net.cable.rogers.com) has joined #mythtv | |
| [15:08:06] | SteveGoodey (SteveGoodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has joined #mythtv | |
| [15:34:22] | jpabq: | stichnot: I did not write that part of of H264Parser, so am not married to it. I believe it was originally added just for informational purposes. In my opinion, you can do what ever you need to do to get playback correct. |
| [15:46:42] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [15:46:43] | danielk22: | stichnot: yep |
| [15:47:11] | neufeld (neufeld!~user@69-165-173-139.dsl.teksavvy.com) has quit (Quit: ERC Version 5.3 (IRC client for Emacs)) | |
| [15:54:42] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 264 seconds) | |
| [15:58:22] | danielk22 (danielk22!~danielk@exchange.wgen.net) has quit (Quit: Leaving.) | |
| [16:03:19] | Steve-Goodey (Steve-Goodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [16:04:08] | Steve-Goodey (Steve-Goodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has joined #mythtv | |
| [16:07:02] | peper03 (peper03!~peper03@port-92-203-12-60.dynamic.qsc.de) has quit (Remote host closed the connection) | |
| [16:28:34] | FabriceMG1 (FabriceMG1!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has quit (Quit: FabriceMG1) | |
| [16:28:42] | peper03 (peper03!~peper03@port-92-203-12-60.dynamic.qsc.de) has joined #mythtv | |
| [16:30:48] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [16:32:05] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Remote host closed the connection) | |
| [16:32:21] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [16:35:54] | stichnot: | "return AVERROR_PATCHWELCOME;" — I love it |
| [16:38:57] | stichnot: | Can anyone get me an h.264 sample with a resolution change? |
| [16:42:43] | Sharky-Sleep is now known as Sharky112065 | |
| [16:49:52] | neufeld (neufeld!~user@69-165-173-139.dsl.teksavvy.com) has joined #mythtv | |
| [16:58:59] | stichnot: | danielk221: This is about the VideoFrame structs that ffmpeg decodes into, right? |
| [17:00:55] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [17:06:36] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has quit (Ping timeout: 276 seconds) | |
| [17:18:43] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [17:23:39] | danielk22 (danielk22!~danielk@exchange.wgen.net) has joined #mythtv | |
| [17:26:41] | stichnot (stichnot!~stichnot@216.239.45.79) has joined #mythtv | |
| [17:26:41] | stichnot (stichnot!~stichnot@mythtv/developer/stichnot) has joined #mythtv | |
| [17:26:41] | stichnot (stichnot!~stichnot@216.239.45.79) has quit (Changing host) | |
| [17:37:48] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Quit: Leaving) | |
| [18:00:20] | Merlin83b (Merlin83b!~Daniel@2a00:1ee0:3:1337:b54f:5022:6101:4229) has quit (Read error: Connection reset by peer) | |
| [18:27:28] | gigem (gigem!~david@mythtv/developer/gigem) has quit (Quit: WeeChat 0.3.8) | |
| [18:29:34] | gigem (gigem!~david@pool-71-123-128-124.dllstx.fios.verizon.net) has joined #mythtv | |
| [18:29:35] | gigem (gigem!~david@pool-71-123-128-124.dllstx.fios.verizon.net) has quit (Changing host) | |
| [18:29:35] | gigem (gigem!~david@mythtv/developer/gigem) has joined #mythtv | |
| [18:31:00] | taylorr: | stichnot: I think the sample that skd5aner provided for a ticket has a resolution change |
| [18:32:59] | taylorr: | stichnot: ticket #11159 and I believe it's on the box.com share |
| [18:32:59] | ** MythLogBot http://code.mythtv.org/trac/ticket/11159 ** | |
| [18:36:54] | stichnot: | taylorr: thanks, I'll look for that |
| [19:40:01] | sl1ce (sl1ce!~johnathan@pool-100-0-73-123.bstnma.fios.verizon.net) has quit (Quit: Konversation terminated!) | |
| [19:40:17] | stichnot: | taylorr: skd5aner's sample makes mythavtest segfault in master... this is with software decoding and XVideo on my laptop |
| [19:42:05] | sl1ce (sl1ce!~johnathan@100.0.73.123) has joined #mythtv | |
| [19:47:46] | sl1ce (sl1ce!~johnathan@100.0.73.123) has quit (Remote host closed the connection) | |
| [19:49:11] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [19:49:19] | sl1ce (sl1ce!~johnathan@100.0.73.123) has joined #mythtv | |
| [19:49:36] | rhpot1991 (rhpot1991!~rhpot1991@ubuntu/member/rhpot1991) has quit (Ping timeout: 245 seconds) | |
| [19:53:18] | rhpot1991 (rhpot1991!~rhpot1991@2001:4968:202:3:2ca2:718:23c8:4d39) has joined #mythtv | |
| [19:53:19] | rhpot1991 (rhpot1991!~rhpot1991@2001:4968:202:3:2ca2:718:23c8:4d39) has quit (Changing host) | |
| [19:53:19] | rhpot1991 (rhpot1991!~rhpot1991@ubuntu/member/rhpot1991) has joined #mythtv | |
| [19:57:35] | taylorr: | stichnot: it still causes a segfault? I hoped that it was fixed... it plays fine with vdpau for some reason |
| [19:58:27] | taylorr: | stichnot : if you cut the beginning of the video so that it starts on the first keyframe it might help |
| [20:01:46] | tonsofpcs: | is this an mpeg2ts with mpeg4avc in it or a 'mpeg4 ts' ? (if it's the former, I can probe it in excruciating detail with the Tek MTS on my desk if you'd like) |
| [20:05:58] | SteveGoodey (SteveGoodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [20:06:26] | taylorr: | tonsofpcs: this is an HD-PVR produces recording so it's H.264 in an MPEG-TS format |
| [20:06:54] | taylorr: | not sure which type of TS |
| [20:11:11] | SteveGoodey (SteveGoodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has joined #mythtv | |
| [20:11:57] | taylorr: | stichnot: run 'dd if=input.mpg ibs=188 skip=17833 of=out.mpg' for the 11159 sample and see if the segfault goes away |
| [20:20:47] | taylorr: | stichnot: odd, if I cut off all the unreferenced video frames before the first keyframe then it reports the video as being 1280x720... so it looks like the 720x480 frames are all unreferenced which probably is what causes the segfault |
| [20:32:16] | stichnot: | taylorr: after running dd, I get a bunch of log messages "Timed out waiting for frames, and there are not enough free frames. Discarding buffered frames.", and no playback |
| [20:41:31] | tonsofpcs: | well, if you want to toss the file this way, I can get to that sample real quick and tell you what is happening in the file... can't tell you the decoder, ofc. |
| [20:48:51] | taylorr: | stichnot: vlc doesn't play the original correctly but the cut version plays perfectly... probably something in the player that's not quite right |
| [20:49:21] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [20:55:52] | peper03: | "internal compiler error"? WTF? Some commit is causing the DVD VM to assert. Tried to bisect it and now I'm getting compiler errors? |
| [21:01:09] | rsiebert (rsiebert!~quassel@g225057200.adsl.alicedsl.de) has joined #mythtv | |
| [21:01:13] | SteveGoodey (SteveGoodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [21:04:12] | rsiebert_ (rsiebert_!~quassel@g231187238.adsl.alicedsl.de) has quit (Ping timeout: 272 seconds) | |
| [21:07:18] | SteveGoodey (SteveGoodey!~steve@86.147.183.135) has joined #mythtv | |
| [21:09:06] | tgm4883 (tgm4883!~tgm4883@ubuntu/member/tgm4883) has quit (Quit: ZNC - http://znc.in) | |
| [21:09:55] | tgm4883 (tgm4883!~tgm4883@ubuntu/member/tgm4883) has joined #mythtv | |
| [21:13:06] | peper03 (peper03!~peper03@port-92-203-12-60.dynamic.qsc.de) has quit (Quit: Konversation terminated!) | |
| [21:19:38] | peper03 (peper03!~peper03@port-92-203-12-60.dynamic.qsc.de) has joined #mythtv | |
| [21:27:21] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has quit (Read error: No route to host) | |
| [21:39:43] | peper03: | Ok, compiling works again for whatever reason but it appears that whichever commit is causing the assertion, it was before the last DB upgrade :( |
| [21:40:17] | peper03: | s/upgrade/schema update/ |
| [21:49:46] | Steve-Goodey (Steve-Goodey!~steve@host86-147-183-135.range86-147.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [21:57:38] | SteveGoodey (SteveGoodey!~steve@86.147.183.135) has quit (Quit: Konversation terminated!) | |
| [22:03:15] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [22:18:31] | stuartm: | peper03: tried a distclean? |
| [22:20:08] | peper03: | stuartm: Yep, several times. The DVD plays fine with current 0.26-fixes on the same machine. On master, I've got back to commit 1eaecea and it hits an assertion in vm.c straight away. |
| [22:21:24] | stuartm: | https://github.com/MythTV/mythtv/commit/1eaecea |
| [22:21:53] | peper03: | It doesn't make much sense, as very little has changed there. It seems to be some part of the IFO structure that it doesn't like but apart from the recent commit to resync libdvdnav/libdvdread, nothing has changed compared to 0.26-fixes (as far as I'm aware). |
| [22:22:58] | stuartm: | which assert is being triggered? |
| [22:24:12] | peper03: | https://github.com/MythTV/mythtv/blob/master/ . . . m/vm.c#L1154 |
| [22:24:24] | peper03: | If you can understand that bit of code, please explain it to me :) |
| [22:26:54] | stuartm: | doesn't make sense to me, assert if cellN is a positive integer ... but cellN is then used as the index in an array and must therefore be a positive integer? |
| [22:27:24] | stuartm: | < 0 I could understand |
| [22:28:07] | peper03: | No, it's asserting that ....block_type == 0. In this case, it isn't. It's 2. |
| [22:29:41] | stuartm: | oh, weird, the first line in my browser was 1141 assert((vm->state).cellN > 0); not 1154 |
| [22:30:00] | Sharky112065 (Sharky112065!~Sharky112@24.19.57.28) has joined #mythtv | |
| [22:30:19] | peper03: | Line 1154 should be highlighted. It is in my browser. |
| [22:31:03] | stuartm: | yeah, it is here, but the contrast wasn't very good so I didn't notice (pale yellow on white) |
| [22:31:56] | stuartm: | fwiw, 1141 still doesn't make any sense to me ;) |
| [22:32:17] | danielk22 (danielk22!~danielk@exchange.wgen.net) has left #mythtv () | |
| [22:35:11] | peper03: | It's checking that cellN > 0. If it isn't, it'll abort. |
| [22:36:29] | peper03: | FWIW, this is the structure being referenced: https://github.com/MythTV/mythtv/blob/master/ . . . types.h#L209 |
| [22:36:30] | stuartm: | doh, yeah, I was forgetting that assert checks whether a statement is false, not whether it's true |
| [22:37:16] | peper03: | Depends on your point of view. It'll *do* something if it's false. But it's asserting that it's true :) |
| [22:37:41] | stuartm: | peper03: yeah, I'm looking at dvdread_getbits atm, it's initialised to 2 but getbits would appear to default to returning 0 in the event of an error |
| [22:38:00] | peper03: | But yeah, you tend to read it back-to-front. |
| [22:39:07] | stuartm: | I've not used assert() in years, it's banned in this project and quite a lot of other projects too because it's often just a poor replacement for proper error handling |
| [22:39:30] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [22:39:43] | stuartm: | consequently it's not the first time I've forgotten how it works :) |
| [22:40:00] | peper03: | I don't see where a default value is set. The '2' is the number of bits to read, isn't it? |
| [22:42:30] | stuartm: | I need new glasses, I read that : as = |
| [22:42:49] | joki (joki!~joki@p548620FB.dip.t-dialin.net) has quit (Ping timeout: 244 seconds) | |
| [22:43:15] | joki (joki!~joki@p5486299D.dip.t-dialin.net) has joined #mythtv | |
| [22:43:31] | peper03: | Time for a bigger monitor or larger font :) |
| [22:45:54] | peper03: | Ok, this is interesting. I tried opening the IFO in IfoEdit. I'm not certain which file was causing the problem, but if I'm looking at the right bit, IfoEdit has the block type marked as 'Invalid'. |
| [22:46:22] | peper03: | What the hell's going on? If it really *is* invalid, why does it play on 0.26-fixes? |
| [22:47:05] | stuartm: | I'm obviously not going to be much help tonight, if you've not got it figured out by tomorrow I can take another look when I'm not half asleep :) |
| [22:47:59] | stuartm: | peper03: your 0.26 build is not a debug build? |
| [22:48:10] | peper03: | Same problem here :) I think I'll leave it for tonight. Too much is not making sense. |
| [22:48:25] | peper03: | No, it's a normal packaged build. |
| [22:48:37] | stuartm: | assert will only trigger in debug/profile builds |
| [22:49:01] | peper03: | Oh, yes. Hadn't thought of that. |
| [22:50:26] | peper03: | And yet, I used this DVD for #11371. I wanted to test my new patch and hit the assertion. |
| [22:50:26] | ** MythLogBot http://code.mythtv.org/trac/ticket/11371 ** | |
| [22:50:36] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [22:51:02] | peper03: | Why didn't I hit it when I was creating that patch? Or was I not using a debug build... |
| [22:51:07] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Quit: Leaving) | |
| [22:51:13] | stuartm: | in fact looking at configure, only debug builds, we strip it for profile builds |
| [22:51:44] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [22:52:04] | stuartm: | s/strip/disable/ |
| [22:52:43] | stuartm: | by the look of it, we now only support two build types, profile and debug, no idea when we dropped 'release' builds |
| [22:52:53] | peper03: | Ah, that's probably it. I just checked my config.log. To start off with, I wasn't setting the compile-type option at all. |
| [22:53:27] | peper03: | Obviously spent so long at work not being able to use a debugger that I got out of the habit :) |
| [22:53:59] | stuartm: | help text is out of date, it still indicates 'release' is valid, but we're only disabling asserts for profile builds |
| [22:54:24] | stuartm: | peper03: well at least that little mystery is solved |
| [22:54:44] | peper03: | Yep. Next mystery is why is Pixar creating invalid DVDs? |
| [22:54:48] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Client Quit) | |
| [22:55:28] | bas-t (bas-t!~tycho@82.72.78.137) has joined #mythtv | |
| [22:55:59] | peper03: | Next mystery after that, why is libdvdnav asserting on something that obviously doesn't cause it to fail? |
| [22:56:35] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 260 seconds) | |
| [22:56:54] | stuartm: | well that's easy, if it was after they were bought by Disney at least ... 99% of problem DVDs are Disney discs, I think they master them in-house and very, very badly |
| [22:58:47] | stuartm: | the second mystery, well people make stupid assumptions that standards/specs will always be followed exactly and they don't know how or why to use asserts (generally best avoided entirely) |
| [22:58:55] | peper03: | Yep, Cars 2 from 2011. Disney bought Pixar in, wow, 2006. Is it that long ago? |
| [22:59:38] | stuartm: | asserts should really only ever be used to guard against errors in the code, not to validate external input (as they are being used here) |
| [22:59:49] | bas-t (bas-t!~tycho@82.72.78.137) has quit (Client Quit) | |
| [23:00:25] | peper03: | It's always possible that it's down to copy-protection too. This DVD is one of those with 99 titles. Maybe the libdvdread/libdvdnav code is following the wrong path at some point. |
| [23:01:44] | stuartm: | peper03: sine if it plays with a profile build (no assert) that doesn't seem to be the case, the assert is just bogus |
| [23:01:46] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [23:01:47] | stuartm: | since |
| [23:03:10] | peper03: | Exactly. It either isn't using actually using that value anywhere of significance later or it is part of the copy protection and that IFO is not touched again later. |
| [23:03:38] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit (Client Quit) | |
| [23:04:35] | peper03: | I'll have another look at the forked libdvdnav/read stuff tomorrow. Would be interesting to see if there's anything in there that would have an effect here. |
| [23:06:05] | peper03: | I queried a work-around on the mailing list a couple of weeks ago. Not a single comment. Doesn't surprise me that it got forked. |
| [23:06:53] | stuartm: | peper03: we could just disable the asserts entirely in both builds, they aren't used anywhere in mythtv code and individual developers can enable them if they want to use asserts when testing their own patches |
| [23:10:37] | peper03: | stuartm: Doesn't sound like there'd be too many downsides to that. Would it make sense to log them instead of disabling entirely? There's a good chance they'd get lost in the noise, though. |
| [23:15:44] | stuartm: | logging them might at least help in debugging issues reported by users |
| [23:16:24] | stuartm: | I'm going to bed, I'll do something about it in the morning |
| [23:17:20] | peper03: | Yep. I just did a quick seach. There are quite a lot of uses of assert in non-external code. 4 in AvFormatDecoder alone. |
| [23:17:43] | peper03: | Anyway, bed sounds good :) |
| [23:19:14] | peper03 (peper03!~peper03@port-92-203-12-60.dynamic.qsc.de) has quit (Quit: Konversation terminated!) | |
| [23:20:48] | stuartm: | right, but none of those should be there since our coding standards expressly forbid them :) There's actually not too many, 4 in AVF, one in a recorder, 4 in CC708, 1 in mythplayer, 1 in ringbuffer and that's pretty much it for our code |
| [23:22:15] | stuartm: | the rest are libs like mythsoundtouch which is third party, minilzo.cpp which is third party, some disabled calls in the alsa stuff |
| [23:27:12] | stuartm: | we can even just disable them in external libs, that would be simpler to do if we got them all moved to external/ |
| [23:31:25] | stichnot: | A while ago I cleaned a lot of the asserts out of cc708, only leaving the ones that I didn't know how to address. |
| [23:31:45] | stichnot: | I think these asserts are all grandfathered :) |
| [23:32:22] | stichnot: | (sorry if "grandfathered" is not a common term outside the U.S.) |
| [23:32:37] | Seeker`_ (Seeker`_!~cjo20@host109-154-190-19.range109-154.btcentralplus.com) has quit (Ping timeout: 246 seconds) | |
| [23:33:45] | Seeker` (Seeker`!~cjo20@host86-145-12-185.range86-145.btcentralplus.com) has joined #mythtv | |
| [23:33:46] | Seeker` (Seeker`!~cjo20@host86-145-12-185.range86-145.btcentralplus.com) has quit (Changing host) | |
| [23:33:46] | Seeker` (Seeker`!~cjo20@unaffiliated/seeker) has joined #mythtv | |
| [23:33:59] | danielk221: | Aren't asserts already disabled in our default 'profile' builds? I know I've had to jump through hoops to enable them for debugging locally... |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.