| Friday, November 16th, 2012, 00:03 UTC | ||
| [00:03:50] | stuartm: | how many people have enough recordings to say that? Takes 4 tenths of a second here to build the list for my recordings |
| [00:04:25] | stuartm: | stichnot: I'd just increase the log interval, say 150 – 200 |
| [00:13:34] | peper03 (peper03!~peper03@port-92-203-109-130.dynamic.qsc.de) has quit (Quit: Konversation terminated!) | |
| [00:19:40] | stichnot: | stuartm: my default group has 500 recordings, the kids group 1500. :) |
| [00:20:07] | stichnot: | the main thing is to suppress the "buttonlist item 0" message which is useless |
| [00:20:53] | stichnot: | it takes several seconds to build the list in the foreground on my ION system |
| [00:36:06] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Read error: Connection reset by peer) | |
| [00:36:13] | stuartm_ (stuartm_!~stuartm@cpc1-derb9-0-0-cust441.8-3.cable.virginmedia.com) has joined #mythtv | |
| [00:36:13] | stuartm_ (stuartm_!~stuartm@cpc1-derb9-0-0-cust441.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [00:36:13] | stuartm_ (stuartm_!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [01:01:42] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [01:02:36] | sraue (sraue!~stephan@xbmc/staff/sraue) has quit (Ping timeout: 252 seconds) | |
| [01:06:28] | sraue (sraue!~stephan@xbmc/staff/sraue) has joined #mythtv | |
| [01:08:57] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 252 seconds) | |
| [01:10:47] | Mousey (Mousey!~r0dent_@ross154.net) has quit (Quit: Read Error: Connection reset by beer) | |
| [01:11:09] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [01:20:14] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Quit: Leaving) | |
| [01:31:43] | pheld (pheld!dwkhha@109-109-76-195.bb.cust.telefiber.no) has quit (Quit: Leaving.) | |
| [01:44:01] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 246 seconds) | |
| [02:41:00] | rsiebert_ (rsiebert_!~quassel@g225057100.adsl.alicedsl.de) has joined #mythtv | |
| [02:43:41] | rsiebert (rsiebert!~quassel@g225050122.adsl.alicedsl.de) has quit (Ping timeout: 255 seconds) | |
| [04:30:03] | VManiac16 (VManiac16!~Unknown@69.4.155.83) has quit (Read error: Connection reset by peer) | |
| [04:43:08] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [05:05:26] | Vernon_at_work (Vernon_at_work!~singv003@lightcloud.verns.net) has quit (Ping timeout: 255 seconds) | |
| [05:07:50] | CaCtus491 (CaCtus491!~Kent@123-243-197-152.static.tpgi.com.au) has quit (Ping timeout: 268 seconds) | |
| [05:07:58] | CaCtus491 (CaCtus491!~Kent@123-243-197-152.static.tpgi.com.au) has joined #mythtv | |
| [06:36:41] | wahrhaft (wahrhaft!~quassel@cpe-24-210-70-5.columbus.res.rr.com) has quit (Ping timeout: 256 seconds) | |
| [06:38:05] | cesman (cesman!~cesman@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [06:49:36] | cesman (cesman!~cesman@pdpc/supporter/professional/cesman) has quit (Ping timeout: 245 seconds) | |
| [07:07:00] | cesman (cesman!~cesman@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [07:07:53] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [07:08:53] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has joined #mythtv | |
| [07:52:29] | wolfgang (wolfgang!~wolfgang@178-27-151-224-dynip.superkabel.de) has quit (Ping timeout: 268 seconds) | |
| [08:35:01] | len_ (len_!~quassel@75-168-49-149.mpls.qwest.net) has quit (Remote host closed the connection) | |
| [08:50:25] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has joined #mythtv | |
| [09:02:27] | Merlin83b (Merlin83b!~Daniel@2a00:1ee0:3:1337:2417:3db1:d11a:a2f8) has joined #mythtv | |
| [09:29:49] | joki (joki!~joki@p548622DB.dip.t-dialin.net) has quit (*.net *.split) | |
| [09:29:50] | Cougar (Cougar!~cougar@kkk.version6.net) has quit (*.net *.split) | |
| [09:34:31] | FabriceMG (FabriceMG!~Thunderbi@217.112.59.207) has quit (Quit: FabriceMG) | |
| [09:40:52] | joki (joki!~joki@p548622DB.dip.t-dialin.net) has joined #mythtv | |
| [09:40:52] | Cougar (Cougar!~cougar@kkk.version6.net) has joined #mythtv | |
| [09:53:26] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
| [09:59:32] | joki (joki!~joki@p548622DB.dip.t-dialin.net) has quit (*.net *.split) | |
| [09:59:32] | Cougar (Cougar!~cougar@kkk.version6.net) has quit (*.net *.split) | |
| [10:10:03] | joki (joki!~joki@p548622DB.dip.t-dialin.net) has joined #mythtv | |
| [10:10:03] | Cougar (Cougar!~cougar@kkk.version6.net) has joined #mythtv | |
| [10:14:34] | bas-t (bas-t!~tycho@52484E89.cm-4-1b.dynamic.ziggo.nl) has quit () | |
| [10:28:26] | cougar_h (cougar_h!~cougar@kkk.version6.net) has joined #mythtv | |
| [10:33:45] | joki- (joki-!~joki@p54862AA1.dip.t-dialin.net) has joined #mythtv | |
| [10:35:27] | joki (joki!~joki@p548622DB.dip.t-dialin.net) has quit (*.net *.split) | |
| [10:35:28] | Cougar (Cougar!~cougar@kkk.version6.net) has quit (*.net *.split) | |
| [10:35:38] | cougar_h is now known as Cougar | |
| [10:35:44] | joki- is now known as joki | |
| [10:40:19] | stuartm_ is now known as stuartm | |
| [10:53:04] | Goga777 (Goga777!~Goga777@128-71-166-166.broadband.corbina.ru) has joined #mythtv | |
| [11:07:48] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has quit (Quit: FabriceMG) | |
| [11:30:34] | SmallR2002 (SmallR2002!~quassel@c-98-253-173-240.hsd1.il.comcast.net) has quit (Ping timeout: 240 seconds) | |
| [11:32:12] | SmallR2002 (SmallR2002!~quassel@c-98-253-173-240.hsd1.il.comcast.net) has joined #mythtv | |
| [11:36:48] | jab (jab!~jab@firewall.adslpipe.co.uk) has joined #mythtv | |
| [11:51:13] | jab (jab!~jab@firewall.adslpipe.co.uk) has left #mythtv () | |
| [12:36:19] | IReboot (IReboot!~doug@CPE1caff7df6774-CM00252eac6f40.cpe.net.cable.rogers.com) has quit (Remote host closed the connection) | |
| [13:18:37] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has joined #mythtv | |
| [13:30:59] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has joined #mythtv | |
| [13:36:48] | wahrhaft (wahrhaft!~quassel@cpe-24-210-70-5.columbus.res.rr.com) has joined #mythtv | |
| [13:43:10] | dblain (dblain!~dblain@mythtv/developer/dblain) has quit () | |
| [14:09:55] | zombor (zombor!~zombor__@65.29.231.135) has joined #mythtv | |
| [14:09:55] | zombor (zombor!~zombor__@65.29.231.135) has quit (Changing host) | |
| [14:09:55] | zombor (zombor!~zombor__@kohana/developer/zombor) has joined #mythtv | |
| [14:09:58] | Goga777 (Goga777!~Goga777@128-71-166-166.broadband.corbina.ru) has quit (Remote host closed the connection) | |
| [14:11:47] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [14:13:18] | FabriceMG (FabriceMG!~Thunderbi@LCaen-156-54-30-212.w80-11.abo.wanadoo.fr) has quit (Quit: FabriceMG) | |
| [14:33:42] | dblain (dblain!~dblain@mythtv/developer/dblain) has joined #mythtv | |
| [14:45:31] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [14:54:00] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [15:09:50] | stoffel (stoffel!~quassel@pD9E41F52.dip.t-dialin.net) has joined #mythtv | |
| [15:12:12] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 276 seconds) | |
| [15:17:12] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Ping timeout: 252 seconds) | |
| [15:22:20] | wolfgang1 (wolfgang1!~wolfgang@178-27-149-246-dynip.superkabel.de) has joined #mythtv | |
| [15:25:32] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [15:26:14] | stoffel (stoffel!~quassel@pD9E41F52.dip.t-dialin.net) has quit (Ping timeout: 240 seconds) | |
| [15:31:26] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [15:37:52] | stoffel (stoffel!~quassel@pD9E41F52.dip.t-dialin.net) has joined #mythtv | |
| [15:38:29] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [16:17:17] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [16:20:54] | Merlin83b (Merlin83b!~Daniel@2a00:1ee0:3:1337:2417:3db1:d11a:a2f8) has quit (Read error: Connection reset by peer) | |
| [16:28:10] | vallor (vallor!~Ponzo@pdpc/supporter/monthlygold/vallor) has left #mythtv ("http://quassel-irc.org - Chat comfortably. Anywhere.") | |
| [16:49:40] | sraue (sraue!~stephan@xbmc/staff/sraue) has quit (Ping timeout: 246 seconds) | |
| [17:14:24] | stoffel (stoffel!~quassel@pD9E41F52.dip.t-dialin.net) has quit (Ping timeout: 276 seconds) | |
| [17:32:43] | SteveGoodey (SteveGoodey!~steve@host86-148-172-139.range86-148.btcentralplus.com) has joined #mythtv | |
| [17:39:05] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [18:05:04] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 246 seconds) | |
| [18:07:45] | petefunk (petefunk!~pfunk@unaffiliated/petefunk) has joined #mythtv | |
| [18:13:11] | stuartm: | danielk22: tracked a DVD subtitle bug down to MythPlayer::toTrackType(int type) falling through to kTrackTypeAudio (0) if it doesn't understand the type value it's given, this seems all wrong and I'm thinking of having the enum instead start with a new kTrackTypeUnknown instead – does this sound reasonable? |
| [18:15:41] | peper03 (peper03!~peper03@port-92-203-80-122.dynamic.qsc.de) has joined #mythtv | |
| [18:16:11] | stuartm: | the caption display modes include kDisplayDVDButton which has no corresponding value in the track type enum, we could create one but adding special values in the base class for sub-class specific behaviour isn't really ideal |
| [18:18:09] | stuartm: | besides it's not really a track, treating it as such causes more problems than it solves |
| [18:19:34] | joki (joki!~joki@p54862AA1.dip.t-dialin.net) has quit (Ping timeout: 240 seconds) | |
| [18:21:24] | stoffel (stoffel!~quassel@pD9E425F9.dip.t-dialin.net) has joined #mythtv | |
| [18:24:32] | danielk22: | stuartm: that does seem wrong, unknown makes a lot more sense. |
| [18:25:23] | stuartm: | good |
| [18:27:17] | IReboot (IReboot!~doug@CPE1caff7df6774-CM00252eac6f40.cpe.net.cable.rogers.com) has joined #mythtv | |
| [18:29:45] | amejia (amejia!~andres@xbmc/staff/amejia) has joined #mythtv | |
| [18:38:50] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [18:39:51] | dekarl (dekarl!~dekarl@p4FCEEBF9.dip.t-dialin.net) has quit (Ping timeout: 255 seconds) | |
| [18:40:32] | joki (joki!~joki@p54861E40.dip.t-dialin.net) has joined #mythtv | |
| [18:45:24] | dekarl (dekarl!~dekarl@p4FE849AA.dip.t-dialin.net) has joined #mythtv | |
| [18:46:31] | sraue (sraue!~stephan@xbmc/staff/sraue) has joined #mythtv | |
| [18:50:54] | foobum (foobum!~foobum@46-65-7-97.zone16.bethere.co.uk) has joined #mythtv | |
| [18:52:51] | amejia (amejia!~andres@xbmc/staff/amejia) has quit (Quit: Konversation terminated!) | |
| [19:04:50] | amessina (amessina!~amessina@2001:470:c1dc:7779:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [19:17:04] | SteveGoodey (SteveGoodey!~steve@host86-148-172-139.range86-148.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [19:23:54] | amejia (amejia!~andres@xbmc/staff/amejia) has joined #mythtv | |
| [19:47:41] | peper03: | What's the process for adding new translatable strings? I would like to submit a patch to show a pop-up if the user tries to play a DVD with an empty drive. |
| [19:49:45] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [19:53:42] | stuartm: | peper03: I was thinking of hiding the 'Play DVD' option if the drive is empty instead, although that requires more work and may be some way down the road |
| [19:56:53] | peper03: | That's a possibility too. Whatever you prefer. At the moment nothing at all happens so the user isn't sure whether he/she pressed 'OK' or not. |
| [19:57:28] | peper03: | Showing a popup is a two-liner. How the i18n stuff affects that, I don't know. |
| [19:58:15] | wagnerrp: | basically, you just use "tr()" instead of "QString()" |
| [19:58:23] | wagnerrp: | and everything else gets picked up automatically |
| [19:59:14] | peper03: | Ok. The first part I'd got already. I just didn't know whether the base text needed to be added manually to one of the language files. |
| [19:59:31] | wagnerrp: | the language templates are automatically generated using a special tool |
| [20:00:26] | peper03: | Ok, that makes sense. I had a quick look in one or two and saw source file references with line numbers. Doing that by hand would be rather error-prone! |
| [20:03:43] | peper03: | stuartm: Should I create a ticket with patch or would you rather do the 'hiding the menu entry' option? The patch obviously doesn't have to be accepted but if I know that in advance I can save myself a few minutes of time now :) |
| [20:13:04] | stuartm: | create the ticket/patch, it may be a while before I get around to implementing my idea and it would be better to have some solution in the interim |
| [20:13:22] | stuartm: | plus we might be able to backport your approach easily |
| [20:16:35] | peper03: | Ok. I would think a backport would be completely painless. |
| [20:17:20] | peper03: | I would show "Unable to play DVD". Any objections? There doesn't seem to be any code that handles Blu-Ray explicitly. Just DVDs. |
| [20:26:28] | stuartm: | we do handle blu-ray too, so something more generic and maybe which is clearer about the problem e.g. "No disc found in drive" or "Please insert a disc into the drive" |
| [20:36:57] | Guest93476 (Guest93476!~quassel@75-168-49-149.mpls.qwest.net) has joined #mythtv | |
| [20:37:25] | peper03: | I'm in 'internal_play_media' in main.cpp of MythFrontend. There's a call to pginfo->IsVideoDVD() else pginfo->IsVideo(). I assume Blu-Ray falls under 'IsVideo'. |
| [20:42:25] | stichnot: | peper03: you may want to add a pginfo->IsVideoBD() test |
| [20:44:54] | peper03: | stichnot: I wouldn't have a problem with that but those calls (IsVideoDVD/IsVideo) are already there. If I added IsVideoBD, I'd be altering the current logic and I've no idea how that works. |
| [20:45:25] | peper03: | I'd try it with a Blu-Ray but Amazon sent me a hair-dryer today instead of the Blu-Ray drive I ordered :-o |
| [20:46:41] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Quit: ChatZilla 0.9.89 [Firefox 16.0.2/20121025210744]) | |
| [20:49:33] | shadowone (shadowone!~shadowone@ppp59-167-189-79.static.internode.on.net) has quit (Ping timeout: 276 seconds) | |
| [20:50:07] | stuartm: | Blu-Ray is tricky, although it's possible to play back direct from disc it cheats a little by requiring the disc to be mounted, it also requires you to use a leaked host key unless your drive is hackable (most new ones aren't) |
| [20:50:22] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [20:50:48] | stuartm: | the host keys keep being revoked and currently my drive won't play anything with any leaked host keys that I've been able to find |
| [20:51:12] | stuartm: | which is why it's just easier to use MakeMKV and rip the discs instead |
| [20:56:03] | peper03: | So the Blu-Ray player feature does drop into the 'IsVideo' bit. It's just playing a file and trying to interpret any VM code or other such structure? |
| [21:02:01] | stuartm: | it's doing more than just playing a file, there is full decryption and navigation support, it's not really much different to the DVD stuff, only as it currently stands it's like reading a DVD which has been copied to disc (maintaining the structure), I'm not exactly sure why but there were problems at the time it was implemented with reading without mounting |
| [21:02:49] | stuartm: | that probably wouldn't be the case anymore, but no-one has gone back to look at it |
| [21:05:31] | stuartm: | peper03: if you look at playDisc() of main.cpp you'll see BD related stuff |
| [21:08:09] | peper03: | Ah, ok. That's what I was just looking for. |
| [21:09:45] | peper03: | Hmm. That actually makes things trickier. I could check the return value of the calls to HandleMedia but there's no guarantee if an error code is returned, that a pop-up hasn't already been shown. |
| [21:12:55] | peper03: | Seems I fell into the trap of thinking this would be an easy fix :) |
| [21:13:06] | stuartm: | yeah, that whole thing is tricky and it's not even clear to me why we're using the media handler callbacks for internal stuff anyway, those were created for plugins |
| [21:14:27] | stuartm: | looking at the most recent version of libbluray the documentation still indicates that it requires a mount point, not a device node, we might be able to achieve something through libudf though which means we don't need to mount |
| [21:15:00] | stuartm: | mplayer apparently doesn't have this problem, might be worth a look at their code for ideas |
| [21:15:38] | peper03: | Does it matter *how* we access the data if there's no disc to access? |
| [21:16:21] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit (Quit: Peace! Got A Week Off!) | |
| [21:16:29] | stuartm: | peper03: no, sorry my mind was wandering :) |
| [21:21:05] | peper03: | Also, checking the return value won't work. If the bookmark popup is shown, you'll always get -1. |
| [21:23:26] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [21:23:52] | peper03: | Actually, maybe my original idea would work. playDisc looks for a Blu-Ray mountpoint. If it doesn't find one (e.g. there's no disc), it assumes you want to play a DVD. If there's no DVD either, you'll hit the 'else' condition I was using. |
| [21:25:06] | peper03: | It's not perfect as the error condition is not in playDisc but it's not too horrible, in my opinion. |
| [21:26:07] | peper03: | If Blu-Ray playback were changed to not use a mountpoint, I guess it would need special handling in internal_play_media anyway (which is where my patch is). |
| [21:40:43] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has quit (Quit: Ex-Chat) | |
| [21:41:04] | stuartm: | the alternative is just to ask the MediaMonitor if there is a disc present, and what type of media it is, but I'd accept a patch however it was done since the mediamonitor can be hard work |
| [21:43:22] | peper03: | Does the MediaMonitor always work? I've never had the 'On DVD insertion' feature work. Is that handled by MediaMonitor? It's presumably some system config (udev?) that needs tweaking but I've never got around to looking at it. |
| [21:43:57] | peper03: | If it doesn't always work, the pop-up won't be shown for some users. |
| [21:45:20] | stuartm: | peper03: it works reliably here and shouldn't depend on external configuration, but I wouldn't say it's bug free either, that shouldn't be a reason to just ignore it though, just a good reason to get the bugs fixed :) |
| [21:45:59] | stuartm: | as I say, do it however you want to, I don't have a strong preference |
| [21:47:44] | peper03: | Ok. I'll submit the quick two-liner patch and see if why the media detection doesn't work. I have a feeling I've seen something about it not always working somewhere. |
| [21:48:18] | peper03: | The patch, if accepted, can easily be changed to something else anyway. Thanks for the help! |
| [22:24:09] | stoffel (stoffel!~quassel@pD9E425F9.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [22:31:33] | zombor (zombor!~zombor__@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [22:46:21] | rsiebert_ (rsiebert_!~quassel@g225057100.adsl.alicedsl.de) has quit (Remote host closed the connection) | |
| [22:51:56] | MaverickTech (MaverickTech!~MaverickT@111.86.233.220.static.exetel.com.au) has quit (Ping timeout: 246 seconds) | |
| [22:54:46] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 256 seconds) | |
| [22:57:44] | sl1ce (sl1ce!~johnathan@c-66-31-34-71.hsd1.ma.comcast.net) has quit (Quit: Konversation terminated!) | |
| [22:58:09] | rsiebert (rsiebert!~quassel@g225057100.adsl.alicedsl.de) has joined #mythtv | |
| [23:06:44] | sl1ce (sl1ce!~johnathan@c-66-31-34-71.hsd1.ma.comcast.net) has joined #mythtv | |
| [23:06:50] | amejia (amejia!~andres@xbmc/staff/amejia) has quit (Quit: Konversation terminated!) | |
| [23:26:23] | zombor (zombor!~zombor__@65.29.231.135) has joined #mythtv | |
| [23:26:23] | zombor (zombor!~zombor__@65.29.231.135) has quit (Changing host) | |
| [23:26:24] | zombor (zombor!~zombor__@kohana/developer/zombor) has joined #mythtv | |
| [23:42:53] | peper03 (peper03!~peper03@port-92-203-80-122.dynamic.qsc.de) has quit (Quit: Konversation terminated!) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.