| Tuesday, June 26th, 2012, 00:11 UTC | ||
| [00:11:57] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [00:16:27] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (Quit: kormoc) | |
| [00:17:03] | Mousey (Mousey!~r0dent_@ross154.net) has quit (Remote host closed the connection) | |
| [00:24:51] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [00:26:24] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [00:49:32] | aloril (aloril!~aloril@dsl-tkubrasgw3-fe7ef900-153.dhcp.inet.fi) has quit (Ping timeout: 250 seconds) | |
| [01:05:13] | dekarl1 (dekarl1!~dekarl@p4FCEE2B9.dip.t-dialin.net) has joined #mythtv | |
| [01:06:07] | dekarl (dekarl!~dekarl@p4FCEE085.dip.t-dialin.net) has quit (Ping timeout: 265 seconds) | |
| [01:06:33] | aloril (aloril!~aloril@dsl-tkubrasgw3-fe7ef900-153.dhcp.inet.fi) has joined #mythtv | |
| [01:07:34] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
| [01:24:09] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Remote host closed the connection) | |
| [01:32:08] | mrand (mrand!~mrand@ubuntu/member/mrand) has quit (Ping timeout: 240 seconds) | |
| [01:47:03] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [01:51:11] | wahrhaft (wahrhaft!~quassel@cpe-24-210-71-26.columbus.res.rr.com) has joined #mythtv | |
| [01:57:27] | amejia (amejia!~andres@xbmc/staff/amejia) has quit (Quit: Konversation terminated!) | |
| [02:50:13] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [03:04:15] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [03:08:50] | cocoa117 (cocoa117!~cocoa117@188-222-31-239.zone13.bethere.co.uk) has quit (Ping timeout: 260 seconds) | |
| [03:11:54] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [03:12:00] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [03:15:45] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [03:15:50] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [03:16:40] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
| [03:18:08] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [03:18:12] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
| [04:14:49] | foxbuntu (foxbuntu!~foxbuntu@174-30-96-44.desm.qwest.net) has joined #mythtv | |
| [04:14:55] | foxbuntu (foxbuntu!~foxbuntu@174-30-96-44.desm.qwest.net) has quit (Changing host) | |
| [04:14:55] | foxbuntu (foxbuntu!~foxbuntu@ubuntu/member/foxbuntu) has joined #mythtv | |
| [04:29:01] | Czar_Away (Czar_Away!~Unknown@69.4.155.83) has quit (Read error: Connection reset by peer) | |
| [04:29:42] | Czar_Away (Czar_Away!~Unknown@69.4.155.83) has joined #mythtv | |
| [04:48:35] | stichnot (stichnot!~chatzilla@192.55.55.41) has joined #mythtv | |
| [04:48:35] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [04:48:35] | stichnot (stichnot!~chatzilla@192.55.55.41) has quit (Changing host) | |
| [04:50:44] | cattelan is now known as cattelan_away | |
| [04:52:10] | wahrhaft (wahrhaft!~quassel@cpe-24-210-71-26.columbus.res.rr.com) has quit (Remote host closed the connection) | |
| [06:10:32] | xris (xris!~xris@mythtv/developer/xris) has quit (Quit: Terminated with extreme prejudice - dircproxy 1.2.0) | |
| [06:13:11] | xris (xris!~xris@mythtv/developer/xris) has joined #mythtv | |
| [06:17:45] | jya (jya!~jyavenard@120.148.99.165) has joined #mythtv | |
| [06:17:45] | jya (jya!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [06:17:45] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [06:41:21] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [06:44:19] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (Quit: kormoc) | |
| [07:17:58] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [07:17:59] | jya_ (jya_!~jyavenard@120.148.99.165) has joined #mythtv | |
| [07:17:59] | jya_ (jya_!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [07:17:59] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [07:31:51] | petefunk_ (petefunk_!~pfunk@pud5.7ac0.org) has joined #mythtv | |
| [07:32:00] | Beirdo_ (Beirdo_!~gjhurlbu@mythtv/developer/beirdo) has joined #mythtv | |
| [07:32:06] | Anssi_ (Anssi_!hannulaa@mandriva/developer/anssi) has joined #mythtv | |
| [07:36:41] | peitolm (peitolm!~moreyc@mandlebrot.random-chaos.org.uk) has quit (*.net *.split) | |
| [07:36:42] | Anssi (Anssi!hannulaa@mandriva/developer/anssi) has quit (*.net *.split) | |
| [07:36:42] | Beirdo (Beirdo!~gjhurlbu@mythtv/developer/beirdo) has quit (*.net *.split) | |
| [07:36:42] | petefunk (petefunk!~pfunk@pud5.7ac0.org) has quit (*.net *.split) | |
| [07:36:42] | Anssi_ is now known as Anssi | |
| [07:37:26] | peitolm (peitolm!~moreyc@mandlebrot.random-chaos.org.uk) has joined #mythtv | |
| [07:49:55] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [07:51:57] | jya (jya!~jyavenard@120.148.99.165) has joined #mythtv | |
| [07:51:57] | jya (jya!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [07:51:57] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [07:52:18] | Goga777 (Goga777!~Goga777@95-30-19-184.broadband.corbina.ru) has joined #mythtv | |
| [08:02:54] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
| [08:05:03] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [08:14:58] | Goga777 (Goga777!~Goga777@95-30-19-184.broadband.corbina.ru) has quit (Read error: Connection reset by peer) | |
| [08:23:48] | knightr_ (knightr_!~knightr@69-165-170-178.dsl.teksavvy.com) has joined #mythtv | |
| [08:27:20] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 260 seconds) | |
| [08:31:51] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has quit (Quit: “The only way to have a friend is to be one.” ― Ralph Waldo Emerson) | |
| [08:44:31] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has joined #mythtv | |
| [08:50:21] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [08:59:31] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [09:02:43] | jya (jya!~jyavenard@120.148.99.165) has joined #mythtv | |
| [09:02:43] | jya (jya!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [09:02:43] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [09:06:48] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has quit (Quit: “The only way to have a friend is to be one.” ― Ralph Waldo Emerson) | |
| [09:10:07] | Sharky112065 (Sharky112065!~Sharky112@c-24-19-57-28.hsd1.wa.comcast.net) has joined #mythtv | |
| [09:20:36] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [09:37:05] | XDS2010 (XDS2010!users.1218@gateway/web/irccloud.com/x-wajqddyruhhldtdm) has quit (Remote host closed the connection) | |
| [09:40:11] | XDS2010 (XDS2010!~users.121@gateway/web/irccloud.com/x-pemjozmzoaerohye) has joined #mythtv | |
| [09:47:04] | jya (jya!~jyavenard@120.148.99.165) has joined #mythtv | |
| [09:47:05] | jya (jya!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [09:47:05] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [09:52:25] | XDS2010 (XDS2010!~users.121@gateway/web/irccloud.com/x-pemjozmzoaerohye) has quit (Remote host closed the connection) | |
| [09:55:36] | XDS2010 (XDS2010!~users.121@gateway/web/irccloud.com/x-ytkgvyguhjoyfjhw) has joined #mythtv | |
| [10:28:40] | Goga777 (Goga777!~Goga777@128-71-230-12.broadband.corbina.ru) has joined #mythtv | |
| [10:57:11] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [10:57:43] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [11:09:33] | jya_ (jya_!~jyavenard@120.148.99.165) has joined #mythtv | |
| [11:09:34] | jya_ (jya_!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [11:09:34] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [11:09:34] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [11:09:35] | jya_ is now known as jya | |
| [11:43:31] | knightr_ (knightr_!~knightr@69-165-170-178.dsl.teksavvy.com) has quit (Read error: Connection reset by peer) | |
| [11:43:35] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [12:04:56] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Quit: Leaving) | |
| [12:35:53] | Goga777 (Goga777!~Goga777@128-71-230-12.broadband.corbina.ru) has quit (Read error: Connection reset by peer) | |
| [13:02:54] | cocoa117 (cocoa117!~cocoa117@188-222-31-239.zone13.bethere.co.uk) has joined #mythtv | |
| [13:22:07] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has joined #mythtv | |
| [13:22:07] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has quit (Changing host) | |
| [13:22:07] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [13:30:22] | cattelan_away is now known as cattelan | |
| [13:30:50] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Operation timed out) | |
| [13:35:38] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [13:36:08] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [13:38:30] | n1md4 (n1md4!~nimda@anion.cinosure.com) has joined #mythtv | |
| [13:38:46] | rsiebert (rsiebert!~quassel@g229055221.adsl.alicedsl.de) has joined #mythtv | |
| [13:39:20] | n1md4: | Hello. A question heard all too much I'm sure, but can anyone recommend a well supported budget dvb-s pci card please? |
| [13:39:52] | n1md4: | I'm looking around the wiki, here www.linuxtv.org/wiki/index.php/DVB-S_PCI_Cards but I'm flooded ... |
| [13:41:03] | n1md4: | In fact, I may need a DVB-S2 card, assuming they're also backward compatible. |
| [13:41:45] | rsiebert_ (rsiebert_!~quassel@e179130056.adsl.alicedsl.de) has quit (Ping timeout: 260 seconds) | |
| [13:53:34] | n1md4: | I'm looking toward a Hauppauge WinTV NOVA HD S2 ... |
| [13:55:36] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Ping timeout: 256 seconds) | |
| [13:58:35] | toeb: | n1md4: i think you are looking for #mythtv-users , this channel is for development... |
| [14:09:47] | stuarta (stuarta!~stuarta@callisto.ppp0.squashedfrog.net) has joined #mythtv | |
| [14:10:46] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has joined #mythtv | |
| [14:10:46] | stuarta (stuarta!~stuarta@callisto.ppp0.squashedfrog.net) has quit (Changing host) | |
| [14:26:15] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Quit: Leaving) | |
| [14:32:08] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [14:45:49] | stichnot: | danielk22: it's hard to get a reasonable stack trace with the nvidia-tls stuff in the way, but I attached gdb to mythbackend, set a breakpoint in sbrk, and observed the thread ID of the caller. Most of the time it's the thread running MainServer::HandleFileTransferQuery() > FileTransfer::RequestBlock() > MythSocket::writeData(). That's not necessarily the exact trace at the time of the... |
| [14:45:51] | stichnot: | ...sbrk() call. It's also not clear whether that thread is leaking, or having to call sbrk because another thread is leaking. |
| [14:47:59] | n1md4: | toeb: Ah! You're right :) |
| [14:48:25] | stuarta: | you tried valgrind on it? |
| [14:48:40] | n1md4 (n1md4!~nimda@anion.cinosure.com) has left #mythtv () | |
| [14:50:15] | stichnot: | no valgrind yet, but someone else did in a recent ticket and found nothing |
| [14:50:38] | stichnot: | suspicion is not a true leak, but uncontrolled Qt growth that is cleaned up on exit |
| [14:53:43] | stuartm: | stuarta: valgrind shows nothing at all |
| [14:54:25] | stuartm: | the memory is being reclaimed on exit, so far gdb/oprofile/valgrind haven't shed much light |
| [14:55:18] | stuarta: | so then it's not a leak, but something not free'd but still referenced |
| [14:55:47] | stuartm: | it does seem to be related to file transfers (streaming) in some way though, but there have been no changes to that code in a long time |
| [14:56:11] | stuarta: | that doesn't mean it had no error before |
| [14:56:21] | stuartm: | except for reference counting and reverting those individually hasn't fixed it |
| [14:56:44] | stuartm: | stuarta: right, but unless we can identify why it's now causing problems ... |
| [14:57:35] | stuartm: | what I've not tried is reverting all those connected reference counting commits together, can't immediately see why that would make a difference though |
| [14:57:56] | stuartm: | ... unless one of the sockets was being shared between classes and gets up-ref'd twice ... |
| [14:58:37] | stuartm: | that's as good a theory as I've had all day, worth checking it out |
| [15:06:04] | stuartm: | no, actually that's just dumb, if it was the interaction of two separate commits reverting one would still fix it ... |
| [15:06:10] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 250 seconds) | |
| [15:15:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
| [15:15:10] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [15:15:31] | stuartm: | radical thought, you don't suppose that gcc is compiling the socket code any differently since we enabled the hidden virtual warnings? i.e. without the warning gcc just does what it thinks best to solve the problem but with the warning enabled it's leaving them in a broken state? |
| [15:19:52] | stuarta: | stranger things have happened |
| [15:49:39] | stuartm: | not this time though :) Guess I'm back to trawling through the code :( |
| [15:52:44] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [15:54:42] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [15:59:17] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [16:04:12] | Defense|Twin (Defense|Twin!~jepz@e177236104.adsl.alicedsl.de) has joined #mythtv | |
| [16:31:36] | SteveGoodey (SteveGoodey!~steve@host86-160-43-123.range86-160.btcentralplus.com) has joined #mythtv | |
| [16:32:40] | joki (joki!~joki@p5486599C.dip.t-dialin.net) has quit (Ping timeout: 260 seconds) | |
| [16:33:05] | joki (joki!~joki@p548642AA.dip.t-dialin.net) has joined #mythtv | |
| [16:33:22] | Mousey (Mousey!~r0dent_@ross154.net) has joined #mythtv | |
| [16:35:41] | Lomion0815 (Lomion0815!~markus@178-191-190-148.adsl.highway.telekom.at) has joined #mythtv | |
| [16:37:21] | Lomion0815: | I just recognized that SET_BOOKMARK in 0.25 is requesting 2 int32 values for location ... is there any protocol version which requires a single 64-bit integer? |
| [16:45:15] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has quit (Quit: Coyote finally caught me) | |
| [16:48:36] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
| [16:52:31] | Beirdo_: | superm1: you might want to check out the zeromq install change I made last night, it's very similar to your patch |
| [16:52:38] | Beirdo_ is now known as Beirdo | |
| [16:52:41] | Beirdo: | stupid _ |
| [16:54:13] | Beirdo: | if it doesn't quite work, please let me know. I may still need to pass in the INSTALL_ROOT from the main makefile like you did, but I thought that that was in config.mak |
| [16:54:25] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [16:54:38] | Beirdo: | morning, Mr. Kormoc |
| [16:55:15] | Beirdo: | Pioneer Square is a nice area to be in, I can see why you like it :) |
| [16:56:11] | sunkan (sunkan!~sunkan@alva.zappa.cx) has joined #mythtv | |
| [17:04:36] | Lomion0815 (Lomion0815!~markus@178-191-190-148.adsl.highway.telekom.at) has quit (Remote host closed the connection) | |
| [17:08:55] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Remote host closed the connection) | |
| [17:20:11] | stichnot (stichnot!~chatzilla@192.55.55.41) has joined #mythtv | |
| [17:20:11] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [17:20:11] | stichnot (stichnot!~chatzilla@192.55.55.41) has quit (Changing host) | |
| [17:20:59] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [17:22:07] | Lomion0815 (Lomion0815!~markus@178-191-190-148.adsl.highway.telekom.at) has joined #mythtv | |
| [17:32:09] | stichnot: | ok... someone just solved the backend memory leak. Who's going to take the credit? |
| [17:34:04] | danielk22: | Heh, you just did a git update ? |
| [17:34:39] | stichnot: | yep |
| [17:34:46] | danielk22: | I added some code to the threadpool to clean up deferred deletes, I was just going to ask you to test :) |
| [17:34:48] | stichnot: | and I doubt it was Beirdo's change... |
| [17:37:17] | stichnot: | VIRT/RES quickly rises from 479/57 to 484/63 during the mythcommflag test then drops back to 479/58 when mythcommflag ends |
| [17:39:46] | stichnot: | Any idea why the code didn't "leak" before? |
| [17:39:53] | danielk22: | If this is really working then my guess is Qt is allocating some kind of temporary cache in the RequestBlock() code and freeing it via deleteLater(). We're not using any deferred deletes in the code. |
| [17:41:10] | Beirdo: | I've put in the sendPostedEvents into logging.cpp |
| [17:41:18] | Beirdo: | not sure if I committed that or not |
| [17:41:39] | Beirdo: | it did seem to slow the memory growth a touch |
| [17:41:48] | danielk22: | stichnot: 2 possibilities. 1/ Our thread-pool threads are never going away because they are kept busy in some way they weren't before. 2/ This behavior is specific to certain versions of Qt. |
| [17:42:01] | Beirdo: | but yeah, if it's internally using deleteLater() and not telling us... grrrr. |
| [17:42:57] | stichnot: | danielk22: I never changed my version of Qt, and I could definitely see the growth or non-growth during my git bisect testing |
| [17:42:58] | danielk22: | Cleaning up in the thread pool class is the right thing to do anyway. |
| [17:43:17] | Beirdo: | yeah, this is forcing us to do code review and cleanup :0 |
| [17:43:18] | stichnot: | Beirdo: I don't think you pushed anything like that lately |
| [17:43:38] | Beirdo: | stichnot: OK, I know I was messing with it last night, but wasn't sure if I pushed it |
| [17:43:39] | danielk22: | stichnot: Then #1 seems the most likely scenario. |
| [17:43:39] | ** MythLogBot http://code.mythtv.org/trac/ticket/1 ** | |
| [17:43:41] | Beirdo: | likely not |
| [17:44:16] | stichnot: | I assume the new logging related threads are drawing from the thread pool? |
| [17:44:29] | Beirdo: | no |
| [17:44:38] | stichnot: | hmm |
| [17:44:57] | Beirdo: | they have static threads, and zeromq creates its own outside of Qt (pthreads, basically) |
| [17:50:07] | stichnot: | I undid danielk22's one-liner and the leak came back so that's definitely it |
| [17:50:29] | Beirdo: | WOOHOO! |
| [17:50:38] | ** Beirdo gives danielk22 a high-five ** | |
| [17:50:59] | Beirdo: | good work. We probably have a couple other places to look at doing similar things |
| [17:51:49] | Defense|Twin (Defense|Twin!~jepz@e177236104.adsl.alicedsl.de) has quit (Remote host closed the connection) | |
| [17:52:13] | Beirdo: | any reason to use QCoreApplication:: rather than qApp-> ? |
| [17:52:43] | Beirdo: | just curious, as if there's a good reason, I'd like to keep my code consistent with the rest, etc |
| [17:52:46] | stichnot: | but... until we have a very plausible explanation of why the zeromq merge triggered the problem, I'm going to assume it will come back in the future... |
| [17:53:04] | Beirdo: | well, we did change a lot of crap at once |
| [17:53:08] | Beirdo: | and... |
| [17:53:15] | Beirdo: | logging uses deleteLater |
| [17:53:39] | Beirdo: | and the sendPostedEvents seems to only affect objects in the current thread |
| [17:54:24] | stichnot: | Logging adds a new Qt event loop, right? |
| [17:54:27] | Beirdo: | so this would be the correct way to clean up after those threads (or putting the same into the Epilog() |
| [17:54:57] | Beirdo: | I think the internal threads for zeromq do, yes |
| [17:55:12] | Beirdo: | oh wait, they aren't in zeromq, they are in nzmqt |
| [17:55:21] | Beirdo: | same difference |
| [17:55:56] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [17:56:34] | Beirdo: | the way the loggingitems are used has changed quite a bit though |
| [17:56:46] | Beirdo: | so it's possible that it was somehow related |
| [17:56:52] | stichnot: | I was looking at a gdb backtrace and saw two threads with event loops. One of them was hard to identify but I assumed it was logging related. I wonder if moving from 1 event loop to 2 made a difference |
| [17:57:02] | Beirdo: | that is possible |
| [17:57:11] | Beirdo: | one of those should be thread 1 |
| [17:57:22] | Beirdo: | the other, I was wondering exactly what it was too |
| [17:57:39] | stichnot: | I doubt it had to do with loggingitems because I more or less disabled all that code and the growth was still there |
| [17:58:07] | Beirdo: | well, there's likely something else using deleteLater that hits as well, and even bigger |
| [17:58:28] | Beirdo: | but the LoggingItems were definitely causing some growth |
| [17:58:38] | Beirdo: | maybe only 1% of the total or something :) |
| [17:58:42] | stichnot: | not with "-v none" :) |
| [17:58:52] | Beirdo: | heh, true |
| [17:59:15] | Beirdo: | hmm |
| [17:59:27] | stichnot: | danielk22: do we have the same thread pool stuff in the frontend? there were also reports of frontend growth |
| [17:59:35] | Beirdo: | I could move the logging items to the loggerthread... |
| [17:59:41] | Beirdo: | yes, it's in the common lib |
| [17:59:44] | danielk22: | stichnot: Yep, used in the frontend and backend. |
| [18:00:01] | stichnot: | btw, I love how these things always turn out to be one-liners |
| [18:00:21] | Beirdo: | they are the "search for years, and type in one line to fix" bugs |
| [18:00:32] | Beirdo: | or sometimes, one character :) |
| [18:01:24] | stichnot: | danielk22, Beirdo, stuartm: have you all verified the fix? |
| [18:01:38] | Beirdo: | no, I can't verify it until I'm home |
| [18:02:00] | Beirdo: | as to really stress it (in my case anyways), I need to be watching something |
| [18:02:16] | Beirdo: | but I think we can tentatively call it fixed :) |
| [18:02:24] | Beirdo: | or partly |
| [18:04:48] | stichnot: | Manually running mythcommflag on a remote machine is the way I quickly stress-test it. |
| [18:04:51] | Beirdo: | I'll be looking carefully tonight for other uses of processEvents to make sure that those threads all do sendPostedEvents as well periodically |
| [18:05:16] | stuartm: | hmm, I didn't get commit emails for those |
| [18:05:29] | stuartm: | stichnot: I'll test momentarily |
| [18:05:41] | Beirdo: | there was one sent about half an hour ago |
| [18:05:51] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Remote host closed the connection) | |
| [18:05:56] | Beirdo: | it's in my email anyways |
| [18:06:17] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [18:06:29] | Beirdo: | fall down, go boom? |
| [18:06:56] | stuartm: | Beirdo: yeah I didn't get it, just checked and the cert on my server has changed, looks like they did the migration ahead of schedule ... oops |
| [18:07:06] | Beirdo: | ahhh |
| [18:07:21] | Beirdo: | it might still be queued then |
| [18:08:41] | Beirdo: | oh, please remind me if I forget... the git email hook needs to set the reply-to |
| [18:08:56] | Beirdo: | it doesn't stock, and we need that fixed, and I keep forgetting |
| [18:13:04] | stichnot: | I just noticed that on the backend status page, the "next 10 recordings" section uses the "Today"/"Tomorrow" date formatting (which is new), whereas the Job Queue section uses raw dates. Wondering if this was deliberate. (Personally, I prefer only raw dates on that page.) |
| [18:14:34] | Beirdo: | the CPU usage may be from the event loop iterating the event list and skipping the deferred deletions |
| [18:14:52] | Beirdo: | so that may just solve both issues simultaneously |
| [18:21:48] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has joined #mythtv | |
| [18:21:48] | zombor (zombor!~zombor_@50-73-122-41-ip-static.hfc.comcastbusiness.net) has quit (Changing host) | |
| [18:21:49] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:22:21] | stichnot: | Pretty sure the excess CPU use came from malloc/free looking harder and harder for free space. Also, once the file transfer stops, CPU use goes down to practically zero, so there would be plenty of opportunity to clean up then, yet Qt wouldn't. |
| [18:24:59] | kormoc: | Beirdo, is PiSq where RIM is? |
| [18:27:19] | Beirdo: | this office, yes (Gist) |
| [18:27:36] | Beirdo: | Occidental & King |
| [18:28:25] | Beirdo: | stichnot: yeah, that could be too, although I did see excessive CPU with plenty of memory around |
| [18:28:58] | Beirdo: | yeah, it had opportunity to cleanup, but danielk's fix makes it actually clean up now :) |
| [18:29:30] | Beirdo: | especially for things like the seektable updating, etc. |
| [18:29:44] | Beirdo: | could have been part of the issue anyways |
| [18:29:53] | stuartm: | danielk22: without even testing streaming, things are obviously improved, the backend is no longer using any noticable cpu (0%) at all immediately after startup |
| [18:29:59] | Beirdo: | doubt the bug hunt is over, but at least we seemed to bag a big one |
| [18:30:16] | Beirdo: | s/we/danielk/ :) |
| [18:31:56] | stichnot: | stuartm: that sounds like Beirdo's suggestion – the event loop no longer continually passing over deferred deletes |
| [18:32:44] | Beirdo: | yay |
| [18:34:38] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [18:34:55] | Beirdo: | the more I think about it, the more I think that call should be in the Epilog() for all threads |
| [18:35:08] | Beirdo: | save us looking for the ones we missed |
| [18:35:29] | Beirdo: | when the thread's going to exit, flush all the deletions |
| [18:35:52] | Beirdo: | well "exit" |
| [18:36:01] | Beirdo: | if it actually exits, I think Qt does it for us |
| [18:36:09] | danielk22: | Beirdo: That won't do anything. The objects are deleted when the parent object gets deleted. In this case the QThread the objects are created in. |
| [18:36:15] | Beirdo: | yeah |
| [18:36:36] | stuartm: | so far so good |
| [18:36:43] | Beirdo: | it will help for any thread pool ones though, but I guess you already covered that. Never mind. |
| [18:37:19] | Beirdo: | as long as we all behave and use the threadpool code and not reinvent the wheel |
| [18:39:19] | stuartm: | yeah, I was thinking about that and other 're-use' issues, we need some specific instructions (wiki page?) detailing the key stuff like the threadpool, date functions and the like which everyone should be using in new code |
| [18:39:48] | Beirdo: | yeah. Shudder... we should document a bit :) |
| [18:40:02] | Beirdo: | oh the horror |
| [18:42:52] | stuartm: | yeah, not just documentation of classes but summary documentation that draws attention to which classes should or must be used given different tasks/goals, what code/classes should be avoided too |
| [18:44:24] | Beirdo: | for sure |
| [18:45:04] | Beirdo: | a lot of that we have in bits and pieces, and deep in danielk's brain, but he's not always around to smack us into line :) |
| [18:45:07] | stuartm: | of course it only helps if people read the documentation beforehand and if they don't ignore the guidance because think they know better, but let's worry about that if/when it happens :) |
| [18:45:17] | Beirdo: | so true |
| [18:47:31] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [18:49:08] | clever_ (clever_!~clever@142.167.139.147) has joined #mythtv | |
| [18:49:30] | clever (clever!~clever@142.167.199.79) has quit (Ping timeout: 246 seconds) | |
| [18:52:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
| [18:56:55] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:59:37] | stoffel (stoffel!~quassel@pD9E41595.dip.t-dialin.net) has joined #mythtv | |
| [19:03:19] | kormoc: | Beirdo, once you try Tat's, you'll be hooked :) |
| [19:04:15] | Beirdo: | heh, so I've been told |
| [19:04:24] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has quit (Quit: leaving) | |
| [19:04:27] | Beirdo: | there are just too many good places to eat around here |
| [19:06:26] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
| [19:10:32] | stichnot: | Beirdo: do you want to do the honors and close #10846? |
| [19:13:29] | Beirdo: | #10846 |
| [19:13:29] | ** MythLogBot http://code.mythtv.org/trac/ticket/10846 ** | |
| [19:13:38] | Beirdo: | let me take a look |
| [19:14:34] | Beirdo: | you can go for it :) I still plan on rerunning valgrind if I can get it to behave for me, and kill off more memory leaks (and potential ones) |
| [19:15:02] | Beirdo: | pretty sure the problem he reported is the same we've been pounding on. |
| [19:15:38] | Beirdo: | lunch... be back later |
| [19:17:16] | stichnot: | OK, I'll close it thanks to danielk22's commit. |
| [19:20:47] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has quit (Quit: leaving) | |
| [19:21:32] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
| [19:23:24] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has quit (Client Quit) | |
| [19:23:38] | anykey_ (anykey_!~anykey@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
| [19:39:33] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 248 seconds) | |
| [19:39:57] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [19:55:21] | stoffel (stoffel!~quassel@pD9E41595.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [20:39:19] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Operation timed out) | |
| [21:02:18] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [21:02:59] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [21:39:30] | SteveGoodey (SteveGoodey!~steve@host86-160-43-123.range86-160.btcentralplus.com) has quit (Remote host closed the connection) | |
| [21:44:03] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [21:53:08] | amejia (amejia!~andres@129.174.97.130) has joined #mythtv | |
| [21:53:08] | amejia (amejia!~andres@xbmc/staff/amejia) has joined #mythtv | |
| [21:53:08] | amejia (amejia!~andres@129.174.97.130) has quit (Changing host) | |
| [22:07:11] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 255 seconds) | |
| [22:07:13] | Lomion0815 (Lomion0815!~markus@178-191-190-148.adsl.highway.telekom.at) has quit (Quit: leaving) | |
| [22:11:12] | Slasher` (Slasher`!~Slasher@188.165.164.15) has quit (Quit: ZNC - http://znc.sourceforge.net) | |
| [22:11:37] | Slasher` (Slasher`!~Slasher@188.165.164.15) has joined #mythtv | |
| [22:13:19] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Ping timeout: 244 seconds) | |
| [22:28:34] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [22:41:23] | knightr_ (knightr_!~knightr@69-165-170-178.dsl.teksavvy.com) has joined #mythtv | |
| [22:41:35] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
| [22:42:41] | mrand (mrand!~mrand@ubuntu/member/mrand) has quit (Ping timeout: 252 seconds) | |
| [22:44:31] | f33dMB (f33dMB!~f33dMB@li100-62.members.linode.com) has joined #mythtv | |
| [23:00:12] | Toast (Toast!~quassel@87.127.37.199) has joined #mythtv | |
| [23:10:25] | cocoa117 (cocoa117!~cocoa117@188-222-31-239.zone13.bethere.co.uk) has quit (Quit: Leaving) | |
| [23:17:24] | Toast (Toast!~quassel@87.127.37.199) has quit (Remote host closed the connection) | |
| [23:22:50] | Toast (Toast!~quassel@87.127.37.199) has joined #mythtv | |
| [23:24:27] | Toast (Toast!~quassel@87.127.37.199) has quit (Remote host closed the connection) | |
| [23:27:36] | Toast (Toast!~quassel@87.127.37.199) has joined #mythtv | |
| [23:29:44] | Toast (Toast!~quassel@87.127.37.199) has quit (Remote host closed the connection) | |
| [23:42:23] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
| [23:48:32] | amejia (amejia!~andres@xbmc/staff/amejia) has joined #mythtv | |
| [23:51:29] | knightr_ (knightr_!~knightr@69-165-170-178.dsl.teksavvy.com) has quit (Quit: Leaving) | |
| [23:52:08] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [23:53:58] | knightr: | I'm curently trying to setup a test environement and something is keeping my backend from starting. If I try to start it manually after it has failed I get " Error: Not all threads were shut down properly: |
| [23:53:58] | knightr: | Thread SignalingTimer is still running". The only Myth process I saw running was the log server but killing it makes no difference... |
| [23:57:12] | stichnot: | knightr: that sounds like a problem from several days ago. Is this the latest Master? |
| [23:58:42] | knightr: | stichnot, yep, fetch a few hours ago... |
| [23:58:50] | knightr: | s/fetch/fetched |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.