| Thursday, May 10th, 2012, 00:03 UTC | ||
| [00:03:56] | stuartm: | disturbing number of leaks in the new services stuff, lots of stuff created on the heap and never deleted as though whoever wrote all this didn't know that it wouldn't be deleted when it went out of scope |
| [00:05:11] | andreax (andreax!~andreaz@p5089F59C.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [00:05:29] | Beirdo: | sad. |
| [00:06:09] | Beirdo: | I asked Eric to send me login info as well so I can peruse the fun |
| [00:07:52] | Beirdo: | man, it would make our lives that much simpler if we could dump Windows once and for all :) |
| [00:08:13] | stuartm: | hmm, might have overstated it, five leaks just felt like more as I was triaging them |
| [00:08:16] | Beirdo: | but, not likely to happen, so we will continue playing whack-a-mole |
| [00:08:47] | Beirdo: | Udo would be so happy that leaks are being plugged. |
| [00:09:03] | dmfrey (dmfrey!~dmfrey@64-121-93-243.c3-0.smt-ubr1.atw-smt.pa.cable.rcn.com) has joined #mythtv | |
| [00:10:21] | stuartm: | I'm wary about letting non-devs have access btw, it's not a read-only thing but a tracker/triage interface that allows severity/resolution to be set for each warning, not something we want just anyone messing with |
| [00:11:08] | Beirdo: | agreed |
| [00:15:12] | jya: | stuartm: do we have scripting support in the theme? |
| [00:15:28] | jya: | like what kind of programming can the theme do ? |
| [00:16:50] | jya: | fwiw, I have recently worked on a javascript interpreter that adds native access to most apple's cocoa UI framework… Adapting it so it works for the myth/qt one wouldn't be a big stretch |
| [00:19:11] | stuartm: | jya: no scripting |
| [00:19:12] | no1home (no1home!~no1home@pool-72-64-181-247.tampfl.fios.verizon.net) has joined #mythtv | |
| [00:22:36] | stuartm: | so far the number of real warnings seems pretty small, numbers are boosted by stuff like "No check of the return value of "query.exec()"." |
| [00:23:02] | Beirdo: | hehe |
| [00:23:04] | danielk22: | stuartm: Are you sure the services things are real leaks? I believe Qt manages that memory. |
| [00:23:06] | stuartm: | which is intentional, the code in question doesn't care whether it succeeds or fails |
| [00:25:52] | stuartm: | danielk22: aye they are, PI and RecordingRule objects created and either copied or access for metadata but not deleted |
| [00:26:18] | danielk22: | :| |
| [00:26:26] | stuartm: | mostly in dvr.cpp |
| [00:26:34] | danielk22: | Wonder why they aren't just created on the stack if they are copied. |
| [00:26:42] | stuartm: | I'm not sure they even need to be on the heap ... exactly |
| [00:27:25] | stuartm: | the storagegroup leak I've already fixed was similar, created on the heap when it could/should have been on the stack |
| [00:30:38] | stuartm: | danielk22: Dvr::GetRecordSchedule() is one example – I'll fix these tomorrow |
| [00:31:55] | stuartm: | Dvr::EnableRecordSchedule() is even better, no possible reason for creating it on the heap there |
| [00:32:07] | danielk22: | heh, httpconfig.cpp:74.. there is a comment "// FIXME, this is always&A circ; false, what's it for" just below the "// DISABLE HTML SETUP SAVI NG" comment that explains why it's always false. |
| [00:36:15] | stuartm: | I'm glad we've finally got the coverity report, but so far it's fairly dull, I was expecting more from it – a lot of this is the sort of thing cppcheck (free & open source) is already telling us |
| [00:36:49] | danielk22: | stuartm: I looked at the memory corruption section and saw some stuff... |
| [00:38:08] | stuartm: | hmm, all in the audio code |
| [00:39:03] | stuartm: | well one video filter and freemheg too but I don't tend to count those |
| [00:41:24] | danielk22: | Heh, the real limitation of the tool is in the security section. Only one thing in that list. But the protocol as designed allows anyone to run arbitrary commands with the permissions of the user running mythbackend without any authentication. |
| [00:44:41] | stuartm: | heh yeah, as I've made a point of saying on multiple occasions, there countless ways I can cause serious damage on a remote backend if it's accessible |
| [00:46:56] | stuartm: | a tissue paper bag is more secure than MythTV, I've often reasoned that we never receive reports from security researchers because they take one look at our project and drop dead of a heart attack |
| [00:47:15] | jya: | Beirdo: I'm not sure how avformat_open_input could be integrated in a ringbuffer class… avformat_open_input is called in avformatdecoder.cpp already… |
| [00:48:27] | danielk22: | stuartm: The web UI looks pretty slick. |
| [00:48:38] | stuartm: | danielk22, Beirdo, jya: in case you haven't already figured it out, if you filter out the 'ignored' warnings then you'll get just the stuff affecting our code and no ffmpeg etc |
| [00:49:22] | stuartm: | danielk22: the coverity ui? |
| [00:49:49] | danielk22: | Yeah, lets you filter things out (which presumably stay filtered out on the next run). |
| [00:49:58] | Beirdo: | nice |
| [00:50:44] | Beirdo: | jya: it's not integrated in the ringbuffer class, it's used in avfd, and links TO the ringbuffer |
| [00:51:31] | jya: | Beirdo: sure, but I wonder what kind of data the ringbuffer is supposed to return to let it all happen via avfd |
| [00:51:55] | Beirdo: | huh? |
| [00:52:09] | Beirdo: | I don't see any problem with how it's setup now |
| [00:52:40] | Beirdo: | we have a custom protocol handler that is used for reading buffers, seeking, etc from avfd using the ringbuffer |
| [00:52:54] | stuartm: | danielk22: some powerful filters definitely, overall though I still find the UI to be cluttered, the important information is lost off-screen and I keep having to switch back and forth between tabs |
| [00:52:55] | Beirdo: | not sure what you're getting at |
| [00:53:36] | stuartm: | I think it could be boiled down to something much simpler |
| [00:54:06] | jya: | Beirdo: right now, a URL is opened using ffurl_open ; which doesn't work for HLS |
| [00:54:29] | Beirdo: | from where? |
| [00:54:37] | jya: | the streamingringbuffer class |
| [00:54:42] | Beirdo: | ahhh |
| [00:55:07] | jya: | so what that class feed to avfd is the 136 bytes of the file contained at that URL |
| [00:55:25] | jya: | and after that it fails, cause it never gets more data |
| [00:55:34] | Beirdo: | when it should be feeding the URL, I think |
| [00:55:41] | Beirdo: | I dunno |
| [00:56:02] | jya: | yes… but then I don't know how the Seek, GetRealFileSize would handle it |
| [00:56:20] | jya: | those are methods that should be handled by the streamingringbuffer |
| [00:56:21] | Beirdo: | only one way to find out :) |
| [00:56:39] | jya: | but if the data is owned by avfd as it would be it that opened the file |
| [00:57:14] | jya: | it just seems to me that what we are doing is very convoluted… we open the file ourselves, to calculate its length, perform the seeking etc.. |
| [00:57:36] | jya: | yet, we still use ffmpeg to open the file directly, and it can do all the seeking etc itself |
| [00:57:45] | Beirdo: | and it does |
| [00:57:53] | Beirdo: | via the callbacks we give it |
| [00:58:55] | jya: | but what if you have no callback useful as such ? |
| [00:59:03] | jya: | like for hls, i want ffmpeg to do it all |
| [00:59:19] | jya: | right now we use ffurl_blah |
| [00:59:24] | Beirdo: | then you don't use an AVIOContext |
| [00:59:30] | Beirdo: | or whatever it's called |
| [00:59:39] | jya: | which reads the content directly and pass on the data |
| [01:00:54] | jya: | well, hopefully this will all make sense to me once I dig into it |
| [01:01:05] | Beirdo: | heeh, it's a mess, I grant you that |
| [01:01:15] | Beirdo: | and we probably could even make it less so |
| [01:07:27] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [01:08:47] | jya: | the ringbuffer class (those inheriting from RingBuffer) are only use by the frontend for playback right? |
| [01:08:59] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [01:09:13] | Beirdo: | they are used in the backend for recording too, I think |
| [01:09:31] | Beirdo: | and for sending to the frontend |
| [01:09:58] | jya: | ok.. so if I change the streamingringbuffer class to let ffmpeg do the whole lot, then we wouldn't be able to record those streams anymore |
| [01:10:31] | Beirdo: | wouldn't surprise me |
| [01:10:38] | jya: | hum.... |
| [01:10:43] | jya: | catch 22 |
| [01:11:14] | jya: | so really, my HLS ringbuffer class may have some use after all if we ever intend to record those |
| [01:11:50] | jya: | as this output a .ts directly |
| [01:16:30] | Beirdo: | hehe. coverity caught a nasty bug in ffmpeg |
| [01:16:40] | Beirdo: | thankfully, I don't think we use alsdec.c |
| [01:17:00] | Beirdo: | they have an infinite loop in zero_remaining (603176) |
| [01:23:32] | Beirdo: | which is still not fixed upstream for that matter |
| [01:32:02] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [01:39:26] | Captain_Murdoch: | danielk22, the 'always false' comment is because it's matching "right(7) == "config" which is only 6 characters long. I put that comment in well before we commented out the disabling setup saving section. |
| [01:51:35] | jya_ (jya_!~jyavenard@120.148.99.165) has joined #mythtv | |
| [01:51:35] | jya_ (jya_!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [01:51:36] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [01:57:30] | stichnot: | Is it safe to create a QImage in one thread and then use it in another thread? |
| [02:02:52] | Beirdo: | doubtful. they probably say in the docs |
| [02:03:35] | Beirdo: | hmm, looks like they do the usual shallow copy |
| [02:04:30] | Beirdo: | you might be ok. It doesn't specifically say on that page |
| [02:05:52] | Beirdo: | treat it like it's a QString, and you won't be far off :) |
| [02:06:42] | Beirdo: | OK, and time to go home. |
| [02:14:23] | cattelan_away is now known as cattelan | |
| [02:16:45] | Captain_Murdoch: | stichnot, yes, we do that in the background image loading in mythui. we load in background threads and send an event when loaded so they can be displayed. |
| [02:19:04] | dmfrey (dmfrey!~dmfrey@64-121-93-243.c3-0.smt-ubr1.atw-smt.pa.cable.rcn.com) has quit (Quit: Ex-Chat) | |
| [02:34:35] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has quit (Remote host closed the connection) | |
| [02:40:23] | Yancho (Yancho!~mpulis@unaffiliated/yancho) has quit (Read error: Operation timed out) | |
| [02:42:03] | ** wagnerrp checks to see what Beirdo wants ** | |
| [03:00:54] | Beirdo: | heh |
| [03:01:09] | Beirdo: | for the freebsd stuff, I was struggling to get bswap working |
| [03:01:17] | Beirdo: | but I think I found a solution that works |
| [03:05:55] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [03:10:16] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [03:21:57] | danielk22: | Captain_Murdoch: ah, I'm sure that's just a typo. |
| [03:26:49] | Captain_Murdoch: | figured it might be. the comment was a note for myself to look at or ask about it sometime. wasn't being used at the time so I left it |
| [03:30:14] | danielk22: | I'm not sure that code will survive when we get back to the web config of the backend, but I should fix it now just so that bug doesn't have to be found again if we do use it... Thanks for the heads up. |
| [03:30:19] | superm1: | Beirdo: looks like GCC 4.7 is indeed fixed in the ffmpeg sync |
| [03:30:24] | superm1: | quantal master build passed today |
| [03:32:19] | Beirdo: | yay :) |
| [03:32:37] | Beirdo: | if not, we would be fixing it in short order :) |
| [03:33:06] | Beirdo: | jeez. I can't restart the backend until midnight? |
| [03:33:37] | Beirdo: | 9 recordings between then and now |
| [03:34:19] | superm1: | still need that backported commit though on 0.25-fixes though for 4.7 |
| [03:34:40] | Beirdo: | k |
| [03:35:04] | Beirdo: | yeah, I'll do that in a moment. The ticket's still open, right? |
| [03:35:07] | superm1: | yup |
| [03:38:26] | Beirdo: | test compiling |
| [03:38:34] | Yancho (Yancho!~mpulis@unaffiliated/yancho) has joined #mythtv | |
| [03:38:51] | jya: | Beirdo: I'm tracing what avformat_open_input does, and it calls ffurl_open just like I was doing by hand, so if http, it sticks to http, doesn't use hls at all :( |
| [03:39:26] | Beirdo: | if it does a probe it should work fine |
| [03:44:20] | jya: | I wonder if I could probe myself from after calling ffurl_open manually.. and then do what avformat_open_input except that I get the raw data and not fully demux |
| [03:44:34] | Beirdo: | dunno |
| [03:47:04] | Beirdo: | I think you can do the open and then probe |
| [03:47:25] | Beirdo: | av_probe_input_format |
| [03:47:28] | jya: | i see plenty of "Using network protocols without global network initialization. Please use avformat_network_init(), this will become mandatory later." in the log |
| [03:47:51] | Beirdo: | well, you might wanna use that too then :) |
| [03:48:01] | Beirdo: | new API FTW |
| [03:48:55] | Beirdo: | ahhh |
| [03:49:18] | Beirdo: | you do the av_probe_input_format, and then the open, passing IN the format |
| [03:51:26] | jya: | I don't really want to call av_read_frame to get to the raw data, otherwise how will avfd knows what format it is |
| [03:52:41] | Beirdo: | av_read_frame returns encoded data |
| [03:53:16] | Beirdo: | and that's how ffmpeg works |
| [03:53:31] | Beirdo: | I'm confused :) |
| [03:54:35] | jya: | i see… I was off to begin with... |
| [03:54:52] | jya: | now.. how do I do a seek :) |
| [03:56:42] | Beirdo: | av_seek_frame |
| [03:57:09] | Beirdo: | http://www.ffmpeg.org/doxygen/trunk/group__lavf__decoding.html |
| [03:57:14] | Beirdo: | in case you were wondering :) |
| [04:01:14] | jya: | yes… but it works in timestamp, and I don't believe that's the info I'm receiving for the seek value |
| [04:02:19] | Beirdo: | superm1: done |
| [04:02:44] | Beirdo: | I think they left that as an exercise for the student. |
| [04:06:22] | Beirdo: | weeelll, damn good thing I tried this before merging |
| [04:07:35] | Beirdo: | signal handler needs a bit more work |
| [04:08:53] | sraue (sraue!~stephan@xbmc/staff/sraue) has quit (Ping timeout: 248 seconds) | |
| [04:16:40] | sraue (sraue!~stephan@xbmc/staff/sraue) has joined #mythtv | |
| [04:19:27] | tgm4883: | just an FYI, since I know sometimes some people in here wait on Mythbuntu daily builds for a certain patch. I have disabled the daily builds for a few days and will reenable them once our build servers are no longer being overrun |
| [04:27:25] | jya: | that sucks.. |
| [04:27:37] | jya: | time to refire my repo I guess.. |
| [04:28:28] | tgm4883 (tgm4883!~tgm4883@ubuntu/member/tgm4883) has quit (Excess Flood) | |
| [04:29:36] | jya: | oohhhh . I get my video playing with av_read_frame |
| [04:29:40] | jya: | all screwed up though |
| [04:30:14] | Beirdo: | hehe |
| [04:30:29] | Beirdo: | ooooh, must initialize the app first. |
| [04:30:31] | Beirdo: | duh |
| [04:30:55] | jya: | video is stuttering like crazy, it's like it's replaying a bit from the beginning each time |
| [04:31:23] | jya: | what I do is call av_read_frame until I've fetched more data than requested from safe_read. |
| [04:31:30] | jya: | I store the excess in a QByteArray |
| [04:32:11] | jya: | next time, I get the data from the QByteArray first, empty what's used an continue |
| [04:32:36] | jya: | not efficient the emptying of the QByteArray, should use a circular buffer instead |
| [04:32:46] | jya: | that;s for later |
| [04:34:30] | jya: | anything that strikes you as wrong ? http://pastebin.com/bvju2wyN |
| [04:38:05] | Beirdo: | not off-hand |
| [04:39:15] | jya: | the video looks like it plays 1s, then play 1s again, but from .2s earlier |
| [04:41:16] | Beirdo: | I'm sure it's something simple in the end |
| [04:41:34] | Beirdo: | it usually is |
| [04:45:41] | jya: | ah… I had the VDA decoder in use… using ffmpeg decode, it plays okay… no audio though and there are glitches |
| [04:46:08] | jya: | when using the VDA decoder, I see plenty of dropped frame |
| [04:47:06] | jya: | 22.79fps average… something is not right |
| [04:49:02] | Beirdo: | WTF |
| [04:49:32] | Beirdo: | sooo, I wonder if this will break crap |
| [04:51:28] | jya: | Beirdo: you're sure av_read_frame returns the raw data, i mean audio + video ? looking at the log, I have no audio coming through |
| [04:51:57] | Beirdo: | it will return the next received frame |
| [04:52:32] | Beirdo: | you may want to read the ffmpeg example code |
| [04:54:28] | Beirdo: | or even avfd :) |
| [04:55:12] | J-e-f-f-A_ (J-e-f-f-A_!~J-e-f-f-A@unaffiliated/j-e-f-f-a) has joined #mythtv | |
| [04:55:30] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@unaffiliated/j-e-f-f-a) has quit (Ping timeout: 260 seconds) | |
| [04:55:30] | J-e-f-f-A_ is now known as J-e-f-f-A | |
| [04:57:16] | jya: | i wonder if that approach will work… call av_read_frame in a loop, copy that into a buffer and do it again … maybe I'm not copying from the right data :( |
| [04:57:24] | jya: | where's my audio ! |
| [05:03:29] | Beirdo: | have you tried an av_dump_format? |
| [05:07:00] | jya: | i would if I knew about it :) |
| [05:07:22] | Beirdo: | hehehe |
| [05:07:52] | Beirdo: | methinks you aren't using ffmpeg's doxygen docs |
| [05:12:10] | tgm4883 (tgm4883!~tgm4883@2001:4968:202:3:20f:eaff:fefc:ba0e) has joined #mythtv | |
| [05:12:10] | tgm4883 (tgm4883!~tgm4883@2001:4968:202:3:20f:eaff:fefc:ba0e) has quit (Changing host) | |
| [05:12:10] | tgm4883 (tgm4883!~tgm4883@ubuntu/member/tgm4883) has joined #mythtv | |
| [05:12:34] | jya: | i am… but they don't allow search, not always easy to navigate |
| [05:12:52] | Beirdo: | the easiest way is to hit avformat.h |
| [05:13:06] | Beirdo: | as that's where the majority of it will be |
| [05:13:14] | jya: | I wonder if the data I'm getting from av_read_format is actual ts packet |
| [05:13:26] | Beirdo: | probably |
| [05:13:42] | jya: | if it's been split between audio/video |
| [05:14:06] | Beirdo: | you need to check each packet to see what stream it's in, I think |
| [05:15:17] | Beirdo: | or at least type... I don't recall |
| [05:15:26] | Beirdo: | look for the ProcessPacket stuff in avfd |
| [05:18:02] | kc (kc!~Casper@unaffiliated/kc) has quit (Remote host closed the connection) | |
| [05:18:49] | kc (kc!~Casper@unaffiliated/kc) has joined #mythtv | |
| [05:20:00] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@unaffiliated/j-e-f-f-a) has quit (Ping timeout: 260 seconds) | |
| [05:20:45] | jya: | how do you get to print all the ffmpeg verbose stuff? |
| [05:21:04] | Beirdo: | -v libav should get you a lot of it |
| [05:21:42] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@unaffiliated/j-e-f-f-a) has joined #mythtv | |
| [05:21:55] | Beirdo: | oh, I hate being on-call |
| [05:22:02] | jya: | ok… if I understand what the demuxer is supposed to do, is get you the frame from within the container |
| [05:22:07] | kc (kc!~Casper@unaffiliated/kc) has quit (Remote host closed the connection) | |
| [05:22:15] | jya: | but here, I do want the container |
| [05:22:30] | Beirdo: | why? |
| [05:22:45] | jya: | because it's to work via the ringbuffer |
| [05:23:04] | jya: | in avfd, it expects to get raw bytes, as if you were reading the file |
| [05:23:10] | jya: | from disk |
| [05:23:41] | kc (kc!~Casper@unaffiliated/kc) has joined #mythtv | |
| [05:24:25] | jya: | looking at fileringbuffer, it reads the file from disk, and feed that to avfd |
| [05:24:40] | jya: | ore more exactly, avfd is fetching via the ringbuffer, that read from the disk |
| [05:27:00] | jya: | FileRingBuffer::safe_read, doesn't attempt to demux anything, it just call read(file_descriptor, buffer, size) |
| [05:27:45] | jya: | by calling av_read_frame, I've already demuxed the data, I would need to remux it as it was originally |
| [05:28:02] | jya: | so it can then be played by avfd |
| [05:28:09] | Beirdo: | gimme a minute |
| [05:28:13] | Beirdo: | work emergency |
| [05:36:16] | Beirdo: | there |
| [05:36:22] | Beirdo: | machine is rebooting |
| [05:36:29] | Beirdo: | now, let's go see... |
| [05:37:42] | Beirdo: | well, if you are trying to use the HLS demuxer, you want it to demux |
| [05:38:00] | jya: | yes.. that demux into ts |
| [05:38:19] | Beirdo: | as in, you likely need a subclass of avfd |
| [05:38:33] | Beirdo: | no, I don't think that's how it works |
| [05:38:43] | Beirdo: | I could be wrong though |
| [05:39:12] | jya: | the data retrieved by hls, are segment of a ts stream |
| [05:39:20] | jya: | that, I'm sure about |
| [05:39:50] | jya: | I just tried to play a http://blah.mp4 file |
| [05:40:05] | jya: | and sure enough, it can't detect the format and won't play with that method |
| [05:41:53] | jya: | when avfd tries to play the data I'm passing back, it sees only one stream of h264 content, with a bitrate of 0 |
| [05:42:28] | Beirdo: | hls_read_packet returns one AVPacket at a time. |
| [05:43:22] | Beirdo: | when it hands it off, it looks to be the same as avformat_read_frame (and is likely called by it) |
| [05:43:48] | jya: | so you're saying that's not ts packet ? |
| [05:44:00] | Beirdo: | it might be, incoming. |
| [05:44:12] | Beirdo: | when you read, you get demuxed data by the looks of it |
| [05:44:18] | Beirdo: | it IS a demuxer after all |
| [05:44:31] | jya: | sure but I don't want it to remux too much :) |
| [05:44:35] | jya: | demux |
| [05:44:40] | Beirdo: | it doesn't |
| [05:44:50] | Beirdo: | it demuxes the same as every other demuxer |
| [05:45:05] | jya: | ok… so I need to remux that into say ts |
| [05:45:09] | Beirdo: | you're just trying to feed the output back into a demuxer, and that's not gonna work |
| [05:45:12] | jya: | so I can pass it on to avfd |
| [05:45:56] | Beirdo: | as I said, you probably will need to subclass avfd and reimplement the ProcessPacket, etc. |
| [05:46:03] | jya: | no way... |
| [05:46:26] | jya: | if I was to simply remux into a ts frame, pass that raw data to avfd, then it can read it just fine |
| [05:46:44] | jya: | can ts contains any data of any kind ? |
| [05:46:45] | Beirdo: | there's no point to doing that |
| [05:47:19] | jya: | if I don't want to change the whole architecture , I do |
| [05:47:20] | Beirdo: | video, audio, closed captioning, some other stuff |
| [05:47:42] | Beirdo: | huh? |
| [05:47:47] | jya: | currently we have tv_play , create a ringbuffer and pass it on to avfd |
| [05:47:54] | Beirdo: | no |
| [05:48:03] | Beirdo: | we have create a ringbuffer and hand it to a decoder |
| [05:48:19] | Beirdo: | I'm saying replace avfd with one that works with hls |
| [05:48:34] | Beirdo: | same architecture |
| [05:48:50] | jya: | that would mean changing the way avfd is called, as we detect the format content |
| [05:49:18] | jya: | so instead of creating AvFormatDecoder instance, we create the derivated one |
| [05:49:31] | Beirdo: | when we detect, if it's HLS, use a different decoder |
| [05:49:37] | Beirdo: | correct |
| [05:50:02] | jya: | sure, but for the time being, the avfd instance is created before we detect what the data type is |
| [05:50:53] | jya: | at least with remuxing, while dirty, it means I have zero to change.. the changes are self-contained in streamingbuffer.cpp |
| [05:51:59] | Beirdo: | it means you are making what I'd consider a rather disgusting hack to avoid changing a bit of other code :) |
| [05:52:03] | Beirdo: | but go nuts ;) |
| [05:52:12] | Beirdo: | get it working, we can redo it later |
| [05:52:26] | jya: | it's either that, or I use my own code, which output ts packets |
| [05:52:42] | Beirdo: | aw come on, I just rebooted this server, and now my connection to it died |
| [05:54:14] | Beirdo: | there, done with it |
| [05:54:24] | jya: | can mpeg-ts contain any stream type ? |
| [05:55:10] | jya: | the other advantage of demux / remuxing… it that it would allow to use the streamingbuffer for recording easily |
| [05:55:37] | jya: | if i was to amend avfd to simply know how to read the frame provided, then it would be playback only |
| [05:56:02] | Beirdo: | you'd have to read the MPEG-TS docs |
| [05:59:13] | no1home (no1home!~no1home@pool-72-64-181-247.tampfl.fios.verizon.net) has quit (Remote host closed the connection) | |
| [06:01:03] | dekarl (dekarl!~dekarl@p4FE847FA.dip.t-dialin.net) has joined #mythtv | |
| [06:03:25] | Beirdo: | ummm |
| [06:03:32] | Beirdo: | avfd IS playback only |
| [06:03:58] | Beirdo: | IIRC, the ringbuffers are the shared part, not the *decoder* :) |
| [06:04:35] | Beirdo: | we so need an architecture diagram, don't we? ;) |
| [06:06:58] | solars (solars!~solars@194.208.132.118) has joined #mythtv | |
| [06:07:49] | Steve-Goodey (Steve-Goodey!~steve@host86-182-4-91.range86-182.btcentralplus.com) has joined #mythtv | |
| [06:09:10] | superm1: | tgm4883: maybe we should only disable 0.25, but leave 0.26 running? |
| [06:09:16] | superm1: | for the few days |
| [06:09:38] | superm1: | until the PPA system catches up |
| [06:13:13] | jya: | Beirdo: exactly, AVFD is playback only… if I want to keep streamingbuffer.cpp to work for both encoder and decoder, it needs to output a raw container.. |
| [06:14:18] | Beirdo: | sounds like you want to make a AVIOContext type of thing |
| [06:14:36] | Beirdo: | similar to what the other ring bugger provides |
| [06:14:40] | Beirdo: | errrr. buffer |
| [06:15:02] | Beirdo: | that's what I get for typing while watching Grey's Anatomy |
| [06:15:22] | jya: | do you know of an example of code remuxing demuxed data? |
| [06:15:39] | Beirdo: | nope |
| [06:15:39] | jya: | i only wrote one muxer once , for the spdif code, was a while ago.. |
| [06:16:00] | Beirdo: | maybe the HLS code in mythtranscode |
| [06:16:05] | Beirdo: | but that's encoding too |
| [06:16:38] | jya: | yeah, it generates the segment |
| [06:16:46] | Beirdo: | so... how to fix crystalhd code with no crystalhd and no idea where to get the lib? |
| [06:17:39] | jya: | right, going to work on something less frustrating |
| [06:17:49] | jya: | fix the AC3 encoder |
| [06:18:00] | Beirdo: | http://www.ffmpeg.org/doxygen/trunk/structAVIOContext.html |
| [06:18:14] | Beirdo: | it looks like that's the level you should be looking at working with |
| [06:18:54] | Beirdo: | see AvFormatDecoder::InitByteContext |
| [06:19:32] | Beirdo: | or maybe just extending AVF_RingBufferProtocol to handle HLS? |
| [06:19:56] | jya: | AVIOContext is handled by avbuffer |
| [06:20:15] | jya: | it calls the respective function (read_Safe, open, seek etc) |
| [06:20:32] | Beirdo: | yes |
| [06:20:36] | jya: | right, let see what you have modified to my nice ac3encoder during this merge |
| [06:20:42] | ben1066_ (ben1066_!~quassel@host109-152-58-115.range109-152.btcentralplus.com) has joined #mythtv | |
| [06:20:47] | Beirdo: | as implemented in avfringbuffer |
| [06:21:10] | Beirdo: | I dunno :) |
| [06:21:15] | Beirdo: | yeah anyways... |
| [06:22:06] | Steve-Goodey (Steve-Goodey!~steve@host86-182-4-91.range86-182.btcentralplus.com) has quit (Remote host closed the connection) | |
| [06:22:08] | jya: | the AC3 encoder hasn't changed during the merge |
| [06:22:25] | ben1066 (ben1066!~quassel@86.160.30.34) has quit (Ping timeout: 260 seconds) | |
| [06:23:06] | Beirdo: | 40 more minutes and I can try my logging branch on the backend too |
| [06:23:36] | jya: | ah yes ! it has been modified |
| [06:27:41] | Beirdo: | well, for straight decoding, it's workin great :) |
| [06:28:46] | jya: | I think in the end, you've screwed up every part of the code doing audio :) |
| [06:30:04] | Beirdo: | every part of it had to change to the new API |
| [06:30:59] | jya: | well, if could have worked just well, exception being of deprecated warning when compiling |
| [06:31:30] | jya: | maybe that would have been an easier approach, leave the deprecated for the time being… rather than break all -> fix one by one |
| [06:32:07] | Beirdo: | no, as then they'd never get changed |
| [06:32:29] | Beirdo: | and then when they rip OUT the deprecated stuff (at any time) for the next sync, it's totally borked |
| [06:32:36] | Beirdo: | and we had enough of THAT too |
| [06:32:53] | jya: | i wouldn't have left any deprecated stuff in code I maintain |
| [06:35:03] | jya: | I'm doing the easy way, I just copy the code in ffmpeg that convert for the new API… then simplify |
| [06:35:09] | jya: | so I don't have to think too much |
| [06:46:29] | jya: | the public API in ffmpeg, is only stuff in libavcodec.h , libavformat.h etc? |
| [06:47:48] | Beirdo: | yes |
| [06:47:52] | wagnerrp: | Beirdo: is the fancy "fast decode" for mythcommflag gone after this sync? |
| [06:48:06] | Beirdo: | it was already gone because someone disabled it |
| [06:48:19] | wagnerrp: | ah |
| [06:48:59] | Beirdo: | someone thought it was a good idea to prematurely remove the setting... and default it to off |
| [06:50:10] | Beirdo: | but I haven't heard complaints :) |
| [06:59:18] | MavT (MavT!~MaverickT@111.86.233.220.static.exetel.com.au) has joined #mythtv | |
| [06:59:38] | hashbang (hashbang!~alex@213-152-35-50.dsl.eclipse.net.uk) has joined #mythtv | |
| [07:03:05] | MaverickTech (MaverickTech!~MaverickT@111.86.233.220.static.exetel.com.au) has quit (Ping timeout: 265 seconds) | |
| [07:13:58] | jya: | hum… that code looks buggy to me :( |
| [07:15:46] | hashbang (hashbang!~alex@213-152-35-50.dsl.eclipse.net.uk) has quit (Quit: Leaving.) | |
| [07:20:33] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [07:24:53] | Chutt (Chutt!~ijr@cpe-24-29-225-175.neo.res.rr.com) has quit (Read error: Connection reset by peer) | |
| [07:25:22] | jya_: | ok.. it's not just the AC3 encoder that's broken by the look of things, but the SPDIF muxer too :( |
| [07:35:15] | Beirdo: | well, yeah. |
| [07:35:31] | Beirdo: | IIRC, stream_copy went poof |
| [07:38:40] | jya_: | i get a segfault about 25% of the time on my linux box when starting mythfrontend |
| [07:38:47] | jya_: | haven't looked at it why yet |
| [07:39:11] | Beirdo: | well, can't help ya there :) |
| [07:39:25] | Beirdo: | not until you've looked into it, of course |
| [07:39:34] | jya_: | not yet… but don't worry, I blame you anyway :) |
| [07:39:44] | Beirdo: | of course you do :) |
| [07:39:59] | jya_: | right… dinner time.. will get back to it after |
| [07:40:09] | Beirdo: | bedtime for me |
| [07:40:21] | jya_: | looks like for audio encoder, it's going to be much easier to use the deprecated API |
| [07:40:31] | jya_: | i can't figure it out what's wrong |
| [07:40:53] | Beirdo: | the new api works fine in mythtranscode for HLS encoding |
| [07:41:03] | Beirdo: | check, maybe I missed a spot or something |
| [07:42:09] | Beirdo: | after dinner, of course :) |
| [07:42:37] | Beirdo: | I really don't think using the deprecated API is a wise plan as it will be disappearing anytime now |
| [07:43:13] | Beirdo: | it's just delaying the inevitable |
| [07:50:06] | rsiebert_ (rsiebert_!~quassel@g225057213.adsl.alicedsl.de) has joined #mythtv | |
| [07:50:06] | rsiebert (rsiebert!~quassel@g224248185.adsl.alicedsl.de) has quit (Read error: Connection reset by peer) | |
| [07:51:11] | Beirdo: | one thing you might wanna try in the AC3 encode part: |
| [07:51:23] | Beirdo: | move the AVFrame allocation into the loop |
| [07:51:34] | Beirdo: | (and deallocation of course) |
| [07:52:08] | Beirdo: | it could be some fields need to be reset back to defaults, and reusing the same frame otherwise is problematic |
| [07:52:39] | Beirdo: | but definitely referring to the HLS encoding may well help. There's probably something simple missing |
| [07:53:14] | mrand (mrand!~mrand@ubuntu/member/mrand) has quit (Ping timeout: 256 seconds) | |
| [07:56:16] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [07:57:35] | Beirdo: | anyways, sleep time |
| [08:00:40] | solars (solars!~solars@194.208.132.118) has quit (Ping timeout: 252 seconds) | |
| [08:06:40] | solars (solars!~solars@194.208.132.118) has joined #mythtv | |
| [08:11:46] | jya_: | Beirdo: I'm pretty sure I got the AC3 encoder right... |
| [08:11:53] | jya_: | something else is going on in the spdif encoder |
| [08:12:04] | jya_: | i mean muxer |
| [08:14:25] | ** stuarta yawns ** | |
| [08:37:52] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Ping timeout: 272 seconds) | |
| [08:40:56] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [08:46:02] | obo (obo!~obo@rockbox/developer/obo) has quit (Ping timeout: 265 seconds) | |
| [08:48:51] | obo (obo!~obo@70-140-190-120.lightspeed.hstntx.sbcglobal.net) has joined #mythtv | |
| [08:48:51] | obo (obo!~obo@70-140-190-120.lightspeed.hstntx.sbcglobal.net) has quit (Changing host) | |
| [08:48:51] | obo (obo!~obo@rockbox/developer/obo) has joined #mythtv | |
| [09:10:41] | Goga777 (Goga777!~Goga777@2.95.137.147) has joined #mythtv | |
| [10:05:02] | Guest67565 (Guest67565!~mike@c-98-232-220-158.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:05:50] | 16WAAJXO3 (16WAAJXO3!~mike@c-98-232-220-158.hsd1.or.comcast.net) has joined #mythtv | |
| [10:23:11] | Goga777 (Goga777!~Goga777@2.95.137.147) has quit (Remote host closed the connection) | |
| [10:38:42] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [11:23:59] | _charly_ (_charly_!kroseneg@sunrise.schmidham.net) has joined #mythtv | |
| [11:28:17] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [11:48:46] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Read error: Connection reset by peer) | |
| [11:52:44] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [11:54:47] | dblain (dblain!~dblain@mythtv/developer/dblain) has quit (Ping timeout: 250 seconds) | |
| [11:56:17] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [12:05:45] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [12:13:36] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [12:17:54] | dblain (dblain!~dblain@c-76-127-227-175.hsd1.ma.comcast.net) has joined #mythtv | |
| [12:17:54] | dblain (dblain!~dblain@c-76-127-227-175.hsd1.ma.comcast.net) has quit (Changing host) | |
| [12:17:55] | dblain (dblain!~dblain@mythtv/developer/dblain) has joined #mythtv | |
| [12:20:03] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Ping timeout: 245 seconds) | |
| [12:35:00] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has joined #mythtv | |
| [12:43:35] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [13:20:07] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [13:46:13] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [13:52:49] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has joined #mythtv | |
| [13:56:54] | cattelan is now known as cattelan_away | |
| [14:02:37] | Anssi (Anssi!hannulaa@mandriva/developer/anssi) has quit (Remote host closed the connection) | |
| [14:09:46] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [14:25:33] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [14:28:10] | Anssi (Anssi!hannulaa@mandriva/developer/anssi) has joined #mythtv | |
| [14:33:21] | amejia__ is now known as amejia | |
| [14:58:06] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Remote host closed the connection) | |
| [14:59:09] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Quit: Body blow! Body blow!) | |
| [15:13:36] | 77CAAXOLZ (77CAAXOLZ!~Goga777@2.95.137.147) has joined #mythtv | |
| [15:13:36] | Goga777 (Goga777!~Goga777@2.95.137.147) has joined #mythtv | |
| [15:13:39] | 77CAAXOLZ (77CAAXOLZ!~Goga777@2.95.137.147) has quit (Read error: Connection reset by peer) | |
| [15:13:39] | Goga777 (Goga777!~Goga777@2.95.137.147) has quit (Read error: Connection reset by peer) | |
| [15:16:57] | sphery: | stuartm: re #10710 , you may want to see paul-h's replies in http://www.gossamer-threads.com/lists/mythtv/users/516856#516856 (note, also, there's one that hasn't yet made it to gossamer) |
| [15:16:57] | ** MythLogBot http://code.mythtv.org/trac/ticket/10710 ** | |
| [15:30:29] | cocoa117 (cocoa117!~cocoa117@188-222-31-239.zone13.bethere.co.uk) has quit (Quit: Leaving) | |
| [15:39:51] | Chutt (Chutt!~ijr@cpe-24-29-225-175.neo.res.rr.com) has joined #mythtv | |
| [16:04:14] | joki- (joki-!~joki@p54863432.dip.t-dialin.net) has joined #mythtv | |
| [16:04:23] | joki (joki!~joki@p54863008.dip.t-dialin.net) has quit (Ping timeout: 260 seconds) | |
| [16:04:23] | joki- is now known as joki | |
| [16:19:06] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [16:20:04] | stichnot (stichnot!~chatzilla@192.55.54.36) has joined #mythtv | |
| [16:20:04] | stichnot (stichnot!~chatzilla@192.55.54.36) has quit (Changing host) | |
| [16:20:05] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [16:23:44] | petefunk (petefunk!~pfunk@unaffiliated/petefunk) has quit (Ping timeout: 252 seconds) | |
| [16:34:09] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [16:40:54] | petefunk (petefunk!~pfunk@pud5.7ac0.org) has joined #mythtv | |
| [16:41:34] | dekarl1 (dekarl1!~dekarl@p4FCEF838.dip.t-dialin.net) has joined #mythtv | |
| [16:43:06] | dekarl (dekarl!~dekarl@p4FE847FA.dip.t-dialin.net) has quit (Ping timeout: 265 seconds) | |
| [16:45:45] | stuartm: | sphery: looks like he's emailed me directly |
| [16:45:51] | stuartm: | haven't read it yet |
| [16:48:18] | amejia_ (amejia_!~andres@129.174.97.130) has joined #mythtv | |
| [16:48:21] | amejia_ (amejia_!~andres@129.174.97.130) has quit (Changing host) | |
| [16:48:22] | amejia_ (amejia_!~andres@xbmc/staff/amejia) has joined #mythtv | |
| [16:50:16] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Remote host closed the connection) | |
| [16:52:25] | jya_ (jya_!~jyavenard@120.148.99.165) has joined #mythtv | |
| [16:52:25] | jya_ (jya_!~jyavenard@120.148.99.165) has quit (Changing host) | |
| [16:52:25] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [16:58:57] | gambakufu (gambakufu!~mooznach@bzq-84-110-34-203.red.bezeqint.net) has joined #mythtv | |
| [16:59:07] | gambakufu (gambakufu!~mooznach@bzq-84-110-34-203.red.bezeqint.net) has left #mythtv () | |
| [17:02:58] | mrand (mrand!~mrand@ubuntu/member/mrand) has quit (Ping timeout: 245 seconds) | |
| [17:04:22] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 265 seconds) | |
| [17:05:30] | jya_ (jya_!~jyavenard@mythtv/developer/jya) has quit (Quit: jya_) | |
| [17:11:57] | ben1066 (ben1066!~quassel@host109-152-59-25.range109-152.btcentralplus.com) has joined #mythtv | |
| [17:14:35] | ben1066_ (ben1066_!~quassel@host109-152-58-115.range109-152.btcentralplus.com) has quit (Ping timeout: 260 seconds) | |
| [17:37:23] | SmallR2002 (SmallR2002!~quassel@c-98-253-173-240.hsd1.il.comcast.net) has quit (Ping timeout: 246 seconds) | |
| [17:37:27] | SmallR2002 (SmallR2002!~quassel@c-98-253-173-240.hsd1.il.comcast.net) has joined #mythtv | |
| [17:42:20] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Read error: Connection reset by peer) | |
| [17:45:54] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has joined #mythtv | |
| [17:48:45] | ben1066_ (ben1066_!~quassel@host86-128-56-59.range86-128.btcentralplus.com) has joined #mythtv | |
| [17:50:45] | ben1066 (ben1066!~quassel@host109-152-59-25.range109-152.btcentralplus.com) has quit (Ping timeout: 260 seconds) | |
| [17:54:55] | ben1066_ (ben1066_!~quassel@host86-128-56-59.range86-128.btcentralplus.com) has quit (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.) | |
| [17:55:57] | ben1066 (ben1066!~quassel@host86-128-56-59.range86-128.btcentralplus.com) has joined #mythtv | |
| [18:00:10] | Steve-Goodey (Steve-Goodey!~steve@host86-182-4-91.range86-182.btcentralplus.com) has joined #mythtv | |
| [18:02:26] | ben1066_ (ben1066_!~quassel@host86-151-190-218.range86-151.btcentralplus.com) has joined #mythtv | |
| [18:02:53] | ben1066_ (ben1066_!~quassel@host86-151-190-218.range86-151.btcentralplus.com) has quit (Client Quit) | |
| [18:04:45] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
| [18:04:54] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:05:20] | ben1066 (ben1066!~quassel@host86-128-56-59.range86-128.btcentralplus.com) has quit (Ping timeout: 260 seconds) | |
| [18:06:20] | ben1066 (ben1066!~quassel@host86-151-190-218.range86-151.btcentralplus.com) has joined #mythtv | |
| [18:06:20] | ben1066 (ben1066!~quassel@host86-151-190-218.range86-151.btcentralplus.com) has quit (Changing host) | |
| [18:06:20] | ben1066 (ben1066!~quassel@unaffiliated/ben1066) has joined #mythtv | |
| [18:06:47] | stichnot (stichnot!~chatzilla@192.55.54.36) has joined #mythtv | |
| [18:06:48] | stichnot (stichnot!~chatzilla@192.55.54.36) has quit (Changing host) | |
| [18:06:48] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [18:09:09] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
| [18:11:08] | ben1066 is now known as ben1066_ | |
| [18:11:31] | ben1066_ is now known as ben1066 | |
| [18:12:01] | Cougar (Cougar!~cougar@kkk.version6.net) has quit (Quit: Cougar) | |
| [18:12:23] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:12:51] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
| [18:13:23] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:13:41] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Read error: Connection reset by peer) | |
| [18:14:12] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:17:58] | Goga777 (Goga777!~Goga777@2.95.137.147) has joined #mythtv | |
| [18:21:29] | Goga777 (Goga777!~Goga777@2.95.137.147) has quit (Remote host closed the connection) | |
| [18:23:14] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [18:25:12] | Cougar (Cougar!~cougar@kkk.version6.net) has joined #mythtv | |
| [18:52:03] | solars (solars!~solars@194.208.132.118) has quit (Ping timeout: 250 seconds) | |
| [18:53:57] | rhpot1991: | sphery: https://bugs.launchpad.net/ubuntu/+source/mythtv/+bug/997367 |
| [18:54:07] | rhpot1991: | hopefully that is enough information |
| [19:12:06] | solars (solars!~solars@194.208.132.118) has joined #mythtv | |
| [19:13:55] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has quit (Remote host closed the connection) | |
| [19:17:28] | stuartm: | 700581 – In PList::​ParseBinaryReal(unsigned char *): An integer overflow occurs, with the result converted to a wider integer type |
| [19:17:36] | stuartm: | that one is interesting |
| [19:18:18] | sphery: | rhpot1991: thanks... will get to that soon |
| [19:44:53] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [19:50:59] | solars (solars!~solars@194.208.132.118) has quit (Ping timeout: 245 seconds) | |
| [19:58:39] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has quit (Remote host closed the connection) | |
| [19:59:16] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has joined #mythtv | |
| [20:04:33] | solars (solars!~solars@194.208.132.118) has joined #mythtv | |
| [20:14:22] | NightMonkey (NightMonkey!~NightrMon@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [20:26:27] | dmfrey (dmfrey!~dmfrey@webdefence.cluster-h.websense.net) has quit (Quit: Ex-Chat) | |
| [20:32:53] | stichnot (stichnot!~chatzilla@mythtv/developer/stichnot) has quit (Remote host closed the connection) | |
| [20:33:22] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [20:55:17] | Beirdo: | stuartm: actually, I think originally, the myth_av_log() one was meant to intentionally fall through |
| [20:55:43] | Beirdo: | but it doesn't matter, so let's make Coverity happy :) |
| [21:05:04] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [21:05:59] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 245 seconds) | |
| [21:06:23] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
| [21:07:16] | stuartm: | the OVERFLOW_BEFORE_WIDEN warnings are worth a look |
| [21:19:44] | Steve-Goodey (Steve-Goodey!~steve@host86-182-4-91.range86-182.btcentralplus.com) has quit (Remote host closed the connection) | |
| [21:22:06] | stuartm: | Beirdo: given that the outcome would be the same I could have ignored that one, but I decided not to because the first case explicitly set the mask which it wouldn't have needed to do if it was meant to fall through |
| [21:23:16] | stuartm: | you could also call that one a false positive, since the outcome would be identical, but I'll leave that to the coverity folks to figure out :) |
| [21:23:31] | Beirdo: | yeah, originally, the first one just set mask, not level, and fell through and picked up level from the second case |
| [21:23:43] | Beirdo: | but now that the level is in the first case too, a break makes more sense |
| [21:24:13] | Beirdo: | anyways, if we WANT to do that, we should leave a comment saying so :) |
| [21:25:08] | stuartm: | right, since missing breaks are a very common mistake it's better to leave a comment indicating that the lack of one was intentional |
| [21:25:17] | Beirdo: | absolutely |
| [21:25:38] | stuartm: | not that I've always left comments, but I'll try to do so in future ;) |
| [21:25:52] | Beirdo: | me too. I forget at times too |
| [21:40:52] | stuartm: | I'm trying to make a meaningful impact on this coverity stuff, but I can easily see it becoming a chore that I'll tire of |
| [21:41:30] | Beirdo: | yeah, hopefully people start to learn how to code in ways that are cleaner :) |
| [21:41:32] | stuartm: | http://scan5.coverity.com:8080/defects/index. . . . AAAAAAAAJyQ_ << All external code and a number of fixed/false positives excluded |
| [21:41:57] | stuartm: | 326 defects, from a starting point of ~1000 |
| [21:43:06] | stuartm: | still plenty of false positives etc to weed out, I reckon a minimum of 10–20% |
| [21:45:31] | stuartm: | oh cool you can move the columns around, that should make things better |
| [22:02:45] | rhpot1991: | sphery: sounds good, ping me if you need any additional information |
| [22:03:41] | solars (solars!~solars@194.208.132.118) has quit (Ping timeout: 244 seconds) | |
| [22:09:20] | XChatMav (XChatMav!~MaverickT@111.86.233.220.static.exetel.com.au) has joined #mythtv | |
| [22:10:54] | wagnerrp_ (wagnerrp_!~wagnerrp_@mythtv/developer/wagnerrp) has joined #mythtv | |
| [22:11:26] | ybot (ybot!quassel@nat/nokia/x-gndggdwnryixipxt) has joined #mythtv | |
| [22:11:33] | jcarlos_ (jcarlos_!~quassel@85.137.99.76.dyn.user.ono.com) has joined #mythtv | |
| [22:12:11] | yb0t (yb0t!quassel@nat/nokia/x-dbkpfjxdqbylsvwq) has quit (Read error: Connection reset by peer) | |
| [22:12:12] | jcarlos (jcarlos!~quassel@85.137.99.76.dyn.user.ono.com) has quit (Quit: No Ping reply in 180 seconds.) | |
| [22:12:28] | MavT (MavT!~MaverickT@111.86.233.220.static.exetel.com.au) has quit (Ping timeout: 260 seconds) | |
| [22:12:28] | wagnerrp (wagnerrp!~wagnerrp_@mythtv/developer/wagnerrp) has quit (Ping timeout: 260 seconds) | |
| [22:44:40] | andreax (andreax!~andreaz@p54BF21A3.dip.t-dialin.net) has joined #mythtv | |
| [22:49:00] | amessina (amessina!~amessina@2001:470:1f11:a4:d6be:d9ff:fe8d:7c1e) has quit (Quit: Konversation terminated!) | |
| [22:51:34] | wagnerrp_ is now known as wagnerrp | |
| [22:56:54] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has quit (Ping timeout: 244 seconds) | |
| [23:12:49] | stichnot (stichnot!chatzilla@mythtv/developer/stichnot) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.