| Tuesday, October 18th, 2011, 00:02 UTC | ||
| [00:02:28] | taylorr: | Anssi: nope, VLC has a feature request for DVD forced subs from 5 years ago that hasn't been completed yet and XBMC just had support for automatically selecting a subtitle track with the forced track flag set in matroska |
| [00:02:54] | iamlindoro: | Good lord, something very bad is happening with current git |
| [00:03:16] | iamlindoro: | specifically, when trying to git pull |
| [00:03:23] | iamlindoro: | "error: Your local changes to the following files would be overwritten by merge:" on a bunch of files I've never touched in my life |
| [00:03:30] | taylorr: | Ansii: we actually decode the flagged subtitle segments from the full subtitle stream and display on the forced segments |
| [00:03:46] | iamlindoro: | They all pertain to the last day or so's worth of changes |
| [00:04:06] | iamlindoro: | Anyone else able to try a git pull and see what happens? |
| [00:04:29] | Anssi: | taylorr: ah, maybe I misread the backlog, didn't know this was about DVD |
| [00:05:31] | danielk22: | iamlindoro: I just did a pull. prolly something local based on the description. git status say something interesting ? |
| [00:05:56] | iamlindoro: | danielk22: Actually, you are the one I expected it to work for... I was assuming it was caused by your detached head fix |
| [00:06:05] | taylorr: | Anssi: changes are necessary in libavcodec to support forced subtitle segment detection – AFAIK we are the only ones that have this code – it's not upstream |
| [00:06:25] | danielk22: | heh, i tried it on a different machine... |
| [00:06:31] | iamlindoro: | danielk22: Was a pristine tree beforehand... had to git reset and then rm all the scte* files before a pull would work |
| [00:07:01] | iamlindoro: | oh well, thanks for trying anyway |
| [00:07:30] | taylorr: | Anssi: forced subtitles exist for DVD, Blu-ray and rips to Matroska |
| [00:07:42] | taylorr: | we should support all 3 now |
| [00:07:50] | Anssi: | got it |
| [00:09:28] | taylorr: | Anssi: the only remaining issue is for titles that have a separate forced subtitle track – the DVD and Blu-ray structure has to have the information about those tracks but I don't know if libdvdnav and libbluray support that |
| [00:25:22] | panfist (panfist!~stachursk@c-68-46-148-31.hsd1.pa.comcast.net) has joined #mythtv | |
| [00:26:20] | panfist: | i just installed myth front/backend on the new ubuntu, and i can't figure out how to add media to the library |
| [00:26:36] | panfist: | there used to be something in utilities/setup > setup > media, but i don't see a media submenu anymore |
| [00:27:04] | danielk22: | iamlindoro: Dunno. Obviously I can't be 100% sure I did everything right with git, but I did do sanity checking before and after the push. Including pulling to pristine and non-pristine trees that had a checkout from yesterday. |
| [00:31:51] | sphery: | panfist: /topic (you want #mythtv-users ) |
| [00:32:39] | panfist: | so sorry, total noob mistake |
| [00:34:14] | gigem (gigem!~gigem@pool-71-170-166-111.dllstx.fios.verizon.net) has joined #mythtv | |
| [00:34:14] | gigem (gigem!~gigem@mythtv/developer/gigem) has joined #mythtv | |
| [00:34:14] | gigem (gigem!~gigem@pool-71-170-166-111.dllstx.fios.verizon.net) has quit (Changing host) | |
| [00:41:12] | MavT (MavT!~MaverickT@111.86.233.220.static.exetel.com.au) has joined #mythtv | |
| [00:44:10] | danielk22 (danielk22!~danielk@96.57.9.142) has quit (Ping timeout: 260 seconds) | |
| [00:44:10] | MaverickTech (MaverickTech!~MaverickT@220.233.86.111) has quit (Ping timeout: 260 seconds) | |
| [00:44:53] | danielk22 (danielk22!~danielk@96.57.9.142) has joined #mythtv | |
| [00:51:14] | mrand (mrand!~mrand@ubuntu/member/mrand) has quit (*.net *.split) | |
| [00:51:14] | sailerboy (sailerboy!~sailerboy@sailerboy.net) has quit (*.net *.split) | |
| [00:51:15] | Anssi (Anssi!hannulaa@mandriva/developer/anssi) has quit (*.net *.split) | |
| [00:51:15] | kenni (kenni!~kenni@mythtv/developer/kenni) has quit (*.net *.split) | |
| [00:51:15] | kurre2 (kurre2!~tomimo@xdsl-83-150-88-111.nebulazone.fi) has quit (*.net *.split) | |
| [00:51:16] | vallor (vallor!~Ponzo@pdpc/supporter/monthlygold/vallor) has quit (*.net *.split) | |
| [00:51:16] | jedix (jedix!~jedix@24-246-5-37.cable.teksavvy.com) has quit (*.net *.split) | |
| [00:51:16] | laga (laga!~laga@h1626373.stratoserver.net) has quit (*.net *.split) | |
| [00:51:16] | davide (davide!~david@host70.16.intrusion.com) has quit (*.net *.split) | |
| [00:51:16] | kc (kc!~Casper@unaffiliated/kc) has quit (*.net *.split) | |
| [00:51:16] | mrec (mrec!~markus@sundtek.de) has quit (*.net *.split) | |
| [00:51:17] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has quit (*.net *.split) | |
| [00:51:17] | jpabq- (jpabq-!~jpabq@174-28-167-122.albq.qwest.net) has quit (*.net *.split) | |
| [00:51:17] | jwhite (jwhite!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has quit (*.net *.split) | |
| [00:51:18] | markk (markk!~mark@host86-181-156-164.range86-181.btcentralplus.com) has quit (*.net *.split) | |
| [00:51:18] | Malard (Malard!Malard@xbmc/staff/malard) has quit (*.net *.split) | |
| [00:51:19] | tomimo (tomimo!~kurre@xdsl-83-150-88-111.nebulazone.fi) has quit (*.net *.split) | |
| [00:51:19] | dlblog (dlblog!~dlblog@c-76-127-227-175.hsd1.ma.comcast.net) has quit (*.net *.split) | |
| [00:55:09] | davide (davide!~david@host70.16.intrusion.com) has joined #mythtv | |
| [00:55:09] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [00:55:09] | markk (markk!~mark@host86-181-156-164.range86-181.btcentralplus.com) has joined #mythtv | |
| [00:55:09] | sailerboy (sailerboy!~sailerboy@sailerboy.net) has joined #mythtv | |
| [00:55:09] | Malard (Malard!Malard@xbmc/staff/malard) has joined #mythtv | |
| [00:55:09] | kc (kc!~Casper@unaffiliated/kc) has joined #mythtv | |
| [00:55:09] | kenni (kenni!~kenni@mythtv/developer/kenni) has joined #mythtv | |
| [00:55:09] | tomimo (tomimo!~kurre@xdsl-83-150-88-111.nebulazone.fi) has joined #mythtv | |
| [00:55:09] | kurre2 (kurre2!~tomimo@xdsl-83-150-88-111.nebulazone.fi) has joined #mythtv | |
| [00:55:09] | dblain (dblain!~dblain@mythtv/developer/dblain) has joined #mythtv | |
| [00:55:09] | Anssi (Anssi!hannulaa@mandriva/developer/anssi) has joined #mythtv | |
| [00:55:09] | mrec (mrec!~markus@sundtek.de) has joined #mythtv | |
| [00:55:09] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has joined #mythtv | |
| [00:55:09] | jpabq- (jpabq-!~jpabq@174-28-167-122.albq.qwest.net) has joined #mythtv | |
| [00:55:09] | jwhite (jwhite!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has joined #mythtv | |
| [00:55:09] | dlblog (dlblog!~dlblog@c-76-127-227-175.hsd1.ma.comcast.net) has joined #mythtv | |
| [00:55:09] | laga (laga!~laga@h1626373.stratoserver.net) has joined #mythtv | |
| [00:55:09] | jedix (jedix!~jedix@24-246-5-37.cable.teksavvy.com) has joined #mythtv | |
| [00:55:09] | vallor (vallor!~Ponzo@pdpc/supporter/monthlygold/vallor) has joined #mythtv | |
| [01:06:58] | davide (davide!~david@host70.16.intrusion.com) has quit (Remote host closed the connection) | |
| [01:07:24] | davide (davide!~david@host70.16.intrusion.com) has joined #mythtv | |
| [01:17:34] | NightMonkey (NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey) has quit (Quit: Body blow! Body blow!) | |
| [01:18:51] | wagnerrp (wagnerrp!~wagnerrp_@mythtv/developer/wagnerrp) has quit (Remote host closed the connection) | |
| [01:19:55] | wagnerrp (wagnerrp!~wagnerrp_@nr-ft1-66-42-241-137.fuse.net) has joined #mythtv | |
| [01:19:55] | wagnerrp (wagnerrp!~wagnerrp_@nr-ft1-66-42-241-137.fuse.net) has quit (Changing host) | |
| [01:19:56] | wagnerrp (wagnerrp!~wagnerrp_@mythtv/developer/wagnerrp) has joined #mythtv | |
| [01:45:44] | danielk22: | markk: I'm missing something, AFAICT there is no audio stream in the sample. pid 0x0 has 1535 instances of a single PAT, pid 0x409 has the 1534 instances of the PMT, and pid 0x948 has some DSM data (1582 TS Packets). Most of the sample is the 73696 packets of stuffing on pid 0x1fff. Is that what you were expecting? |
| [02:29:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [02:59:49] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [03:01:48] | Captain_Murdoch: | danielk22, do you prefer --infile/--outfile or the pre-existing --srcfile/--destfile for mythutil args? I don't mind which ones we use, but it would be nice if we could standardize those so that we don't have some utils using one naming convention and others using something different. I used --srcfile/--destfile originally for the copyfile util, but don't mind changing that to --infile/--outfile. |
| [03:03:54] | Captain_Murdoch: | also, if you can think of a better way to do the commandlineparser help text setup, feel free to hack away. I didn't want to have a big if else if else if statement somewhere, that's why I used the function pointers in the map, but couldn't think of an easy way at the time to do the help text. might need a mod to the lib code for the command line parser to be able to add to the list of AllowOneOf() args. |
| [03:11:12] | ub3r (ub3r!~b3ast@ool-457c8cb2.dyn.optonline.net) has joined #mythtv | |
| [03:11:20] | ub3r (ub3r!~b3ast@ool-457c8cb2.dyn.optonline.net) has left #mythtv () | |
| [03:13:18] | Chutt (Chutt!~ijr@cpe-76-190-198-203.neo.res.rr.com) has quit (Remote host closed the connection) | |
| [03:16:03] | danielk22: | Captain_Murdoch: --infile/--outfile is what is used by the other command line utils, I just wanted to use the same naming convention. I was going to mention it when I saw you online, but didn't want to change the copyfile stuff without talking to you first. |
| [03:17:17] | Captain_Murdoch: | ok, I'll change my stuff. I thought we had a mix. |
| [03:19:11] | danielk22: | Captain_Murdoch: before the latest set of command line parser rewrites I'd been trying to standardize the command line params across programs. :) |
| [03:21:48] | Captain_Murdoch: | great, all for it. If we can ->SetRequires("infile")->SetRequires("outfile"), then we might be able to make a helper to MythCommandLineParser to add --infile and --outfile for us. addInFile(bool addOutFile = false); |
| [04:48:02] | reynaldo (reynaldo!~rverdejo@pc-147-56-101-190.cm.vtr.net) has quit (Ping timeout: 244 seconds) | |
| [05:26:28] | jmartens (jmartens!~jmartens@s5597ca60.adsl.wanadoo.nl) has joined #mythtv | |
| [05:38:29] | jmartens (jmartens!~jmartens@s5597ca60.adsl.wanadoo.nl) has quit (Quit: Leaving.) | |
| [05:44:09] | jpabq_ (jpabq_!~jpabq@mythtv/developer/jpabq) has quit (Ping timeout: 255 seconds) | |
| [05:54:45] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 252 seconds) | |
| [05:55:34] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [05:58:23] | jmartens (jmartens!~jmartens@109.232.42.33) has joined #mythtv | |
| [05:58:42] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [06:34:08] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 245 seconds) | |
| [07:09:53] | willcooke (willcooke!~will@canonical/willcooke) has joined #mythtv | |
| [07:15:12] | markk: | danielk22: exactly. no audio – just some very low bitrate MHEG data. It does nothing more than put up an onscreen bitmap saying it's off air. just takes forever to tune. |
| [07:27:48] | PointyPumper (PointyPumper!~pintlezz@190.244.65.185) has quit (Read error: Connection reset by peer) | |
| [07:29:24] | PointyPumper (PointyPumper!~pintlezz@190.244.65.185) has joined #mythtv | |
| [08:02:37] | markk: | taylorr: nice to hear it's working. just had a look at simplifying the OSD menu but think I'll leave as is for the time being. Although not common, there are going to be those situations with mkv files with multiple subtitle types – and the configuration just becomes a mess if we try to deal with every situation. |
| [08:33:36] | xavierh (xavierh!~xavier@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has joined #mythtv | |
| [08:42:34] | len (len!~quassel@174-30-241-127.mpls.qwest.net) has quit (Remote host closed the connection) | |
| [09:11:17] | Goga777 (Goga777!~Goga777@shpd-95-53-217-227.vologda.ru) has joined #mythtv | |
| [09:21:46] | xavierh: | stuartm: thanks for rootChanged |
| [09:28:13] | Goga777 (Goga777!~Goga777@shpd-95-53-217-227.vologda.ru) has quit (Remote host closed the connection) | |
| [09:50:24] | markk (markk!~mark@host86-181-156-164.range86-181.btcentralplus.com) has quit (Quit: Ex-Chat) | |
| [10:05:02] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:05:54] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:13:42] | reynaldo (reynaldo!~rverdejo@pc-147-56-101-190.cm.vtr.net) has joined #mythtv | |
| [10:49:14] | Feico (Feico!~Feico@s529db771.adsl.wanadoo.nl) has joined #mythtv | |
| [11:47:23] | markk (markk!~mark@host86-181-156-164.range86-181.btcentralplus.com) has joined #mythtv | |
| [11:49:23] | map7 (map7!~map7@ppp118-209-40-224.lns20.mel4.internode.on.net) has joined #mythtv | |
| [12:09:44] | davide (davide!~david@host70.16.intrusion.com) has quit (Remote host closed the connection) | |
| [12:10:06] | davide (davide!~david@host70.16.intrusion.com) has joined #mythtv | |
| [12:15:04] | zombor (zombor!~zombor_@65.29.231.135) has joined #mythtv | |
| [12:15:14] | zombor (zombor!~zombor_@65.29.231.135) has quit (Changing host) | |
| [12:15:14] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [12:17:47] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [12:24:38] | taylorr: | markk: I did find an issue with forced last night – if you enable full subtitles and the disable full subtitles then forced no longer displays – I'm guessing when disabling full subtitles we are doing SetVisable to false or something like that |
| [12:30:55] | stuartm: | does anyone know of an app which allows you to toggle the forced flag on subs in mkv? I've ripped my blurays with makemkv which doesn't support the mkv forced flag but will rip forced subtitles into a separate stream |
| [12:31:49] | taylorr: | stuartm: you mean set the forced track flag? |
| [12:32:41] | taylorr: | you can do that by using mkvmerge that is included the mkvtoolnix package |
| [12:32:44] | stuartm: | aye, not the segment flags obviously |
| [12:32:57] | stuartm: | taylorr: thanks |
| [12:33:22] | taylorr: | really no need to use the forced track flag though since the latest code will display just the forced segments |
| [12:34:05] | stuartm: | taylorr: right, it just doesn't appear that makemkv marks the forced segments – I could be wrong though |
| [12:37:45] | taylorr: | stuartm: no it retains the forced flags – doesn't touch the stream itself |
| [12:38:03] | taylorr: | if there aren't any then that means the original didn't have them |
| [12:38:25] | stuartm: | taylorr: ah, ok, I need to try again with the latest code then |
| [12:40:29] | taylorr: | stuartm: if you told makemkv to create a forced only track and it's empty and discarded then that means there were no forced segments in the full track |
| [12:42:16] | stuartm: | there are forced subs for these discs, I don't think I remembered to install after pulling/building the visibility fix |
| [12:43:04] | stuartm: | there is a forced only track that works when manually enabled, just not automatically |
| [13:07:28] | map7 (map7!~map7@ppp118-209-40-224.lns20.mel4.internode.on.net) has quit (Ping timeout: 276 seconds) | |
| [13:12:50] | markk: | taylorr: yesterday's patch *should* work in that scenario. Must be something I missed. |
| [13:13:10] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [13:16:20] | markk: | taylorr: seems to be working here. Is that when enabling the subs for a different track/language? ie. trying to get the forced subs from something other than the autodetected track. |
| [13:28:26] | willcooke (willcooke!~will@canonical/willcooke) has quit (Quit: We will learn more of his wisdom later) | |
| [13:29:38] | willcooke (willcooke!~will@willcooke.plus.com) has joined #mythtv | |
| [13:29:38] | willcooke (willcooke!~will@willcooke.plus.com) has quit (Changing host) | |
| [13:29:38] | willcooke (willcooke!~will@canonical/willcooke) has joined #mythtv | |
| [13:35:31] | markk: | taylorr, stuartm: just found my first section of forced subs on a bluray rip. seems to be a problem with them being decoded too late (or the timing is off at least). some flash on very briefly. |
| [14:03:40] | taylorr: | markk: I'm not exactly sure how I got it in the state where the forced subs didn't show anymore – I thought I just enabled/disabled the same track |
| [14:04:22] | taylorr: | markk: yes, I noticed the short duration and sometimes missing subs – I figured it might have been an existing issue |
| [14:04:38] | taylorr: | I don't think the pgs decoder properly sets the start/end time for subs |
| [14:05:03] | taylorr: | seems like they are all set to be 20000ms in duration |
| [14:16:40] | markk: | taylorr: yeah – seem to be some comments on it in pgssubdec |
| [14:21:00] | xavierh (xavierh!~xavier@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has quit (Quit: Lost terminal) | |
| [14:49:51] | j-rod|afk is now known as j-rod | |
| [14:51:21] | danielk22: | Is there a way to create a 2nd fork of a repo using github? I already have one fork of mythtv, and whenever I click the fork button it just brings me to that branch instead of letting me create a new one... |
| [14:51:22] | xavierh (xavierh!~xavier@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has joined #mythtv | |
| [14:56:18] | jpabq_ (jpabq_!~jpabq@mythtv/developer/jpabq) has joined #mythtv | |
| [14:58:50] | j-rod is now known as j-rod|afk | |
| [14:58:52] | j-rod|afk is now known as j-rod | |
| [15:25:22] | Malard (Malard!Malard@xbmc/staff/malard) has quit () | |
| [15:32:24] | Malard (Malard!Malard@malard.plus.com) has joined #mythtv | |
| [15:32:24] | Malard (Malard!Malard@malard.plus.com) has quit (Changing host) | |
| [15:32:24] | Malard (Malard!Malard@xbmc/staff/malard) has joined #mythtv | |
| [15:36:31] | taylorr: | markk: are you sure we need to be able to enable/disable forced subtitles? |
| [15:37:28] | taylorr: | basically forced subtitles should always be enabled |
| [15:37:51] | taylorr: | it's only full subtitles that should be enabled/disabled which we already have |
| [15:43:20] | xavierh (xavierh!~xavier@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has quit (Quit: Lost terminal) | |
| [15:49:15] | markk: | taylorr: a little googling the other day suggested there were some discs with too many forced subs and various people complaining about not being able to disable them – so I added the option. |
| [15:53:58] | taylorr: | markk: ok, that's a good reason :) |
| [15:54:30] | taylorr: | I guess a blu-ray player user would be out of luck |
| [15:55:58] | markk: | also accounts for those poorly mastered, dodgy discs from south east asia (that I have never seen, just heard about) that force some foreign language subtitling on the poor unsuspecting user. |
| [16:06:22] | taylorr: | markk: the more control the better |
| [16:06:43] | jmartens (jmartens!~jmartens@109.232.42.33) has quit (Quit: Leaving.) | |
| [16:07:20] | taylorr: | markk: I have some code that would add a second "forced only" for each subtitle track – I was thinking this would be a nice way for a user to select a subtitle track add have it only play the forced subtitles |
| [16:08:10] | taylorr: | the problem is the OSD UI – if you take "0: English" and add a second "0: English (forced only)" you may or may not see the "forced only" |
| [16:09:02] | taylorr: | especially for language descriptors that are very long like Spanish;Castillian;blah |
| [16:09:31] | taylorr: | I wish the subtitle list was left justified and automatically sized to show all the characters |
| [16:10:20] | taylorr: | one method I was thinking of doing is "0: English" followed by "0: ... (forced only)" |
| [16:10:51] | taylorr: | I'm guessing that "..." is universally recognized repeat the line before |
| [16:17:49] | markk: | taylorr: the justification will be theme dependant. I think the 0: ... (forced) sounds reasonable – just worried about those discs with about 10 different language tracks, plus 10 for the directors commentary. 40 selections is pretty unwieldy:) |
| [16:31:21] | Captain_Murdoch: | could just show the 2-digit language string for the forced only line. or have a tree with the language as the top level, so Disabled, 0: English, and 1: Spanish as the top level and with each language/track having sub-options of All and Forced Only. |
| [16:34:57] | jmartens (jmartens!~jmartens@s5597ca60.adsl.wanadoo.nl) has joined #mythtv | |
| [16:40:25] | taylorr: | markk: heh, I agree it can add up – but when sphery adds the selection saving code it shouldn't be too bad |
| [16:41:05] | taylorr: | markk: the other option is to have another submenu called "Forced Only" and list all the subtitles under it |
| [16:42:45] | danielk22: | taylorr: "Spanish ; Castillian" could be shortened in North America :) I don't think there are any Basque transmissions.. |
| [16:46:32] | danielk22: | BTW I don't think we translate those strings, so if we put them in the GUI they will always be in English... |
| [16:49:55] | taylorr: | danielk22: I'm probably going to start committing some changes to dtvrecorder and the recorder class this week – you might want to review them to make sure I don't do anything that's going to cause issues |
| [16:55:22] | andreax (andreax!~andreaz@p4FC12407.dip.t-dialin.net) has joined #mythtv | |
| [17:06:57] | davide (davide!~david@host70.16.intrusion.com) has quit (Remote host closed the connection) | |
| [17:07:20] | davide (davide!~david@host70.16.intrusion.com) has joined #mythtv | |
| [17:12:55] | Malard (Malard!Malard@xbmc/staff/malard) has quit () | |
| [17:15:13] | danielk22: | taylorr: Sure, if you want to run them by me before hand feel free. I can respond fairly quickly this week, less so next week. But I always review recorder commits. |
| [17:36:11] | Malard (Malard!Malard@malard.plus.com) has joined #mythtv | |
| [17:37:25] | Malard (Malard!Malard@malard.plus.com) has quit (Changing host) | |
| [17:37:25] | Malard (Malard!Malard@xbmc/staff/malard) has joined #mythtv | |
| [17:39:38] | markk: | stuartm: what's the 'correct' way to go about handling of mapping actions from specific devices to actual internal actions. we map keypresses to actions. I think for lirc we map remote keypresses to keys, which then get translated to actions. Should an external device always emulate keypresses so that the keys/actions can be remapped? does that all make sense |
| [17:52:34] | xavierh (xavierh!~chatzilla@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has joined #mythtv | |
| [18:01:25] | willcooke (willcooke!~will@canonical/willcooke) has quit (Quit: We will learn more of his wisdom later) | |
| [18:07:43] | xavierh (xavierh!~chatzilla@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has quit (Ping timeout: 248 seconds) | |
| [18:15:08] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [18:16:29] | markk: | evening Malard |
| [18:17:16] | Cougar (Cougar!~cougar@kkk.version6.net) has quit (Quit: Cougar) | |
| [18:24:52] | xavierh (xavierh!~chatzilla@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has joined #mythtv | |
| [18:29:03] | stuartm: | markk: there's never been much agreement on the 'correct' way, but translating actions to keypresses has stuck because various attempts to redesign have all been rejected for different reasons |
| [18:29:14] | Malard: | hi markk |
| [18:29:36] | Malard: | played much more with the adapter? |
| [18:30:57] | stuartm: | markk: someone here was refactoring input handling and they mentioned mapping external input to a new internal input event instead of keypresses – as I say it's been tried before but maybe this time it will be done acceptably |
| [18:32:17] | stuartm: | markk: if you're looking to add support for a new input device then it might be worth looking at that patch – http://code.mythtv.org/trac/ticket/10069 |
| [18:32:50] | markk: | stuartm: so to date, I've written the libcec adaptor support by mapping CEC commands (e.g. Play) directly to actions. Which is fine and clean. It doesn't however allow for customisation (without extra code). Presumably if I went CEC command->KeyPress, then the user can customise the associated actions via the key editor... |
| [18:34:10] | jams: | stuartm that was xavierh and there is a patch in trac |
| [18:34:17] | stuartm: | jams: ^^ |
| [18:34:36] | stuartm: | seems like xavierh stuck with keyevents for now but that's easily changed |
| [18:34:43] | markk: | stuartm: I looked at that patch – it emulates keypresses as well. |
| [18:34:49] | markk: | :) |
| [18:35:45] | stuartm: | markk: yes they could use the keypress editor, but there's absolutely no reason why the key editor couldn't handle something else, e.g. you send the Play event and the editor shows 'Play' and maps that directly, it would just require a lookup table for each input device |
| [18:35:54] | jams: | heh..little late i guess |
| [18:36:22] | markk: | Malard: not had much time to dig any more – but initial support is pretty straightforward, just trying to work out the best approach before committing it. |
| [18:38:26] | stuartm: | markk: it's much neater IMHO to map input directly to actions, I guess if you're willing that would be the way to go – I can adapt xavierh's patch to add a new internal InputEvent and the hooks for any raw event >> event name/code tables it would use |
| [18:40:19] | markk: | stuartm: sorry – not entirely sure what that means/involves :) |
| [18:40:23] | Malard: | good stuff, do you know if there is anyway to do a join announcement and can we advertise on the pulse-eight website mythtv supports the adapter when it's all committed? |
| [18:42:04] | markk: | Malard: we tend not to announce much – apart from releases! |
| [18:42:31] | markk: | stuartm: are you comfortable with the input patch? (i.e. the approach) |
| [18:42:45] | stuartm: | markk: what sort of timeframe are you looking at? I'm re-decorating atm and that's keeping me busy, but I can probably find the time to write up something in the next 2 weeks |
| [18:43:13] | stuartm: | markk: I've only looked at the summary, I'm happy enough about that approach |
| [18:45:09] | stuartm: | ok, patch is generally fine, I'm not sure what all the setting stuff is about though |
| [18:46:03] | markk: | stuartm: all my coding is between decorating:) (and child minding over half term atm) – I think the easiest thing to do is to get the cec stuff in as is (Play->ACTION_PLAY). It will be simple enough to move it over to anything new. |
| [18:46:12] | willcooke (willcooke!~will@willcooke.plus.com) has joined #mythtv | |
| [18:46:12] | willcooke (willcooke!~will@willcooke.plus.com) has quit (Changing host) | |
| [18:46:12] | willcooke (willcooke!~will@canonical/willcooke) has joined #mythtv | |
| [18:46:19] | stuartm: | markk: that's fine |
| [18:46:40] | Malard: | markk would it go into the features for the next release that its been added? |
| [18:47:16] | markk: | Malard: yes |
| [18:47:32] | Malard: | cool, and would there be anything stopping us from promoting it on our side? |
| [18:48:37] | markk: | I don't see a problem with that. Unless anyone else has any objections?? |
| [18:49:42] | danielk22: | markk: The easiest thing to do is just translate the CEC events to keys, that way if the remote has keys that don't map cleanly to something in MythTV they can still be used. (Or they map to say Red,Green,Blue,Yellow keys which have special meaning in the UK but might be better mapped to something like "Delete", "Edit", "Menu", "Info" in the US.) |
| [18:50:15] | iamlindoro: | No objection here to the "supported in" |
| [18:50:39] | Malard: | danielk22 nice idea, although do you realise CEC is bi-directional, so you can have mythtv telling the TV what to do instead |
| [18:51:12] | Malard: | in all honesty, having users use their existing TV remotes is a by production from what I originally intended, I always assumed that people would want to ditch their TV remote in favour of a more powerful and unified PC remote |
| [18:51:26] | Malard: | whereby volume would always go to the amp, numbers control the active context etc |
| [18:51:58] | markk: | Malard: sure – but there are quick wins to be had:) |
| [18:52:19] | xavierh: | stuartm: #10069, just allow to create new input event handler using a plugin mechanism |
| [18:52:29] | Malard: | oh definatly, we've only got the library and xbmc handling power on/off and recieving keys from the remote |
| [18:52:49] | stuartm: | danielk22: I'm not sure I follow that? Any input can be mapped by the user to an action without needing to go via a keypress first – yes it requires a re-write of input handling but that's not particularly arduous |
| [18:52:56] | Malard: | we want to do a lot more, such as integrating an external DVD or blu-ray player seemlessly into XBMC, so it will just switch the active source but still remain in control passing key strokes etc |
| [18:53:06] | stuartm: | xavierh: yep, I saw that once I actually looked at it :) |
| [18:53:15] | xavierh: | stuartm: at rewrote #10053 in a much cleaner and less invasive way, I plan to submit it soom, just need to finish with mythcontrol |
| [18:53:26] | stuartm: | xavierh: ah |
| [18:54:00] | stuartm: | xavierh: I'd forgotten about that patch |
| [18:54:14] | danielk22: | stuartm: Sure but the remapping UI is already complicated, why complicate it with another remapping paradigm? |
| [18:54:15] | stuartm: | I was all geared up to go and write it myself :) |
| [18:55:02] | xavierh: | it is copmplicated because we have to map lirc -> qkeyevent -> action context |
| [18:55:25] | xavierh: | My patch allow lirc (or other input) -> context action |
| [18:56:41] | markk: | heh – this is all becoming so much clearer :( |
| [18:56:42] | xavierh: | but don't look at the submitted patch on #10053, you are going to have an heart attack |
| [18:57:42] | stuartm: | danielk22: it's not really any different, the mapping UI maps Actions to keys, not keys to actions – lets say that they have a device with a key labelled 'Ferkle' – it's clearer if the UI shows 'Ferkle' mapped to an action and not 'ALT+F' or whatever hardcoded keypress has been chosen |
| [18:58:19] | stuartm: | markk: just go with what you've got for now, it can easily be re-factored/rewritten later |
| [18:58:51] | danielk22: | I didn't realize the new framework was already largely written... |
| [18:59:33] | markk: | can I just suggest that, once whatever changes have been made, that we document in the code somewhere how it should work. It's a minefield at the moment. |
| [18:59:34] | danielk22: | markk: I'd say just get it working somehow with the current code and then it can be refactored when a new UI is put in. |
| [18:59:41] | stuartm: | markk: absolutely |
| [19:12:52] | markk: | stuartm: so does this mean that those action defines I've been gradually working on need to become global... (I currently have the CEC object hacked into mythfrontend/main but want to add it to mythmainwindow – and presumably eventually a plugin – but the tv actions aren't available in mythui) |
| [19:22:04] | stuartm: | markk: some of the current tv actions are destined to become global, e.g. Play (used in mythmusic, mythgallery, mythnetvision et al) but others just wouldn't belong there |
| [19:22:39] | stuartm: | I'd sooner move those action registrations out of libmythtv into mythfrontend or if pushed, to libmythbase |
| [19:24:24] | stuartm: | well, I guess it has to be libmythbase – momentary thinko there |
| [19:26:01] | stuartm: | markk: or maybe it makes a lot of sense for them to be in libmythui along with the rest of the input stuff, I guess I just don't know what I'm saying atm ;) |
| [19:26:27] | markk: | stuartm: libmythbase was what I had in mind – which also helps with non-gui apps. (I've always had grand plans for a music playing client with http control) |
| [19:28:45] | stuartm: | markk: when you said global, did you mean the global action context, or moving them to a globally accessible location e.g. libmythbase? |
| [19:33:06] | stuartm: | re-reading I see it was the latter, I managed to confuse the two, maybe I should get an early night |
| [19:36:32] | Beirdo: | anyone mind if I fix the pile of warnings in the goom/ stuff in mythmusic? |
| [19:37:00] | stuartm: | Beirdo: Paul might |
| [19:37:05] | Beirdo: | I know paulh wanted us to steer clear of mythmusic itself, but is the goom stuff OK? |
| [19:37:16] | Beirdo: | K |
| [19:37:18] | stuartm: | I really couldn't say |
| [19:37:24] | Beirdo: | yeah, he's not here to comment. Drats. |
| [19:37:45] | Beirdo: | they are pretty simple to fix when the time comes. |
| [19:37:58] | stuartm: | we could add those to the suppressions list for now if we want to clear the field |
| [19:38:09] | Beirdo: | meh |
| [19:38:13] | danielk22: | Beirdo: I'd stay clear of it, if three months go by and Paul hasn't made progress on mythmusic... |
| [19:38:17] | Beirdo: | :) |
| [19:38:38] | Beirdo: | OK, I'll send him a specific email about those files to see if he minds for those specific ones. |
| [19:38:57] | Beirdo: | but otherwise, it can wait |
| [19:39:37] | danielk22: | There are plenty of warnings elsewhere :) |
| [19:40:02] | Beirdo: | true, and I'll be looking at them too, just they were the first obvious ones on the list |
| [19:40:05] | Beirdo: | hehe |
| [19:42:38] | Beirdo: | the pxsup2dast.c ones make me shudder |
| [19:42:58] | Beirdo: | using longjmp rather than threads... blech. |
| [19:44:18] | danielk22: | Beirdo: That's really upstream code. And even though it's really ugly it works. |
| [19:44:35] | Beirdo: | yup. Which is why we look at it, shudder, and move on :) |
| [19:44:40] | saintdev (saintdev!~saint@c-24-9-201-236.hsd1.co.comcast.net) has joined #mythtv | |
| [19:44:41] | saintdev (saintdev!~saint@unaffiliated/saintdev) has joined #mythtv | |
| [19:44:41] | saintdev (saintdev!~saint@c-24-9-201-236.hsd1.co.comcast.net) has quit (Changing host) | |
| [19:50:20] | stuartm: | to float the idea again, does anyone object to moving all third party code to an external folder under the current directories? e.g. pxsup2dast.c would move to mytharchivehelper/external/ |
| [19:50:37] | Beirdo: | I think that's a good plan |
| [19:50:56] | stuartm: | it would help to distinguish the upstream code and make it easier to ignore in automated checks |
| [19:50:58] | Beirdo: | makes it a lot more obvious what we need to take care before tinkering with |
| [19:51:03] | Beirdo: | yup |
| [19:51:35] | danielk22: | stuartm: I don't think anyone is opposed, just lazy :) |
| [19:52:39] | Beirdo: | if we do that, we should likely have a README in those dirs with where the external stuff's upstream is too, maybe |
| [19:53:38] | Beirdo: | just thinking for future syncs :) |
| [19:53:54] | stuartm: | danielk22: heh, well I'm happy to start on it |
| [19:53:55] | danielk22: | I'd love it if the last sync revision was documented in some standard way. Like a "LAST_SYNC" file. |
| [19:54:14] | Beirdo: | Oooh, that sounds like a smart plan too |
| [19:54:33] | stuartm: | Beirdo: yeah, I was thinking the same, a readme or other documentation listing the source, last update, reason for importing too |
| [19:54:35] | danielk22: | I'd have resynced the live555 library a long time ago if I didn't have to hunt for the last sync revision in the commit history... |
| [19:54:41] | Beirdo: | saves digging through git log to find it |
| [19:56:19] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 276 seconds) | |
| [19:57:24] | Beirdo: | I'll certainly keep that up for our ffmpeg syncs. I'll go dig out the currently synced version in a bit and make a file. I like the idea of saving future headscratching :) |
| [19:59:23] | Beirdo: | email to paulh sent. We'll see what he thinks about tweaking the goom files. |
| [20:00:18] | Beirdo: | I think the general plan was to nuke them sometime soon anyways |
| [20:11:41] | ocrateb (ocrateb!~ocrateb@s83-177-186-55.cust.tele2.se) has joined #mythtv | |
| [20:12:24] | xavierh: | I updated #10053 with a new file with a much cleaner and simplier design, see comment |
| [20:14:39] | Feico (Feico!~Feico@s529db771.adsl.wanadoo.nl) has quit (Quit: Toedeledokie) | |
| [20:16:29] | Beirdo: | xavierh: thanks :) |
| [20:19:23] | xavierh: | back to frontend setup now |
| [20:23:05] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (*.net *.split) | |
| [20:23:06] | MavT (MavT!~MaverickT@111.86.233.220.static.exetel.com.au) has quit (*.net *.split) | |
| [20:23:06] | brfransen (brfransen!~brfransen@216.254.250.47) has quit (*.net *.split) | |
| [20:23:06] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has quit (*.net *.split) | |
| [20:23:06] | joe___ (joe___!~jmk@64.73.32.135) has quit (*.net *.split) | |
| [20:23:06] | justinh (justinh!~justin@cpc10-salf5-2-0-cust50.10-2.cable.virginmedia.com) has quit (*.net *.split) | |
| [20:23:06] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has quit (*.net *.split) | |
| [20:23:08] | jpabq_ is now known as jpabq | |
| [20:23:22] | ocrateb (ocrateb!~ocrateb@s83-177-186-55.cust.tele2.se) has quit (Quit: Leaving) | |
| [20:24:41] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [20:24:42] | MavT (MavT!~MaverickT@111.86.233.220.static.exetel.com.au) has joined #mythtv | |
| [20:24:42] | brfransen (brfransen!~brfransen@216.254.250.47) has joined #mythtv | |
| [20:24:42] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [20:24:42] | 17WAAF6BR (17WAAF6BR!~jpabq@mythtv/developer/jpabq) has joined #mythtv | |
| [20:24:42] | joe___ (joe___!~jmk@64.73.32.135) has joined #mythtv | |
| [20:24:42] | justinh (justinh!~justin@cpc10-salf5-2-0-cust50.10-2.cable.virginmedia.com) has joined #mythtv | |
| [20:24:42] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has joined #mythtv | |
| [20:33:34] | len (len!~quassel@174-30-241-127.mpls.qwest.net) has joined #mythtv | |
| [20:42:19] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [20:59:04] | Captain_Murdoch: | beirdo, we can remove mythutil.h from those files now that they include their own header file which themselves include mythutil.h. also noticed that mpegutils.cpp includes mpegutils.h twice if the next person touching that area wants to fix that. |
| [21:02:45] | Beirdo: | Heh, yeah, I guess that would work :) |
| [21:21:47] | danielk22: | markk: I got your message on the sample file. I'll re-test tonight after the munchkin is in bed. When I tried opening it in mythavtest I didn't get an off-air message at all even with a 18MB sample.. |
| [21:35:25] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [21:36:26] | markk: | danielk22: do you have MHEG compiled in? and interactive TV enabled in the OSD settings? |
| [21:36:40] | j-rod is now known as j-rod|afk | |
| [21:38:40] | markk: | stuartm: yes – sorry for the confusion. I was purely referring to moving libmythui/mythuiactions.h and libmythtv/tv_actions.h into something more central. wasn't referring to the Global Context. |
| [21:41:53] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (Quit: kormoc) | |
| [21:43:58] | jmartens (jmartens!~jmartens@s5597ca60.adsl.wanadoo.nl) has quit (Quit: Leaving.) | |
| [21:49:21] | ocrateb (ocrateb!~ocrateb@s83-177-186-55.cust.tele2.se) has joined #mythtv | |
| [21:49:53] | ocrateb (ocrateb!~ocrateb@s83-177-186-55.cust.tele2.se) has quit (Remote host closed the connection) | |
| [21:57:14] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [22:02:29] | jams: | Captain_Murdoch- so i'm working on updating my setting clone/save/restore patch. Would that be appropriate for mythutils or should it remain it's own cmdline util? |
| [22:02:33] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Read error: Connection reset by peer) | |
| [22:03:27] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [22:04:07] | xavierh: | jams: I was actually thinking about if while working on the frontend setup. |
| [22:04:20] | xavierh: | 8about it |
| [22:04:25] | xavierh: | *about it |
| [22:05:11] | jams: | xavierh- as in giving it a UI? |
| [22:05:55] | xavierh: | jams: could you reword it? |
| [22:06:17] | jams: | so what were you thinking about? |
| [22:07:27] | xavierh: | Sorry, I got you now, I thaught to myself as all the setting are/will be in a tree, at each node/level I could propose the option to take the setting from a different host |
| [22:08:10] | xavierh: | i.e load totaly or partially settings from a different host and apply it to the current one |
| [22:08:15] | jams: | there is some crossover there |
| [22:08:44] | xavierh: | I am not really doing it just add a thought about it |
| [22:09:23] | jams: | it's a good thought |
| [22:10:29] | xavierh: | I don't know how difficult it would be however. |
| [22:13:14] | andreax (andreax!~andreaz@p4FC12407.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [22:17:30] | xavierh: | jams: Saving/restoring setting is not as easy as it may look at the first look, some setting require different table to be properly populated, For example DefaultVideoPlaybackProfile |
| [22:19:20] | markk: | anyone else seeing mythfrontend crash on exit in latest master? |
| [22:23:33] | jams: | markk- middle of a compile now, will let you know shortly |
| [22:25:02] | xavierh: | markk: I though it was like this because of my local change related to #10069 |
| [22:26:55] | markk: | stuartm: looks like libmythui – anything notable changed recently? http://pastebin.ca/2091200 |
| [22:40:34] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [22:41:56] | jams: | seems ok here |
| [22:42:52] | jams: | oh wait..wrong branch |
| [22:44:34] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [22:45:29] | xavierh: | jams: I wished I knew git well enough to do local branches :) |
| [22:47:36] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Ping timeout: 240 seconds) | |
| [22:49:32] | Captain_Murdoch: | jams, if it's all command line, I'd say stick it in mythutil. once it's in there, it's easy to split out later if we decided to. for an easy diff to see what's required for new utils, you can look at daniel's commit that added mpegutils.cpp/.h |
| [22:51:00] | Captain_Murdoch: | I plan on removing all the old code that was replaced by mythutil, but have been tossing around different ideas of removing it totally or whether to leave behind warnings to direct users to mythutil. I'd rather just make a clean cutover with no junk left lying around in 5+ other directories. |
| [23:00:47] | jams: | markk- so no crash at the end for me with a clean checkup. Does take longer then it used to. |
| [23:01:43] | xavierh (xavierh!~chatzilla@cpc1-swin3-0-0-cust920.3-1.cable.virginmedia.com) has quit (Remote host closed the connection) | |
| [23:01:56] | jams: | Captain_Murdoch- it's all cmdline based, so sounds good. wouldn't be hard to put a ui on top of it but I dropped that a while ago. |
| [23:58:03] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has quit (Quit: jpabq) | |
| [23:58:05] | danielk22: | markk: It was compiled in but disabled. |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.