| Friday, August 26th, 2011, 00:01 UTC | ||
| [00:01:17] | danielk22: | Yeah, I think it's safe to assume that if a function is safe in the windows runtime it's safe in MINGW, but we should probably concentrate stuff like gmtime_r() in compat.h so we can quickly fix if that assumptions proves false. |
| [00:01:35] | Beirdo: | makes sense |
| [00:02:01] | Beirdo: | although having a compat.cpp for the actual code in some cases might be easier on the eyes |
| [00:02:14] | Beirdo: | but sure, let's keep it all in one place |
| [00:02:39] | Beirdo: | the same goes for the PREFIX64 stuff I had to put in for printf (where we use %lld) |
| [00:02:49] | Beirdo: | stupid mingw wants %I64d |
| [00:02:53] | danielk22: | yeah, compat.cpp would be fine. |
| [00:03:25] | Beirdo: | I'll be moving that fun to compat.h too as dbcheck.cpp is whining about %lld as well |
| [00:04:28] | danielk22: | Beirdo: that's because it's passing things down to the windows printf. Although, I think C99 supports long long, so that's kinda weird. |
| [00:04:43] | Beirdo: | yeah. It's crazy :) |
| [00:05:23] | Beirdo: | the more fiddling I've needed to do to get stuff right for Windows, the deeper my dislike of the platform gets |
| [00:07:24] | Beirdo: | hahaha |
| [00:07:34] | Beirdo: | I go to google for DEPLIBS qmake... |
| [00:07:55] | Beirdo: | #1 hit is a pastebin of the mythplugins configure... crap |
| [00:09:25] | Beirdo: | I want one that's NOT our code, please |
| [00:09:28] | Beirdo: | :) |
| [00:09:39] | Beirdo: | or maybe... the qmake docs with that in it |
| [00:14:16] | Beirdo: | oooh, that's our own local .pro variable. |
| [00:14:19] | Beirdo: | duh :) |
| [00:16:00] | stuartm: | https://github.com/danmar/cppcheck/commit/dfe . . . f2e18ebd2acb |
| [00:17:39] | Beirdo: | cool |
| [00:17:50] | stuartm: | that guy has also picked up another of the tickets, so hopefully that will also get fixed soon |
| [00:20:13] | Beirdo: | Hmmm, I wonder. |
| [00:20:33] | stuartm: | I've still not submitted tickets for the font related false positives, or the invalid iterator errors, but if the open tickets are dealt with in the same fashion it will be worth the effort |
| [00:20:49] | Beirdo: | sure seems that way. I like it. |
| [00:37:36] | Beirdo: | yes, I did make sure that I could still build correctly in Linux, I'm not expecting any issues |
| [00:38:16] | Beirdo: | our qmake stuff is a nightmare (to me at least) of interwoven config files |
| [00:44:13] | Beirdo: | Hmm, scheduling for the cppcheck seems to have thought there were no important changes |
| [00:44:24] | Beirdo: | will have to re-educate it |
| [01:04:16] | davide_ (davide_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [01:04:17] | davide_ (davide_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [01:04:17] | davide_ (davide_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [01:05:04] | davide (davide!~david@host103.16.intrusion.com) has quit (Ping timeout: 250 seconds) | |
| [01:13:04] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [01:19:49] | kenni (kenni!~kenni@x1-6-00-00-24-c8-e2-a3.k456.webspeed.dk) has joined #mythtv | |
| [01:19:52] | kenni (kenni!~kenni@x1-6-00-00-24-c8-e2-a3.k456.webspeed.dk) has quit (Changing host) | |
| [01:19:53] | kenni (kenni!~kenni@mythtv/developer/kenni) has joined #mythtv | |
| [01:28:31] | knightr: | danielk22, Kenni is right, strings with newlines don't cause any problem... I had noticed your commits as well but thought you might have noticed a problem with some of them but I don't know of any either... leading/trailing spaces could cause problems with themes (anything that's put in themestrings.h IIRC but not with regular strings that come from normal source code AFAIK... |
| [01:56:29] | danielk22: | knightr: it was years since I noticed a problem so I'll need to revisit this based on what you and kenni have mentioned.. |
| [02:10:16] | ybot (ybot!~quassel@61.14.141.36) has quit (Remote host closed the connection) | |
| [02:10:46] | ybot (ybot!~quassel@61.14.141.36) has joined #mythtv | |
| [02:14:02] | ** Beirdo shakes his fist at buildbot ** | |
| [02:14:26] | Beirdo: | seems all the normal scheduling borked on me |
| [02:14:33] | Beirdo: | easy to fix, I hope :) |
| [02:15:09] | Beirdo: | will find out shortly (as I have another settings.pro tweak to commit after testing that it doens't break linux compiles |
| [02:20:20] | MythBuild (MythBuild!~MythBuild@184-106-209-209.static.cloud-ips.com) has quit (Quit: buildmaster reconfigured: bot disconnecting) | |
| [02:20:32] | MythBuild (MythBuild!~MythBuild@184-106-209-209.static.cloud-ips.com) has joined #mythtv | |
| [02:31:30] | Beirdo: | OK, that looks better |
| [02:33:44] | Beirdo: | hmmm |
| [02:40:14] | Beirdo: | funny, that didn't fail when I tried by hand. |
| [02:58:37] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@unaffiliated/j-e-f-f-a) has quit (Quit: Oh No!!!! ;-)) | |
| [03:01:18] | J-e-f-f-A (J-e-f-f-A!~J-e-f-f-A@unaffiliated/j-e-f-f-a) has joined #mythtv | |
| [03:02:08] | Beirdo: | oh what fun |
| [03:06:30] | MaverickTech (MaverickTech!~MaverickT@dns2.arel.com.au) has quit (Ping timeout: 276 seconds) | |
| [03:11:56] | Beirdo: | there, that should be fixed |
| [03:12:58] | Beirdo: | now what did I break? Sorry, this buildbot upgrade has been horrid. |
| [03:19:08] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv | |
| [03:22:18] | Beirdo: | oh I see. |
| [03:22:38] | Beirdo: | Github is now telling me the repo is https:// I have it configured for git:// |
| [03:30:29] | MythBuild: | build #893 of master-linux-ppc is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . c/builds/893 |
| [03:31:23] | MythBuild: | build #886 of master-freebsd-64bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/886 |
| [03:33:14] | MythBuild: | build #2106 of master-linux-64bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2106 |
| [03:33:27] | MythBuild: | build #1854 of master-linux-32bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/1854 |
| [03:34:26] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [03:40:37] | Beirdo: | YAY |
| [03:40:49] | Beirdo: | now next time it breaks... we'll see it |
| [03:41:04] | MythBuild: | build #652 of master-debian-stable-64bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/652 |
| [03:50:59] | Beirdo: | YAY, Windows build also successful |
| [03:51:24] | Beirdo: | I'm going home, and hope nothing breaks in the meantime. Should be back on in 30min or so |
| [06:12:29] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [06:45:33] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 276 seconds) | |
| [06:55:07] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [07:14:44] | Beirdo: | stuartm: I updated my cppcheck, BTW. It trimmed a few off, I think |
| [07:14:53] | Beirdo: | anyways, I'm off to bed shortly |
| [08:04:12] | stuarta: | my solution to windows being a pain is normally to delete it and install linux |
| [08:06:32] | ** stuarta ponders getting the buildbot to rebuild cppcheck everytime they fix a bug ** | |
| [08:15:33] | ** stuarta eyes up the bootstrap.sh script ** | |
| [10:05:02] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:06:05] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:21:25] | stuartm: | they fixed another false-positive overnight |
| [10:54:43] | kth (kth!~kth@unaffiliated/kth) has quit (Remote host closed the connection) | |
| [11:01:13] | stuarta: | they are good |
| [11:45:07] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [11:50:40] | stuartm: | Captain_Murdoch: http://code.mythtv.org/cppcheck/index.html#L7 << This will leak, I'm just not sure how best to fix it – if we transition from playing something in the database to an arbitrary file we can't just call delete on m_currentMetadata because that will invalidate the pointer in all_music |
| [11:51:46] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [11:57:07] | stuartm: | I suppose one way to do it would be a second member to track/delete arbitrary file metadata so m_currentMetadata can remain unmolested, it's not pretty but it would work |
| [11:58:22] | stuartm: | something like this – http://pastebin.com/m01QeXPQ |
| [12:00:24] | danielk22: | cool, down to 5+11 cppcheck errors+warnings! I believe the iifa errors are bogus (but the code there is a little odd). |
| [12:08:56] | sturebror (sturebror!~foo@2a01:1b0:7999:446:0:6:d7a8:d17c) has left #mythtv () | |
| [12:23:10] | stuartm: | anyone object to backporting the 'always use loopback when local' patch? |
| [12:24:08] | davide_ (davide_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [12:24:35] | davide_ (davide_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [12:24:35] | davide_ (davide_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [12:24:35] | davide_ (davide_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [13:12:32] | GreyFoxx (GreyFoxx!~greg@mythtv/developer/GreyFoxx) has quit (*.net *.split) | |
| [13:19:40] | GreyFoxx (GreyFoxx!~greg@2607:ae00:fff9::1) has joined #mythtv | |
| [13:20:33] | danielk22: | stuartm: I could see it causing the kind of problems people don't expect in a maintenance version... i.e. there configuration is borked in some small way and suddenly things stop working just before they go on vacation. |
| [13:25:19] | stuartm: | yeah, entirely understandable and really the answer I expected when I asked – to some extent my motivations are selfish – I don't want wasting time building from source on my production box but that machines flaky wifi is the reason I wrote it in the first place |
| [13:27:00] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [13:27:15] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [13:46:17] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [13:46:53] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [13:47:10] | kth (kth!~kth@unaffiliated/kth) has quit (Client Quit) | |
| [13:56:24] | stuartm: | before anyone comments, I've already changed my mind about 3b6143cb – in the past someone decided to make those variables mutable and that seems like the way to go for CreateTempDirectory() |
| [13:58:05] | Captain_Murdoch: | stuartm, that musicplayer.cpp leak wasn't my code that I know of. |
| [14:00:15] | iamlindo` (iamlindo`!~iamlindor@c-71-202-67-27.hsd1.ca.comcast.net) has joined #mythtv | |
| [14:00:31] | Anduin_ (Anduin_!~awithers@pdpc/supporter/professional/anduin) has joined #mythtv | |
| [14:00:35] | coling_ (coling_!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
| [14:00:47] | ** Captain_Murdoch thinks it would be nice if github's IRC integration mentioned the actual commit tag so I didn't have to click the shortened URL to find it out. ** | |
| [14:00:54] | stuartm: | Captain_Murdoch: ah, ok, I made an assumption because it was network control related |
| [14:00:58] | hz__ (hz__!~hz@hoiseth.no) has joined #mythtv | |
| [14:01:04] | stuartm: | Captain_Murdoch: agreed |
| [14:01:20] | Captain_Murdoch: | I added the play file for videos but not for music. |
| [14:01:22] | stuartm: | Captain_Murdoch: it used to but they've kept messing with it lately |
| [14:01:37] | joe____ (joe____!~jmk@64.73.32.135) has quit (Ping timeout: 240 seconds) | |
| [14:01:40] | jwhite_ (jwhite_!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has joined #mythtv | |
| [14:01:47] | jwhite (jwhite!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has quit (Ping timeout: 252 seconds) | |
| [14:01:47] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has quit (Ping timeout: 252 seconds) | |
| [14:01:47] | highzeth_ (highzeth_!~hz@hoiseth.no) has quit (Ping timeout: 252 seconds) | |
| [14:01:47] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has quit (Ping timeout: 252 seconds) | |
| [14:01:47] | Anduin (Anduin!~awithers@pdpc/supporter/professional/anduin) has quit (Ping timeout: 252 seconds) | |
| [14:01:49] | stuartm: | Captain_Murdoch: I believe it should be fixed now anyway |
| [14:01:57] | joe___ (joe___!~jmk@64.73.32.135) has joined #mythtv | |
| [14:02:00] | stuartm: | the play_file leak |
| [14:02:00] | skd5aner (skd5aner!~skd5aner@cpe-071-071-242-134.carolina.res.rr.com) has quit (Ping timeout: 240 seconds) | |
| [14:02:00] | kc (kc!~Casper@unaffiliated/kc) has quit (Ping timeout: 240 seconds) | |
| [14:02:31] | kc (kc!~Casper@unaffiliated/kc) has joined #mythtv | |
| [14:02:36] | skd5aner (skd5aner!~skd5aner@cpe-071-071-242-134.carolina.res.rr.com) has joined #mythtv | |
| [14:03:36] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has quit (Ping timeout: 240 seconds) | |
| [14:03:43] | abqjp (abqjp!~jpabq@174-28-172-82.albq.qwest.net) has joined #mythtv | |
| [14:04:04] | abqjp is now known as jpabq | |
| [14:04:04] | jpabq (jpabq!~jpabq@174-28-172-82.albq.qwest.net) has quit (Changing host) | |
| [14:04:04] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has joined #mythtv | |
| [14:05:37] | Captain_Murdoch: | stuartm, next step is to get that cppcheck script to compare the diff of this run vs the last run and see what new errors/warnings there are and then see who made commit(s) to the affected file since the last cppcheck run so we can send out a nastygram. :) |
| [14:06:07] | Captain_Murdoch: | nice work BTW. |
| [14:09:33] | stuartm: | I'm going to suppress the unused variable warnings with cppcheck since gcc is already reporting those and cppcheck won't honour gcc's __attribute__((unused)) aka MUNUSED |
| [14:36:05] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (*.net *.split) | |
| [14:36:06] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has quit (*.net *.split) | |
| [14:36:07] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (*.net *.split) | |
| [14:36:07] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has quit (*.net *.split) | |
| [14:36:07] | sailerboy (sailerboy!sailerboy@ipv61.sailerboy.net) has quit (*.net *.split) | |
| [14:36:07] | sutula (sutula!sutula@nat/hp/x-acemlcpkpaigbggs) has quit (*.net *.split) | |
| [14:36:08] | taylorr (taylorr!~taylorr@unaffiliated/elmojo) has quit (*.net *.split) | |
| [14:36:08] | tris (tris!tristan@2001:1868:a00a::4) has quit (*.net *.split) | |
| [14:36:08] | dekarl (dekarl!~dekarl@dslb-084-058-164-202.pools.arcor-ip.net) has quit (*.net *.split) | |
| [14:36:08] | _charly__ (_charly__!kroseneg@sunrise.schmidham.net) has quit (*.net *.split) | |
| [14:36:08] | laga (laga!~laga@h1626373.stratoserver.net) has quit (*.net *.split) | |
| [14:36:09] | Seeker` (Seeker`!~cjo20@unaffiliated/seeker) has quit (*.net *.split) | |
| [14:36:09] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has quit (*.net *.split) | |
| [14:39:38] | tris (tris!tristan@2001:1868:a00a::4) has joined #mythtv | |
| [14:44:18] | sailerboy (sailerboy!sailerboy@2607:f358:1:fed5:22:0:ece3:d738) has joined #mythtv | |
| [14:44:19] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [14:44:19] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has joined #mythtv | |
| [14:44:19] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [14:44:19] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has joined #mythtv | |
| [14:44:19] | sutula (sutula!sutula@nat/hp/x-acemlcpkpaigbggs) has joined #mythtv | |
| [14:44:19] | taylorr (taylorr!~taylorr@unaffiliated/elmojo) has joined #mythtv | |
| [14:44:19] | dekarl (dekarl!~dekarl@dslb-084-058-164-202.pools.arcor-ip.net) has joined #mythtv | |
| [14:44:19] | _charly__ (_charly__!kroseneg@sunrise.schmidham.net) has joined #mythtv | |
| [14:44:19] | laga (laga!~laga@h1626373.stratoserver.net) has joined #mythtv | |
| [14:44:19] | Seeker` (Seeker`!~cjo20@unaffiliated/seeker) has joined #mythtv | |
| [14:44:19] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has joined #mythtv | |
| [14:52:32] | AnAnt (AnAnt!~anant@sabily/member/anant) has joined #mythtv | |
| [14:52:36] | AnAnt: | Hello, is there a linux software like SkyGrabber ? |
| [14:54:29] | AnAnt (AnAnt!~anant@sabily/member/anant) has left #mythtv () | |
| [15:27:27] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Ping timeout: 264 seconds) | |
| [15:34:29] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [15:36:59] | stuartm: | I've looked at this several times in the past and I don't see a leak, but maybe I'm just seeing what I expect to see, could someone else check it? http://code.mythtv.org/cppcheck/index.html#L2 |
| [15:45:44] | Captain_Murdoch: | is it because the "*newFont = *tmp" copies by value, not the reference, so the value in *tmp is never freed. |
| [15:46:15] | Captain_Murdoch: | stuartm, ^^ |
| [15:49:29] | stuartm: | Captain_Murdoch: the value in tmp remains in the global map and is deleted when the map is deleted |
| [15:50:36] | stuartm: | it's not the easiest code to follow and one day I'll re-write it |
| [15:55:41] | stuartm: | Captain_Murdoch: there was meant to be a question mark at the end of that first reply, that's how I read the code, it doesn't make it a fact :) |
| [15:57:17] | coling_ is now known as coling | |
| [16:01:58] | Captain_Murdoch: | I think it's getting confused because of that line. it's not complaining about the similar code in mythuiguidegrid.cpp when we do almost the same thing but with a non-pointer copy in the middle. ie, *tmp = GetFont(); font = *tmp; *m_font = font; |
| [16:04:16] | stuartm: | Captain_Murdoch: I thought it might be that line so I tried re-arranging it as above and it still complains |
| [16:09:34] | Captain_Murdoch: | may be unrelated, but do we ever delete the global font map? gFontMap in mythfontproperties.cpp? what's the difference between *gFontMap and globalFontMap which is static? one other difference between the usage in those two files is that mythuiguidegrid.cpp doesn't try parent->GetFont(); |
| [16:13:00] | stuartm: | one map is older, it's used for the old UI iirc, the other is it's replacement |
| [16:14:24] | stuartm: | both predate my involvement in mythui so I've only ever been able to guess at the reasons why certain things were done the way they were |
| [16:15:10] | stuartm: | Captain_Murdoch: I don't think the global font maps are explicitly deleted, they are as far as I know just left to be cleaned up when the program exits |
| [16:16:29] | Captain_Murdoch: | you might try commenting out the 'parent->GetFont()' lines in mythfontproperties.cpp and seeing if cppcheck still complains. |
| [16:16:42] | Captain_Murdoch: | that would confirm if it's that difference between the two use cases. |
| [16:17:32] | stoffel (stoffel!~quassel@p57B4CCCD.dip.t-dialin.net) has joined #mythtv | |
| [16:17:58] | stuartm: | it still complains, but if I comment out GetGlobalFontMap()->GetFont() it stops |
| [16:27:13] | Captain_Murdoch: | and that's the one that we don't free up since it uses gFontMap. |
| [16:28:40] | stuartm: | I think we'll just ignore these ones for now unless someone can demonstrate that they are actually leaking |
| [16:29:22] | stuartm: | the old global font map code can be deleted when the mythmusic port is complete, and that will simplify things slightly |
| [16:45:36] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has quit (Quit: Coyote finally caught me) | |
| [16:48:47] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
| [16:48:53] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has quit (Client Quit) | |
| [16:49:10] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
| [16:51:28] | kormoc is now known as kormoc_afk | |
| [17:05:52] | davide_ (davide_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [17:05:52] | davide_ (davide_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [17:05:52] | davide_ (davide_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [17:23:46] | andreax (andreax!~andreaz@p57B91FED.dip.t-dialin.net) has joined #mythtv | |
| [17:28:42] | stuartm: | http://www.theregister.co.uk/2011/08/26/choco . . . ry_tv_to_uk/ |
| [17:35:34] | Mousey (Mousey!~wtfisme@ross154.net) has joined #mythtv | |
| [17:40:44] | stuartm: | heh, another failed fix for the vbi leak false positive |
| [18:01:45] | danielk22: | stuartm: Another false positive? "Technically the member function 'DTVMultiplex::Clear' can be const. mythtv/libs/libmythtv/dtvmultiplex.h:33" |
| [18:07:23] | cattelan_away is now known as cattelan | |
| [18:07:26] | rseward_ (rseward_!18e7bb4a@gateway/web/freenode/ip.24.231.187.74) has quit (Ping timeout: 252 seconds) | |
| [18:09:46] | kormoc_afk is now known as kormoc | |
| [18:17:57] | stuartm: | danielk22: yep, I've made a note and will open a ticket later |
| [18:30:13] | iamlindo` is now known as iamlindoro | |
| [18:30:17] | iamlindoro (iamlindoro!~iamlindor@c-71-202-67-27.hsd1.ca.comcast.net) has quit (Changing host) | |
| [18:30:17] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has joined #mythtv | |
| [18:40:58] | pheld (pheld!zdyggp@109-109-76-195.bb.cust.telefiber.no) has joined #mythtv | |
| [18:53:09] | Beirdo: | MythBuild: force build master-vista-mingw-32bit now |
| [18:53:10] | MythBuild: | build #0 forced |
| [18:53:10] | MythBuild: | I'll give a shout when the build finishes |
| [19:01:25] | Beirdo: | and yes, you read that right :) |
| [19:04:50] | iamlindoro: | Windows doesn't surprise me, but the Vista does |
| [19:04:54] | stoffel (stoffel!~quassel@p57B4CCCD.dip.t-dialin.net) has quit (Read error: No route to host) | |
| [19:05:52] | stoffel (stoffel!~quassel@p57B4CCCD.dip.t-dialin.net) has joined #mythtv | |
| [19:21:09] | stoffel (stoffel!~quassel@p57B4CCCD.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [19:24:32] | Kunalagon (Kunalagon!~Kunalagon@212.200.241.70) has joined #mythtv | |
| [19:24:44] | Kunalagon (Kunalagon!~Kunalagon@212.200.241.70) has quit (Client Quit) | |
| [19:35:07] | stuartm: | no Windows 7? |
| [19:35:50] | stuartm: | Beirdo: how fast is the build?> |
| [19:38:06] | Beirdo: | a little over an hour |
| [19:38:13] | Beirdo: | I don't have Win 7 |
| [19:38:14] | Beirdo: | :) |
| [19:39:23] | stuartm: | Win 7 was a joke :) |
| [19:39:40] | stuartm: | well actually, from what I hear Vista was the joke ... |
| [19:40:32] | stuartm: | Beirdo: well at least if I commit late in evening I'll be fast asleep by the time it reports that I've broken the build ;) |
| [19:41:23] | Beirdo: | hehe |
| [19:41:45] | Beirdo: | true enough. I'm hoping to get ccache in place, apparently there is a version that will work |
| [19:44:53] | Chutt (Chutt!~ijr@cpe-76-190-198-203.neo.res.rr.com) has quit (Read error: Connection reset by peer) | |
| [19:45:19] | pheld (pheld!zdyggp@109-109-76-195.bb.cust.telefiber.no) has quit (Quit: Leaving.) | |
| [19:50:56] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has quit (Remote host closed the connection) | |
| [20:22:40] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has joined #mythtv | |
| [20:22:40] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [20:22:40] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has quit (Changing host) | |
| [20:24:09] | MythBuild: | Hey! build master-vista-mingw-32bit #0 is complete: Success [build successful] |
| [20:24:10] | MythBuild: | Build details are at http://code.mythtv.org/buildbot/builders/mast . . . bit/builds/0 |
| [20:43:00] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has joined #mythtv | |
| [20:43:00] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has quit (Changing host) | |
| [20:43:00] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [20:58:47] | stuartm: | ~90m then |
| [21:05:46] | ghoti (ghoti!~paul@scratch.it.ca) has quit (Read error: Operation timed out) | |
| [21:05:53] | ghoti (ghoti!~paul@scratch.it.ca) has joined #mythtv | |
| [21:10:00] | Beirdo: | yeah, that looks like it |
| [21:10:13] | Beirdo: | heh. most of the warnings are the util.h |
| [21:19:01] | cocoa117 (cocoa117!~cocoa117@188-222-31-239.zone13.bethere.co.uk) has joined #mythtv | |
| [21:23:47] | sraue (sraue!~stephan@xbmc/staff/sraue) has quit (Quit: Ex-Chat) | |
| [21:28:04] | timlegge (timlegge!~tim@mctnnbsa51w-156034063103.dhcp-dynamic.FibreOp.nb.bellaliant.net) has quit (Ping timeout: 245 seconds) | |
| [21:31:11] | sraue (sraue!~stephan@xbmc/staff/sraue) has joined #mythtv | |
| [21:36:02] | sphery: | danielk22: I'm trying to figure out what we're attempting to do with the str_startts bindings at https://github.com/MythTV/mythtv/blob/master/ . . . nfo.cpp#L230 . I'd like to convert it to pass the QDateTime directly, but the less than and greater than str_startts seems wrong to me (and why the :50 seconds instead of the actual value)? |
| [21:36:46] | cocoa117 (cocoa117!~cocoa117@188-222-31-239.zone13.bethere.co.uk) has quit (Ping timeout: 258 seconds) | |
| [21:37:00] | sphery: | and we have a similar :50 at L343 with desiredts... could I just use a desiredts.addSecs(50) for that or does it need to be :50? |
| [21:38:44] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 264 seconds) | |
| [21:38:44] | danielk22: | sphery, that isn't my code originally, but I assume the :50 matters, there is also :00 versions. |
| [21:40:04] | danielk22: | you could achieve the same thing with a QDateTime using something like desiredts.addSecs(50 – desiredts.secs()); |
| [21:40:46] | sphery: | OK, I'll go with that--will prevent us from using the invalid format date string, again :) |
| [21:40:57] | timlegge (timlegge!~tim@mctnnbsa51w-156034063103.dhcp-dynamic.FibreOp.nb.bellaliant.net) has joined #mythtv | |
| [21:41:23] | sphery: | thanks |
| [21:47:21] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has quit (Remote host closed the connection) | |
| [21:58:41] | stuartm: | I've the vaguest memory of the 50 second stuff being added, and there was a reason for it ... but I can't remember anything useful :/ |
| [21:59:41] | stuartm: | this is one of those examples where in-line comments should have been added to explain code which doesn't have an obvious explanation |
| [22:03:20] | gezb10 (gezb10!gezb10@cpc2-aztw7-0-0-cust90.aztw.cable.virginmedia.com) has joined #mythtv | |
| [22:06:09] | gezb10: | Hi, what is the prefered way of providing a bugfix to mythtv now, is it still to attach a patch to a Trac ticket, or should I make a fix in github and send a pull request |
| [22:07:22] | sphery: | Yeah, I half-remember something about the "increment seconds by 1 until we have a unique filename, but if we hit 50 we'll have a problem", but I'm still very confused about program.starttime < :STARTTS1 AND program.endtime > :STARTTS2 where both are given the value str_startts = desiredts.toString("yyyy-MM-ddThh:mm:50"); |
| [22:08:04] | sphery: | gezb10: we still want a ticket in Trac for tracking purposes at the least... If you'd like to do a pull request, feel free to do so, but then please also provide the link to the pull request in a ticket |
| [22:08:41] | sphery: | or you can just attach a patch to the ticket if that's easier for you |
| [22:09:43] | gezb10: | Ok I'll do it as a patch, my fix is a simple one line change to mytharchive. Currently you cant import native archives because the parameter name for MythArchiveHelper has changed. |
| [22:12:01] | danielk22: | sphery: maybe it would help to look at the history of that line? |
| [22:12:07] | sphery: | danielk22: in https://github.com/MythTV/mythtv/commit/63b999eae , you changed it to bind the QDateTime m_searchTime directly , but in master, we have the line: bindings[":PGILSEARCHTIME1"] = m_searchTime.toString("yyyy-MM-dd hh:00:00"); ( https://github.com/MythTV/mythtv/blob/master/ . . . st.cpp#L1295 ). Are you certain we don't need the 0 for min/seconds? |
| [22:13:03] | sphery: | and, yeah, I probably should track the history... was hoping to not have to do that because if its having been moved around |
| [22:14:08] | sphery: | (Loading the programinfo refactor commits in the browser from github maxes out my CPU for many minutes :( ) |
| [22:15:22] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [22:15:44] | danielk22: | sphery: hmm, that's one of those things that needs to be re-implemented for UTC.. some timezones depart from UTC by 30 minutes, not an hour.. |
| [22:16:34] | danielk22: | (At least one timezone with 1 billion ppl that I can think of India). |
| [22:21:18] | sphery: | ah, so it's just trying to get the nearest hour to the search time... seems using the actual search time would make sense, then--even if we take into account time zone, not all broadcasts start at the hour (some can be +/- a few minutes on different channels--or at "random" times on things like HBO) |
| [22:21:35] | sphery: | so I like your approach |
| [22:25:24] | stuartm: | the search time is for timeslot recordings? |
| [22:26:50] | stuartm: | I remember some discussion about introducing more leeway on timeslot recordings so that programmes which had been shifted +/- 30 or more minutes would still be recorded |
| [22:28:52] | hz__ is now known as hz | |
| [22:29:15] | sphery: | Since this is in mythfrontend dir (and not a lib), I'm guessing it's just for the frontend's many search views--the ones you were talking about consolidating/removing as appropriate |
| [22:31:27] | ThisNewGuy (ThisNewGuy!~doug@pool-98-109-19-98.nwrknj.fios.verizon.net) has quit (Quit: Leaving.) | |
| [22:31:59] | stuartm: | I wasn't paying close enough attention :) |
| [22:37:29] | gezb10 (gezb10!gezb10@cpc2-aztw7-0-0-cust90.aztw.cable.virginmedia.com) has quit () | |
| [23:41:54] | moodboom (moodboom!~moodboom@pdpc/supporter/active/moodboom) has quit (Quit: Leaving) | |
| [23:44:32] | andreax (andreax!~andreaz@p57B91FED.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [23:47:27] | Chutt (Chutt!~ijr@cpe-76-190-198-203.neo.res.rr.com) has joined #mythtv | |
| [23:53:47] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Quit: Leaving) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.