| Thursday, August 25th, 2011, 00:01 UTC | ||
| [00:01:10] | kormoc_afk is now known as kormoc | |
| [00:42:46] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [01:03:29] | davide (davide!~david@host103.16.intrusion.com) has quit (Remote host closed the connection) | |
| [01:03:55] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [01:07:21] | mrand (mrand!~mrand@ubuntu/member/mrand) has left #mythtv () | |
| [01:50:38] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
| [02:11:11] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has quit (Ping timeout: 240 seconds) | |
| [02:18:33] | kormoc is now known as kormoc_afk | |
| [02:39:26] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
| [03:04:12] | danielk22: | stuartm: yep, the changes are only in master. it's the mthread change. |
| [03:11:10] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has quit (Remote host closed the connection) | |
| [03:15:41] | wahrhaft (wahrhaft!~quassel@cpe-24-210-71-26.columbus.res.rr.com) has quit (Ping timeout: 240 seconds) | |
| [03:17:11] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [03:42:42] | rseward_ (rseward_!18e7bb4a@gateway/web/freenode/ip.24.231.187.74) has joined #mythtv | |
| [03:56:33] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [04:00:42] | kormoc_afk is now known as kormoc | |
| [05:24:34] | stoffel (stoffel!~quassel@p57B4A79C.dip.t-dialin.net) has joined #mythtv | |
| [05:48:47] | stoffel (stoffel!~quassel@p57B4A79C.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [06:00:47] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has quit (Ping timeout: 264 seconds) | |
| [06:02:41] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [06:14:17] | Captain_Murdoch (Captain_Murdoch!~cpinkham@ip72-218-58-187.hr.hr.cox.net) has joined #mythtv | |
| [06:14:17] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has joined #mythtv | |
| [06:14:17] | Captain_Murdoch (Captain_Murdoch!~cpinkham@ip72-218-58-187.hr.hr.cox.net) has quit (Changing host) | |
| [06:41:17] | Agrajag- (Agrajag-!~filip@c58-111-134-254.artrmn3.nsw.optusnet.com.au) has joined #mythtv | |
| [06:51:44] | Beirdo: | danielk22: should we be good to replace a random() with qrand() now that you have it doing qsrand() in each mthread startup? |
| [06:52:20] | Beirdo: | I'm looking at the error (in mingw) for Programs.cpp in libmythfreemheg |
| [06:52:45] | Beirdo: | looks like I should be able to make that a qrand() and #include <QtGlobal> and it should be good to go |
| [06:54:24] | Beirdo: | I have that ready to commit and try. Compiling it by hand in Windows is working. |
| [06:54:49] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 240 seconds) | |
| [06:58:08] | Beirdo: | Actually, I think I'll commit, feel free to redo it if needed. I just wanna see this thing compile completely :) |
| [07:07:40] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [07:08:28] | kth (kth!~kth@unaffiliated/kth) has quit (Client Quit) | |
| [07:17:09] | Agrajag- (Agrajag-!~filip@c58-111-134-254.artrmn3.nsw.optusnet.com.au) has quit (Quit: BitchX for president.) | |
| [08:14:57] | Beirdo: | hehe, stupid git in windows. I set the user.name to "Gavin Hurlbut" (with quotes), it dropped the lastname anyways. Gotta love Windoze |
| [08:15:41] | Beirdo: | fixed the config by hand, but whatever...one extras commit has no last name. At least the email's right |
| [08:16:18] | _klk_ (_klk_!~Adium@208.90.215.163) has quit (Quit: Leaving.) | |
| [08:30:45] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has quit (Ping timeout: 260 seconds) | |
| [08:43:18] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has joined #mythtv | |
| [09:55:06] | stuartm: | define random() as qrand() in compat.h for windows? |
| [09:56:19] | stuartm: | which I now notice is exactly what was done ... |
| [10:03:21] | MythBuild: | build #2096 of master-linux-64bit is complete: Exception [exception interrupted] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2096 blamelist: Gavin Hurlbut <ghurlbut@mythtv.org > |
| [10:05:02] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:05:42] | Beirdo: | yeah |
| [10:05:54] | Beirdo: | I just noticed, so I changed it to use that |
| [10:05:58] | Beirdo: | Oh WTF? |
| [10:05:58] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:06:09] | Beirdo: | oh that was me restarting the slave |
| [10:06:10] | Beirdo: | hehe |
| [10:06:26] | Beirdo: | MythBuild: force build master-linux-64bit now |
| [10:06:26] | MythBuild: | build forced [ETA 6m06s] |
| [10:06:26] | MythBuild: | I'll give a shout when the build finishes |
| [10:10:48] | MythBuild: | Hey! build master-linux-64bit #2097 is complete: Success [build successful] |
| [10:10:48] | MythBuild: | Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/2097 |
| [10:11:06] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [10:11:29] | Beirdo: | And I have the cppcheck one almost ready... at the point of needing to upgrade cppcheck now :) |
| [10:13:35] | kth (kth!~kth@unaffiliated/kth) has quit (Client Quit) | |
| [10:17:26] | ** stuarta hides quietly in the corner ** | |
| [10:18:11] | Beirdo: | cppcheck: unusedFunction check can't be used with -j option, so it was disabled. |
| [10:18:12] | Beirdo: | heh |
| [10:18:28] | Beirdo: | stuarta: how's yer OSX buildslave coming along? |
| [10:18:42] | stuarta: | that'll be why i was hiding :) |
| [10:18:54] | stuarta: | zero progress |
| [10:19:04] | stuarta: | bloody decorating house :( |
| [10:19:22] | stuarta: | not even had a chance to cutover to my new prod backend :( |
| [10:19:55] | Beirdo: | ahh |
| [10:19:59] | Beirdo: | it happens |
| [10:20:04] | stuarta: | constantly |
| [10:20:28] | Beirdo: | yeah, life does seem to keep getting in the way of fun :) |
| [10:20:46] | stuarta: | parents over for the next 3.5weeks, so doubt i'm going to make any osx buildbot progress |
| [10:20:58] | stuarta: | hopefully have an evening to cutover the backend |
| [10:21:37] | Beirdo: | cool |
| [10:21:41] | Beirdo: | well, good to know |
| [10:22:09] | stuarta: | on the bright side the new backend has sufficient memory and hopefully cpu to run a few kvm vm's |
| [10:22:46] | stuarta: | which ideally means i can add additional debian build slaves |
| [10:22:54] | stuarta: | and share the love |
| [10:23:35] | stuarta: | yours are ubuntu aren't they? |
| [10:23:50] | Beirdo: | yeah, they are |
| [10:24:07] | stuarta: | you going to keep one on the LTS release and one on current? |
| [10:24:14] | Beirdo: | and the ppc one (no longer using mine) is debian |
| [10:24:34] | Beirdo: | nah, they are both on LTS, but with upgraded packages |
| [10:24:50] | stuarta: | special upgrades? ;-) |
| [10:24:59] | Beirdo: | I haven't had a chance to even consider using latest ubuntu |
| [10:25:11] | stuarta: | well the new backend is ubuntu server |
| [10:25:15] | Beirdo: | heh, usually forklift upgrades from newer distros |
| [10:25:31] | Beirdo: | yeah, ubuntu server LTS is what I have here |
| [10:26:00] | Beirdo: | things like libx264, for instance... much newer than 10.04.2 LTS package |
| [10:26:01] | stuarta: | same |
| [10:26:18] | Beirdo: | I think I have 11.04 package there.. maybe 10.10, can't remember |
| [10:26:30] | stuarta: | i try and keep them stock, so that we know it builds on the LTS release (or debian stable) |
| [10:27:16] | Beirdo: | yeah, that's generally a good plan. I don't think I've upgraded much. libx264 is the only one I recall off-hand |
| [10:27:38] | Beirdo: | and it's only used to allow mythffmpeg to encode H264 for nuvexport |
| [10:27:42] | stuarta: | particularly debian, as it'll be the last to move beyond Qt4.6 |
| [10:27:49] | Beirdo: | so not even needed for the usual builds |
| [10:27:55] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [10:28:00] | stuarta: | ubuntu is already on 4.7, debian stable is still 4.6 |
| [10:28:24] | stuarta: | centos5 is much the same |
| [10:29:12] | Beirdo: | aye |
| [10:29:50] | stuarta: | now i'll just have to work out how to have a local git master that auto syncs from our master so i don't pull the same updates 3 times... |
| [10:30:06] | stuarta: | which i'm sure is easy |
| [10:30:33] | ** stuarta decides it's time for a cuppa ** | |
| [10:30:34] | Beirdo: | heh |
| [10:30:49] | Beirdo: | it's time (well past it actually) for me to go to bed |
| [10:31:02] | Beirdo: | 3:30am... what, am I in University again? |
| [10:35:23] | Beirdo: | so, as soon as this cppcheck run finishes, I'm retiring for the night |
| [10:36:25] | stuarta: | almost time to get up again |
| [10:36:28] | stuartm: | Beirdo: there was the script which sets up symlinks and other magic, I can't remember what it's called right now |
| [10:37:22] | stuartm: | I used it here to have two copies, one for development and one for building from, only one git pull required, but I do have to 'reset --hard' the other to sync it |
| [10:42:54] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [10:43:38] | Beirdo: | buildbot was most definitely unhappy with the lack of #!/bin/bash on that script, BTW :) |
| [10:44:26] | Beirdo: | oooh, libmythfreemheg compiled. w00t |
| [10:44:49] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [10:45:02] | stuartm: | Beirdo: heh |
| [10:46:08] | Beirdo: | I'll have it all done tomorrow, I hope (both windows and cppcheck) |
| [10:46:29] | Beirdo: | the windows one will need a README to say exactly what to download, etc |
| [10:46:54] | Beirdo: | and how many chickens and/or goats to sacrifice, and at what points |
| [10:46:57] | stuartm: | that does explain the warnings I was getting from the rsync portion, it kept complaining something about no shell, which should have been my first clue |
| [10:47:51] | Beirdo: | takes about 8min to run on my backend box |
| [10:47:53] | Beirdo: | not bad |
| [10:48:03] | stuartm: | yeah, half the time that it takes here |
| [10:48:26] | stuartm: | it was a lot worse before I added the config args, over an hour |
| [10:48:37] | Beirdo: | yikes |
| [10:49:17] | stuartm: | since it would check each file with an ifdef multiple times in all possible combinations of configurations |
| [10:49:38] | Beirdo: | many of which are impossible, I'd imagine |
| [10:50:51] | stuartm: | aye, it's something that the cppcheck devs are well aware of, they are talking about dropping the --force behaviour and only checking the most widely used defines or similar |
| [10:54:03] | Beirdo: | OK, Pretty sure this has got it. |
| [10:54:33] | Beirdo: | I ran the last two steps by hand this time as I had a wee typo |
| [10:54:51] | Beirdo: | and I didn't feel like running it manually again tonight |
| [10:55:19] | Beirdo: | but it's on my development buildbot setup, and should rerun at every commit to either extras or to mythtv |
| [10:55:39] | stuartm: | cool |
| [10:55:53] | Beirdo: | and if it is still looking good tomorrow, I'll move it over and we can run it every 6h, 2h, whatever |
| [10:56:14] | Beirdo: | it can run on my box for now if ya want, it doesn't seem to really affect it much :) |
| [10:56:43] | Beirdo: | the rsync also worked, so the copy up there should be the one I pushed |
| [10:56:58] | Beirdo: | yeah, if you update the exceptions file, it will rebuild :) |
| [10:57:37] | stuartm: | Beirdo: timestamp at the bottom should prove that |
| [10:57:45] | Beirdo: | yup, it does |
| [10:58:03] | Beirdo: | oh, and if you change the script (add new -D options), it will see that too |
| [10:58:15] | stuartm: | nice! |
| [10:59:02] | Beirdo: | took a bit of work to get buildslave to like pulling from two repos (ultimately needed an upgraded buildslave version) |
| [10:59:08] | Beirdo: | but it's workin |
| [10:59:41] | stuartm: | I wonder if using the includes option (-I) would give us any useful warnings, something for me to try locally I guess |
| [10:59:58] | stuartm: | Beirdo: great work, have a beer on me :) |
| [11:00:01] | Beirdo: | yeah, it's possible :) |
| [11:00:22] | Beirdo: | thanks :) I'll do that tomorrow :) 4am is a good bedtime :) |
| [11:00:42] | Beirdo: | and thanks for getting it all setup :) |
| [11:01:06] | Beirdo: | the more tools like this we can have autogenerate us reports that are useful... the better |
| [11:01:51] | Beirdo: | night all |
| [11:01:57] | stuarta: | nn |
| [11:04:17] | stuartm: | I could take another look at krazy, some of the warnings that generates are about mis-use or dangerous usage of QT features but it's also tailored pretty specifically to the KDE coding standards and preferences ... |
| [11:07:44] | stuartm: | it would be great if Nick could share his translation status scripts so that we could have those run by buildbot and the results hosted on the server |
| [11:12:41] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [11:13:21] | knightr: | stuartm, he did make them available (he announced it a while ago IIRC) they are on github I think... |
| [11:13:46] | stuartm: | knightr: ah, ok, that's good news |
| [11:14:18] | knightr: | stuartm, https://github.com/knowledgejunkie/mythtv-translation-status |
| [11:15:20] | knightr: | announcement was here http://www.mythtv.org/pipermail/mythtv-transl . . . /000143.html |
| [11:15:36] | knightr: | ttyl, I have to get ready for work... |
| [11:18:04] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Ping timeout: 245 seconds) | |
| [11:18:23] | stuartm: | knightr: hmm, I remember reading that now :) |
| [11:18:44] | stuartm: | Beirdo: so, translation scripts ^^ |
| [12:04:54] | davide (davide!~david@host103.16.intrusion.com) has quit (Remote host closed the connection) | |
| [12:05:22] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [12:05:45] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [12:20:10] | Goga777 (Goga777!~Goga777@shpd-95-53-177-107.vologda.ru) has joined #mythtv | |
| [12:26:09] | stuartm: | I've just been reading up on random() and it's a macro calling rand(), so no more thread-safe than rand()? The re-entrant version is random_r()? |
| [12:39:25] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
| [12:40:52] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [12:47:25] | danielk22: | stuartm: random() is thread-safe where available. But it gets it's thread-safety via a mutex so it imposes synchronization which isn't ideal. |
| [12:48:15] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [12:50:09] | stuartm: | fair enough, that wasn't detailed in the man page but the existence of random_r() hinted that random() might not be thread safe after all |
| [12:50:19] | danielk22: | stuartm: random_r() is like rand_r() in that it allows a predictable sequence of numbers. Both functions are re-entrant, but random_r has much better randomness in the lower order bits. |
| [12:51:32] | danielk22: | stuartm: to add confusion on linux rand() is actually thread-safe.. not so on OSX/FreeBSD. |
| [12:52:47] | stuartm: | heh |
| [12:58:15] | stuartm: | http://code.mythtv.org/cppcheck/index.html#L192 << Not strictly false positives since _ptrs is mutable but do we want to suppress these anyway? |
| [13:02:31] | danielk22: | stuartm: Yeah, but they should be checked first. We don't want to disable a warning for a set that's a stub and doesn't actually set anything. |
| [13:05:38] | Goga777 (Goga777!~Goga777@shpd-95-53-177-107.vologda.ru) has quit (Read error: Connection reset by peer) | |
| [13:06:30] | Goga777 (Goga777!~Goga777@shpd-95-53-177-107.vologda.ru) has joined #mythtv | |
| [13:07:47] | danielk22: | SetStreamProgramInfo and SetProgramInfo look scary, there is no checking to make sure we're not writing off the end of the array. |
| [13:11:11] | danielk22: | In practice we have 4k to play with.. but still.. |
| [13:15:02] | danielk22: | stuartm: #202 should be suppressed, SetupDeinterlace() can't be const because it is an override that has to have the same signature as the SetupDeinterlace() in the parent and siblings. |
| [13:16:15] | stuartm: | I'll report that one too |
| [13:16:50] | stuartm: | assuming you don't want to |
| [13:27:10] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [14:05:59] | stuartm: | https://sourceforge.net/apps/trac/cppcheck/ticket/3049 |
| [14:07:32] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [14:12:47] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Ping timeout: 264 seconds) | |
| [14:21:03] | Goga777 (Goga777!~Goga777@shpd-95-53-177-107.vologda.ru) has quit (Remote host closed the connection) | |
| [15:03:10] | stuartm: | danielk22: for the record, MUNUSED does suppress the gcc set-but-unused warnings |
| [15:04:15] | stuartm: | it says as much here – http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html |
| [15:16:03] | MythBuild: | build #886 of master-linux-ppc is complete: Failure [failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . c/builds/886 blamelist: Stuart Morgan <smorgan@mythtv.org > |
| [15:40:46] | kenni: | Beirdo: I got a new job, so I don't have access to the datacenter anymore...however, if badly needed, I can always setup a Windows VM on my server at home, dedicated to the buildbot. |
| [15:42:17] | ** stuarta tries to work out how stuartm broke the build ** | |
| [15:42:52] | stuartm: | wait, what? |
| [15:43:16] | danielk22: | hmm, stuartm mythcorecontext.h changed but not mythversion.h ? |
| [15:45:52] | stuarta: | dunno what that compiler is on about, we aren't even passing it that flag |
| [15:46:00] | stuartm: | oversight, fixed, but I'm not sure how that explains the ppc build failure |
| [15:46:18] | stuartm: | g++: fatal error: -fuse-linker-plugin, but liblto_plugin.so not found |
| [15:47:19] | stuartm: | I'm going to force a cppcheck update since Beirdo hasn't got the cppcheck slave online yet |
| [15:47:52] | stuarta: | we don't even use the -fuse-linker-plugin flag |
| [15:48:29] | stuartm: | there isn't much about the osx/windows builds that makes sense to me |
| [15:48:55] | stuarta: | well you won't get any osx buildbot failures atm :) |
| [15:49:26] | stuartm: | the ppc build isn't osx? |
| [15:49:38] | stuartm: | ah, it says linux-ppc |
| [15:49:53] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [15:49:59] | stuartm: | hmm |
| [15:50:27] | j-rod|afk is now known as j-rod | |
| [15:51:32] | stuarta: | i think that's running ubuntu |
| [15:51:49] | stuarta: | debian |
| [15:51:59] | stuarta: | http://code.mythtv.org/buildbot/buildslaves/mousey-linux-ppc |
| [16:11:44] | kenni: | danielk22: Embedded newline and tabulator chars in i18n strings are fully supported by the Qt translation tools, so no need to "fix" them :) That will just generate two separate strings, which can be harder to translate individually. |
| [16:14:19] | hz (hz!~hz@hoiseth.no) has quit (Disconnected by services) | |
| [16:14:43] | highzeth_ (highzeth_!~hz@hoiseth.no) has joined #mythtv | |
| [16:38:44] | danielk22: | kenni: Really? is that a Qt4 thing? What about leading and trailing spaces? |
| [17:04:46] | davide (davide!~david@host103.16.intrusion.com) has quit (Remote host closed the connection) | |
| [17:05:16] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [17:10:20] | Beirdo: | kenni: not a problem. I can host it for now until a point where someone else feels like taking it on or has the available equipment. I have it working in a VM as it is, works OK, mostly |
| [17:10:54] | Beirdo: | jobs do change :) |
| [17:19:29] | Mousey (Mousey!~wtfisme@ross154.net) has joined #mythtv | |
| [17:26:52] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [17:34:51] | stoffel (stoffel!~quassel@p57B4B639.dip.t-dialin.net) has joined #mythtv | |
| [17:37:54] | MythBuild: | build #888 of master-linux-ppc is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . c/builds/888 |
| [17:41:37] | ghoti (ghoti!~paul@scratch.it.ca) has quit (Read error: Operation timed out) | |
| [17:45:41] | Beirdo: | OMG. |
| [17:45:55] | Beirdo: | the windows build is in "installing core" :) |
| [17:50:21] | stoffel (stoffel!~quassel@p57B4B639.dip.t-dialin.net) has quit (Ping timeout: 252 seconds) | |
| [17:52:51] | Beirdo: | and we crap out in compile plugins. Big surprise |
| [17:53:44] | Beirdo: | can't find libs and external includes. that's likely a buildbot config issue |
| [17:54:34] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [17:58:27] | Beirdo: | OK, that should sort itself out after this config change, i think |
| [17:59:17] | Beirdo: | and meeting time |
| [18:30:14] | mrand (mrand!~mrand@ubuntu/member/mrand) has quit (Ping timeout: 246 seconds) | |
| [18:31:29] | stoffel (stoffel!~quassel@p57B4B639.dip.t-dialin.net) has joined #mythtv | |
| [18:32:00] | stuartm: | vbi.c false positive has been fixed |
| [18:32:10] | mrand (mrand!~mrand@ubuntu/member/mrand) has joined #mythtv | |
| [18:33:51] | danielk22: | heh, those guys are fast :) |
| [18:47:49] | andreax (andreax!~andreaz@p57B93087.dip.t-dialin.net) has joined #mythtv | |
| [18:50:34] | stuartm: | danielk22: they definitely don't hang around when it comes to false positives and most are fixed quickly, but in total they've got more open tickets than we have and it's a much smaller, younger project |
| [18:50:47] | stuartm: | https://sourceforge.net/apps/trac/cppcheck/ticket/3038#comment:5 |
| [18:51:30] | stuartm: | 510 active tickets vs our 349 |
| [18:54:15] | ghoti (ghoti!~paul@scratch.it.ca) has joined #mythtv | |
| [18:59:01] | _klk_ (_klk_!~Adium@208.90.215.163) has joined #mythtv | |
| [19:11:00] | stuartm: | Beirdo: the non-waterfall views in buildbot are very slow atm? |
| [19:13:51] | wagnerrp: | they seem quick enough to me |
| [19:14:05] | Beirdo: | which one? the code.mythtv.org one, or my test one? |
| [19:14:24] | wagnerrp: | perhaps not |
| [19:14:25] | Beirdo: | YAY, successful cppcheck run |
| [19:15:47] | wagnerrp: | does the buildbot possibly have the same sqlite locking issue as trac? |
| [19:16:19] | Beirdo: | I haven't heard of one |
| [19:16:45] | Beirdo: | it's pretty snappy for me |
| [19:17:23] | wagnerrp: | try it right now |
| [19:18:14] | Beirdo: | intersesting |
| [19:18:46] | wagnerrp: | it seems to stall on the grid view |
| [19:18:53] | wagnerrp: | and locks out any other access while its stalled |
| [19:19:50] | Beirdo: | it might need an upgrade on the server side |
| [19:21:28] | wagnerrp: | its consistently taking 38 seconds |
| [19:21:31] | Beirdo: | I'll look around to see if they've mentioned such fun. |
| [19:21:40] | Beirdo: | only on the grid? |
| [19:21:51] | wagnerrp: | grid and t-grid |
| [19:22:49] | Beirdo: | hmm, interesting data points. I'll toy with it tonight, I guess |
| [19:24:23] | Beirdo: | it's certainly loading a lot from on-disk pickles |
| [19:24:54] | Beirdo: | like seemingly... every build!? |
| [19:25:05] | Beirdo: | OK, this is hopefully something they've fixed since |
| [19:27:15] | wagnerrp: | i can understand the client pickling stuff |
| [19:27:22] | wagnerrp: | but why wouldnt the server be using a database? |
| [19:27:59] | Beirdo: | not quite sure :) |
| [19:28:05] | Beirdo: | it does use sqlite |
| [19:35:17] | schwinn434 (schwinn434!~jimmy@adsl-98-93-66-67.owb.bellsouth.net) has joined #mythtv | |
| [19:35:32] | schwinn434 (schwinn434!~jimmy@adsl-98-93-66-67.owb.bellsouth.net) has quit (Quit: Ex-Chat) | |
| [19:36:02] | schwinn434 (schwinn434!~jimmy@adsl-98-93-66-67.owb.bellsouth.net) has joined #mythtv | |
| [19:49:59] | schwinn434 (schwinn434!~jimmy@adsl-98-93-66-67.owb.bellsouth.net) has quit (Quit: Ex-Chat) | |
| [19:50:34] | schwinn434 (schwinn434!~jimmy@adsl-98-93-66-67.owb.bellsouth.net) has joined #mythtv | |
| [20:15:31] | DjMadness_ is now known as DjMadness | |
| [20:15:36] | DjMadness (DjMadness!~DjMadness@91.215.159.77) has quit (Changing host) | |
| [20:15:37] | DjMadness (DjMadness!~DjMadness@pdpc/supporter/student/DjMadness) has joined #mythtv | |
| [20:25:52] | Beirdo: | I guess I really need to get cppcheck working |
| [20:25:55] | Beirdo: | err |
| [20:26:01] | ** Beirdo slaps himself ** | |
| [20:26:02] | Beirdo: | ccache |
| [20:38:22] | stoffel (stoffel!~quassel@p57B4B639.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [20:42:36] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [20:46:14] | schwinn434: | hello |
| [20:49:29] | MythBuild (MythBuild!~MythBuild@184-106-209-209.static.cloud-ips.com) has quit (Quit: buildmaster reconfigured: bot disconnecting) | |
| [20:50:39] | MythBuild (MythBuild!~MythBuild@184-106-209-209.static.cloud-ips.com) has joined #mythtv | |
| [20:51:13] | Beirdo: | wow, that was a rude upgrade |
| [20:51:14] | Beirdo: | :) |
| [20:52:29] | Beirdo: | MythBuild: force build cppcheck-master now |
| [20:52:30] | MythBuild: | build #0 forced |
| [20:52:30] | MythBuild: | I'll give a shout when the build finishes |
| [20:53:11] | Beirdo: | To all... our buildbot is now running more current code (0.8.4p2 instead of 0.8.2) |
| [20:53:29] | Beirdo: | please poke me if you see things acting massively differently than before |
| [20:58:25] | Beirdo: | stuartm: I put the cppcheck as a every 2h schedule for now, at :15 |
| [20:59:34] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [21:00:40] | wagnerrp: | Beirdo: meaning it will run at most every 2 hours? |
| [21:01:02] | Beirdo: | yes |
| [21:01:15] | Beirdo: | if there are no changes, it should skip the run |
| [21:01:44] | Beirdo: | otherwise, if there are changes in mythtv or extras, it will run at (even hour):15 |
| [21:01:57] | Beirdo: | with hours defined at GMT, I believe |
| [21:02:12] | wagnerrp: | oh, so its not commit triggered |
| [21:02:24] | Beirdo: | it is on a schedule |
| [21:02:40] | Beirdo: | commits trigger whether or not to run at the scheduled time |
| [21:02:47] | Beirdo: | just like the doxygen every 6h |
| [21:04:12] | kenni (kenni!~kenni@mythtv/developer/kenni) has quit (Ping timeout: 240 seconds) | |
| [21:05:56] | MythBuild: | Hey! build cppcheck-master #0 is complete: Success [build successful] |
| [21:05:56] | MythBuild: | Build details are at http://code.mythtv.org/buildbot/builders/cppc . . . ter/builds/0 |
| [21:06:22] | stuartm: | Beirdo: http://code.mythtv.org/cppcheck/index.html |
| [21:07:25] | Beirdo: | how the... |
| [21:07:49] | Beirdo: | it worked fine pushing from my test buildbot, but not from the live one? |
| [21:07:51] | Beirdo: | I'll fix that :) |
| [21:08:51] | Beirdo: | OK, hand-fixed the file in place, now to add a rule to chmod that. |
| [21:12:24] | Beirdo: | OK, next run, it should behave right. I now have it chmod before rsyncing |
| [21:12:38] | Beirdo: | which I had to do for the doxygen too |
| [21:12:59] | Beirdo: | must be a hidden setting somewhere for the umask |
| [21:13:01] | stuartm: | heh, the vbi false positive isn't fixed |
| [21:14:07] | Beirdo: | the cppcheck I'm running is a git pull from last night, so it should be about as new as we can get |
| [21:28:18] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Read error: Operation timed out) | |
| [21:35:21] | jya (jya!~jyavenard@60-242-40-141.static.tpgi.com.au) has joined #mythtv | |
| [21:35:22] | jya (jya!~jyavenard@60-242-40-141.static.tpgi.com.au) has quit (Changing host) | |
| [21:35:22] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [21:38:53] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Read error: Connection reset by peer) | |
| [21:39:16] | jya (jya!~jyavenard@60-242-40-141.static.tpgi.com.au) has joined #mythtv | |
| [21:39:17] | jya (jya!~jyavenard@60-242-40-141.static.tpgi.com.au) has quit (Changing host) | |
| [21:39:17] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [21:44:11] | stuartm: | yeah, seems the committed fix didn't actually solve it |
| [21:45:00] | stuartm: | Beirdo: the fix was committed 3–4 hours ago, but I can still reproduce it |
| [21:45:41] | Beirdo: | oh :) |
| [21:46:07] | Beirdo: | yeah, let me know if I need to update my cppcheck install as we go along. It's a 5min task if that, not a problem |
| [21:46:46] | stuartm: | danielk22: are we sure that the vbi leak is a false positive? I don't claim to have a tight grip on that code but reading through I can't see where it's freed – it's detached from the vbi struct before the vbi struct is deleted and I can't see any code to delete the vbi_client struct |
| [21:48:10] | stuartm: | and does this simplified test case look correct? http://pastebin.com/vCipRm2u |
| [22:00:33] | danielk22: | stuartm: I didn't review the code past the comment saying that it wasn't broken. |
| [22:02:00] | danielk22: | The reasoning in the comment sounded reasonable. :) |
| [22:02:53] | stuartm: | I can still reproduce the warning with the test case I wrote so it may still be a false positive, but I need someone else to decide that the test case is correct before I re-open the ticket |
| [22:03:25] | danielk22: | k, I can take a look this weekend. things are a bit crazy w/work atm. |
| [22:08:47] | stuartm: | the bit I'm unsure about is whether it's fine to cast the ptr to the struct type and then call free ... it _seems_ correct to me but my experience of pure C is limited |
| [22:10:01] | danielk22: | stuartm: it's ugly but legal. |
| [22:10:18] | stuartm: | that's all that matters |
| [22:10:57] | stuartm: | IMHO referencing the struct by it's first element is ugly, but equally legal |
| [22:11:27] | danielk22: | yup. |
| [22:12:35] | stuartm: | where did that code come from anyway? |
| [22:13:06] | danielk22: | I think it was VLC.. I wasn't the one who imported it. |
| [22:13:28] | danielk22: | There should be a copyright notice in there somewhere. |
| [22:16:04] | stuartm: | if the following applies to all the code, it came from xawtv and was modified by Robert Kulagowski – https://github.com/MythTV/mythtv/blob/master/ . . . itext/cc.cpp |
| [22:16:28] | stuartm: | I never knew that he did anything except contributions to documentation |
| [22:16:31] | danielk22: | heh, xawtv! we may be the only ones maintaining that code :) |
| [22:17:16] | stuartm: | danielk22: yeah, slim hope of finding an improved copy to re-sync from |
| [22:20:57] | MaverickTech (MaverickTech!~MaverickT@dns2.arel.com.au) has joined #mythtv | |
| [22:25:10] | Beirdo: | I guess I'll be kicking the windows buildslave around tonight to get the plugins to compile. |
| [22:25:17] | Beirdo: | likely missing something simple |
| [22:28:39] | schwinn434 (schwinn434!~jimmy@adsl-98-93-66-67.owb.bellsouth.net) has quit (Quit: Ex-Chat) | |
| [22:34:25] | Beirdo: | OK, README now exists for the win32 buildslave config |
| [22:35:23] | Beirdo: | hope I got all the lousy steps :) |
| [22:36:37] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
| [22:45:04] | j-rod is now known as j-rod|afk | |
| [22:47:37] | stuartm: | does that README contain just the words "Don't do it"? |
| [22:48:26] | ybot (ybot!~quassel@61.14.141.36) has quit (Remote host closed the connection) | |
| [22:49:13] | ybot (ybot!~quassel@61.14.141.36) has joined #mythtv | |
| [22:52:10] | Beirdo: | hehe |
| [22:52:20] | Beirdo: | no, but the 18 steps should discourage most people |
| [22:56:15] | wagnerrp: | it used to |
| [22:56:25] | wagnerrp: | there was the perl file that was supposed to do it all for you |
| [22:56:44] | Beirdo: | blech |
| [22:56:44] | wagnerrp: | and then there was an outline of all the manual steps to build dependencies and such |
| [22:56:58] | wagnerrp: | and the document basically said, dont do it manually |
| [22:57:23] | Beirdo: | this uses lvr's build script (modified) to bootstrap in all the prerequisites |
| [22:57:37] | Beirdo: | and then uses ./configure and make separately |
| [22:58:05] | Beirdo: | and I still need to tweak the paths in the plugins configure somewhere, it's not quite right still |
| [22:58:43] | Beirdo: | but still, to run as a buildslave, you need python, twisted, ... |
| [22:58:50] | Beirdo: | oh, and mingw/msys :) |
| [23:02:45] | stuartm: | and a masochistic streak |
| [23:02:56] | Beirdo: | definitely |
| [23:03:10] | Beirdo: | and a strong stubborn streak couldn't hurt either |
| [23:03:59] | Beirdo: | I will not allow Windows to defeat me :) |
| [23:04:18] | Beirdo: | although it sure is trying |
| [23:25:07] | Beirdo: | stuartm: I think we can suppress the warning about gmtime in compat.h |
| [23:25:16] | Beirdo: | that IS the portability fix :) |
| [23:26:05] | Beirdo: | and I think the same may be true on the logging.cpp warning for localtime. Pretty sure that is Windows only, and we don't have a better option |
| [23:54:45] | danielk22: | I looked up localtime and gmtime on windows, they use thread local variables so they are safe so long as you use their results before calling any of the other time functions, which we do in compat.h gmtime_r and the localtime in logging.cpp. |
| [23:55:00] | danielk22: | HOWEVER I don't know if that applies to MINGW! |
| [23:55:30] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 258 seconds) | |
| [23:56:22] | danielk22: | I was looking up the MSDN docs, it's possible that MINGW has it's own unsafe versions of these POSIX's calls. |
| [23:57:25] | Beirdo: | yeah |
| [23:58:01] | danielk22: | I don't think so, just because that is contrary to their philosophy.. but I really don't know.. |
| [23:58:01] | Beirdo: | if we want to be super-anal, we can protect the two with a shared mutex, but dunno if it's necessary |
| [23:58:37] | Beirdo: | my understanding is that they use the MSVCRT directly |
| [23:59:20] | Beirdo: | rather than cygwin, which gives you a true POSIX-type environment and slows it down to implement some of these things posixly |
| [23:59:53] | andreax (andreax!~andreaz@p57B93087.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.