| Tuesday, August 23rd, 2011, 00:06 UTC | ||
| [00:06:22] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [00:14:41] | xris (xris!~xris@mythtv/developer/xris) has quit (Quit: Terminated with extreme prejudice - dircproxy 1.2.0) | |
| [00:18:43] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [00:19:31] | wagnerrp: | hehe... https://github.com/codedance/Retaliation |
| [00:19:34] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
| [00:20:29] | _Meliorator (_Meliorator!m@dunnington.eu) has joined #mythtv | |
| [00:22:11] | kwmonroe` (kwmonroe`!~kwmonroe@129.42.208.179) has quit (Ping timeout: 240 seconds) | |
| [00:22:29] | rhpot1991 (rhpot1991!~rhpot1991@ubuntu/member/rhpot1991) has quit (Ping timeout: 276 seconds) | |
| [00:22:30] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Ping timeout: 276 seconds) | |
| [00:22:30] | timlegge (timlegge!~tim@mctnnbsa51w-156034063103.dhcp-dynamic.FibreOp.nb.bellaliant.net) has quit (Ping timeout: 276 seconds) | |
| [00:22:30] | Meliorator (Meliorator!m@dunnington.eu) has quit (Ping timeout: 276 seconds) | |
| [00:22:31] | poptix (poptix!poptix@poptix.net) has quit (Ping timeout: 276 seconds) | |
| [00:22:56] | rhpot1991 (rhpot1991!~rhpot1991@204.8.45.13) has joined #mythtv | |
| [00:22:56] | rhpot1991 (rhpot1991!~rhpot1991@204.8.45.13) has quit (Changing host) | |
| [00:22:56] | rhpot1991 (rhpot1991!~rhpot1991@ubuntu/member/rhpot1991) has joined #mythtv | |
| [00:23:15] | poptix (poptix!poptix@poptix.net) has joined #mythtv | |
| [00:23:44] | Beaver (Beaver!~Beaver@99.54.137.111) has joined #mythtv | |
| [00:25:14] | MythBuild: | build #837 of master-freebsd-64bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/837 |
| [00:25:58] | timlegge (timlegge!~tim@mctnnbsa51w-156034063103.dhcp-dynamic.FibreOp.nb.bellaliant.net) has joined #mythtv | |
| [00:30:49] | iamlindoro: | wagnerrp: Now we just need to get them installed in each dev's bedroom/office/basement/mom's house |
| [00:36:42] | wagnerrp: | yeah, the 'get it fixed before the ppc bot reaches it or... nothing' just doesnt really carry any weight |
| [00:37:08] | kormoc is now known as kormoc_afk | |
| [00:48:11] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 264 seconds) | |
| [01:05:18] | davide (davide!~david@host103.16.intrusion.com) has quit (Remote host closed the connection) | |
| [01:05:43] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [01:43:43] | xris (xris!~xris@mythtv/developer/xris) has joined #mythtv | |
| [02:06:23] | danielk22: | stuartm: lots of warnings in the plugins :| |
| [02:09:12] | danielk22: | BTW I would not fix the mythevent.h passed by reference warnings.. I fixed that in the past and ended up reverting it.. There is some unsafe string code somewhere in MythEvent code and this inefficiency is saving us from segfaults.. |
| [02:15:16] | kormoc_afk is now known as kormoc | |
| [02:17:59] | andreax (andreax!~andreaz@p57B95350.dip.t-dialin.net) has joined #mythtv | |
| [02:37:58] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (Read error: Connection reset by peer) | |
| [02:38:47] | kormoc_afk (kormoc_afk!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [02:38:48] | kormoc_afk is now known as kormoc | |
| [02:56:14] | Beaver (Beaver!~Beaver@99.54.137.111) has quit () | |
| [03:01:45] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
| [03:09:43] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv | |
| [03:10:28] | wahrhaft (wahrhaft!~quassel@cpe-24-210-71-26.columbus.res.rr.com) has quit (Remote host closed the connection) | |
| [03:27:22] | andreax (andreax!~andreaz@p57B95350.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [03:29:25] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [03:44:09] | danielk22: | stuartm: it looks like we're not getting cppcheck warnings about using functions that aren't re-entrant by spec, such as rand(). |
| [03:44:43] | danielk22: | stuartm: is that due to an older cppcheck being used or is the warning level just not cranked up to 11 ? |
| [03:45:47] | danielk22: | rand() is just as safe on Linux as random(), but it's not required to be re-entrant or thread-safe. |
| [03:52:24] | danielk22: | heh, some googling shows random() isn't very good either on FreeBSD and OS X... |
| [04:04:02] | MaverickTech (MaverickTech!~MaverickT@115.189.255.248) has joined #mythtv | |
| [04:04:18] | clever: | generaly, i think its refering to the seed number, it may produce a different set of random numbers because of a race condition with another thread |
| [04:05:03] | clever: | either because the second thread ate 3 numbers in the sequence, or both ran it at once and scrambled the seed (making it more random) |
| [04:12:14] | _klk_ (_klk_!~Adium@208.90.215.163) has quit (Ping timeout: 240 seconds) | |
| [04:14:54] | MavT (MavT!~MaverickT@115.189.242.81) has joined #mythtv | |
| [04:15:35] | MaverickTech (MaverickTech!~MaverickT@115.189.255.248) has quit (Ping timeout: 272 seconds) | |
| [04:17:34] | _klk_ (_klk_!~Adium@208.90.215.163) has joined #mythtv | |
| [04:19:50] | sraue (sraue!~stephan@xbmc/staff/sraue) has quit (Quit: Ex-Chat) | |
| [04:28:19] | sraue (sraue!~stephan@xbmc/staff/sraue) has joined #mythtv | |
| [04:36:20] | simonckenyon (simonckenyon!~simoncken@195.7.61.12) has quit (Ping timeout: 260 seconds) | |
| [04:39:39] | MavT (MavT!~MaverickT@115.189.242.81) has quit (Ping timeout: 272 seconds) | |
| [04:40:14] | jya (jya!~jyavenard@60-242-40-141.static.tpgi.com.au) has joined #mythtv | |
| [04:40:15] | jya (jya!~jyavenard@60-242-40-141.static.tpgi.com.au) has quit (Changing host) | |
| [04:40:15] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
| [04:45:52] | MaverickTech (MaverickTech!~MaverickT@115.189.217.72) has joined #mythtv | |
| [05:38:39] | stuartm: | danielk22: ah, I hadn't enabled the 'posix' warnings |
| [05:39:25] | MaverickTech (MaverickTech!~MaverickT@115.189.217.72) has quit (Ping timeout: 252 seconds) | |
| [05:40:34] | stuartm: | I'm forcing a run with --std=posix |
| [05:40:56] | stuartm: | fwiw I'm using the latest code from their git repo |
| [05:47:43] | stuartm: | danielk22: we can add any warnings we want to ignore to a 'suppressions' file, that can be a bit fragile though, we either ignore all errors of a certain type (e.g. const check) in a file or we specify a line number which is subject to change |
| [05:50:22] | stuartm: | cppcheck manual – http://cppcheck.sourceforge.net/manual.pdf |
| [06:08:48] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [06:18:31] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 258 seconds) | |
| [06:26:48] | MaverickTech (MaverickTech!~MaverickT@131.203.137.143) has joined #mythtv | |
| [06:33:47] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Ping timeout: 264 seconds) | |
| [06:42:49] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [07:46:10] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has quit (Ping timeout: 246 seconds) | |
| [07:46:21] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has joined #mythtv | |
| [07:46:21] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has quit (Changing host) | |
| [07:46:21] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [07:52:07] | MaverickTech (MaverickTech!~MaverickT@131.203.137.143) has quit (Ping timeout: 246 seconds) | |
| [07:52:09] | MavT (MavT!~MaverickT@131.203.137.143) has joined #mythtv | |
| [07:59:35] | MavT (MavT!~MaverickT@131.203.137.143) has quit (Ping timeout: 264 seconds) | |
| [08:00:24] | MaverickTech (MaverickTech!~MaverickT@131.203.137.143) has joined #mythtv | |
| [08:09:55] | len_ (len_!~quassel@184-97-158-26.mpls.qwest.net) has quit (Remote host closed the connection) | |
| [08:31:54] | _klk_ (_klk_!~Adium@208.90.215.163) has quit (Quit: Leaving.) | |
| [08:51:56] | purserj (purserj!~purserj@hosting.collaborynth.com.au) has quit (Ping timeout: 258 seconds) | |
| [08:52:23] | purserj (purserj!~purserj@hosting.collaborynth.com.au) has joined #mythtv | |
| [09:08:33] | stuartm: | danielk22: 'portability' warnings are now included and it's been updated for current master, the pesdata() related false positives have been fixed upstream so they are no longer listed |
| [09:58:00] | ** stuarta tries to understand how the vbi.c cl leak isnt a leak ** | |
| [10:02:32] | stuarta: | i'm sure it could be coded in a better way... |
| [10:05:02] | Guest90137 (Guest90137!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:05:57] | mike (mike!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:06:23] | mike is now known as Guest59352 | |
| [10:22:37] | topal (topal!~hero108@88.225.242.248) has joined #mythtv | |
| [10:23:36] | topal (topal!~hero108@88.225.242.248) has left #mythtv () | |
| [11:20:40] | MavT (MavT!~MaverickT@dns2.arel.com.au) has joined #mythtv | |
| [11:23:24] | MaverickTech (MaverickTech!~MaverickT@131.203.137.143) has quit (Ping timeout: 240 seconds) | |
| [11:39:25] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [12:04:01] | davide (davide!~david@host103.16.intrusion.com) has quit (Remote host closed the connection) | |
| [12:04:27] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [12:45:45] | danielk22: | clever: When two threads use the same seed they both get the same number out. But it's more about correctness in this case, an implementation of rand() is allowed to segfault or give out all 0's when accessed by two threads at once. Some of the other non-re-entrant functions may have more serious problems. |
| [13:04:21] | XChatMav (XChatMav!~MaverickT@131.203.137.143) has joined #mythtv | |
| [13:06:24] | clever: | yeah |
| [13:07:47] | MavT (MavT!~MaverickT@dns2.arel.com.au) has quit (Ping timeout: 240 seconds) | |
| [13:15:54] | stuartm: | danielk22: so use rand_r? Or isn't that available on windows? |
| [13:20:14] | danielk22: | stuartm: Just random(), it's supposed to be safe. On windows we already have an implementation of random() using rand() there we can just implement the posix rand_r().. I'll commit something in a few minutes. |
| [13:21:01] | stuartm: | danielk22: k |
| [13:21:32] | danielk22: | But I am more interested in the other unsafe functions.. like we're using strtok() and localtime() |
| [13:21:58] | danielk22: | There is a localtime is in logging.cpp which gets called often enough that we could have problems. |
| [13:22:48] | danielk22: | It looks like that is the only use of localtime() in the whole program, so until someone adds another localtime() we're safe. |
| [13:23:36] | stuartm: | gmtime() doesn't cause an issue with localtime()? |
| [13:23:56] | stuartm: | couple of instances of ctime() too |
| [13:24:08] | danielk22: | hmm, dunno. But it is only used in windows... |
| [13:24:11] | stuartm: | but those are in mythcommflag |
| [13:24:53] | stuartm: | oh, you've already fixed the gmtime one |
| [13:25:03] | danielk22: | wasn't me :) |
| [13:26:45] | stuartm: | odd, it's warning about it in the cppcheck report, but it's fixed in the github browser ... yet I don't see a commit between the report being created and now |
| [13:26:59] | stuartm: | must be a false positive, it's matching the wrong string ... |
| [13:29:24] | danielk22: | possible, some of those .size() -> .empty() conversions I did where on vectors where the two functions are both O(1) |
| [13:29:48] | stuartm: | ah, no, it's a windows macro which should be in compat.h |
| [13:30:45] | stuartm: | https://github.com/MythTV/mythtv/blob/master/ . . . lper.cpp#L24 |
| [13:36:00] | danielk22: | It looks like on windows localtime is uses thread local variables so it's safe. |
| [13:46:16] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [13:53:32] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has quit (Read error: No route to host) | |
| [13:54:04] | j-rod|afk is now known as j-rod | |
| [13:55:17] | jpabq (jpabq!~jpabq@174-28-172-82.albq.qwest.net) has joined #mythtv | |
| [13:55:17] | jpabq (jpabq!~jpabq@174-28-172-82.albq.qwest.net) has quit (Changing host) | |
| [13:55:17] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has joined #mythtv | |
| [13:56:31] | jpabq- (jpabq-!~jpabq@174-28-172-82.albq.qwest.net) has joined #mythtv | |
| [14:08:35] | stuartm: | jpabq: thanks |
| [14:46:14] | stuartm: | we're using both _WIN32 and WIN32 – what's the difference? |
| [14:47:56] | stuartm: | i.e. can those instances of WIN32 be converted to _WIN32 (the MS defined one) |
| [14:48:23] | DJDan (DJDan!~djdan@115-64-177-188.static.tpgi.com.au) has joined #mythtv | |
| [14:57:00] | stuartm: | these are all the defines currently used in our code (excluded third party stuff where possible) – http://pastebin.com/1gxQAbC6 |
| [14:58:13] | danielk22: | http://stackoverflow.com/questions/662084/wha . . . defines-in-c |
| [14:59:06] | danielk22: | WIN32 is defined in the windows header files, _WIN32 by the microsoft compiler. (presumably gcc on windows too, but I dunno). |
| [15:02:56] | stuartm: | we only use WIN32 in 3/4 places, so it can probably be replaced with _WIN32 for consistency |
| [15:04:29] | danielk22: | yeah, if we ever use a compiler that doesn't define _WIN32 we can just add the -D_WIN32 or equivalent.. According to wikipedia all modern compilers define it for non-mobile versions of windows. |
| [15:07:59] | stuartm: | I'm feeding cppcheck a list of configs to check instead of forcing a check of all, if I exclude all the impossible configs then it should be a little faster |
| [15:20:41] | stuartm: | wow, much faster, ~16m vs over an hour |
| [15:24:11] | stuartm: | and it seems to have found more, not less issues |
| [15:26:36] | stuartm: | danielk22: in xine_demux_sputext.cpp we have "#ifdef DEBUX_XINE_DEMUX_SPUTEXT" – note the mispelt DEBUG, in the header it's defined with the G – any reason not to fix the spelling but disable the define? |
| [15:33:01] | ghoti (ghoti!~paul@scratch.it.ca) has joined #mythtv | |
| [15:42:44] | danielk22: | stuartm: I can't think of any reason not to fix.. |
| [15:43:05] | stuartm: | already did so, decided it was a dumb question :) |
| [16:09:56] | danielk22: | stuartm: I'll take a look at mythmusic warnings. |
| [16:10:50] | Mousey (Mousey!~wtfisme@ross154.net) has joined #mythtv | |
| [16:11:12] | stuartm: | k |
| [16:11:59] | stuartm: | well after restricting the configuration checked it's somehow managed to find more, not less things to gripe about |
| [16:17:54] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [16:26:49] | Gibby (Gibby!~Gibby@204.118.10.244) has quit (Ping timeout: 245 seconds) | |
| [16:27:00] | Gibby_ (Gibby_!~Gibby@204.118.10.244) has joined #mythtv | |
| [16:27:13] | Gibby_ is now known as Gibby | |
| [16:42:20] | brfransen (brfransen!~brfransen@216.254.250.47) has quit (Ping timeout: 240 seconds) | |
| [16:51:47] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 258 seconds) | |
| [16:54:26] | stuartm: | another null into db warning – http://pastebin.com/HeEBtUCM |
| [17:03:32] | davide (davide!~david@host103.16.intrusion.com) has quit (Remote host closed the connection) | |
| [17:04:00] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [17:07:28] | brfransen (brfransen!~brfransen@216.254.250.47) has joined #mythtv | |
| [17:10:11] | jcarlos (jcarlos!~quassel@85.137.99.76.dyn.user.ono.com) has quit (Ping timeout: 240 seconds) | |
| [17:11:18] | jcarlos (jcarlos!~quassel@85.137.99.76.dyn.user.ono.com) has joined #mythtv | |
| [17:14:25] | stuartm: | Beirdo: since those mythtranscode changes went in I'm seeing artefacts at cut points |
| [17:15:34] | Beirdo: | hmmm, well, I guess we should run that to the ground |
| [17:25:52] | DjMadness_ (DjMadness_!~DjMadness@91.215.159.77) has joined #mythtv | |
| [17:27:00] | DjMadness (DjMadness!~DjMadness@pdpc/supporter/student/DjMadness) has quit (Ping timeout: 240 seconds) | |
| [17:27:59] | stoffel (stoffel!~quassel@p57B4BF62.dip.t-dialin.net) has joined #mythtv | |
| [17:32:05] | ThisNewGuy (ThisNewGuy!~doug@pool-98-109-19-98.nwrknj.fios.verizon.net) has left #mythtv () | |
| [17:39:33] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has quit (Quit: ZNC - http://znc.sourceforge.net) | |
| [17:39:51] | jpabq (jpabq!~jpabq@174-28-172-82.albq.qwest.net) has joined #mythtv | |
| [17:40:36] | andreax (andreax!~andreaz@p57B95BB2.dip.t-dialin.net) has joined #mythtv | |
| [17:40:39] | jpabq (jpabq!~jpabq@174-28-172-82.albq.qwest.net) has quit (Changing host) | |
| [17:40:40] | jpabq (jpabq!~jpabq@mythtv/developer/jpabq) has joined #mythtv | |
| [17:43:28] | ThisNewGuy (ThisNewGuy!~doug@pool-98-109-19-98.nwrknj.fios.verizon.net) has joined #mythtv | |
| [17:50:03] | SteveGoodey (SteveGoodey!~steve@host86-160-205-179.range86-160.btcentralplus.com) has joined #mythtv | |
| [17:54:04] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [17:57:07] | SteveGoodey (SteveGoodey!~steve@host86-160-205-179.range86-160.btcentralplus.com) has quit (Remote host closed the connection) | |
| [17:57:32] | _klk_ (_klk_!~Adium@208.90.215.163) has joined #mythtv | |
| [17:57:34] | kth (kth!~kth@unaffiliated/kth) has quit (Client Quit) | |
| [18:01:41] | ThisNewGuy (ThisNewGuy!~doug@pool-98-109-19-98.nwrknj.fios.verizon.net) has quit (Read error: Connection reset by peer) | |
| [18:07:57] | ** Beirdo scratches his head ** | |
| [18:08:05] | Beirdo: | I'll get this to work eventually |
| [18:08:12] | ThisNewGuy (ThisNewGuy!~doug@pool-98-109-19-98.nwrknj.fios.verizon.net) has joined #mythtv | |
| [18:13:30] | stuartm: | danielk22: I'll take mythgame |
| [18:18:35] | danielk22: | stuartm: I'm just waiting for the mythmusic scan to finish to do a quick smoke check on those fixes. I didn't do all of them, just the ones I could do without trying to figure out what the code is supposed to do vs. what it actually does. |
| [18:18:56] | danielk22: | We should be able to get below 200 warning today :) |
| [18:22:00] | stuartm: | at least one genuine bug in mythgame, we were deleting entirely the wrong object |
| [18:23:59] | stuartm: | guessing it was a copy/paste error |
| [18:30:08] | stoffel (stoffel!~quassel@p57B4BF62.dip.t-dialin.net) has quit (Ping timeout: 240 seconds) | |
| [18:33:15] | DJDan (DJDan!~djdan@115-64-177-188.static.tpgi.com.au) has quit (Remote host closed the connection) | |
| [18:33:35] | danielk22: | Wow, the earthquake I felt 30 minutes ago was actually in Virginia! |
| [18:36:31] | danielk22: | stuartm: Can we suppress "the scope of the variable 'blah' can be reduced" in info? I think there may be some real problems reported at the info level and that just obscures them. |
| [18:39:33] | danielk22: | The technically the member function ... can be const has a lot of false positives, example 'TeletextReader::SetIsSubtitle' |
| [18:39:36] | stuartm: | danielk22: yes, we can suppress a test based on it's ID (hovering over the severity table cell will display that), I'll add one for 'variableScope' |
| [18:40:08] | stoffel (stoffel!~quassel@p57B4BF62.dip.t-dialin.net) has joined #mythtv | |
| [18:40:13] | stuartm: | danielk22: if we can make a note of false positives I'll report them upstream before suppressing them |
| [18:43:05] | stuartm: | the suppression file looks like this right now – http://pastebin.com/hevKJ0Lh |
| [18:43:23] | danielk22: | stuartm: don't suppress the const ones, even with the false positives they are useful. |
| [18:43:54] | stuartm: | danielk22: I won't :) |
| [18:44:31] | stuartm: | not all of them anyway, but we can suppress specific instances where we know them to be false positives |
| [18:48:11] | stuartm: | cron script – http://pastebin.com/z3nFvjky (if anyone wants to nominate configs we can safely ignore it will help get the runtime down) |
| [18:49:54] | stuartm: | full run currently takes ~14m 36secs here on a 2.5Ghz dual-core |
| [18:54:52] | stoffel (stoffel!~quassel@p57B4BF62.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [19:00:45] | stuartm: | danielk22: updated with scope warnings suppressed |
| [19:07:15] | Beirdo: | WTF is wrong with this mingw32 buildslave |
| [19:08:09] | Beirdo: | make: gcc: Command not found |
| [19:08:12] | Beirdo: | is so! |
| [19:53:20] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [20:21:29] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [20:22:23] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [21:17:10] | MavT (MavT!~MaverickT@dns2.arel.com.au) has joined #mythtv | |
| [21:19:52] | XChatMav (XChatMav!~MaverickT@131.203.137.143) has quit (Ping timeout: 240 seconds) | |
| [21:20:05] | Beirdo: | ahhh, I have success. |
| [21:20:22] | XChatMav (XChatMav!~MaverickT@131.203.137.143) has joined #mythtv | |
| [21:21:23] | Beirdo: | basing this on what jmartens had (which is based on LVR's script + loosely on our buildbot rules for Linux) |
| [21:21:42] | Beirdo: | and have tidied it up to closer match the Linux side. |
| [21:22:21] | Beirdo: | other than LVR's patches being totally off the grid as far as I can tell, it's seeming to build OK |
| [21:22:44] | Beirdo: | at least the prereqs (which it will check, but not rebuild, on each run) |
| [21:23:13] | MaverickTech (MaverickTech!~MaverickT@dns2.arel.com.au) has joined #mythtv | |
| [21:24:12] | MavT (MavT!~MaverickT@dns2.arel.com.au) has quit (Ping timeout: 240 seconds) | |
| [21:24:32] | XChatMav (XChatMav!~MaverickT@131.203.137.143) has quit (Ping timeout: 240 seconds) | |
| [21:25:49] | danielk22: | Hmm, I wonder if we should just use Qt's qrand on windows... |
| [21:26:59] | Beirdo: | might not be a bad plan, I guess. |
| [21:30:27] | stuartm: | what does qrand use on linux/bsd out of interest? Could it be used for all platforms, or just Windows? |
| [21:33:49] | danielk22: | stuartm: I believe qrand has the same crappy randomness as rand does... so it's still not the preferred... |
| [21:34:49] | danielk22: | Some of our random expressions are of the form (random()&1) which has a very short period of repeat if you use rand(). |
| [21:36:14] | stuartm: | fair enough, figured it was worth asking :) |
| [21:37:13] | danielk22: | RAND_MAX is also only 32k on windows rather than the 2g on linux, and qrand() respects RAND_MAX, meaning the granularity is pretty awful when we use it to generate floats... makes me wonder if there is a new call in C++11... |
| [21:37:40] | stuartm: | ouch |
| [21:38:14] | danielk22: | yep, C++11 has three new random number generators... |
| [21:38:15] | stuartm: | I mean we're not using it for security, but still ... |
| [21:39:00] | andreax (andreax!~andreaz@p57B95BB2.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [21:40:39] | stuartm: | danielk22: do you happen to knwo how much of C++11 is already supported by gcc? |
| [21:41:24] | danielk22: | stuartm: I think most of it is, but it's premature to start using C++11 constructs :) |
| [21:41:40] | stuartm: | all these new features are great, but we might be waiting years for full support :( |
| [21:42:38] | stuartm: | we're down to 574 warnings btw |
| [21:46:00] | danielk22: | heh, only of those 110 are at the warning or error level :) |
| [21:46:51] | stuartm: | yup |
| [21:47:29] | stuartm: | the programrecpriorityinfo ones are a false positive which I've reported |
| [21:48:20] | stuartm: | I'll take mythtv-setup, those are nice and simple |
| [21:49:22] | stuartm: | and probably my fault |
| [21:51:45] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 276 seconds) | |
| [21:52:09] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Remote host closed the connection) | |
| [21:53:06] | univate_ (univate_!~chris@124-171-227-128.dyn.iinet.net.au) has joined #mythtv | |
| [21:55:00] | Beirdo: | wow, you guys are really knocking them out |
| [21:55:23] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [21:55:48] | j-rod is now known as j-rod|afk | |
| [21:58:01] | stuartm: | it's the ultimate busy work, looks impressive but mostly it's not ;) |
| [21:58:25] | stuartm: | the exception perhaps is the additional effort danielk22 has put into the rand() stuff |
| [21:59:44] | Gibby (Gibby!~Gibby@204.118.10.244) has quit (Ping timeout: 245 seconds) | |
| [22:00:03] | Gibby (Gibby!~Gibby@204.118.10.244) has joined #mythtv | |
| [22:01:53] | stuartm: | still the logic behind getting the count down is sound, it makes it easier to identify the real issues found by cppcheck – even the lowly style warnings can on inspection turn out to be bugs, i.e. an unused variable maybe should have been used |
| [22:05:13] | Beirdo: | yeah |
| [22:05:27] | Beirdo: | I like seeing clean builds, so I'm all for it |
| [22:06:10] | Beirdo: | for the system-unix and system-windows "uninitialized in ctor" ones, those are char[] buffers... not sure how we want to init that in a ctor, so I left it |
| [22:09:55] | danielk22: | The point is really to get the count down so that real bugs don't get lost in flood. |
| [22:17:18] | univate_ (univate_!~chris@124-171-227-128.dyn.iinet.net.au) has quit (Quit: Ex-Chat) | |
| [22:21:05] | stuartm: | snap |
| [22:23:03] | danielk22: | hmm, there is a problem with qrand |
| [22:23:49] | danielk22: | qsrand needs to be called for every thread... but I don't want to implement that unless we're actually keeping that implementation on windows.. |
| [22:28:40] | stuartm: | danielk22: if all the threads are MThread, can it not be done in the MThread constructor? |
| [22:33:43] | danielk22: | Not in the MThread constructor, that's run in the thread that creates MThread. But it could go in MThread::RunProlog(). |
| [22:34:45] | stuartm: | oops, yeah |
| [22:51:57] | MavT (MavT!~MaverickT@131.203.137.143) has joined #mythtv | |
| [22:55:18] | danielk22: | Heh, we could just lift the Mersenne Twister algorithm from Glib... |
| [22:55:41] | Beirdo: | do we *really* need a good random? |
| [22:55:57] | MaverickTech (MaverickTech!~MaverickT@dns2.arel.com.au) has quit (Ping timeout: 272 seconds) | |
| [22:56:02] | Beirdo: | it affects what? the order music gets shuffled in? |
| [22:56:56] | stuartm: | which never seems random enough to me, but I think that's more a case of coincidence etc |
| [22:57:21] | MaverickTech (MaverickTech!~MaverickT@131.203.137.143) has joined #mythtv | |
| [22:57:45] | Beirdo: | heh, there is that side of it too, but I just wonder if it's not a bit of a waste of time searching for a "good" random |
| [22:57:51] | MavT (MavT!~MaverickT@131.203.137.143) has quit (Ping timeout: 272 seconds) | |
| [22:57:58] | Beirdo: | safe, sure :) |
| [22:59:34] | danielk22: | Beirdo: We need more bits than we get from rand or qrand on windows. And it would be nice to have one decent pseudo-random number generator for all uses in MythTV. |
| [23:00:02] | danielk22: | stuartm: the music thing is probably more about how rand()/random() is used than the underlying function... |
| [23:00:18] | Beirdo: | K. fair enough |
| [23:00:56] | Beirdo: | windows buildbot still off building me the prereqs |
| [23:01:02] | Beirdo: | heh |
| [23:01:10] | stuartm: | danielk22: I didn't mean to imply otherwise, I don't think rand() is at fault there, I'm not even sure there is a problem it can just feel like it's not very random at times |
| [23:01:46] | clever: | if you want better random you could just open /dev/urandom for linux |
| [23:01:49] | danielk22: | It's like float.. having a good spec makes the most difference when you aren't being careful about underrun and such. |
| [23:01:52] | stuartm: | even a randomised list can produce a perfectly ordered list once in a blue moon |
| [23:02:01] | Beirdo: | stuartm: of course, if almost all your music sounds alike, it won't help either. Randomly choosing an AC/DC song out of a pile of AC/DC songs will sound pretty unrandom |
| [23:03:18] | stuartm: | Beirdo: hehe, I have pretty good variety and a decent number of tracks to chose from so it's not that :) |
| [23:04:33] | Gibby_ (Gibby_!~Gibby@204.118.10.244) has joined #mythtv | |
| [23:05:26] | danielk22: | clever: we want fast too :) |
| [23:05:59] | Gibby (Gibby!~Gibby@204.118.10.244) has quit (Ping timeout: 245 seconds) | |
| [23:05:59] | Gibby_ is now known as Gibby | |
| [23:06:02] | danielk22: | And the real problem is windows, we can use random() on UNIX, which is good enough.. |
| [23:09:24] | Beirdo: | you had me at "the real problem is Windows".... |
| [23:10:12] | Beirdo: | having just spent umpteen hours getting what I hope is a clean and workable Windows buildbot slave ready... |
| [23:10:22] | Beirdo: | gotta say, I hate Windows more than eve r:) |
| [23:30:24] | _klk_: | hi all. i am running mythcommflag manually over live tv capture encoded using h264 in an mkv container. i'm noticing that it is missing a lot of commercials (only tagging around 20% of the actuall commercials). earlier, i used to be writing only 500x500 grayscale encoded using mpeg4 to an avi file, and it was achieving around 90% accuracy. would there be a reason for the decrease in accuracy when processing full frames? |
| [23:33:30] | wagnerrp: | might be related to this... http://code.mythtv.org/trac/ticket/9997 |
| [23:45:09] | clever: | danielk22: depends more on the usecase, random playlists in mythmusic dont happen too often and dont need it to be reproduceable |
| [23:49:16] | _klk_: | wagnerrp: i see – that's from 4 days ago. i'll recompile from HEAD and then try again |
| [23:54:05] | stuartm: | _klk_: that patch hasn't been committed yet |
| [23:54:44] | wagnerrp: | hence why its still an open ticket with a patch |
| [23:58:23] | _klk_: | ah, ok. i should have looked closer. |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.