| Tuesday, August 16th, 2011, 00:53 UTC | ||
| [00:53:21] | anykey_ (anykey_!~guedel@46-126-245-147.dynamic.hispeed.ch) has quit (*.net *.split) | |
| [00:53:21] | kwmonroe` (kwmonroe`!~kwmonroe@32.97.110.58) has quit (*.net *.split) | |
| [00:53:22] | JEDIDIAH___ (JEDIDIAH___!~jedi@cpe-76-185-75-39.tx.res.rr.com) has quit (*.net *.split) | |
| [00:53:22] | jcarlos (jcarlos!~quassel@85.137.99.76.dyn.user.ono.com) has quit (*.net *.split) | |
| [00:53:22] | aloril (aloril!~aloril@84.249.126.153) has quit (*.net *.split) | |
| [00:53:22] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has quit (*.net *.split) | |
| [00:53:22] | paul-h (paul-h!~paulh@mythtv/developer/paul-h) has quit (*.net *.split) | |
| [00:53:22] | ybot (ybot!~quassel@61.14.141.36) has quit (*.net *.split) | |
| [00:53:22] | dlblog (dlblog!~dlblog@c-76-127-227-175.hsd1.ma.comcast.net) has quit (*.net *.split) | |
| [00:53:40] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
| [00:53:42] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has joined #mythtv | |
| [00:53:47] | JEDIDIAH___ (JEDIDIAH___!~jedi@cpe-76-185-75-39.tx.res.rr.com) has joined #mythtv | |
| [00:53:50] | dlblog (dlblog!~dlblog@c-76-127-227-175.hsd1.ma.comcast.net) has joined #mythtv | |
| [00:53:55] | paul-h (paul-h!~paulh@5adce259.bb.sky.com) has joined #mythtv | |
| [00:53:55] | paul-h (paul-h!~paulh@5adce259.bb.sky.com) has quit (Changing host) | |
| [00:53:55] | paul-h (paul-h!~paulh@mythtv/developer/paul-h) has joined #mythtv | |
| [00:54:31] | jcarlos (jcarlos!~quassel@85.137.99.76.dyn.user.ono.com) has joined #mythtv | |
| [00:54:46] | ybot (ybot!~quassel@61.14.141.36) has joined #mythtv | |
| [00:57:05] | aloril (aloril!~aloril@dsl-tkubrasgw3-fe7ef900-153.dhcp.inet.fi) has joined #mythtv | |
| [01:01:48] | anykey_ (anykey_!~guedel@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
| [01:03:44] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [01:04:10] | gigem_ (gigem_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [01:04:10] | gigem_ (gigem_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [01:04:11] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [01:05:51] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
| [01:12:30] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv | |
| [01:51:48] | Gibby (Gibby!~Gibby@204.118.10.244) has quit (Quit: ZNC - http://znc.sourceforge.net) | |
| [02:20:02] | Gibby (Gibby!~Gibby@204.118.10.244) has joined #mythtv | |
| [03:44:00] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [04:54:54] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [04:55:29] | kth (kth!~kth@unaffiliated/kth) has quit (Client Quit) | |
| [04:59:41] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has quit (Remote host closed the connection) | |
| [05:58:58] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has quit (Ping timeout: 264 seconds) | |
| [06:12:25] | Captain_Murdoch (Captain_Murdoch!~cpinkham@ip72-218-58-187.hr.hr.cox.net) has joined #mythtv | |
| [06:12:25] | Captain_Murdoch (Captain_Murdoch!~cpinkham@mythtv/developer/CaptainMurdoch) has joined #mythtv | |
| [06:12:25] | Captain_Murdoch (Captain_Murdoch!~cpinkham@ip72-218-58-187.hr.hr.cox.net) has quit (Changing host) | |
| [06:52:36] | Beirdo: | stuartm: I am getting spewed by new messages re: UpdateUIListItem called with title unknown to us in m_recordingList (during playback) |
| [06:52:54] | Beirdo: | any way we can get that to not happen, or is this work in progress, or... :) |
| [06:53:03] | Beirdo: | (debug-level messages, BTW) |
| [06:53:29] | Beirdo: | I ask you as you were the last I remember toying with that. |
| [07:32:45] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has quit (Ping timeout: 258 seconds) | |
| [07:35:13] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has joined #mythtv | |
| [07:35:13] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [07:35:13] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has quit (Changing host) | |
| [07:51:25] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [07:56:36] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [08:27:20] | simonckenyon (simonckenyon!~simoncken@195.7.61.12) has quit (Ping timeout: 260 seconds) | |
| [08:48:28] | simonckenyon (simonckenyon!~simoncken@195.7.61.12) has joined #mythtv | |
| [09:40:47] | stuartm: | Beirdo: during playback? That definitely shouldn't be happening ... |
| [09:44:01] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [09:47:01] | stoffel (stoffel!~quassel@p57B4C5A4.dip.t-dialin.net) has joined #mythtv | |
| [09:58:20] | stoffel (stoffel!~quassel@p57B4C5A4.dip.t-dialin.net) has quit (Ping timeout: 260 seconds) | |
| [10:05:01] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:05:51] | mike (mike!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:06:17] | mike is now known as Guest44869 | |
| [10:35:20] | ikonia (ikonia!~irc@unaffiliated/ikonia) has joined #mythtv | |
| [10:41:56] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [10:51:03] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [11:02:54] | Goga777 (Goga777!~Goga777@shpd-92-101-155-87.vologda.ru) has joined #mythtv | |
| [11:09:38] | SteveGoodey (SteveGoodey!~steve@host86-160-43-155.range86-160.btcentralplus.com) has joined #mythtv | |
| [11:22:22] | SteveGoodey (SteveGoodey!~steve@host86-160-43-155.range86-160.btcentralplus.com) has quit (Remote host closed the connection) | |
| [11:25:07] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [11:26:27] | Goga777 (Goga777!~Goga777@shpd-92-101-155-87.vologda.ru) has quit (Remote host closed the connection) | |
| [11:38:46] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [12:04:57] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [12:05:24] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [12:16:20] | andreax (andreax!~andreaz@p57B92D1B.dip.t-dialin.net) has joined #mythtv | |
| [12:17:44] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
| [12:23:11] | chainsawbike (chainsawbike!~chainsawb@chainsawbike-1-pt.tunnel.tserv25.sin1.ipv6.he.net) has quit (Ping timeout: 260 seconds) | |
| [12:24:21] | clever (clever!~clever@2001:470:1d:19a:205:5dff:feff:f422) has quit (Ping timeout: 260 seconds) | |
| [12:26:16] | chainsawbike (chainsawbike!~chainsawb@chainsawbike-1-pt.tunnel.tserv25.sin1.ipv6.he.net) has joined #mythtv | |
| [13:17:40] | andreax (andreax!~andreaz@p57B92D1B.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [13:32:48] | andreax (andreax!~andreaz@p57B92D1B.dip.t-dialin.net) has joined #mythtv | |
| [13:41:20] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [13:50:38] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [14:10:50] | j-rod|afk is now known as j-rod | |
| [14:21:14] | chainsawbike (chainsawbike!~chainsawb@chainsawbike-1-pt.tunnel.tserv25.sin1.ipv6.he.net) has quit (Quit: yep... i broke it good that time...) | |
| [14:23:49] | chainsawbike (chainsawbike!~chainsawb@chainsawbike-1-pt.tunnel.tserv25.sin1.ipv6.he.net) has joined #mythtv | |
| [14:39:03] | stuartm: | Beirdo: fwiw, that's not my code issuing those messages, it's something that danielk22 added |
| [14:39:27] | stuartm: | I can look at fixing the problem though |
| [15:17:25] | ghoti (ghoti!~paul@scratch.it.ca) has quit (Ping timeout: 260 seconds) | |
| [15:20:47] | ghoti (ghoti!~paul@scratch.it.ca) has joined #mythtv | |
| [15:23:49] | gigem_: | stuartm: have you tried my subtitle then description patch yet? the submitter okayed it, but i'd llike yours too. |
| [15:28:27] | stuartm: | gigem_: compiling now, sorry I was distracted earlier today |
| [15:29:41] | danielk22: | stuartm: I didn't add anything recently to that code |
| [15:29:58] | danielk22: | at least not intentionally :) |
| [15:39:30] | kormoc_afk is now known as kormoc | |
| [15:40:05] | tester6673 (tester6673!~andy@host86-181-54-225.range86-181.btcentralplus.com) has joined #mythtv | |
| [15:40:50] | stuartm: | gigem_: ok, it's not easily to diff --printsched output because the ordering is inconsistent but so far it looks fine |
| [15:41:21] | tester6673 (tester6673!~andy@host86-181-54-225.range86-181.btcentralplus.com) has quit (Remote host closed the connection) | |
| [15:42:05] | andysummerskill (andysummerskill!~andy@host86-181-54-225.range86-181.btcentralplus.com) has joined #mythtv | |
| [15:44:32] | stoffel (stoffel!~quassel@p57B4C5A4.dip.t-dialin.net) has joined #mythtv | |
| [15:45:48] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has joined #mythtv | |
| [15:47:02] | stuartm: | gigem_: nothing jumps out, every change in printsched that I looked at was caused by programs with the same starttime being ordered differently in the output :) |
| [15:47:27] | brfransen (brfransen!~brfransen@216.254.250.47) has quit (Quit: brfransen) | |
| [15:47:48] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [15:48:10] | stuartm: | danielk22: I haven't touched it that recently either, but it depends what Beirdo means by 'new' |
| [15:53:30] | brfransen (brfransen!~brfransen@216.254.250.47) has joined #mythtv | |
| [15:54:42] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has quit (Remote host closed the connection) | |
| [15:56:43] | gigem_: | stuartm: thanks. i'll look at the schedule sorting we discussed later today. |
| [15:57:38] | jarle (jarle!~jarle@70.84-234-133.customer.lyse.net) has joined #mythtv | |
| [16:23:24] | gigem_: | stuartm: i checked the schedule sorting and i made that change 6 years ago in 8563858b! do you have mixed case callsign/short names or can you give me any other information on why your sorting changes? |
| [16:33:12] | Mousey (Mousey!~wtfisme@ross154.net) has joined #mythtv | |
| [16:47:21] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Read error: Operation timed out) | |
| [16:56:22] | asummers (asummers!56b536e1@gateway/web/freenode/ip.86.181.54.225) has joined #mythtv | |
| [16:57:06] | andysummerskill (andysummerskill!~andy@host86-181-54-225.range86-181.btcentralplus.com) has quit (Remote host closed the connection) | |
| [17:01:39] | stoffel (stoffel!~quassel@p57B4C5A4.dip.t-dialin.net) has quit (Ping timeout: 276 seconds) | |
| [17:04:58] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [17:05:32] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [17:06:51] | stuartm: | gigem_: the callsigns are mixed case, they are the same as the long name |
| [17:09:32] | stuartm: | we might be confusing the sorting I mentioned last night, which appears consistent, in Upcoming Recordings and the sorting issue I found with --printsched just now |
| [17:10:05] | stuartm: | for --printsched, the sorting seems completely random, e.g. for several matches with the same timeslot the callsigns start B,B,C,C,V,E,B,C suggesting no sort by callsign (or channum) is being performed there |
| [17:10:46] | Beirdo: | heh, OK. Well, it's only in debug that I saw it, but I can take some time hopefully and trace down its origins if it's not ringing any bells for people |
| [17:14:22] | asummers (asummers!56b536e1@gateway/web/freenode/ip.86.181.54.225) has quit (Quit: Page closed) | |
| [17:14:24] | stuartm: | the sorting last night with upcoming recordings is starttime/channum, which you suggested should be starttime/callsign instead |
| [17:14:40] | stuartm: | https://github.com/MythTV/mythtv/commit/8563858b |
| [17:17:37] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [17:27:10] | stoffel (stoffel!~quassel@p57B4C5A4.dip.t-dialin.net) has joined #mythtv | |
| [17:40:25] | wagnerrp: | Captain_Murdoch: well its working, but to be honest, its a bit too convoluted for my tasts |
| [17:41:07] | wagnerrp: | through i dont really know how you would simply it and still check for inter-dependencies |
| [17:43:39] | wagnerrp: | http://www.wagnerrp.com/files/MythTV/commandlineparser/ |
| [17:44:05] | wagnerrp: | arguments are now stored in a pointer to a new class |
| [17:44:19] | wagnerrp: | the various add() methods return a pointer to the new instance |
| [17:44:46] | wagnerrp: | to which you can SetGroup(), SetParentOf(), SetChildOf(), SetRequires(), or SetBlocks() |
| [17:45:24] | wagnerrp: | each takes a string, and the cross referenced names are reconciled to the argument instances once they are all stored |
| [17:46:32] | wagnerrp: | child options are listed indented under each of their parents, and require at least one of their parents to be set on the command line to be valid |
| [17:46:49] | wagnerrp: | required arguments require all to be set, and blocks require none to be set |
| [17:47:58] | wagnerrp: | aside from that, ordering is still alphabetical |
| [17:49:43] | Anduin (Anduin!~awithers@pdpc/supporter/professional/anduin) has joined #mythtv | |
| [18:01:11] | andreax1 (andreax1!~andreaz@p57B92BB1.dip.t-dialin.net) has joined #mythtv | |
| [18:02:09] | andreax (andreax!~andreaz@p57B92D1B.dip.t-dialin.net) has quit (Ping timeout: 250 seconds) | |
| [18:05:54] | robertzaccour (robertzaccour!18b7dda1@gateway/web/freenode/ip.24.183.221.161) has joined #mythtv | |
| [18:07:44] | robertzaccour: | I'm confused about the hd-pvr setup. How do I unpack the driver? |
| [18:08:03] | wagnerrp: | this is the mythtv development channel, you want #mythtv-users |
| [18:08:55] | robertzaccour: | nobody there |
| [18:09:05] | robertzaccour: | oops typed it wrong |
| [18:09:15] | wagnerrp: | theres 168 users there, but you arent |
| [18:09:26] | robertzaccour: | I just said I typed it wrong |
| [18:10:31] | stuartm: | so std::auto_ptr is deprecated in c++11, I know there are one or two uses in the code which can easily be removed which I think is preferable to maintaining the behaviour when 99.9% of the code requires pointers to be manually freed |
| [18:12:27] | stuartm: | although it seems we're using a number of instances of QPointer which is the same thing |
| [18:12:43] | robertzaccour (robertzaccour!18b7dda1@gateway/web/freenode/ip.24.183.221.161) has left #mythtv () | |
| [18:24:03] | gigem_: | stuartm: hmm, i see an example in my --printsched output now. i'm stumped, but will keep looking. |
| [18:26:54] | Captain_Murdoch: | wagnerrp, I haven't looked over the libmythbase files, but did look over the mfdb change. it is the arg->SetBlah() stuff you're thinking is convoluted or the implementation of those methods? |
| [18:36:07] | wagnerrp: | Captain_Murdoch: the internal implementation of those methods |
| [18:36:26] | Captain_Murdoch: | wagnerrp, ah, ok. yeah, I can see how that could get hairy. |
| [18:39:25] | stoffel (stoffel!~quassel@p57B4C5A4.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [19:14:02] | taylorr (taylorr!~taylorr@cpe-173-095-144-220.nc.res.rr.com) has joined #mythtv | |
| [19:14:02] | taylorr (taylorr!~taylorr@unaffiliated/elmojo) has joined #mythtv | |
| [19:14:02] | taylorr (taylorr!~taylorr@cpe-173-095-144-220.nc.res.rr.com) has quit (Changing host) | |
| [19:21:00] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [19:24:22] | gigem_: | stuartm: found it. it was a case of a fix in one area obscuring a related fix in another area. |
| [19:30:28] | stuartm: | gigem_: :) |
| [19:36:06] | danielk22: | stuartm: QPointer is a bit smarter than std::auto_ptr :) |
| [19:37:05] | danielk22: | It looks like QPointer is also depreciated in Qt4 though... |
| [19:40:05] | danielk22: | Well the QPointer replacements seem to require the pointed to to be derived from QObject, so depreciated is too strong a word.. |
| [19:53:11] | brfransen (brfransen!~brfransen@216.254.250.47) has quit (Read error: Connection reset by peer) | |
| [19:55:26] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
| [20:06:00] | brfransen (brfransen!~brfransen@216.254.250.47) has joined #mythtv | |
| [20:39:49] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [20:40:52] | danielk22: | Beirdo: http://www.cuymedia.net/tmp/logging-patches.tbz <-- 9 patches for logging... |
| [20:41:37] | Beirdo: | OK, let me take a look |
| [20:41:57] | Beirdo: | I think the deleteItem() one you just put in may actually be needed. |
| [20:42:15] | Beirdo: | the deleteItem will decrement the use count, and only delete when everyone has used it |
| [20:42:40] | Beirdo: | without it there, we may never delete that logging item |
| [20:44:37] | Beirdo: | ahhh, never mind |
| [20:44:38] | Beirdo: | hehe |
| [20:44:49] | danielk22: | :) when we return false we reinsert it into the queue.. |
| [20:44:55] | Beirdo: | that code case is when it returns and reinserts |
| [20:44:56] | Beirdo: | correct |
| [20:45:04] | Beirdo: | heh |
| [20:45:13] | Beirdo: | been one of those weeks already |
| [20:46:27] | Beirdo: | OK, for the first patch, I don't see why this would be necessary, or even desired. |
| [20:47:28] | Beirdo: | it makes the compilation slower, and in the end really doesn't save you much more than a function call which is a push/jump/pull |
| [20:48:45] | Beirdo: | I would even venture to say that it could significantly affect gcc's capability to optimize the code |
| [20:50:18] | Beirdo: | also, moving the level < 0 check into the macro will break things |
| [20:51:04] | Beirdo: | there are places in the code where the LOG_ANY is used (-1) for checking levels, but it isn't valid for a log message |
| [20:55:07] | Beirdo: | as for the second patch... I very specifically made it a struct rather than a class as at one point (not sure if it still is the case), that type is visible to C users |
| [20:56:06] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [20:56:07] | danielk22: | In the first one the reason for it is so that the QString() doesn't need to be constructed when we're not going to be logging anything. |
| [20:56:22] | Beirdo: | Hmmm. |
| [20:56:37] | danielk22: | The second one doesn't make much sense till you look at 3 & 4. |
| [20:56:52] | danielk22: | It's not used in C code anywhere right now. |
| [20:56:52] | Beirdo: | I guess that could save some time, but is it really worth the extra overhead to save some overhead? |
| [20:57:02] | Beirdo: | OK, good, I'm glad that it's not :) |
| [20:59:00] | danielk22: | Beirdo: 2,3,4 yeah the overhead saved is minimal, basically the cost of memset, but it gets rid of code duplication in the initialization which tends to be a source of errors down the line. |
| [20:59:22] | Beirdo: | yeah, fair enough |
| [21:01:01] | Beirdo: | You still should explicitly cast the currentThreadId() result to uint64_t to cover all the bases... It's an "opaque" value, and we are forcing it into something we can display easier and consistently... |
| [21:01:09] | Beirdo: | at least that was the original thought |
| [21:01:56] | danielk22: | fair enough.. |
| [21:01:59] | j-rod is now known as j-rod|afk | |
| [21:02:13] | Beirdo: | might bite our butts in Windows or some crazy thing :) |
| [21:02:25] | Beirdo: | hehe |
| [21:02:32] | Beirdo: | I like #5 |
| [21:02:54] | Beirdo: | yeah, if we fit into a smaller size, it can really help at times |
| [21:03:17] | Beirdo: | although malloc gives 4k pages in Linux, so it might not help much |
| [21:03:28] | danielk22: | heh, after getting rid of the extra alloc for the message it was really close to being half a page size.. |
| [21:03:34] | Beirdo: | yeah |
| [21:03:47] | stuartm: | more old UI code bites the dust |
| [21:03:54] | Beirdo: | #6... I'm embarrassed that I missed that first 64bit assign |
| [21:04:42] | danielk22: | heh, that should have been a separate patch.. the compiler pointed it out to me. |
| [21:05:05] | Beirdo: | I can't believe I missed that :) |
| [21:05:13] | Beirdo: | ah well, it's fixed now. |
| [21:05:25] | stuarta: | \o/ |
| [21:05:41] | danielk22: | With 5 I was thinking about a custom allocator. The memory usage of the logger is very predictable.. |
| [21:05:43] | Beirdo: | I see you may have fixed the database disabling. It still seems to flap a bit for me sometimes |
| [21:05:49] | Beirdo: | yeah, it is |
| [21:06:19] | Beirdo: | we could make a pool of items and manage them ourselves |
| [21:06:32] | danielk22: | Yeah, I don't think it will save much time though, since the QString mallocs are really what take the most time in processing LOG() |
| [21:06:40] | Beirdo: | which could significantly speed it up |
| [21:06:46] | danielk22: | It might save some memory... |
| [21:06:46] | Beirdo: | ahh |
| [21:07:00] | Beirdo: | yeah, it would definitely save memory |
| [21:07:25] | danielk22: | Right, QString is why patch 1 tries to put that in the macro. |
| [21:07:27] | Beirdo: | we could change all logging to be sprintf style instead of QString :) |
| [21:07:45] | danielk22: | Well QString is really convenient... |
| [21:07:47] | Beirdo: | that would be a super-painful endeavour though |
| [21:07:52] | Beirdo: | exactly |
| [21:08:07] | Beirdo: | it crossed my mind for a very short time |
| [21:08:57] | danielk22: | In 6 I put a timer for the DB logging re-enablement because I was seeing flapping when I turned on VB_ALL logging... |
| [21:09:23] | Beirdo: | yeah, it wasn't workin quite right |
| [21:09:24] | danielk22: | It wasn't stopping because the DB was down, it just couldn't keep up :) |
| [21:09:37] | Beirdo: | I hit that HARD on some of the mythtranscode testing |
| [21:11:01] | Beirdo: | VB_FLUSH seems like an odd way to implement a flush |
| [21:11:03] | danielk22: | 7 is just an example of using VB_STDIO, it probably make more sense in the commflag console output though & it's not quite right. |
| [21:11:32] | danielk22: | how so? |
| [21:12:07] | Beirdo: | ahhh, nvm. I was thinking of the shutdown flush |
| [21:12:08] | Beirdo: | heh |
| [21:12:18] | Beirdo: | that's a output flush |
| [21:13:55] | danielk22: | ah, there is a shutdown flush() command.. but I didn't add one for the DB logger. VB_FLUSH is intended have the convenience of cout<<flush.. I was thinking of the commflag % output. |
| [21:14:11] | Beirdo: | yeah |
| [21:14:20] | Beirdo: | heh, I was just getting confused |
| [21:14:33] | Beirdo: | using VB_FLUSH to do a shutdown flush would be kinda odd |
| [21:14:35] | Beirdo: | heh |
| [21:14:53] | danielk22: | yeah :) |
| [21:15:11] | Beirdo: | how many messages are we maybe losing on shutdown? |
| [21:15:22] | Beirdo: | just looking at #8 |
| [21:15:55] | danielk22: | About 3 during a normal shutdown, a dozen when something goes wrong. |
| [21:15:56] | Beirdo: | a lot of complexity, just wondering if we are actually missing them, or if that's just protection? |
| [21:16:02] | Beirdo: | ah. OK then |
| [21:16:16] | Beirdo: | and those can well be VERY important messages too |
| [21:16:49] | danielk22: | We're missing them.. I noticed it when debugging the MThread::Cleanup(), by necessity it runs after logging is shutdown.. |
| [21:17:13] | Beirdo: | heh, yeah |
| [21:18:07] | danielk22: | When something went wrong it didn't print anything so I converted those to cout redirects.. but after this (or something like it) is in I'll convert them back to LOG(). |
| [21:18:44] | Beirdo: | in #9, I did specifically want a local cached copy of the application name so we don't waste tons of time pulling it from the core application repeatedly |
| [21:18:59] | Beirdo: | likewise the host name |
| [21:19:29] | danielk22: | Beirdo: It only does the prepare once now, unless there is an error so we don't really need to cache.. |
| [21:19:53] | danielk22: | & bind of app name and host name.. |
| [21:19:57] | Beirdo: | what you have there will work, but we are binding on every message to the values actively pulled from the classes |
| [21:20:08] | Beirdo: | Oooh |
| [21:20:13] | Beirdo: | it binds once? |
| [21:20:17] | Beirdo: | never mind :) |
| [21:20:18] | danielk22: | yep :) |
| [21:20:41] | Beirdo: | yeah, that should do the trick. I missed that it was before the loop for those binds |
| [21:20:57] | danielk22: | That's really the point of #9... now that the DB reconnect logic isn't losing prepares we don't need to do all those prepares.. |
| [21:21:10] | Beirdo: | yeah |
| [21:21:12] | Beirdo: | nice |
| [21:21:42] | Beirdo: | OK, so other than a (uint64_t) cast on the currentThread... all looks good to me :) |
| [21:21:43] | danielk22: | thx, but that was really done on sphery's encouragement. |
| [21:21:52] | Beirdo: | :) |
| [21:22:38] | Beirdo: | thanks for passing them by me. A lot of little fiddly things in there that should hopefully make it faster and more stable yet. |
| [21:22:56] | danielk22: | Great.. I'll make that change & revisit patch #1 and run with those changes on production overnight.. |
| [21:23:07] | Beirdo: | sweet. |
| [21:23:26] | danielk22: | Can you point me to an example for #1 with the VB_ALL? |
| [21:23:43] | Beirdo: | ah yes, that part :) |
| [21:24:08] | danielk22: | BTW I also changed the VERBOSE and VERBOSE_LEVEL_CHECK() macros.. |
| [21:24:12] | Beirdo: | LOG_ANY, actually |
| [21:24:35] | Beirdo: | mythtv/libs/libmythtv/avformatdecoder.cpp has a could in there |
| [21:24:41] | Beirdo: | a couple rather |
| [21:25:05] | danielk22: | VERBOSE I changed because I was getting a confusing compiler error whenever I accidentally used VERBOSE instead of LOG in my code. |
| [21:25:16] | Beirdo: | hehe, that was the intention :) |
| [21:25:26] | Beirdo: | hit you up earlier in the compile |
| [21:25:42] | Beirdo: | but this works too, will fail in link anyways |
| [21:25:45] | danielk22: | I added a logLevel >= (level) check to the VERBOSE_LEVEL_CHECK |
| [21:26:19] | Beirdo: | one sec, let me go look at that again |
| [21:26:27] | brfransen (brfransen!~brfransen@216.254.250.47) has quit (Read error: Connection reset by peer) | |
| [21:26:57] | danielk22: | Beirdo: Right, but the error just told me the LVALUE would fail at run time, which was a head scratcher... |
| [21:27:02] | Beirdo: | yeah, it's the ((_LEVEL_)>=0) part that will cause issues in those check |
| [21:27:14] | Beirdo: | haha, nice error message |
| [21:28:04] | Beirdo: | we have a few places that use LOG_ANY (-1), and the modified VERBOSE_LEVEL_CHECK will have a different result for them |
| [21:28:05] | brfransen (brfransen!~brfransen@216.254.250.47) has joined #mythtv | |
| [21:28:45] | Beirdo: | the only place the >=0 is needed is in the LOG() expansion |
| [21:30:06] | Beirdo: | oh, and something I learned years back... when using #define to make macros... it's wise to put () around the args as expanded in the macro religiously as people can do stupid things |
| [21:30:10] | Beirdo: | :) |
| [21:30:21] | danielk22: | This reminds me.. VB_STDIO & VB_FLUSH should always be enabled, but not show up on -v help.. but just setting the default mask doesn't quite wurk.. |
| [21:30:25] | Beirdo: | I notice I didn't do it myself (bad boy) |
| [21:30:52] | Beirdo: | hmmm |
| [21:31:00] | danielk22: | Beirdo: yep, I tried to do that + do {} while (0) protection and using names that won't conflict with variable names. |
| [21:31:08] | Beirdo: | :) |
| [21:31:29] | Beirdo: | yeah, it's always good to be careful |
| [21:32:05] | Beirdo: | and yeah, I like the while(0) methodology so we don't need to remove ; |
| [21:33:29] | Beirdo: | stuartm: YAY, good job removing more old cruft! :) |
| [21:34:44] | danielk22: | I mostly do that do it so if (..) MACRO_A(); else MACRO_B(); works as expected... |
| [21:35:24] | Beirdo: | danielk22: anyways, to fix the >=0, you can just move the && ((_LEVEL_)>=0) part into the if in the LOG() definitions, and all should be grand |
| [21:35:44] | danielk22: | already done :) |
| [21:35:51] | Beirdo: | yeah, it makes macros look like function calls :0 |
| [21:35:55] | Beirdo: | cool :) |
| [21:36:32] | Beirdo: | now that I have a replacement frontend in place, I can get back to fixing bugs, etc too. |
| [21:36:47] | Beirdo: | dying power supplies are evil |
| [21:37:44] | skd5aner: | quick question related to this upnp commit from mark, it says UPnP MediaServer support for mythfrontend. Does he mean to say MediaServer (as in a control point which can find other UPnP servers and provider their data) or a MediaRenderer to play back other UPnP server's content? http://www.mythtv.org/pipermail/mythtv-fireho . . . /000907.html |
| [21:38:08] | stuartm: | Beirdo: paul-h gets the credit, the only place still using those classes was the mythmusic metadata editor which he recently finished porting to mythui |
| [21:38:35] | Beirdo: | skd5aner: hmm, I'd have to take a look at what he implemented, but I thought he was working on MediaRenderer stuff |
| [21:38:46] | Beirdo: | cool |
| [21:38:54] | Beirdo: | next victim: mythgallery? :) |
| [21:39:36] | Beirdo: | skd5aner: the commit modified mediarenderer.cpp, I think he may have typoed the comment |
| [21:40:02] | skd5aner: | Beirdo: yea, that's what sort of tipped me off, plus some of the other comments about other servers and scanning |
| [21:40:30] | Beirdo: | yeah, it looks like he was adding support to connect to MediaServers |
| [21:40:38] | Beirdo: | as a MediaRenderer |
| [21:41:26] | Beirdo: | OK, I'd better go bug my coworker now |
| [22:18:33] | wagnerrp (wagnerrp!~wagnerrp_@mythtv/developer/wagnerrp) has quit (Read error: Connection reset by peer) | |
| [22:20:53] | wagnerrp (wagnerrp!~Wagner@nr-ft1-66-42-241-137.fuse.net) has joined #mythtv | |
| [22:36:15] | danielk22: | Hmmm, I wonder if the lack of activity on the MySQL related BE deadlock threads means it really is fixed in trunk now... *crosses fingers* |
| [22:39:36] | kormoc is now known as kormoc_afk | |
| [22:43:03] | kormoc_afk is now known as kormoc | |
| [22:43:37] | SteveGoodey (SteveGoodey!~steve@host86-160-43-155.range86-160.btcentralplus.com) has joined #mythtv | |
| [22:44:42] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 258 seconds) | |
| [23:05:49] | SteveGoodey (SteveGoodey!~steve@host86-160-43-155.range86-160.btcentralplus.com) has quit (Remote host closed the connection) | |
| [23:09:46] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (Ping timeout: 264 seconds) | |
| [23:17:58] | iamlindoro: | danielk22: Personally, I can't parse warpme's language most of the time-- I *thought* the last thing he said suggested it wasn't fixed, but then I re-read it and it sort of sounded like he hadn't updated or tried at all |
| [23:19:31] | danielk22: | iamlindoro: My understanding was he was about to try it.. and since that was a couple days ago and he was experiencing the problem pretty frequently... |
| [23:20:35] | danielk22: | iamlindoro: I think markk was also experiencing backend stability problems, which was probably the same issue.. so I think we'll know more definitively after his epic return to the UK finishes. |
| [23:24:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [23:46:13] | gigem (gigem!~gigem@mythtv/developer/gigem) has quit () | |
| [23:48:02] | gigem (gigem!~gigem@mythtv/developer/gigem) has joined #mythtv | |
| [23:48:18] | kormoc_afk (kormoc_afk!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [23:48:19] | kormoc_afk is now known as kormoc | |
| [23:50:53] | kormoc (kormoc!~kormoc@mythtv/developer/kormoc) has quit (Client Quit) | |
| [23:52:51] | kormoc_afk (kormoc_afk!~kormoc@mythtv/developer/kormoc) has joined #mythtv | |
| [23:52:52] | kormoc_afk is now known as kormoc | |
| [23:59:06] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 260 seconds) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.