| Saturday, August 6th, 2011, 00:03 UTC | ||
| [00:03:54] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [00:09:12] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [00:29:06] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has quit (Quit: nooneami) | |
| [00:45:59] | Beirdo: | danielk22: home now, so any time you have something for me to try for debugging, let me know :) |
| [00:53:47] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 258 seconds) | |
| [01:05:02] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [01:05:30] | gigem_ (gigem_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [01:05:31] | gigem_ (gigem_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [01:05:31] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [01:20:49] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has joined #mythtv | |
| [01:24:29] | andreax (andreax!~andreaz@p57B944D0.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [01:31:19] | knightr: | guys, I need a second pair of eyes, I'm trying to track down what happened in a refactoring that happened at the beginning of june... |
| [01:51:07] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
| [02:03:00] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [02:05:39] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [02:49:36] | danielk22: | knightr: I can't look it right now.. but maybe you can point out the changeset and I can look later... |
| [02:51:24] | iamlindoro: | danielk22: We were trying to figure out what happened with the MythVideo merge, where I may have broken the translations with a misunderstanding about whether the translation tools were able to reconnect translations across source files-- knightr is going to look into it and figure out if I did indeed break them, and if so we'll figure out a way to fix them |
| [02:58:31] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has quit (Quit: nooneami) | |
| [02:59:50] | knightr: | danielk22, thanks! As iamlindoro explained we were trying to track down translation merge issue related to that refactoring... Now that I have a good idea of what happened (I had missed a changeset it seems), I'll track down what and if anything needs fixing... Good night and thank you! |
| [03:04:01] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has joined #mythtv | |
| [03:13:56] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [03:16:11] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has quit (Quit: nooneami) | |
| [03:29:08] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has joined #mythtv | |
| [03:36:31] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [03:42:30] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 260 seconds) | |
| [03:43:11] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [03:53:16] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [03:53:34] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [03:57:29] | Beirdo: | danielk22: it's like something's keeping the filetransfer from noticing it's finished, but as of yet, I haven't found anything in the code that would explain it to me |
| [03:58:19] | Beirdo: | I'm sure I'm missing something obvious (one it's found) |
| [04:09:49] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [04:15:05] | Beirdo: | also a jobqueue insert failure on hostname = NULL |
| [04:15:34] | wagnerrp: | it should be defaulting to an empty string, not NULL |
| [04:15:39] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [04:15:54] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [04:15:54] | Beirdo: | mind you, I think danielk patched taht earlier today |
| [04:16:06] | Beirdo: | and I didn't pull today's changes |
| [04:17:12] | Beirdo: | so I'll ignore that one :) |
| [04:18:14] | Beirdo: | back to following throught the code to see why the filetransfer doesn't clear when I'd expect |
| [04:22:41] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 240 seconds) | |
| [04:23:33] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [04:26:47] | Beirdo: | ahhh, it clears it out when it gets downref(). That makes sense. |
| [04:27:13] | Beirdo: | now to determine why it takes its time getting to that code, I guess |
| [04:30:44] | Beirdo: | hehe. First off, I wonder why we use a vector instead of a QMap for the sockets... we do a linear search for the socket, it might be better to use a .find() |
| [04:30:58] | Beirdo: | but that's not what changed, just an observation |
| [04:35:35] | Beirdo: | well this should be fun |
| [04:35:45] | Beirdo: | playing a show with socket debugging on, at debug level |
| [04:35:55] | Beirdo: | gonna be a BIG log file |
| [04:46:50] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 252 seconds) | |
| [04:47:08] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [05:04:23] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [05:04:41] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 240 seconds) | |
| [05:05:48] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [05:14:55] | VManiac16 (VManiac16!~Unknown@69.4.155.83) has joined #mythtv | |
| [05:15:35] | mag0o_ (mag0o_!20001@slackhost.lynchmv.com) has joined #mythtv | |
| [05:15:47] | mag0o (mag0o!20001@slackhost.lynchmv.com) has quit (Ping timeout: 255 seconds) | |
| [05:16:24] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Ping timeout: 255 seconds) | |
| [05:16:51] | JEDIDIAH__ (JEDIDIAH__!~jedi@cpe-76-185-75-39.tx.res.rr.com) has quit (Ping timeout: 255 seconds) | |
| [05:17:49] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [05:18:07] | JEDIDIAH__ (JEDIDIAH__!~jedi@cpe-76-185-75-39.tx.res.rr.com) has joined #mythtv | |
| [05:18:12] | skd5aner (skd5aner!~skd5aner@cpe-069-132-082-180.carolina.res.rr.com) has quit (Ping timeout: 255 seconds) | |
| [05:18:39] | Computer_Czar (Computer_Czar!~Unknown@69.4.155.83) has quit (Ping timeout: 255 seconds) | |
| [05:19:02] | skd5aner (skd5aner!~skd5aner@cpe-069-132-082-180.carolina.res.rr.com) has joined #mythtv | |
| [05:21:39] | foobum (foobum!~mythtv@78.105.15.213) has quit (Read error: Operation timed out) | |
| [05:21:58] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [05:35:07] | Beirdo: | and it's looking (from lsof) that the deleted files (once I can delete them) remain open |
| [05:35:37] | Beirdo: | mythbacke 22587 gjhurlbu 180r REG 8,1 1095471104 25165916 /opt/mythtv/video2/default/2265_20110727180000.mpg (deleted) |
| [05:36:03] | Beirdo: | also, the socket for the data transfer is never closed. |
| [05:36:08] | Beirdo: | fun times :) |
| [06:07:21] | Beirdo: | now to run the frontend with file,playback |
| [06:59:11] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has quit (Quit: nooneami) | |
| [07:06:52] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
| [07:07:05] | Beirdo: | danielk22: I have a fix for the deletion issue |
| [07:07:09] | Beirdo: | it's messy |
| [07:08:24] | Beirdo: | the problem is that... with the changes to the RingBuffer class, when the buffer is deleted, it only calls the dtor for RingBuffer, not of the actual classes that inherit it (as the type of the pointer is RingBuffer *, that shouldn't surprise me) |
| [07:09:34] | Beirdo: | so, my workaround is in the RingBuffer dtor, use the type parameter, and cast this to the correct subclass, and call subclass::Destroy() which has the subclass' dtor contents, and the subclass dtors just call Destroy() |
| [07:10:19] | Beirdo: | sucky, but it works. There MUST be a more elegant way, but my brain is running outta juice. I'll get you a patch to look at for reference, but I have no doubts that you may want to do it in a smarter way |
| [07:21:28] | Beirdo: | danielk22: http://cgit.ipv6.beirdo.ca/git/mythtv/commit/ . . . 196cfd91eb98 |
| [07:21:36] | Beirdo: | oops, did it again.. |
| [07:21:52] | Beirdo: | http://www.beirdo.ca/git/mythtv/commit/?h=mth . . . 196cfd91eb98 |
| [07:36:28] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has joined #mythtv | |
| [07:39:09] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has joined #mythtv | |
| [07:42:33] | rooaus (rooaus!~rooaus@ppp59-167-126-229.static.internode.on.net) has joined #mythtv | |
| [07:51:16] | NightMonkey (NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey) has quit (Ping timeout: 250 seconds) | |
| [09:03:52] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has quit (Ping timeout: 252 seconds) | |
| [09:22:15] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has quit (Quit: nooneami) | |
| [09:24:05] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [09:43:11] | rooaus (rooaus!~rooaus@ppp59-167-126-229.static.internode.on.net) has quit (Ping timeout: 260 seconds) | |
| [09:47:45] | rooaus (rooaus!~rooaus@ppp59-167-126-229.static.internode.on.net) has joined #mythtv | |
| [09:57:46] | rooaus (rooaus!~rooaus@ppp59-167-126-229.static.internode.on.net) has quit (Ping timeout: 252 seconds) | |
| [09:57:55] | rooaus_ (rooaus_!~rooaus@ppp59-167-126-229.static.internode.on.net) has joined #mythtv | |
| [10:02:36] | rooaus_ (rooaus_!~rooaus@ppp59-167-126-229.static.internode.on.net) has quit (Ping timeout: 255 seconds) | |
| [10:05:03] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:06:01] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:40:01] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [10:45:10] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has joined #mythtv | |
| [10:55:15] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 255 seconds) | |
| [10:55:57] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [11:18:49] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has quit (Ping timeout: 252 seconds) | |
| [11:28:10] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has joined #mythtv | |
| [11:59:21] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 246 seconds) | |
| [12:00:14] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [12:03:23] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [12:03:48] | gigem_ (gigem_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [12:03:48] | gigem_ (gigem_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [12:03:48] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [13:04:55] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has quit (Quit: Leaving) | |
| [13:18:58] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has joined #mythtv | |
| [13:38:48] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [13:39:07] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [14:04:55] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 260 seconds) | |
| [14:05:07] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [14:05:36] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [14:08:05] | kth (kth!~kth@unaffiliated/kth) has quit (Client Quit) | |
| [14:14:53] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [14:18:45] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [14:19:01] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [14:24:24] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 240 seconds) | |
| [14:25:23] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [14:30:46] | marsilainen (marsilainen!~matt@host-2-97-8-169.as13285.net) has joined #mythtv | |
| [14:32:46] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 252 seconds) | |
| [14:34:45] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has quit (Ping timeout: 246 seconds) | |
| [14:46:32] | danielk22: | Beirdo: I can't look at that link, but did you try just adding virtual in front of ~RingBuffer() in ringbuffer.h ? |
| [14:48:30] | Beirdo: | one moment |
| [14:48:42] | Beirdo: | seems my wireless setup ate itsef |
| [14:49:18] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [14:52:03] | Beirdo: | hmm, no I didn't try that, gimme a moment |
| [14:55:20] | Beirdo: | just compiling now. As I said, I was pretty zonked out by the end, but I was sure there'd be a better way. |
| [14:56:02] | Beirdo: | heheh |
| [14:56:09] | Beirdo: | That seemed to work |
| [14:56:29] | Beirdo: | of all the silly things to forget :) |
| [14:56:31] | Beirdo: | Thanks |
| [14:56:56] | Beirdo: | so, I guess we need that to be virtual. We'll probably find others too. |
| [14:58:15] | Beirdo: | we probably want the FileRingBuffer dtor to chain back to the RingBuffer dtor though, right? |
| [15:00:07] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 240 seconds) | |
| [15:00:45] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [15:05:23] | stuartm: | it does that automatically so long as the base destructor, RingBuffer in this case, is virtual |
| [15:05:51] | Beirdo: | ahhh, so it odes |
| [15:05:54] | Beirdo: | does rather |
| [15:06:04] | Beirdo: | I had the debug print turned off :) |
| [15:09:07] | stuartm: | making the destructor virtual also ensures that the destructors are all called and in the correct order when you're dealing with casts to the base type, so golden rule is always to make your base class destructors virtual :) It saves a lot of tears ;) |
| [15:09:17] | Beirdo: | yup |
| [15:09:29] | Beirdo: | I remember that now that I'm getting to be more awake |
| [15:09:44] | Beirdo: | just cleaning up this mess here now |
| [15:10:18] | Beirdo: | one silly little word... had such an big effect |
| [15:10:19] | Beirdo: | heh |
| [15:10:58] | Beirdo: | it likely worked before as QObject likely enforces a similar concept in its dtor anyways |
| [15:11:16] | Beirdo: | so when it went from QThread to MThread and lost the QObject... |
| [15:13:52] | Beirdo: | so yeah, the remaining sum of that patch now is to make ~RingBuffer virtual, and some debugging logging which we really don't need anymore. |
| [15:13:55] | Dave123 (Dave123!~dave@cpe-74-74-200-106.rochester.res.rr.com) has quit (Quit: Leaving) | |
| [15:14:15] | Beirdo: | so if you can make that simple change for the patch, THAT should be fixed :) |
| [15:21:05] | Gibby (Gibby!~Gibby@204.118.10.244) has quit (Quit: ZNC - http://znc.sourceforge.net) | |
| [15:22:14] | danielk22: | Beirdo: I went ahead and updated master.. the RingBuffer dtor should already have been declared virtual. |
| [15:22:34] | danielk22: | I'll also make the MThread dtor virtual to prevent other similar problems. |
| [15:24:38] | danielk22: | good catch :) |
| [15:25:16] | Beirdo: | thanks, sorry I had to bumble around in my braindeadness last night not remembering something so obvious |
| [15:28:18] | Beirdo: | well, as online guides for C++ say... the behavior without the virtual is undefined by the spec, so who knows what GCC's choices will be for different versions even. |
| [15:31:14] | danielk22: | Beirdo: nah, the behavior is exactly what you saw. the destructor matching the type of the pointer gets called. |
| [15:32:40] | danielk22: | The rule of thumb is that if any method in the class is virtual the dtor should be as well. |
| [15:33:22] | Beirdo: | yeah. Anyways, I'm glad it was just that simple |
| [15:33:35] | Beirdo: | my workaround last night was hella messy |
| [15:33:36] | Beirdo: | :) |
| [15:33:55] | Beirdo: | that's what I get for trying to figure it out on not nearly enough sleep/caffeine |
| [15:42:53] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [15:54:57] | kormoc_afk is now known as kormoc | |
| [16:18:10] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has joined #mythtv | |
| [16:43:21] | NightMonkey (NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [16:46:24] | andreax (andreax!~andreaz@p57B9595A.dip.t-dialin.net) has joined #mythtv | |
| [16:56:11] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 240 seconds) | |
| [16:56:45] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [17:01:14] | Beirdo: | OK, updated to the latest master + latest mthread patch. Should be good to go for some more testing |
| [17:01:22] | Beirdo: | Oooh |
| [17:01:35] | Beirdo: | QMYSQL: Unable to connect |
| [17:01:35] | Beirdo: | Database error was: |
| [17:01:35] | Beirdo: | Too many connections |
| [17:01:43] | Beirdo: | not a moment too soon, it seems |
| [17:02:12] | Beirdo: | not sure what it's issue is, and I need to head out for the day. |
| [17:03:03] | Beirdo: | and now it's closing like 15–20 connections |
| [17:03:43] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [17:03:52] | sphery: | Beirdo: I'd say to increase max_connections in your my.cnf, but I don't know why we'd be using so many connection... FWIW: http://dev.mysql.com/doc/refman/5.1/en/too-many-connections.html |
| [17:04:09] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [17:04:20] | Beirdo: | anyways, I'll get back to it later in the day. Yah, I can fix the symptom, but it would be nice to fix the problem :) |
| [17:04:56] | sphery: | default for mysql is 151 (with MySQL 5.1.15+ or 100 with earlier)... I don't think we should be using that many, though??? |
| [17:05:29] | Beirdo: | DBManager224 is the highest I saw go by in the closing connection spew |
| [17:06:11] | sphery: | so mythtv tried to open 224? |
| [17:06:15] | Beirdo: | mind you, we don't reuse the number, so that just means 224 connections since startup of the backend |
| [17:06:20] | Beirdo: | not sure how many in parallel |
| [17:06:44] | Beirdo: | and I have to be out by the front door in about 10–15min :) |
| [17:07:04] | sphery: | can you check if your distro set a smaller max_connections in my.cnf? |
| [17:07:08] | stuartm: | paul-h: short of a major re-factor I think we need to pick either the xiph/vorbis tag or the id3 tag if we find both in a FLAC file, i.e. instead of trying to read both and somehow merge the two, any thoughts on which should be preferred? |
| [17:07:23] | sphery: | (just so we could see if maybe they're "optimizing" things in a way that will cause problems) |
| [17:07:37] | Beirdo: | sphery: I'm upping my connections for now. max_connections = 50 |
| [17:07:47] | sphery: | ah, so the distro did drop it from defaults |
| [17:08:27] | Beirdo: | Or I did earlier from whereever that got copied from, not sure anymore |
| [17:08:37] | sphery: | that said, 50 still sounds like a bunch... though with 90-some threads in mythtv and a few backends and a few frontends... |
| [17:08:40] | Beirdo: | upped it to 250 for now, we can look into our use :) |
| [17:08:59] | Beirdo: | be nice for it to run while I'm out :) |
| [17:09:04] | sphery: | heh, yeah |
| [17:09:58] | Beirdo: | seeya all in a while |
| [17:15:37] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 258 seconds) | |
| [17:15:52] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [17:16:03] | paul-h: | stuartm: I don't use FLAC at all so not really all that fussed which |
| [17:16:52] | paul-h: | I think xiph/vorbis would be the most common format used in FLAC |
| [17:18:18] | paul-h: | Can't we just prefer on format and then fall back to the other if we don't find what we want in the preferred format? |
| [17:21:51] | foobum (foobum!~mythtv@78.105.15.213) has quit (Read error: Operation timed out) | |
| [17:24:15] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [17:28:00] | paul-h: | stuartm: have you noticed the TagLib audio properties returning wildly inaccurate track lengths? |
| [17:29:27] | paul-h: | I've seen some tracks that should be about 3 minutes long being shown as 11 minutes or more |
| [17:35:34] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 240 seconds) | |
| [17:36:40] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has joined #mythtv | |
| [17:36:41] | paul-h: | EasyTAG makes the same mistake but Picard gets the correct length |
| [17:44:08] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [17:45:33] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [18:01:26] | paul-h: | stuartm: TagLib assumes a constant bit rate when calculating the length so gets it badly wrong if it's a VBR file unless it has a xing header in which case it uses that to get the accurate frame count to do the length calculation |
| [18:08:13] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has quit (Remote host closed the connection) | |
| [18:08:31] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [18:14:34] | stoffel (stoffel!~quassel@p57B4A97A.dip.t-dialin.net) has quit (Ping timeout: 264 seconds) | |
| [18:21:37] | stuartm: | paul-h: that's what I'm proposing, looking for one tag type and if it doesn't exist, then use the other |
| [18:22:31] | stuartm: | paul-h: I've not seen track length issues, but it appears all my mp3s include a xing header (encoded with lame) |
| [18:24:02] | stuartm: | I've tried several times to improve the length calculation, taglib actually seems to do much better than anything we had previously |
| [18:29:16] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 252 seconds) | |
| [18:30:12] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [18:32:35] | paul-h: | At the end of the day the track length isn't all that important it just looks odd when a track seems to end prematurely when you look at the progress bar and it will throw of the playlist time calculations |
| [18:33:16] | paul-h: | I'm thinking of just checking the length a track actually played for and update the length in the DB if it's wildly wrong |
| [18:46:46] | stuartm: | paul-h: yeah, that has been proposed in the past, it was just never implemented |
| [18:52:37] | kwmonroe` (kwmonroe`!~kwmonroe@129.42.208.179) has joined #mythtv | |
| [18:54:46] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has quit (Ping timeout: 240 seconds) | |
| [19:00:20] | kwmonroe (kwmonroe!~kwmonroe@32.97.110.58) has joined #mythtv | |
| [19:03:00] | kwmonroe` (kwmonroe`!~kwmonroe@129.42.208.179) has quit (Ping timeout: 252 seconds) | |
| [19:17:58] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [19:18:15] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [19:35:42] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has joined #mythtv | |
| [19:51:02] | NightMonkey (NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey) has quit (Ping timeout: 250 seconds) | |
| [20:19:23] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [20:20:42] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [20:43:53] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [20:53:24] | danielk22: | Beirdo: It's not surprising the DB connection use is up with the MThread patch. I was discussing earlier with sphery that we might want to just reuse the same connection repeatedly withing the same thread. |
| [20:54:36] | danielk22: | Beirdo: Even so we aren't able to automatically run PurgeIdleConnection() in threads that don't enter the Qt event loop; so we will end up with more active threads overall. |
| [20:54:39] | Beirdo: | yeah, we'll see what we need to do :) |
| [20:54:48] | Beirdo: | gotcha. |
| [20:55:03] | ** Beirdo is at work for a quick pitstop :) ** | |
| [20:55:33] | danielk22: | I have some code written to automatically run PurgeIdleConnection() for threads that do use the Qt event loop... I just need to test.. |
| [20:56:16] | Beirdo: | cool. It should behave well enough with 250 allowed connections for the day, i hope. |
| [20:57:56] | danielk22: | Yeah... if you went over that then there is some thread that's not calling RunEpilog()... |
| [20:58:05] | Beirdo: | I would think so :) |
| [20:58:17] | Beirdo: | we'll go over it I'm sure |
| [21:05:37] | stuartm: | I thought I remembered some commits adjusting playback/transfer buffers to improve wireless performance but I can't seem to find them? |
| [21:07:39] | sphery: | stuartm: https://github.com/MythTV/mythtv/commit/bff85941c ? |
| [21:07:46] | abqjp (abqjp!~jpabq@174-28-172-82.albq.qwest.net) has joined #mythtv | |
| [21:07:47] | abqjp (abqjp!~jpabq@174-28-172-82.albq.qwest.net) has quit (Changing host) | |
| [21:07:47] | abqjp (abqjp!~jpabq@mythtv/developer/jpabq) has joined #mythtv | |
| [21:08:10] | danielk22: | stuartm: there were some by me and then more by markk ... look at ringbuffer and filerringbuffer history.. i don't think wireless was mentioned explicitly.. |
| [21:08:24] | stuartm: | sphery: thanks, that was definitely one of them |
| [21:09:00] | danielk22: | stuartm: I backported the most important bits of my changes to 0.24-fixes. |
| [21:09:30] | danielk22: | (Very recently I think, it was sitting in my tree for a while). |
| [21:09:49] | stuartm: | danielk22: it was mentioned in the commit sphery just pasted, but also outside in irc/trac/email around the time |
| [21:11:21] | stuartm: | danielk22: ok, that's what I was wondering since I'm seeing some issues with 0.24-fixes that seemed to suggest the buffers were too small – the wireless connection is more than fast enough but just the slightest hint of latency was causing playback pauses |
| [21:18:26] | stuartm: | sphery: thanks for looking that up, my email client's search feature seems to be broken :) |
| [21:20:55] | danielk22: | stuartm: You can just increase the buffer size in 0.24-fixes, it's pretty small; but there were a lot of invasive changes in master that won't backport easily. |
| [21:21:07] | stuartm: | the above commit wasn't backported fwiw |
| [21:22:06] | danielk22: | Nope, but there was also another one by markk that could be backported that kept the fill rate closer to 99% |
| [21:22:27] | danielk22: | s/fill rate/buffer fill/ |
| [21:22:40] | stuartm: | yeah, I remember that one now |
| [21:33:08] | danielk22: | Beirdo: I've updated the mthread patch on #5501.. this is lightly tested but appears to noticably reduce the # of threads created. |
| [21:33:42] | danielk22: | s/# of threads/# of DB connections/ |
| [21:54:13] | xris (xris!~xris@mythtv/developer/xris) has quit (Quit: Terminated with extreme prejudice - dircproxy 1.2.0) | |
| [22:00:08] | stuartm: | I should know better than to ask a simple question in -users, if there's a faster way to develop a headache it would have to involve a sharp object and direct contact with brain tissue |
| [22:05:02] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [22:55:25] | xris (xris!~xris@mythtv/developer/xris) has joined #mythtv | |
| [23:06:10] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [23:12:29] | nooneami (nooneami!~nooneami@209-6-138-173.c3-0.bkl-ubr1.sbo-bkl.ma.cable.rcn.com) has quit (Quit: nooneami) | |
| [23:24:28] | skd5aner (skd5aner!~skd5aner@cpe-069-132-082-180.carolina.res.rr.com) has quit (Quit: Leaving) | |
| [23:32:41] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 260 seconds) | |
| [23:33:41] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [23:40:15] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 255 seconds) | |
| [23:41:07] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [23:42:48] | marsilainen (marsilainen!~matt@host-2-97-8-169.as13285.net) has quit (Ping timeout: 240 seconds) | |
| [23:46:06] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 260 seconds) | |
| [23:46:12] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [23:51:50] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [23:52:20] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Ping timeout: 260 seconds) | |
| [23:53:10] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.