| Thursday, August 4th, 2011, 00:31 UTC | ||
| [00:31:59] | gigem (gigem!~gigem@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [00:32:18] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 276 seconds) | |
| [00:33:05] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv | |
| [00:33:46] | gigem (gigem!~gigem@mythtv/developer/gigem) has joined #mythtv | |
| [00:53:55] | kormoc is now known as kormoc_afk | |
| [01:03:57] | davide (davide!~david@host103.16.intrusion.com) has joined #mythtv | |
| [01:05:35] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Ping timeout: 250 seconds) | |
| [01:11:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [01:39:03] | reynaldo (reynaldo!~rverdejo@pc-161-56-101-190.cm.vtr.net) has quit (Ping timeout: 255 seconds) | |
| [01:43:09] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [01:43:38] | kormoc_afk is now known as kormoc | |
| [02:11:00] | kc (kc!~Casper@unaffiliated/kc) has quit (Ping timeout: 260 seconds) | |
| [03:30:40] | Goga777 (Goga777!~Goga777@shpd-92-101-157-52.vologda.ru) has joined #mythtv | |
| [03:46:53] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
| [03:59:36] | reynaldo (reynaldo!~rverdejo@pc-161-56-101-190.cm.vtr.net) has joined #mythtv | |
| [04:06:01] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [04:07:54] | mike|2 (mike|2!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Ping timeout: 276 seconds) | |
| [04:13:31] | Goga777 (Goga777!~Goga777@shpd-92-101-157-52.vologda.ru) has quit (Remote host closed the connection) | |
| [04:20:05] | kc (kc!~Casper@unaffiliated/kc) has joined #mythtv | |
| [06:38:21] | chainsawbike (chainsawbike!~chainsawb@chainsawbike-1-pt.tunnel.tserv25.sin1.ipv6.he.net) has quit (Ping timeout: 260 seconds) | |
| [06:49:44] | chainsawbike (chainsawbike!~chainsawb@chainsawbike-1-pt.tunnel.tserv25.sin1.ipv6.he.net) has joined #mythtv | |
| [07:42:40] | NightMonkey (NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey) has quit (Ping timeout: 250 seconds) | |
| [07:57:11] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [08:16:06] | jafa (jafa!~nkelsey@c-98-234-217-27.hsd1.ca.comcast.net) has quit (Read error: Operation timed out) | |
| [08:33:57] | jafa (jafa!~nkelsey@c-98-234-217-27.hsd1.ca.comcast.net) has joined #mythtv | |
| [09:21:30] | Computer_Czar (Computer_Czar!~Unknown@69.4.155.83) has quit (Ping timeout: 260 seconds) | |
| [09:23:59] | Computer_Czar (Computer_Czar!~Unknown@69.4.155.83) has joined #mythtv | |
| [09:25:27] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
| [09:27:10] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
| [09:27:10] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [09:27:10] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [09:28:25] | cesman_ (cesman_!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has joined #mythtv | |
| [09:35:08] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
| [09:35:46] | jafa (jafa!~nkelsey@c-98-234-217-27.hsd1.ca.comcast.net) has quit (Ping timeout: 250 seconds) | |
| [09:38:57] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
| [09:38:57] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [09:38:57] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [09:56:32] | zCougar (zCougar!~cougar@2001:67c:32c:600:250:56ff:fe81:5f) has joined #mythtv | |
| [10:03:38] | jafa (jafa!~nkelsey@c-98-234-217-27.hsd1.ca.comcast.net) has joined #mythtv | |
| [10:05:02] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
| [10:05:52] | mike (mike!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
| [10:06:18] | mike is now known as Guest4173 | |
| [10:12:39] | stuartm_ (stuartm_!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
| [10:12:39] | stuartm_ (stuartm_!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [10:12:39] | stuartm_ (stuartm_!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [10:12:47] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
| [10:12:48] | stuartm_ is now known as stuartm | |
| [10:19:07] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
| [10:19:09] | stuartm_ (stuartm_!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
| [10:19:09] | stuartm_ (stuartm_!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [10:19:09] | stuartm_ (stuartm_!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [10:31:44] | stuartm_ is now known as stuartm | |
| [11:54:12] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 255 seconds) | |
| [11:54:27] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
| [11:54:27] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [11:54:27] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [12:03:55] | davide_ (davide_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [12:03:55] | davide_ (davide_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [12:03:55] | davide_ (davide_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [12:06:00] | davide (davide!~david@host103.16.intrusion.com) has quit (Ping timeout: 250 seconds) | |
| [12:08:50] | delpurg3 (delpurg3!~del_purge@bas3-montreal02-1096679575.dsl.bell.ca) has joined #mythtv | |
| [12:30:06] | danielk22: | sphery: your call |
| [12:31:42] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has quit (Ping timeout: 250 seconds) | |
| [12:48:30] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has joined #mythtv | |
| [12:49:21] | reynaldo (reynaldo!~rverdejo@pc-161-56-101-190.cm.vtr.net) has quit (Ping timeout: 260 seconds) | |
| [12:54:14] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has quit (Ping timeout: 250 seconds) | |
| [12:58:06] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [13:04:15] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has joined #mythtv | |
| [13:24:25] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has quit (Read error: Operation timed out) | |
| [13:26:36] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [13:28:02] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has joined #mythtv | |
| [13:33:47] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [13:36:14] | Gibby (Gibby!~Gibby@204.118.10.244) has joined #mythtv | |
| [13:53:07] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has quit (Ping timeout: 258 seconds) | |
| [14:08:03] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has joined #mythtv | |
| [14:15:00] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has quit (Ping timeout: 252 seconds) | |
| [14:15:50] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [14:21:12] | NightMonkey (NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey) has joined #mythtv | |
| [14:21:30] | j-rod|afk is now known as j-rod | |
| [14:40:41] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has quit (Remote host closed the connection) | |
| [14:41:17] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has quit (Quit: Leaving) | |
| [14:50:56] | gregL (gregL!~greg@cpe-74-76-125-87.nycap.res.rr.com) has joined #mythtv | |
| [14:58:50] | JamesHarrison (JamesHarrison!~jharrison@cpc4-addl4-2-0-cust450.6-3.cable.virginmedia.com) has joined #mythtv | |
| [15:03:02] | delpurg3 (delpurg3!~del_purge@bas3-montreal02-1096679575.dsl.bell.ca) has quit (Ping timeout: 240 seconds) | |
| [15:13:41] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [15:37:09] | stuartm_ (stuartm_!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [15:37:51] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 255 seconds) | |
| [15:43:03] | danielk22: | sphery: I think we're on to something.. I added some code to randomly disconnect in the exec() and got similar errors to what we've seen for the people with difficulties.. |
| [15:50:58] | foobum (foobum!~mythtv@78.105.15.213) has quit (Ping timeout: 246 seconds) | |
| [15:51:40] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
| [15:53:06] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
| [15:53:06] | stuartm (stuartm!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
| [15:53:06] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [15:53:08] | sphery: | danielk22: yeah, so the disconcerting part is why a connection would go missing in such a short timespan--after a prepare(), but before one of the exec()'s. TTBOMK, we don't keep any MSqlQuery's long term, and the init connection code always does a KickDatabase() to verify a good connection before handing one out. |
| [15:53:09] | danielk22: | sphery: gCoreContext->SaveSetting("ThemeUpdateStatus", QString()); this line is giving me problems.. but I think it's invalid.. QString() should be "" |
| [15:53:38] | danielk22: | sphery: I dunno, don't we keep the logging prepared statement for a very long time? |
| [15:54:07] | stuartm_ (stuartm_!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
| [15:55:34] | sphery: | Actually we don't--we get a new MSqlQuery from the cache for each insert, then prepare, bind, exec. I have a patch on my system that keeps it long term so we could really take advantage of prepared connections and just re-exec it with different data, but I've been afraid to apply it because of the lack of reliability of DB connections some users are facing. |
| [15:56:42] | danielk22: | sphery: ah ok.. well in anycase we shouldn't fall down flat if we need to reconnect between the prepare and exec, so I'll fix that and then you can apply the db logging efficiency patch :) |
| [15:56:54] | sphery: | heh, that would be great |
| [15:57:18] | danielk22: | btw is there a ticket # i should reference? |
| [15:57:24] | sphery: | we do have some code in there, now, that's attempting to deal with "invalid database" (which may actually be triggered by the lost connections?) |
| [15:57:54] | danielk22: | dunno what that is.. can you point it out to me? |
| [15:58:48] | sphery: | https://github.com/MythTV/mythtv/commit/528324d8 was the most-recent addition (see, also http://code.mythtv.org/trac/ticket/8903 ). Unfortunately, it doesn't seem to be easily revertable even for just testing. |
| [15:59:00] | sphery: | but there were a lot of other blocks that were attempting to handle the same issues |
| [16:00:56] | danielk22: | I've actually taken advantage of those for the reconnect. |
| [16:00:56] | sphery: | interesting... maybe we do keep a long-lived MSqlQueryInfo in the scheduler (at least did as of http://www.gossamer-threads.com/lists/mythtv/ . . . 87108#187108 ) |
| [16:02:21] | stoffel (stoffel!~quassel@p57B4A403.dip.t-dialin.net) has joined #mythtv | |
| [16:02:51] | danielk22: | got a conf call.. i'll pastebin a patch in a bit.. |
| [16:04:17] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
| [16:06:09] | danielk22: | http://pastebin.com/SCfdY3qB <-- this is on top of the mthread patch, but should apply without it fairly easily. |
| [16:11:17] | sphery: | danielk22: did you try killing individual connections through mysql to see if the effects differ (compared to killing the whole m_db)? (Using: kill connection <thread_id>; where you can get a list of threads with show proceslist; ) |
| [16:13:07] | sphery: | I'll try to run some tests of that, today, and see what happens with and without the patch |
| [16:13:35] | sphery: | patch looks good, though |
| [16:19:52] | sphery: | danielk22: I'm starting to wonder if the reason we might be having this problem--with the weird "between prepare and exec" timing--is that some connection used in some other thread was found by the recently-added "restart database" code to be disconnected, and then we ripped the whole MSqlDatabase out from under all threads, then restarted it... |
| [16:21:00] | danielk22: | there is a define in there DEBUG_RECONNECT that disconnects randomly.. |
| [16:22:01] | sphery: | yeah, saw that--just wondered what happened with individual connections disconnecting (but leaving the M/QSqlDatabase still valid and other M/QSqlQuery objects still connected) |
| [16:24:29] | delpurg3 (delpurg3!~del_purge@bas3-montreal02-1096679575.dsl.bell.ca) has joined #mythtv | |
| [16:24:57] | sphery: | I haven't actually read through the code to verify this is how it works, but I can imagine the if (!m_db->isOpen() && !m_db->Reconnect()) type approach getting used because an individual connection had timed out (while other valid connections were in use). Then, when we re-create the MSqlDatabase, the other MSqlQuery objects that were in use would have been connected to the MSqlQueryInfo that referenced the old MSqlDatabase, which we had just ... |
| [16:25:03] | sphery: | ... closed in Reconnect() |
| [16:26:05] | sphery: | this would explain how we could successfully check out a MSqlQuery from the cache, prepare it, then do one or more bindValue() calls, then fail on exec(), or fail/hang mid-way through a prepare() or ... |
| [16:29:42] | sphery: | danielk22: as far as tickets go, I think it's worth ref'ing #9704, #9773, and #9792 (even if it's not the cause of each, we've mentioned DB issues for all of them) |
| [16:37:44] | sphery: | danielk22: So, with your mthread patch, we have a per-thread connection pool--meaning that ripping the QSqlDatabase out with the m_db.close() in Reconnect() will only affect other MSqlQuery objects currently checked out by the same thread (which would significantly decrease the opportunities for behavior like I'm theorizing above to occur)? |
| [16:46:00] | jwhite (jwhite!~jwhite@75-146-153-89-minnesota.hfc.comcastbusiness.net) has quit (Remote host closed the connection) | |
| [16:48:34] | danielk22: | sphery: i still haven't groked all of this.. but we don't need kick database anymore do we? Reading the description it seems it was added to deal with MYSQL_OPT_RECONNECT=1 problems.. |
| [16:48:40] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has quit (Ping timeout: 250 seconds) | |
| [16:49:43] | iamlindoro (iamlindoro!~iamlindor@c-71-202-67-27.hsd1.ca.comcast.net) has joined #mythtv | |
| [16:49:44] | iamlindoro (iamlindoro!~iamlindor@c-71-202-67-27.hsd1.ca.comcast.net) has quit (Changing host) | |
| [16:49:44] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has joined #mythtv | |
| [16:52:59] | sphery: | danielk22: yeah, looks that way--I thought it was a per-MSqlQuery function, but it's actually per-MSqlDatabase, so it's as course-grained as the Reconnect() code, too |
| [16:54:10] | sphery: | seems that's been basically useless (and just slowing things down) since MySQL 5 (when they disabled the auto-reconnect stuff) |
| [16:54:12] | danielk22: | sphery: At any instant during program execution MSqlQuery has it's very own MSqlDatabase.. |
| [16:54:36] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has quit (Ping timeout: 240 seconds) | |
| [16:57:00] | sphery: | ah, yeah, you're right... which brings me back to being confused about how we can lose a connection between a prepare and exec |
| [16:57:40] | danielk22: | I think we're doing it to ourselves in the QSqlQuery::lastError().number() == 2006 check.. |
| [16:58:29] | danielk22: | I think before that was added the exec() just failed which was generally handled somehow.. |
| [16:59:29] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has joined #mythtv | |
| [17:02:52] | sphery: | that could be... The MSqlQuery::InitCon() calls KickDatabase(), but it only runs a query to verify the connection once every 30s--not every time it hands one out |
| [17:03:34] | sphery: | and it seems it is designed around the idea that someone will re-connect the connection for us |
| [17:04:17] | andreax (andreax!~andreaz@p57B928E6.dip.t-dialin.net) has joined #mythtv | |
| [17:04:25] | davide_ (davide_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [17:04:26] | davide_ (davide_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [17:04:26] | davide_ (davide_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [17:04:26] | danielk22: | yeah.. and the comment to kickdatabase says that it's to deal with the automatic reconnection logic. |
| [17:05:35] | sphery: | I do like your new approach better, though--because to use the "someone will reconnect" reliably with prepared queries, we'd need to extend KickDatabase() to run a test query on every run, and we'd need to prohibit any long-lived MSqlQuery usage, and it won't handle network issues while the MSqlQuery is in use |
| [17:06:19] | sphery: | so I think your approach + removing KickDatabase() is a good plan |
| [17:07:37] | sphery: | so it looks like Beirdo's code was basically doing for us exactly what MYSQL_OPT_RECONNECT=1 does... but with all the same problems MYSQL_OPT_RECONNECT=1 brings (in terms of failures with prepared statements, etc.) |
| [17:08:06] | sphery: | so he added support for MYSQL_OPT_RECONNECT even before we had Qt that supported it :) |
| [17:08:25] | danielk22: | yeah, I'm going to commit this to trunk and then backport to 0.24-fixes if it doesn't cause any new problems for a couple weeks...Unless I've overlooked something, this is the correct approach. |
| [17:08:34] | sphery: | and with a little extension to cover prepared queries, etc., it's better than the MYSQL_OPT_RECONNECT approach |
| [17:08:44] | sphery: | agreed |
| [17:08:47] | sphery: | thanks a lot for doing this |
| [17:09:33] | sphery: | and now I can't wait to improve DB logger efficiency by taking advantage of prepare statements... I'll hold off on pushing that change until we've had some time to test your patch, though--just so we aren't introducing new variables into the equation |
| [17:09:35] | danielk22: | Yeah, I did drop support for binding output values in the patch.. but we aren't using that feature at all.. if someone wants it adding it back wouldn't be a big deal.. but this keeps the patch size down. |
| [17:20:03] | sphery: | oh, and the ThemeUpdateStatus change looks good... not sure how that was ever working--but it explains why I haven't been notified, lately. |
| [17:31:19] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
| [17:40:49] | Mousey (Mousey!~wtfisme@ross154.net) has joined #mythtv | |
| [17:51:20] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
| [18:17:50] | delpurg3: | is there a version of transcode like the dvd::rip gui that accepts .ts (Transport Stream). im looking to use the cluster encode function but am not very confident in command line programs. |
| [18:18:42] | iamlindoro: | delpurg3: Completely wrong channel, see topic |
| [18:18:57] | iamlindoro: | This is the MythTV development channel, and that question is offtopic even for our users channel |
| [18:19:07] | delpurg3: | sorry |
| [18:19:16] | delpurg3: | where would i go for help in this? |
| [18:20:28] | iamlindoro: | No idea, you might start in your distro's channel |
| [18:20:44] | delpurg3: | thanks sorry to bother |
| [18:20:51] | delpurg3 (delpurg3!~del_purge@bas3-montreal02-1096679575.dsl.bell.ca) has left #mythtv ("Leaving") | |
| [18:34:37] | danielk22: | sphery: We still need KickDatabase just to call open() on the DB if it is closed and to reset m_lastDBKick which we also use to track when a DB connection was last used for closing down excess connections. I think we may not need m_last_bindings, if can just use QSqlQuery::boundValues(). |
| [19:19:34] | cesman_ is now known as cesman | |
| [19:19:44] | cesman (cesman!~cecil@pool-108-38-214-203.lsanca.fios.verizon.net) has quit (Changing host) | |
| [19:19:44] | cesman (cesman!~cecil@pdpc/supporter/professional/cesman) has joined #mythtv | |
| [19:52:24] | stoffel (stoffel!~quassel@p57B4A403.dip.t-dialin.net) has quit (Remote host closed the connection) | |
| [20:22:23] | danielk22: | sphery: It's committed.. But, I don't think it's a full fix without the MThread per thread sql connection changes. |
| [20:23:26] | danielk22: | But this portion is viable for a backport to 0.24-fixes... |
| [20:23:59] | danielk22: | & should really work in 99.99% of cases. |
| [20:39:54] | sphery: | danielk22: thanks... I sent an update to the -users list and asked those who are seeing the issue and running master to update and see if it helps. |
| [20:40:09] | sphery: | Oh, and now I see you sent one, too :) |
| [20:40:52] | MythBuild: | build #1938 of master-linux-64bit is complete: Failure [failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/1938 blamelist: Daniel Kristjansson <danielk@cuymedia.net > |
| [20:43:10] | danielk22: | bah, forgot to test the plugins.. |
| [20:45:50] | sphery: | yeah, I knew mythmusic was doing some, er, "unusual" things with the db, but didn't think it would have issues |
| [20:47:43] | MythBuild: | build #723 of master-freebsd-64bit is complete: Failure [failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/723 blamelist: Daniel Kristjansson <danielk@cuymedia.net > |
| [20:49:56] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
| [20:52:45] | Beirdo: | oh oh ;) |
| [20:54:41] | danielk22: | Should be pretty easy to fix. mythmusic is using one qt3support call which has a direct Qt4 replacement + two methods I just didn't create a thunks for. |
| [20:58:30] | Beirdo: | oooh, more qt3support removal :) |
| [21:02:13] | Trisooma (Trisooma!~trisooma@82.95.240.160) has joined #mythtv | |
| [21:04:24] | Trisooma (Trisooma!~trisooma@82.95.240.160) has quit (Client Quit) | |
| [21:04:26] | MythBuild: | build #1690 of master-linux-32bit is complete: Failure [failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/1690 blamelist: Daniel Kristjansson <danielk@cuymedia.net > |
| [21:05:21] | Trisooma (Trisooma!~trisooma_@82.95.240.160) has joined #mythtv | |
| [21:06:21] | Trisooma (Trisooma!~trisooma_@82.95.240.160) has left #mythtv () | |
| [21:06:38] | Trisooma_ (Trisooma_!~trisooma_@82.95.240.160) has joined #mythtv | |
| [21:09:00] | ** stuartm gags MythBuild ** | |
| [21:09:15] | Trisooma_ (Trisooma_!~trisooma_@82.95.240.160) has quit (Client Quit) | |
| [21:09:47] | Trisooma (Trisooma!~trisooma_@82.95.240.160) has joined #mythtv | |
| [21:19:17] | paul-h: | stuartm: did you know that flac files can have id3v2 tags added to them? Our tagger only supports the xiph comments at the moment |
| [21:20:27] | paul-h: | How easy would it be to add support for both formats? |
| [21:23:54] | dblain: | danielk22: If you have issues with the Service API implementation please discuss with me. There is a lot of good reasons I've implemented it the way I have. |
| [21:23:56] | stuartm: | paul-h: I did know but I hadn't done anything to support ID3 because I don't generally use flac |
| [21:24:26] | dblain: | If you think it's bad coding, maybe I shouldn't be contributing any longer. |
| [21:24:38] | stuartm: | paul-h: it should be trivial though, I can add support |
| [21:26:39] | paul-h: | stuartm: that would be cool if you could. It's in reference to this thread on the users list http://www.mythtv.org/pipermail/mythtv-users/ . . . /319041.html |
| [21:26:57] | stuartm: | if we can't write both xiph and id3v2 to the same file then we'd need a new setting, but I can live with that |
| [21:27:17] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
| [21:27:34] | stuartm: | read support for both is no big deal |
| [21:29:34] | MythBuild: | build #738 of master-linux-ppc is complete: Failure [failed compile plugins] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . c/builds/738 blamelist: Daniel Kristjansson <danielk@cuymedia.net > |
| [21:29:41] | paul-h: | It's mainly to get the album art images it seems so read access is better than nothing |
| [21:31:08] | Trisooma: | stuartm: will 'embedded' album art for flac also be supported when you add this? |
| [21:31:31] | paul-h: | taglib 1.7 does support the xiph coverart images but that may be too new for us |
| [21:32:14] | stuartm: | Trisooma: for ID3v2 tags, yes – we can support taglib 1.7 for xiph tags if no-one minds the odd ifdef |
| [21:32:51] | wagnerrp: | Trisooma: but but... youre just wasting that 30KB per song keeping redundant copies of the artwork! |
| [21:33:23] | ** wagnerrp lurks back under the bridge ** | |
| [21:33:53] | Trisooma: | wagnerrp: my library already contains the artwork (its for my cowon) |
| [21:34:06] | stuartm: | taglib's generally a breeze to work with |
| [21:34:16] | wagnerrp: | i know, im making fun of the other guy in that mailing list thread |
| [21:34:33] | Trisooma: | are ogg tags already supported (just wondering) |
| [21:35:06] | stuartm: | Trisooma: yes, they are |
| [21:36:06] | stuartm: | we support most tag formats to some extent |
| [21:36:27] | stuartm: | I can't remember if we support albumart in ogg ... |
| [21:37:24] | paul-h: | No only id3v2 albumart |
| [21:37:48] | Trisooma: | will this be part of mythmusic rewrite |
| [21:38:05] | Trisooma: | if so, can i help in any way? |
| [21:39:51] | MythBuild: | build #1939 of master-linux-64bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/1939 |
| [21:41:28] | wagnerrp: | thats a bit one, 23 minutes to build even with ccache |
| [21:41:59] | paul-h: | Trisooma: Albumart plays a bigger role in the rewrite if themers want it. We've had support for embedded album art for a while now but only in id3v2 tags |
| [21:43:11] | stuartm: | Trisooma: it's independent of the re-write, the metadata classes were re-written some time ago now, 0.24 supports reading/writing of several tag formats, but apparently I've only added albumart support for id3v2 |
| [21:44:12] | stuartm: | I only use ID3v2 tagged mp3s so ... |
| [21:44:45] | Trisooma: | my lib contains flacs/ogg as well, is this something i can look into |
| [21:45:04] | Trisooma: | or would that be a waste of time? |
| [21:45:44] | stuartm: | if taglib supports artwork in other tag formats then we can add support for them very easily, if they aren't supported by taglib then a lot more work would be involved |
| [21:46:51] | Trisooma: | if i recall correctly taglib (at least) has read support for artwork |
| [21:47:28] | stuartm: | Trisooma: honestly I expect to have something written before you'd get up to speed on the code and taglib api, I know it too well so I wouldn't make this the project you set for yourself |
| [21:47:29] | MythBuild: | build #724 of master-freebsd-64bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/724 |
| [21:48:15] | stuartm: | Trisooma: if you're looking for something to do then maybe paul-h can help |
| [21:48:26] | Trisooma: | stuartm: thanks for the heads up |
| [21:49:25] | Trisooma: | just browsing to see if i can code something for mythtv |
| [21:50:46] | Trisooma: | paul-h: are tickets my best bet if i want to code something? |
| [21:53:21] | stuartm: | Trisooma: understood and the album artwork stuff might have been a nice easy start, but I'd like to do this one myself |
| [21:55:17] | stuartm: | paul-h: seems that 1.7 might be too new to make it the new min version, even Mandriva 2011 which isn't due for release until the end of August is only offering 1.6.3 |
| [21:55:49] | Trisooma: | stuartm: np |
| [21:56:42] | stuartm: | but I can make the xiph albumart support a compile time option if anyone wants support badly enough to install unstable packages or to compile taglib from source |
| [22:00:00] | paul-h: | stuartm: I think I say a news item saying 1.7 came out in March so it's been around a while but I agree it's too soon to make that the minimum |
| [22:01:10] | paul-h: | Trisooma: Thank's for the offer but not sure what you could do really |
| [22:01:22] | wagnerrp: | march 21th |
| [22:01:25] | wagnerrp: | 12th |
| [22:01:43] | wagnerrp: | ... just when all those centos users are finally up to date :) |
| [22:05:12] | j-rod is now known as j-rod|afk | |
| [22:06:07] | MythBuild: | build #1691 of master-linux-32bit is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . /builds/1691 |
| [22:12:09] | Trisooma (Trisooma!~trisooma_@82.95.240.160) has quit (Quit: Enuff for today) | |
| [22:39:10] | andreax (andreax!~andreaz@p57B928E6.dip.t-dialin.net) has quit (Read error: Connection reset by peer) | |
| [22:48:53] | MythBuild: | build #739 of master-linux-ppc is complete: Success [build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . c/builds/739 |
| [23:08:28] | Beirdo: | paul-h: still around? |
| [23:09:00] | Beirdo: | the shared cookie jar thingy is giving me problems when I try to use mythbrowser from mythnews. |
| [23:09:52] | Beirdo: | can we just make mythbrowser use its own cookie jar separate from the downloader? I made it do that for testing, and it seems to be operational, but I wasn't sure what your intentions were long-term, etc. |
| [23:10:07] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Ping timeout: 240 seconds) | |
| [23:15:00] | paul-h: | Beirdo: I really need to get to bed work in the morning. We used to have a separate cookie jar but that caused problems with downloading in MythBrowser if a cookie was required |
| [23:15:39] | Beirdo: | hmm. OK |
| [23:15:57] | paul-h: | For example many web mail clients use cookies when they download attachments |
| [23:16:16] | Beirdo: | well, I'll not checkin what I have, but continue to test that way. We do need to get it all figured out sometime soonish (before 0.25 release whenever that is) |
| [23:16:24] | Beirdo: | but it don't need to be tonight :) |
| [23:17:31] | Beirdo: | gotcha though. We'll just leave it as an open issue :) |
| [23:19:38] | paul-h: | Is this the issue you reported that you only see if you run a debug build of qt or have warning enabled |
| [23:20:07] | Beirdo: | yeah, it craps out saying it can't move the cookie jar to a new thread |
| [23:21:08] | Beirdo: | which means that if you don't have the warnings as fatal, it's probably just leaving it in the old thread, and we are writing to another thread's data space, which is likely to cause us odd crashes at some future time |
| [23:21:20] | Beirdo: | which would be good to avoid :) |
| [23:21:55] | Beirdo: | for now, I just made the mythbrowser part create its own so I could test something else in mythnews |
| [23:22:21] | paul-h: | If you get time have a look at the Qt docs maybe I'm misunderstanding what needs to be done to share the cookies jar. The docs do mention you can share them though |
| [23:22:47] | Beirdo: | yeah, I noticed that and I toyed with it a bit. I'll take a look at that again though |
| [23:23:15] | Beirdo: | if I find something that seems to work, I'll be sure to pass the patch by you before committing it, sound good? |
| [23:24:00] | paul-h: | Yep thanks, Bed time for me, got to get up at 6.30 in the morning :) |
| [23:24:07] | Beirdo: | night, have a good sleep |
| [23:34:38] | Beirdo: | danielk22: any ETA on when the patch on #5501 would be committed? |
| [23:37:36] | danielk22: | Beirdo: prolly monday or tuesday |
| [23:38:14] | Beirdo: | OK, cool. Did you want me to test it on my boxes too, or you have it covered? |
| [23:40:49] | knightr (knightr!~knightr@mythtv/developer/knightr) has quit (Read error: Connection reset by peer) | |
| [23:41:03] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
| [23:41:18] | knightr (knightr!~knightr@mythtv/developer/knightr) has joined #mythtv | |
| [23:44:57] | davide_ (davide_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
| [23:45:22] | davide_ (davide_!~david@host103.16.intrusion.com) has joined #mythtv | |
| [23:45:22] | davide_ (davide_!~david@host103.16.intrusion.com) has quit (Changing host) | |
| [23:45:22] | davide_ (davide_!~david@mythtv/developer/gigem) has joined #mythtv | |
| [23:46:13] | danielk22: | Beirdo: the more testing the better |
| [23:46:25] | foobum (foobum!~mythtv@78.105.15.213) has quit (Remote host closed the connection) | |
| [23:46:39] | Beirdo: | OK :) I'll work that in tonight so it can get some more soak |
| [23:46:44] | foobum (foobum!~mythtv@78.105.15.213) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.