Tuesday, August 2nd, 2011, 00:00 UTC | ||
[00:00:46] | Meliorator (Meliorator!m@dunnington.eu) has quit (Read error: Connection reset by peer) | |
[00:05:17] | wagnerrp: | Beirdo: im looking at system-unix.cpp, and how we spawn the various singleton threads for signals and IO |
[00:05:17] | Meliorator (Meliorator!m@dunnington.eu) has joined #mythtv | |
[00:05:26] | wagnerrp: | is there potential for a race condition there? |
[00:05:58] | Beirdo: | not that I know of |
[00:06:08] | wagnerrp: | two MythSystem entries spawned at the same time, failing the same check, and creating a new thread stored to the singleton |
[00:06:10] | wagnerrp: | one will end up lost |
[00:06:12] | Beirdo: | well, technically, maybe |
[00:06:32] | Beirdo: | the very very first call to MythSystem would have to be a double |
[00:06:34] | wagnerrp: | technically maybe, but anything to realistically worry about? |
[00:06:41] | Beirdo: | after the first time, there's no chance |
[00:07:01] | wagnerrp: | right, im just looking at the file delete thread in which i do the same thing |
[00:07:25] | Beirdo: | and our code doesn't do two at the same time at startup, but... we could protect against it with a startup mutex around the creation |
[00:07:33] | wagnerrp: | it just means that thread is going to sit there unused until program termination |
[00:07:57] | Beirdo: | yeah, essentially |
[00:08:11] | wagnerrp: | i cant see how it would actually do any real harm... |
[00:08:12] | Beirdo: | might be worth idiot-proofing, actually |
[00:08:22] | wagnerrp: | aside from some extra cycles and a bit of additional memory |
[00:08:26] | Beirdo: | yeah, pfft |
[00:14:24] | Meliorator (Meliorator!m@dunnington.eu) has quit (Ping timeout: 276 seconds) | |
[00:19:10] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[00:20:18] | Meliorator (Meliorator!m@dunnington.eu) has joined #mythtv | |
[00:23:21] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 260 seconds) | |
[00:34:33] | Meliorator (Meliorator!m@dunnington.eu) has quit (Read error: Connection reset by peer) | |
[00:35:18] | Meliorator (Meliorator!m@dunnington.eu) has joined #mythtv | |
[00:52:48] | kormoc is now known as kormoc_afk | |
[01:00:47] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[01:01:59] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[01:05:40] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
[01:06:09] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
[01:15:18] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
[01:18:35] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv | |
[01:35:34] | sailerboy (sailerboy!sailerboy@ipv61.sailerboy.net) has quit (Ping timeout: 264 seconds) | |
[01:39:33] | Meliorator (Meliorator!m@dunnington.eu) has quit (Ping timeout: 276 seconds) | |
[01:40:54] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[01:43:29] | danielk22: | wagnerrp: I always mutex lock singleton creation in the factory method. It's trivially easy to do and avoids me wasting mental cycles on whether some change to the how the class is stared will cause a problem down the road. |
[01:45:17] | Meliorator (Meliorator!m@dunnington.eu) has joined #mythtv | |
[01:45:18] | danielk22: | wagnerrp: static QMutex x; static Y *y=NULL; Y *Y:Create() { QMutexLocker l(&x); if (!y) y = new Y(); return y; } |
[01:52:45] | danielk22: | iamlindoro: there is something wrong with the 916597d95 on the first two files. It shows every line as being changed.. ^M ? |
[01:53:27] | iamlindoro: | danielk22: That's as it came from SD |
[01:53:49] | sailerboy (sailerboy!sailerboy@ipv61.sailerboy.net) has joined #mythtv | |
[01:54:03] | iamlindoro: | danielk22: but yeah, I assumed so-- it seemed innocuous enough |
[01:54:31] | iamlindoro: | ie, all other things being equal/functional, no need to rewrite the file and diverge from upstream on principal |
[01:55:10] | iamlindoro: | Now if they'd just sell me a Prime from the top of the list, I could test it for real ;) |
[01:56:04] | danielk22: | iamlindoro: look at https://github.com/MythTV/mythtv/commit/916597d95 it doesn't look right... it looks like the commit fubarred the history of the first two files. |
[01:56:45] | iamlindoro: | danielk22: history looks intact to me: https://github.com/MythTV/mythtv/commits/9165 . . . run_device.c |
[01:57:07] | iamlindoro: | It may not easily show the changeset, but that's the file as it came from their lib tgz |
[01:57:42] | iamlindoro: | Since they don't have a public source control, I can't easily apply the changes by hand, so how would you rather I handle it? |
[02:00:22] | danielk22: | iamlindoro: all you need to do is run a dos2unix converter on the files before committing. Like many devs that develop on windows they are inconsistent about line termination and git isn't as smart as svn,cvs,rcs,etc wrt to text files... |
[02:01:02] | danielk22: | iamlindoro: I believe you can create a git config file to fix this automagically.. but I don't know how.. |
[02:02:03] | wagnerrp: | svn used to allow custom scripts to be run on commit |
[02:02:07] | wagnerrp: | likely git has the same thing |
[02:02:09] | danielk22: | http://help.github.com/line-endings/ |
[02:02:56] | danielk22: | wagnerrp: git does, but we don't run our own git server. |
[02:03:07] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[02:03:32] | wagnerrp: | there isnt a server and client-side part to that? |
[02:03:46] | wagnerrp: | i figured server side would be disabled on github for security reasons |
[02:05:26] | danielk22: | wagnerrp: the link i just posted is for the client side setup.. but that only works if every developer does that on every machine they work from; we would need to run our own server to run a commit hook to do a sanity check. |
[02:06:02] | clever: | i think the client side script is only for devs who tend to actualy mess things up |
[02:07:32] | jafa (jafa!~nkelsey@c-98-234-217-27.hsd1.ca.comcast.net) has joined #mythtv | |
[02:07:42] | danielk22: | clever: anyone doing merges of code from 3rd parties can be hit by this.. you don't have to be editing from a windows machine yourself to get fubarred by it. |
[02:07:49] | jafa: | hi guys, checking in RE libhdhomerun |
[02:07:50] | clever: | ahh |
[02:08:03] | clever: | merging from code writen by a windows system, yeah, that would also apply |
[02:08:30] | iamlindoro: | jafa: ? |
[02:08:35] | wagnerrp: | yeah, i know RDV's stuff used to cause lots of these problems |
[02:09:04] | danielk22: | jafa == nick & sillicon dust |
[02:09:13] | ** iamlindoro knows this ** | |
[02:10:01] | iamlindoro: | jafa: https://github.com/MythTV/mythtv/commit/f6eaa . . . 0bd2b9a0424b https://github.com/MythTV/mythtv/commit/f50ce . . . aabca2360400 |
[02:10:01] | jafa: | saw some commits updating libhdhomerun... is Robert McNamara around? |
[02:10:05] | ** iamlindoro is he ** | |
[02:10:15] | jafa: | ah, hi! |
[02:10:23] | iamlindoro: | hi there |
[02:11:11] | jafa: | there is a bug in the sock code when used under OS X ... libhdhomerun was re-released today (20110801) |
[02:11:18] | iamlindoro: | hah |
[02:11:27] | jafa: | no API changes, just a bugfix |
[02:11:29] | iamlindoro: | must have been just after I grabbed it |
[02:11:33] | iamlindoro: | no worries, I'll get the fix |
[02:11:47] | jafa: | thanks |
[02:12:05] | iamlindoro: | bad timing on my part :) |
[02:12:21] | jafa: | no no, great you are on top of it |
[02:14:07] | iamlindoro: | jafa: Just the stuff in hdhomerun_sock_posix.c ? |
[02:15:07] | ** wagnerrp wonders if iamlindoro is positioning himself into needing hardware for 'testing' ** | |
[02:15:09] | wagnerrp: | :P |
[02:15:10] | jafa: | yes – only that one file changed todays release |
[02:15:41] | jafa: | (even I don't have a 6CC unit) |
[02:16:10] | ** iamlindoro isn't greedy, 3 will be fine ;) ** | |
[02:16:13] | danielk22: | iamlindoro: thx for fixing the crlf issue, it's much easier to review now. |
[02:16:23] | iamlindoro: | danielk22: np |
[02:16:31] | wagnerrp: | if you subscribe to the -users mailing list, there was at least one user who got one in the mail and was having some trouble getting it configured |
[02:16:32] | jafa: | CRLF – which files? |
[02:16:37] | danielk22: | jafa: iamlindoro maybe won't say it but he's in need of a hdhomerun :) |
[02:16:40] | iamlindoro: | jafa: hdhomerun_device.* |
[02:16:51] | jafa: | checking... |
[02:17:02] | iamlindoro: | jafa: 0801 pushed |
[02:17:55] | jafa: | LF only format in our system |
[02:18:37] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[02:21:01] | danielk22: | jafa what revision control system do you use internally? many of them convert line endings to crlf on windows machines by default even if they have lf in the repo. |
[02:21:01] | iamlindoro: | jafa: it looks like that may have actually been fixed between 0729 and 0801 |
[02:21:10] | iamlindoro: | Looking at 0729, the files are DOS format |
[02:21:13] | iamlindoro: | those two, anyway |
[02:21:22] | iamlindoro: | but looks file in 0801 |
[02:21:24] | iamlindoro: | er fine |
[02:21:27] | jafa: | odd – same build script |
[02:21:44] | jafa: | oh, wonder if svn diff ignores line endings |
[02:21:56] | jafa: | I ran a dos2unix command, then diff – no changes |
[02:22:09] | jafa: | it might have fixed the endings and not shown up in the diff |
[02:22:27] | iamlindoro: | oh well, all's well that ends well |
[02:22:32] | jafa: | our internal standard is LF for everything including windows |
[02:22:53] | jafa: | will run some tests – want to avoid it happening again |
[02:27:49] | danielk22: | jafa svn is one of those RCS's that convert line endings by default on windows machines.. |
[02:27:55] | ** Beirdo waits for his HDHR3 on RMA to make it back to him. :) ** | |
[02:29:48] | Beirdo: | Oh good, UPS sees my package heading in. good. |
[03:47:09] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[04:40:08] | Goga777 (Goga777!~Goga777@shpd-78-36-164-121.static.vologda.ru) has joined #mythtv | |
[05:08:44] | Goga777 (Goga777!~Goga777@shpd-78-36-164-121.static.vologda.ru) has quit (Remote host closed the connection) | |
[07:31:22] | dekarl (dekarl!~dekarl@dslb-084-058-164-202.pools.arcor-ip.net) has quit (Ping timeout: 264 seconds) | |
[07:50:12] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
[07:52:47] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv | |
[08:09:28] | pheld (pheld!wjbqdc@109-109-76-195.bb.cust.telefiber.no) has quit (Quit: Leaving.) | |
[08:20:21] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
[09:02:00] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has quit (Quit: Leaving.) | |
[09:27:53] | stuartm: | it's a real shame that git doesn't handle the line endings automatically and even the option to handle them is client side, instead of server side |
[10:05:02] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has quit (Remote host closed the connection) | |
[10:05:31] | sraue (sraue!~stephan@xbmc/staff/sraue) has quit (Ping timeout: 252 seconds) | |
[10:05:31] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has quit (Ping timeout: 252 seconds) | |
[10:05:50] | mike|3 (mike|3!~mike@c-24-21-63-118.hsd1.or.comcast.net) has joined #mythtv | |
[10:06:18] | foobum (foobum!~mythtv@78-105-15-213.zone3.bethere.co.uk) has joined #mythtv | |
[10:06:31] | sraue (sraue!~stephan@xbmc/staff/sraue) has joined #mythtv | |
[10:13:27] | kenni (kenni!~kenni@mythtv/developer/kenni) has quit (Ping timeout: 240 seconds) | |
[10:13:41] | XChatMav (XChatMav!~MaverickT@111.86.233.220.static.exetel.com.au) has quit (Quit: Leaving) | |
[10:16:41] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has quit (Ping timeout: 240 seconds) | |
[10:22:29] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv | |
[10:34:36] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
[10:45:22] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[10:47:33] | stuartm: | nice, we're finally going to get 'fair use' type legalisation in the UK making it legal to 'format shift' e.g. ripping CDs/DVDs |
[10:50:23] | stuarta: | \o/ |
[10:51:28] | stuartm: | well, it remains to be seen if the government can get the bill passed and that depends on how many MPs are bought by the industry |
[10:53:15] | stuarta: | indeed |
[10:53:43] | stuarta: | at least with the news of the world fiasco going on, there should be a few less than usual |
[10:56:20] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[11:13:10] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[11:17:43] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Ping timeout: 258 seconds) | |
[11:57:42] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has quit (Ping timeout: 252 seconds) | |
[12:05:01] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
[12:05:30] | gigem_ (gigem_!~david@host103.16.intrusion.com) has joined #mythtv | |
[12:05:30] | gigem_ (gigem_!~david@host103.16.intrusion.com) has quit (Changing host) | |
[12:05:30] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
[12:41:54] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has quit (Ping timeout: 276 seconds) | |
[12:43:02] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has joined #mythtv | |
[12:59:45] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has quit (Ping timeout: 260 seconds) | |
[13:01:21] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
[13:12:01] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has joined #mythtv | |
[13:14:06] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has quit (Ping timeout: 240 seconds) | |
[13:16:47] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has quit (Ping timeout: 240 seconds) | |
[13:19:50] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[13:24:46] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has joined #mythtv | |
[13:31:39] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
[13:46:27] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has quit (Ping timeout: 276 seconds) | |
[13:54:37] | stuartm_ (stuartm_!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has joined #mythtv | |
[13:54:42] | stuartm_ (stuartm_!~stuartm@cpc4-derb9-0-0-cust534.8-3.cable.virginmedia.com) has quit (Changing host) | |
[13:54:42] | stuartm_ (stuartm_!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
[13:56:47] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
[14:04:34] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has joined #mythtv | |
[14:11:10] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has quit (Ping timeout: 252 seconds) | |
[14:12:15] | Meliorator (Meliorator!m@dunnington.eu) has quit (Ping timeout: 276 seconds) | |
[14:13:53] | j-rod|afk is now known as j-rod | |
[14:17:25] | stuartm_ is now known as stuartm | |
[15:14:52] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
[15:18:17] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[15:23:45] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Quit: jya) | |
[15:25:17] | Meliorator (Meliorator!m@dunnington.eu) has joined #mythtv | |
[15:58:12] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Remote host closed the connection) | |
[16:22:47] | Meliorator (Meliorator!m@dunnington.eu) has quit (Read error: Connection reset by peer) | |
[16:25:17] | Meliorator (Meliorator!m@dunnington.eu) has joined #mythtv | |
[16:30:15] | noahric (noahric!~noahric@nat/google/x-zlfcporxgvodixsk) has joined #mythtv | |
[16:32:01] | noahric (noahric!~noahric@nat/google/x-zlfcporxgvodixsk) has left #mythtv () | |
[16:46:54] | kormoc_afk is now known as kormoc | |
[16:55:56] | Goga777 (Goga777!~Goga777@shpd-95-53-212-132.vologda.ru) has joined #mythtv | |
[16:56:21] | pheld (pheld!~heldal@cl-5.osl-01.no.sixxs.net) has joined #mythtv | |
[17:04:49] | gigem_ (gigem_!~david@mythtv/developer/gigem) has quit (Remote host closed the connection) | |
[17:05:17] | gigem_ (gigem_!~david@host103.16.intrusion.com) has joined #mythtv | |
[17:05:17] | gigem_ (gigem_!~david@host103.16.intrusion.com) has quit (Changing host) | |
[17:05:17] | gigem_ (gigem_!~david@mythtv/developer/gigem) has joined #mythtv | |
[17:09:18] | alex-- (alex--!~alex--@546A28D7.cm-12-3a.dynamic.ziggo.nl) has joined #mythtv | |
[17:09:24] | alex--: | Where is the windows version of mythtv? |
[17:14:14] | zombor_ (zombor_!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[17:17:59] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Disconnected by services) | |
[17:18:11] | zombor_ is now known as zombor | |
[17:29:00] | Beirdo: | so. I had some bad luck last night. Seems mpeg2fix is not happy with repeated frames at this point |
[17:29:14] | Beirdo: | and my TS recordings have them, my PS do not |
[17:29:47] | Beirdo: | so I'll keep looking into what its issues are.. but that's why there's no patch up yet. |
[17:40:57] | andreax (andreax!~andreaz@p57B92641.dip.t-dialin.net) has joined #mythtv | |
[17:45:10] | sphery: | alex--: /topic (you want #mythtv-users ) |
[17:46:34] | stoffel (stoffel!~quassel@p57B4ADC4.dip.t-dialin.net) has joined #mythtv | |
[17:48:53] | Mousey (Mousey!~wtfisme@ross154.net) has joined #mythtv | |
[17:52:37] | alex--: | sphery: sorry didn't know this was development channel |
[18:06:15] | danielk22: | stuartm: I noticed mythavtest is missing a call to DestroyMythMainWindow(); but when I add it the main window doesn't get deleted. it gets stuck trying to delete the children... any ideas ? |
[18:14:00] | stuartm: | nothing immediately comes to mind :/ |
[18:20:10] | stuartm: | where exactly is it getting stuck? |
[18:29:53] | danielk22: | delete d->stackList.back(); it gets stuck inside QVector so perhaps some memory problem. |
[18:31:06] | Goga777 (Goga777!~Goga777@shpd-95-53-212-132.vologda.ru) has quit (Remote host closed the connection) | |
[18:32:31] | stuartm: | and DestroyMythMainWindow() is being called immediately before 'delete gContext;'? |
[18:35:04] | danielk22: | yep |
[18:37:10] | stuartm: | the only possible difference that I can see between that situation and the ones in mfe/mythwelcome is that there may still be a screen left in the stack, we destroy the playback background screen in the TV destructor, and we don't explicitly delete tv |
[18:37:28] | stuartm: | danielk22: does adding "delete tv;" before Destroy.. help? |
[18:38:21] | stuartm: | hmm, that's not right – we create two TV objects and call init on both, meaning two screens are created |
[18:38:28] | kth (kth!~kth@unaffiliated/kth) has joined #mythtv | |
[18:38:40] | stuartm: | one in main.cpp and the other in tv_play.cpp when we call StartTV() |
[18:39:00] | stoffel (stoffel!~quassel@p57B4ADC4.dip.t-dialin.net) has quit (Remote host closed the connection) | |
[18:41:27] | stuartm: | what purpose does the TV::Init() call in main() serve? |
[18:42:11] | danielk22: | stuartm: no idea, that doesn't look right to me either. |
[18:44:25] | stuartm: | it might not be the cause, but calling Init() creates a screen on the screenstack, since we're doing it twice that's two screen that are on the stack when we call Destroy..., none of the other apps call Destroy.. when there are still screens on the stack so the deletion code hasn't really been tested |
[18:47:33] | stuartm: | well StartTV should close at least one of those two screens when it calls the TV destructor, so that's alright, but I wonder if removing that duplicate Init() would help at all |
[18:50:33] | stuartm: | hopefully it's that, if not then I'm stumped |
[18:53:43] | stuartm: | testing the theory now |
[18:55:10] | stuartm: | http://pastebin.com/FMrAVp0X |
[18:57:28] | stuartm: | well it doesn't hang, but it does segfault ... |
[18:59:02] | stuartm: | in the FileLogger |
[18:59:57] | stuartm: | danielk22: were you fixing other teardown related problems in mythavtest then? I get three DB related warnings and this segfault in the logging thread |
[19:00:25] | danielk22: | yeah, I'm trying to get the shutdowns all worked out.. |
[19:00:38] | danielk22: | I have the logging thing fixed here. |
[19:04:49] | stuartm: | the above patch seems to avoid it getting stuck when destroying MythMainWindow, unless the problem was specific to your setup somehow |
[19:07:20] | Jordack (Jordack!~jordack@h69-131-44-221.plmomi.dedicated.static.tds.net) has quit () | |
[19:07:47] | JamesHarrison (JamesHarrison!~jharrison@cpc3-addl4-2-0-cust97.6-3.cable.virginmedia.com) has joined #mythtv | |
[19:07:49] | danielk22: | that's not enough here.. but now it is getting stuck elsewhere: MythScreenStack::PopScreen (this=0x11836e0, screen=0x1163a00, allowFade=false, deleteScreen=true) at mythscreenstack.cpp:97 |
[19:08:58] | danielk22: | nah, it eventually gets stuck in the same place.. |
[19:10:01] | danielk22: | hmm, it may not really be stuck.. everytime I stop it and look at it it is either in QVector or on mythscreenstack.cpp:97 maybe a a loop. |
[19:14:04] | danielk22: | stuartm there should only be one item in the m_Children list right? There are three here and the first deletes fine then it gets stuck on the second one. |
[19:15:15] | stuartm: | danielk22: unless I've missed something there should only be one at that point, dumping the names might shed some light |
[19:15:25] | stuartm: | I think the problem is something else though |
[19:15:30] | danielk22: | how do I dump the names? |
[19:15:48] | alex-- (alex--!~alex--@546A28D7.cm-12-3a.dynamic.ziggo.nl) has left #mythtv () | |
[19:16:20] | stuartm: | we're attempting to do a fade transition when we tear down the main window, that would setup a loop |
[19:17:17] | stuartm: | danielk22: child->objectName(); |
[19:18:56] | danielk22: | It looks like TV::StartTV is using the "popup stack" does that make sense? |
[19:19:55] | danielk22: | Ok, it deletes the popup stack fine, then dies on the main stack.. which has never had anything added to it.. |
[19:21:49] | anykey_ (anykey_!~guedel@46-126-245-147.dynamic.hispeed.ch) has quit (Quit: leaving) | |
[19:22:06] | anykey_ (anykey_!~guedel@46-126-245-147.dynamic.hispeed.ch) has joined #mythtv | |
[19:22:06] | danielk22: | actually it's just a dialog that uses the popup stack.. |
[19:26:37] | stuartm: | danielk22: untested but having reviewed it, I'm probably going to be committing this patch – http://pastebin.com/FXBb2m3n |
[19:27:38] | stuartm: | it ensures that we immediately delete any screens which were already scheduled for deletion before we delete the rest, I could see how it might get stuck if we didn't do that |
[19:33:49] | danielk22: | stuartm: that did it :) |
[19:34:02] | stuartm: | excellent |
[19:34:35] | stuartm: | I'll commit it |
[19:49:19] | danielk22: | stuartm: Thanks! That one was driving me crazy. |
[19:53:15] | stuartm: | yeah, it was an untested case which seems to date back to the day that stuff was first committed by Thor in 2004 :) |
[20:03:54] | Mousey (Mousey!~wtfisme@ross154.net) has quit (Ping timeout: 276 seconds) | |
[20:39:34] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has quit (Quit: leaving) | |
[20:39:53] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[20:52:43] | jya (jya!~jyavenard@mythtv/developer/jya) has joined #mythtv | |
[20:54:36] | jya (jya!~jyavenard@mythtv/developer/jya) has quit (Client Quit) | |
[21:17:54] | coling (coling!~colin@cpc1-sgyl30-2-0-cust258.sgyl.cable.virginmedia.com) has joined #mythtv | |
[21:28:35] | kth (kth!~kth@unaffiliated/kth) has quit (Quit: Leaving.) | |
[21:37:38] | j-rod is now known as j-rod|afk | |
[22:54:25] | MaverickTech (MaverickTech!~MaverickT@111.86.233.220.static.exetel.com.au) has joined #mythtv | |
[22:55:13] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[23:20:12] | zombor (zombor!~zombor_@kohana/developer/zombor) has quit (Remote host closed the connection) | |
[23:26:20] | zombor (zombor!~zombor_@kohana/developer/zombor) has joined #mythtv | |
[23:51:22] | PointyPumper (PointyPumper!~pintlezz@190.244.73.13) has joined #mythtv |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.