| Friday, February 17th, 2012, 01:00 UTC | ||
| [01:00:42] | jpabq_ (jpabq_!~jpabq@mythtv/developer/jpabq) has quit (Quit: jpabq_) | |
| [02:59:08] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has joined #mythtv-theming | |
| [02:59:09] | Mode for #mythtv-theming by ChanServ!ChanServ@services. : +v iamlindoro | |
| [03:02:58] | iamlindoro (iamlindoro!~iamlindor@mythtv/developer/iamlindoro) has left #mythtv-theming () | |
| [09:16:39] | toeb: | is it somehow possible to skip over a button i don't want to display although i'm forced to provide in the xml |
| [09:17:32] | toeb: | i know this is not what was intended by forcing the themer to do but i think in my case it would make sence. |
| [09:19:18] | toeb: | i theming the video-ui.xml edit_metadata window and im forced to provide the screenshot_button, but i don't have enough space to display it properly... Also i'm no where using the video screenshots in my theme so I really do not need this button. |
| [09:20:17] | toeb: | so far i did simply set the buttons area property to be 0,0,0,0 which hides the button but its still selectable. |
| [14:17:06] | Captain_Murdoch: | probably would be best for us to make that button optional. it's a pretty trivial patch. |
| [14:17:42] | Captain_Murdoch: | I can see other themers not wanting to display it, or the fanart, banner, trailer, or coverart buttons. |
| [14:22:43] | Captain_Murdoch: | toeb, if you compile from source, try the following patch to make those images and trailer buttons optional: http://pastebin.ca/2118532 |
| [14:23:22] | stuartm: | those are cases where if they are optional we should still warn in the logs if they are missing, since themers might miss then by accident and prevent users accessing features they'd want |
| [14:25:31] | stuartm: | toeb: an alternative is to define them in the theme but with an area of 1x1 and alpha of 0 – not as tidy maybe, but it doesn't involve code changes |
| [14:27:25] | stuartm: | I've no problem with a theme hiding functionality that's not relevant to their intended use, especially for kiosk type installs, but we also have to guard against themes leaving out functionality that they actually require (because it will blow back on us in the form of invalid bug reports) |
| [14:56:11] | Captain_Murdoch: | but if he hides them, won't they still be used if you try to scroll around? |
| [14:57:08] | Captain_Murdoch: | it's easy to make the log warn if those aren't defined, but still allow the page to work without them. that's just a few more lines to add to the test patch. |
| [15:37:39] | jpabq_ (jpabq_!~jpabq@mythtv/developer/jpabq) has joined #mythtv-theming | |
| [15:44:14] | stuartm: | Captain_Murdoch: good point, I didn't think of the focus issue |
| [16:06:44] | toeb: | Captain_Murdoch: i'll try the patch in the next days |
| [16:08:58] | toeb: | if it is decided to make those buttons optional, also the XXX_text textarreas should |
| [16:09:12] | toeb: | although those are easier to hide |
| [19:16:35] | Captain_Murdoch: | toeb, we can probably get that into 0.25 as a loosely termed bug fix if it accomplishes what we're talking about. themes w/o artwork shouldn't require or expose the artwork buttons, IMHO. |
| [20:13:17] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has joined #mythtv-theming | |
| [23:02:13] | natanojl (natanojl!~jonatan@c83-252-237-63.bredband.comhem.se) has quit (Ping timeout: 248 seconds) | |
| [23:30:34] | jpabq_ (jpabq_!~jpabq@mythtv/developer/jpabq) has quit (Quit: jpabq_) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.