Tuesday, January 31st, 2023, 00:34 UTC | ||
[00:34:09] | peterbennett (peterbennett!~peter@2601:183:100:504:d997:bd5:8031:f7ee) has joined #mythtv | |
[01:21:01] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:7a84:3cff:fedf:a99) has joined #mythtv | |
[01:32:39] | peterbennett (peterbennett!~peter@2601:183:100:504:d997:bd5:8031:f7ee) has quit (Ping timeout: 255 seconds) | |
[01:39:14] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:7a84:3cff:fedf:a99) has quit (Quit: Konversation terminated!) | |
[01:53:04] | dvr (dvr!~dvr@c-24-5-117-17.hsd1.ca.comcast.net) has quit (Ping timeout: 252 seconds) | |
[02:04:26] | dvr (dvr!~dvr@204.179.218.238) has joined #mythtv | |
[02:17:25] | dvr (dvr!~dvr@204.179.218.238) has quit (Ping timeout: 252 seconds) | |
[02:19:30] | dvr (dvr!~dvr@204.179.218.238) has joined #mythtv | |
[02:23:39] | dvr (dvr!~dvr@204.179.218.238) has quit (Ping timeout: 252 seconds) | |
[02:28:02] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has quit (Remote host closed the connection) | |
[02:28:15] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has joined #mythtv | |
[02:43:41] | dvr (dvr!~dvr@c-24-5-117-17.hsd1.ca.comcast.net) has joined #mythtv | |
[02:48:32] | dvr (dvr!~dvr@c-24-5-117-17.hsd1.ca.comcast.net) has quit (Read error: Connection reset by peer) | |
[02:49:28] | dvr (dvr!~dvr@c-24-5-117-17.hsd1.ca.comcast.net) has joined #mythtv | |
[05:07:50] | peterbennett (peterbennett!~peter@2601:183:100:504:470f:63d1:66a:9654) has joined #mythtv | |
[05:12:15] | peterbennett (peterbennett!~peter@2601:183:100:504:470f:63d1:66a:9654) has quit (Ping timeout: 255 seconds) | |
[05:24:30] | gigem (gigem!~david@47.183.236.48) has quit (Quit: WeeChat 3.8) | |
[05:26:16] | dvr (dvr!~dvr@c-24-5-117-17.hsd1.ca.comcast.net) has quit (Remote host closed the connection) | |
[05:33:51] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has quit (Remote host closed the connection) | |
[05:33:58] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has joined #mythtv | |
[07:22:00] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:7a84:3cff:fedf:a99) has joined #mythtv | |
[09:24:49] | DevMythNotifyBot: | pull_request opened by dfdario, "Italian translations with improvements and new sentences": https://github.com/MythTV/mythtv/pull/709 |
[09:25:15] | DevMythNotifyBot: | pull_request edited by dfdario, "Italian translations with improvements and new sentences": https://github.com/MythTV/mythtv/pull/709 |
[12:51:46] | amessina (amessina!~amessina@user/amessina) has joined #mythtv | |
[13:48:43] | peterbennett (peterbennett!~peter@2601:183:100:504:f5b0:3792:33b:7aa) has joined #mythtv | |
[13:56:46] | amessina (amessina!~amessina@user/amessina) has quit (Remote host closed the connection) | |
[14:55:39] | peterbennett (peterbennett!~peter@2601:183:100:504:f5b0:3792:33b:7aa) has quit (Ping timeout: 248 seconds) | |
[15:07:38] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161469-cust195.vm29.cable.virginm.net) has joined #mythtv | |
[15:07:38] | paul-h (paul-h!~paul@mythtv/developer/paul-h) has joined #mythtv | |
[15:07:38] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161469-cust195.vm29.cable.virginm.net) has quit (Changing host) | |
[15:07:38] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v paul-h | |
[15:11:01] | paul-h: | jpabq: Should Dvr::AddRecordedProgram you added to the API back in 2021 be working OK? |
[15:19:19] | paul-h: | So V2 should be working V1 is still broken? https://github.com/MythTV/mythtv/commit/225664a3399e |
[15:21:05] | SteveGoodey (SteveGoodey!~steve@2a00:23c5:7d83:6501:7a24:afff:fe9d:c233) has joined #mythtv | |
[15:31:13] | peterbennett (peterbennett!~peter@2601:183:100:504:fe59:4bed:5d33:7358) has joined #mythtv | |
[15:32:41] | paul-h: | Can't this be simplified int chanid = channel.value("ChanId").toInt() ? https://github.com/MythTV/mythtv/blob/master/ . . . dvr.cpp#L430 |
[15:34:28] | peterbennett: | I would think so |
[15:36:23] | peterbennett: | There is another one pi->m_stars = program.value("Stars").toVariant().toString().toFloat(); |
[15:37:28] | peterbennett: | This one is simpler pi->m_partnumber = program.value("PartNumber").toString("0").toUInt(); |
[15:43:50] | paul-h: | I'm actually just trying to help a user on the forum where the given ChanId ends up being set to 0 so the lookup fails and the API then fails even though he says he is passing a proper value for ChanId |
[15:44:56] | paul-h: | https://forum.mythtv.org/viewtopic.php?f=2&am . . . rt=15#p25282 |
[15:50:25] | peterbennett: | It looks good to me |
[15:50:48] | paul-h: | I wonder if this the problem in fixes/32 it's different https://github.com/MythTV/mythtv/blob/fixes/3 . . . dvr.cpp#L406 |
[15:51:48] | peterbennett: | There must be a reason it was changed |
[15:52:03] | paul-h: | If ChanId is not a string it will be set to "0" if I'm reading the Qt docs properly |
[15:52:49] | peterbennett: | Maybe it need to be in quotes? That makes no sense... |
[15:53:39] | peterbennett: | Perhaps the complicated new code is to allow it either with ot without quotes, where before it has incorrectly required quotes. |
[15:55:28] | peterbennett: | I have never used the embedded json that is used by this api. |
[15:55:43] | paul-h: | Possibly Yeah. I think in fixes it will only work if ChanId is passed in quotes not sure what will happen in master |
[15:57:18] | peterbennett: | There are others that use the toString("0").toUint() in master so maybe those will also need quotes |
[15:58:18] | paul-h: | Yep it's a mess |
[16:04:58] | paul-h: | I've asked him to try again but this time pass the ChanID in quotes just to verify |
[16:14:22] | paul-h: | The original commit suggests that AddRecordedProgram should accept the same format as returned by GetRecorded which sounds fair enough https://github.com/MythTV/mythtv/commit/3c9543904fe |
[16:29:08] | peterbennett: | GetRecorded does nt put quotes around numeric values. |
[16:34:08] | peterbennett (peterbennett!~peter@2601:183:100:504:fe59:4bed:5d33:7358) has quit (Ping timeout: 248 seconds) | |
[17:10:37] | paul-h (paul-h!~paul@mythtv/developer/paul-h) has quit (Ping timeout: 252 seconds) | |
[17:16:36] | peterbennett (peterbennett!~peter@2601:183:100:504:9545:f632:99a2:b2c) has joined #mythtv | |
[17:28:42] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161469-cust195.vm29.cable.virginm.net) has joined #mythtv | |
[17:28:42] | paul-h (paul-h!~paul@mythtv/developer/paul-h) has joined #mythtv | |
[17:28:42] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161469-cust195.vm29.cable.virginm.net) has quit (Changing host) | |
[17:28:42] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v paul-h | |
[17:36:20] | peterbennett (peterbennett!~peter@2601:183:100:504:9545:f632:99a2:b2c) has quit (Ping timeout: 260 seconds) | |
[17:56:10] | peterbennett (peterbennett!~peter@2601:183:100:504:d84:75db:30f4:f69f) has joined #mythtv | |
[18:21:45] | peterbennett (peterbennett!~peter@2601:183:100:504:d84:75db:30f4:f69f) has quit (Ping timeout: 252 seconds) | |
[19:23:45] | hampton (hampton!~hampton@mythtv/developer/hampton) has quit (Quit: Konversation terminated!) | |
[19:24:10] | gigem (gigem!~david@47.183.229.197) has joined #mythtv | |
[20:11:22] | ooshlablu (ooshlablu!~ooshlablu@2601:18d:4600:43f0:270a:ef5:77a5:c7fc) has quit (Ping timeout: 252 seconds) | |
[20:25:41] | gigem (gigem!~david@47.183.229.197) has quit (Quit: WeeChat 3.8) | |
[20:25:59] | gigem (gigem!~david@47.183.229.197) has joined #mythtv | |
[20:26:07] | gigem (gigem!~david@47.183.229.197) has quit (Client Quit) | |
[20:26:57] | gigem (gigem!~david@47.183.229.197) has joined #mythtv | |
[20:33:38] | gigem (gigem!~david@47.183.229.197) has quit (Quit: WeeChat 3.0) | |
[20:36:13] | hampton (hampton!~hampton@mythtv/developer/hampton) has joined #mythtv | |
[20:36:13] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v hampton | |
[20:42:02] | gigem (gigem!~david@47.183.229.197) has joined #mythtv | |
[20:42:09] | gigem (gigem!~david@47.183.229.197) has quit (Client Quit) | |
[20:42:26] | gigem (gigem!~david@47.183.229.197) has joined #mythtv | |
[20:46:29] | peterbennett (peterbennett!~peter@2601:183:100:504:d2ca:4c1c:c093:ddf5) has joined #mythtv | |
[21:16:09] | peterbennett (peterbennett!~peter@2601:183:100:504:d2ca:4c1c:c093:ddf5) has quit (Ping timeout: 255 seconds) | |
[21:24:46] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:7a84:3cff:fedf:a99) has quit (Quit: Konversation terminated!) | |
[21:56:17] | SteveGoodey (SteveGoodey!~steve@2a00:23c5:7d83:6501:7a24:afff:fe9d:c233) has quit (Quit: Konversation terminated!) | |
[22:17:17] | peterbennett (peterbennett!~peter@2601:183:100:504:3fd8:ae24:8df1:782b) has joined #mythtv | |
[22:18:56] | ooshlablu (ooshlablu!~ooshlablu@2601:18d:4600:43f0:37a9:1a9d:e8a2:ca1c) has joined #mythtv | |
[22:53:49] | peterbennett (peterbennett!~peter@2601:183:100:504:3fd8:ae24:8df1:782b) has quit (Ping timeout: 252 seconds) |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.