Friday, October 8th, 2021, 00:18 UTC | ||
[00:18:30] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[00:18:31] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[00:28:41] | amessina (amessina!~amessina@user/amessina) has joined #mythtv | |
[00:39:41] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[01:03:45] | jpabq (jpabq!~quassel@97-123-166-52.albq.qwest.net) has joined #mythtv | |
[01:03:45] | jpabq (jpabq!~quassel@mythtv/developer/jpabq) has joined #mythtv | |
[01:03:45] | jpabq (jpabq!~quassel@97-123-166-52.albq.qwest.net) has quit (Changing host) | |
[01:03:45] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v jpabq | |
[01:24:46] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[01:26:12] | amessina (amessina!~amessina@user/amessina) has quit (Quit: Konversation terminated!) | |
[01:47:02] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[01:49:44] | bill6502 (bill6502!~bill@mythtv/developer/bill6502) has left #mythtv () | |
[04:27:44] | jpabq (jpabq!~quassel@97-123-166-52.albq.qwest.net) has joined #mythtv | |
[04:27:44] | jpabq (jpabq!~quassel@mythtv/developer/jpabq) has joined #mythtv | |
[04:27:44] | jpabq (jpabq!~quassel@97-123-166-52.albq.qwest.net) has quit (Changing host) | |
[04:27:44] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v jpabq | |
[04:53:23] | jpabq (jpabq!~quassel@97-123-166-52.albq.qwest.net) has joined #mythtv | |
[04:53:23] | jpabq (jpabq!~quassel@mythtv/developer/jpabq) has joined #mythtv | |
[04:53:23] | jpabq (jpabq!~quassel@97-123-166-52.albq.qwest.net) has quit (Changing host) | |
[04:53:23] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v jpabq | |
[06:25:50] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[08:21:22] | warpme__ (warpme__!uid391875@helmsley.irccloud.com) has quit (Quit: Connection closed for inactivity) | |
[09:56:45] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[10:27:21] | warpme__ (warpme__!uid391875@id-391875.helmsley.irccloud.com) has joined #mythtv | |
[11:53:09] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[13:06:10] | amessina (amessina!~amessina@user/amessina) has joined #mythtv | |
[13:16:46] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[13:19:39] | stuarta: | i wonder when ubuntu are going to fix pcre2 for 21.10 ?? |
[13:20:06] | gtb (gtb!~gtb@2001:470:69fc:105::1e7) has quit (Read error: Connection reset by peer) | |
[13:20:09] | stuarta[m] (stuarta[m]!~stuartama@2001:470:69fc:105::fff2) has quit (Read error: Connection reset by peer) | |
[13:22:06] | gtb (gtb!~gtb@2001:470:69fc:105::1e7) has joined #mythtv | |
[13:30:15] | stuarta[m] (stuarta[m]!~stuartama@2001:470:69fc:105::fff2) has joined #mythtv | |
[13:33:39] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161467-cust2666.vm29.cable.virginm.net) has joined #mythtv | |
[13:33:39] | paul-h (paul-h!~paul@mythtv/developer/paul-h) has joined #mythtv | |
[13:33:39] | paul-h (paul-h!~paul@pres-25-b2-v4wan-161467-cust2666.vm29.cable.virginm.net) has quit (Changing host) | |
[13:33:40] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v paul-h | |
[13:38:50] | paul-h: | Fixing the parameter names in the header seems to have fixed the broken endpoints |
[13:38:54] | stuarta: | \o/ |
[13:39:07] | stuarta: | nice work |
[13:39:23] | paul-h: | Are you able to see this page? https://wsdldiff.mockmotor.com/index.jsp?diff . . . b5b10fdf42e8 |
[13:41:30] | paul-h: | There is still some breakage with missing endpoints in the content service but I think that was on purpose – all related to *LiveStream stuff |
[13:43:10] | paul-h: | Let's see what the myth service looks like |
[13:46:56] | paul-h: | SendNotification is broken changed parameter Duration -> Timeout |
[13:52:03] | stuarta: | i can't see the details as it's your server |
[13:52:19] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[13:52:19] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[13:53:06] | stuarta: | that's a cool tool |
[13:53:23] | bill6502 (bill6502!~bill@mythtv/developer/bill6502) has joined #mythtv | |
[13:53:24] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v bill6502 | |
[13:54:12] | stuarta: | paul-h: although i can see stuff in the "impact" section |
[13:56:38] | bill6502: | paul-h: ? SendNotification has Duration in V1. SendMessage has Timeout in both |
[13:56:48] | bill6502: | were you testing the Frontend service? |
[13:57:44] | gregl_ (gregl_!~gregl@cpe-24-194-235-95.nycap.res.rr.com) has quit (Remote host closed the connection) | |
[13:59:10] | bill6502: | it would be good if SendNotification in Myth and Frontend were the same, but I don't think we should change it |
[14:09:23] | paul-h: | bill6502: I'm just comparing the wsdl of the old and new for the Myth service |
[14:10:21] | paul-h: | It makes it easy to see whats broken or missing |
[14:11:09] | paul-h: | There's a lot missing from the Myth service? |
[14:11:22] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[14:12:51] | paul-h: | ChangePassword, ParseISODateString, ProfileText, ProfileURL, ProfileUpdated |
[14:13:14] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[14:13:14] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[14:15:03] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Client Quit) | |
[14:15:54] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[14:15:54] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[14:15:54] | stuarta: | paul-h: ChangePassword was recently removed explicitly, which I commented at the time would need putting back and making work |
[14:17:43] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Client Quit) | |
[14:20:21] | bill6502: | stuarta: ChangePassword was deprecated and I removed it for v32. Myth/ManageDigestUser replaced it. I'll put it back if you like. |
[14:21:02] | stuarta: | bill6502: ManageDigestUser does make sense |
[14:21:15] | stuarta: | if we find a use case for change password, then we can add it back |
[14:22:08] | stuarta: | but tbh, the whole authentication piece needs reworking |
[14:22:19] | stuarta: | the original is over 10 years old, and things have moved on a lot |
[14:23:28] | bill6502: | I think it did in v1 when we had digest authentication |
[14:23:48] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[14:23:48] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[14:24:17] | bill6502: | changepassword/managedigestuser was used by webfrontend |
[14:24:19] | stuarta: | bill6502: the main use case i need to have think about is configuration of a new system in order to get it bootstrapped and configured |
[14:25:25] | stuarta: | trusting the "local subnet" is a good suggestion (i think it came from peterbennett) |
[14:25:32] | stuarta: | at least until things are "up" |
[14:25:37] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Client Quit) | |
[14:26:02] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[14:26:02] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[14:26:45] | peterbennett: | I heard my name :) |
[14:29:12] | stuarta: | :-p |
[14:29:47] | bill6502: | peterbennett: would you like me to change recstarttsRaw in v2dvr.h to StartTime (that wasn't why your name was mentioned;)) |
[14:30:36] | peterbennett: | I saw that paul had changed that, are there more of them? |
[14:31:49] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[14:31:59] | peterbennett: | bill6502: paul-h: I suspect that there was a difference between the header files and the cpp files in parameter names, and that is where I went wrong. |
[14:32:36] | peterbennett: | Really should use the same name for a parameter in a header file as you use in the implementation |
[14:32:53] | peterbennett: | Just for sanity sake. |
[14:32:57] | bill6502: | peterbennett: I'm there now, only content.h was changed, I'll do it. |
[14:33:10] | peterbennett: | bill6502: Yes thank you. |
[14:34:01] | peterbennett: | My testing did not pick it up because I use recordedid instead of start time and channel for accessing the data |
[14:34:12] | bill6502: | peterbennett: there are a number of places where the .h has the correct parameter name, but the implementation has the type prepended, like ChanId and nChanId |
[14:35:23] | peterbennett: | OK I don't like that either, but never mind. |
[14:36:06] | stuarta: | the old api was never really "designed", it sorta just evolved |
[14:36:25] | peterbennett: | The old system had two cpies of the header file IIRC with one overriding the other, perhaps the startime parameter name was correct in one but not the other. |
[14:37:03] | stuarta: | ugh |
[14:40:08] | paul-h: | They parameters are correct in the *Services.h files where the abstract? class is defined but often different in the various *.h and &.cpp files that define add implement the classes that is where the confusion is coming from |
[14:40:56] | paul-h: | The new server does things differently there are no v2*Services.h |
[14:40:58] | peterbennett: | paul-h: Yes – When I converted I ignored the abstract class files |
[14:41:06] | bill6502: | If we had a time machine, I'd rename StartTime ProgramStart. But we don't |
[14:41:42] | bill6502: | peterbennett: \o/, love not having the 3d file |
[14:41:47] | paul-h: | peterbennett: Which is good I hated the way that was done :) |
[14:42:40] | peterbennett: | The new way is quite a bit simpler – I suppose I should rewrite the recipe for adding a service. |
[14:43:13] | stuarta: | you can practice making /Status/BackendStatus endpoint :-p |
[14:43:39] | paul-h: | You walked into that one :) |
[14:46:30] | stuarta: | :) |
[14:46:48] | peterbennett: | stuarta: Gee thanks. |
[14:47:22] | stuarta: | peterbennett: i looked yesterday. it made my head hurt |
[14:47:39] | stuarta: | looks like you actually did some of the prereq bits to assemble it |
[14:47:59] | peterbennett: | Are you talking about changing the Status to a proper service? |
[14:48:36] | stuarta: | adding a new endpoint within /Status that is a proper service |
[14:48:48] | stuarta: | we can't kill off the PreFormat ones you did, as plenty uses it |
[14:49:56] | peterbennett: | Unfortunately the old ones use attributes for values, which we don't support in the service model |
[14:50:30] | stuarta: | this is greenfield effectively, since there are no consumers yet for a proper status endpoint for the backend |
[14:56:03] | peterbennett: | Ok i can take a look as a new BackendStatus method. Then the old methods could be deprecated. What about the HTML flavour of the status method? |
[14:56:24] | stuarta: | used by mythweb, and existing "webfrontend" |
[14:56:55] | peterbennett: | And by leanfront .... |
[14:57:02] | stuarta: | so we need to keep them until we at least have fully working replacement and user migration (expectation: at least 2 releases) |
[14:57:33] | peterbennett: | So that will not be deprecated ... |
[14:58:13] | peterbennett: | Perhaps the xslt magic method could be used to convert the xml to html. |
[14:59:56] | stuarta: | maybe, but that's a lot more work than leaving the GetStatusHTML methods alone, and making a BackendStatus endpoint that can use the xml/json serializers |
[15:01:19] | peterbennett: | For now I will leave the old methods and create a new standard method. |
[15:01:29] | stuarta: | that is by far the simplest :-) |
[15:01:40] | peterbennett: | and document the recipe |
[15:01:44] | stuarta: | \o/ |
[15:02:16] | peterbennett: | New Tricks |
[15:12:48] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[15:13:24] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[15:13:24] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[15:21:35] | DevMythNotifyBot: | COMMIT: billmeek pushed 1 commit(s) to branch devel/http: https://github.com/MythTV/mythtv/compare/e144 . . . 43de8f124c42 |
[15:24:10] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[15:41:52] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[15:41:52] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[15:50:40] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Ping timeout: 252 seconds) | |
[15:58:04] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[15:58:04] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[17:23:35] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[19:01:05] | DevMythNotifyBot: | COMMIT: kmdewaal pushed 1 commit(s) to branch master: https://github.com/MythTV/mythtv/compare/72f5 . . . 305836e34fca |
[19:31:46] | frobnic (frobnic!fb@b2b-130-180-11-14.unitymedia.biz) has quit (Ping timeout: 252 seconds) | |
[19:37:00] | frobnic (frobnic!~frobnic@b2b-130-180-11-14.unitymedia.biz) has joined #mythtv | |
[19:40:37] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[19:40:37] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[19:51:23] | warpme__ (warpme__!uid391875@id-391875.helmsley.irccloud.com) has quit (Quit: Connection closed for inactivity) | |
[19:59:54] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[20:45:40] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[22:12:39] | DevMythNotifyBot: | COMMIT: paul-h pushed 1 commit(s) to branch devel/http: https://github.com/MythTV/mythtv/compare/43de . . . e5c4426f5d55 |
[22:18:34] | troyt (troyt!~troyt@2601:681:4100:d591:44dd:acff:fe85:9c8e) has quit (Ping timeout: 252 seconds) | |
[22:23:27] | troyt (troyt!troyt@2601:681:4100:d591:44dd:acff:fe85:9c8e) has joined #mythtv | |
[22:36:04] | paul-h: | bill6502: peterbennett: any idea why ParseISODateString, ProfileText, ProfileURL, ProfileUpdated are present in v2myth.h and v2myth.cpp but don't show in the wsdl and give a 404 Not Found if you try to use them? |
[22:40:14] | bill6502: | paul-h: I changed the ParseISODateString from QDateTime to QString and used name=DateTime in the header, but now get: <DateTime xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" serializerVersion="1.1">Wed Sep 29 19:00:00 2021 GMT</DateTime> |
[22:40:28] | bill6502: | So, my answer right now is no, I don't know. |
[22:47:54] | bill6502: | Added Q_CLASSINFO( "ProfileURL", "methods=GET" ) to v2myth.h and it works, but get the additional xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" serializerVersion="1.1" there too. |
[22:48:56] | bill6502: | both now show up in wsdl with the changes |
[22:54:51] | paul-h: | Wonder if it does not like the void parameter |
[23:01:25] | bill6502: | This works for me: curl --request POST ofc0:6744/Myth/ProfileSubmit, but also returns the xmlns..., rather than the original simple: <bool>true</bool> |
[23:04:34] | bill6502: | Re void, curl --request POST ofc0:6744/Myth/BackupDatabase works, also with the xmlns... |
[23:08:22] | bill6502: | curl --header Accept:application/json --request POST ofc0:6744/Myth/BackupDatabase returns the proper json: {"bool": true}, same as V1 |
[23:10:40] | paul-h: | ProfileSubmit and ProfileDelete do show in the wsdl it's the others that are missing |
[23:11:34] | paul-h: | Notice they are both POST and are present at the top of the class definition eq Q_CLASSINFO( "ProfileSubmit", "methods=POST" ) |
[23:13:17] | MythBuild_: | Build [#75](https://code.mythtv.org/buildbot/#builders/220/builds/75) of `http-ubuntu-18_04–64bit` 4failed. |
[23:27:58] | paul-h (paul-h!~paul@mythtv/developer/paul-h) has quit (Quit: Konversation terminated!) | |
[23:45:50] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[23:45:50] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[23:56:16] | DevMythNotifyBot: | COMMIT: paul-h pushed 1 commit(s) to branch devel/http: https://github.com/MythTV/mythtv/compare/e5c4 . . . ca1f1f041838 |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.