| Wednesday, September 15th, 2021, 00:16 UTC | ||
| [00:16:09] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [00:16:09] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [00:32:14] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
| [01:54:14] | amessina (amessina!~amessina@user/amessina) has quit (Quit: Konversation terminated!) | |
| [02:00:52] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 268 seconds) | |
| [02:11:20] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [03:31:46] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 260 seconds) | |
| [03:37:03] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [04:13:51] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 268 seconds) | |
| [04:17:46] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [04:49:19] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Quit: ZNC 1.8.2 - https://znc.in) | |
| [04:50:00] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [05:04:31] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
| [07:25:13] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
| [08:48:00] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
| [10:24:40] | ooshlablu (ooshlablu!~ooshlablu@2601:18d:4600:43f0:a038:14ff:fe50:8510) has quit (Ping timeout: 240 seconds) | |
| [10:37:17] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
| [10:43:39] | Warped (Warped!~Warped@user/warped) has quit (Quit: We Gone! Bye Bye) | |
| [11:18:18] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [11:18:18] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [11:20:07] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Client Quit) | |
| [11:47:57] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
| [12:22:41] | ooshlablu (ooshlablu!~ooshlablu@98.217.124.239) has joined #mythtv | |
| [12:34:45] | Warped (Warped!~Warped@user/warped) has joined #mythtv | |
| [13:46:08] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [13:46:08] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [14:13:25] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
| [14:54:40] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [14:54:40] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [14:58:57] | peterbennett: | very weird wtf ? https://github.com/MythTV/mythtv/blob/1a426fe . . . _huffman.cpp |
| [15:03:33] | stuarta: | peterbennett: there was a PR raised overnight for that |
| [15:03:52] | stuarta: | https://github.com/MythTV/mythtv/pull/391 |
| [15:08:14] | peterbennett: | stuarta: Yes I saw that, I was wondering what caused it, because it looks fine in Visual Studio |
| [15:17:04] | stuarta: | yeah exactly |
| [15:20:44] | peterbennett: | maybe if I get the secret I can apply it to things I want kept private |
| [15:23:42] | peterbennett: | I see lines 721–765 have unprintable characters |
| [15:29:13] | warpme_ (warpme_!uid391875@id-391875.helmsley.irccloud.com) has joined #mythtv | |
| [15:36:22] | DevMythNotifyBot: | COMMIT: linuxdude42 pushed 14 commit(s) to branch master: https://github.com/MythTV/mythtv/compare/8899 . . . 3590a463af19 |
| [15:37:56] | stuarta: | looks like we are gunna need a merge to devel/http after that |
| [15:49:59] | hampton: | I'll take that pull request. Instead of stripping the non-utf8 characters from the comments, they should be replaced with the actual utf-8 character. |
| [15:54:08] | stuarta: | sounds like a plan |
| [16:19:00] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
| [16:40:44] | DevMythNotifyBot: | COMMIT: linuxdude42 pushed 5 commit(s) to branch master: https://github.com/MythTV/mythtv/compare/3590 . . . 6161dfe1a905 |
| [16:47:29] | MythBuild: | Build [#1345](https://code.mythtv.org/buildbot/#builders/12/builds/1345) of `master-fedora-armv7hl` 4failed. |
| [16:48:14] | hampton: | :-( |
| [16:49:42] | hampton: | git pull failure |
| [16:55:53] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [16:55:53] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [17:04:24] | MythBuild: | Build [#1346](https://code.mythtv.org/buildbot/#builders/12/builds/1346) of `master-fedora-armv7hl` 3completed successfully. |
| [17:06:35] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
| [17:09:42] | DevMythNotifyBot: | COMMIT: linuxdude42 pushed 1 commit(s) to branch master: https://github.com/MythTV/mythtv/compare/6161 . . . 32b7866aa18a |
| [17:10:56] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [17:10:56] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [17:12:23] | hampton: | Is there a preferred method for committing merge requests? "Squash and merge" vs "rebase and merge"? |
| [17:14:01] | hampton: | I'm leaning towards the former for pull request 377. |
| [17:20:43] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
| [17:59:23] | stuarta: | hampton: which ever is most appropriate. a big wieldy set should probably be squashed, a nice self contained one should probably be rebased |
| [18:17:44] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has joined #mythtv | |
| [18:42:06] | ulmus-scott: | regarding the "Squash and merge" vs "rebase and merge": my opinion on that particular request would be to squash all but the final one because it is a new file and those other changes were very minor fixes |
| [18:45:54] | ulmus-scott: | in general however, wouldn't rebase and fast forward merge be better, since that groups all the commits together and doesn't add an unnecessary (in my opinion) commit that says "merge ..." and duplicates the changes in the other commits. |
| [19:08:44] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [19:08:44] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [19:13:28] | ulmus-scott: | hampton: regarding https://github.com/MythTV/mythtv/commit/6161d . . . 61694f7b516d I removed the non-utf characters because they seem to represent the character corresponding to the binary value in the second column; those are the correct characters for ISO-8859–1, but are not a valid UTF-8 representation of the binary data. |
| [19:13:29] | ulmus-scott: | Also, for whatever reason, the comments just stop giving a character. Probably, doesn’t really matter either way. |
| [19:27:29] | ** stuarta waves to ulmus-scott ** | |
| [19:43:06] | ** ulmus-scott waves back ** | |
| [20:04:01] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
| [20:05:22] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
| [20:17:11] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has quit (Ping timeout: 256 seconds) | |
| [20:40:43] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [20:40:43] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [21:42:49] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Ping timeout: 252 seconds) | |
| [22:06:22] | MythBuild: | Build [#367](https://code.mythtv.org/buildbot/#builders/188/builds/367) of `tidy-master` 3completed successfully. |
| [22:06:28] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has joined #mythtv | |
| [22:08:30] | ulmus-scott (ulmus-scott!~ulmus-sco@user/ulmus-scott) has quit (Quit: Leaving) | |
| [22:52:23] | warpme_ (warpme_!uid391875@id-391875.helmsley.irccloud.com) has quit (Quit: Connection closed for inactivity) | |
| [23:29:24] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [23:29:24] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
| [23:57:42] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 260 seconds) | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.