Friday, August 20th, 2021, 00:26 UTC | ||
[00:26:58] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[00:35:40] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has quit (Remote host closed the connection) | |
[00:36:32] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has joined #mythtv | |
[01:07:45] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[01:19:07] | glenb77 (glenb77!~glenb77@38-13-16-127.starry-inc.net) has quit (Quit: glenb77) | |
[01:40:30] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[06:11:25] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[07:31:14] | Warped (Warped!~Warped@user/warped) has quit (Quit: We Gone! Bye Bye) | |
[07:38:47] | Warped (Warped!~Warped@user/warped) has joined #mythtv | |
[09:21:32] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[11:42:42] | stuarta: | hampton: in reviewing https://github.com/MythTV/mythtv/pull/382/fil . . . c6b440c2R462 i've noted that the submitter has had to redefine usleep with sleep on mingw. i though this was taken care of with the std::chrono changes, but looking at the current code it still just uses a usleep. trying to think if there is a better way of handling it without |
[11:42:48] | stuarta: | so much ifdef'ery |
[12:18:24] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[13:05:39] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[13:05:40] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[13:17:18] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
[13:36:42] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[13:44:21] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[14:09:09] | hampton: | I added the std::chrono changes to MThread::usleep. QThread::usleep still takes an unsigned long. That redefined call to usleep looks like its calling the libc version usleep. What fun. |
[14:09:34] | hampton: | Perhaps std::this_thread::sleep_for() could be used instead? |
[14:09:52] | stuarta: | yeah, it doesn't strike me as correct |
[14:11:50] | stuarta: | so do we need to make that change first? |
[14:15:01] | TechMonk (TechMonk!~TechMonk@173.241.20.60) has quit (Ping timeout: 258 seconds) | |
[14:20:37] | hampton: | It looks correct to me. For whatever reason, sleep on mingw appears to take a millisecond argument (not a seconds argument). |
[14:21:35] | stuarta: | :-/ |
[14:21:52] | hampton: | I'm just starting to look at the rest of the changes. They defines a usleep function in compat.h, so why not use that in MythSystemLegacySignalManager::run instead of the ifdefery you pointed out? |
[14:22:03] | stuarta: | i would have thought mingw would have had a usleep |
[14:22:10] | hampton: | Me too |
[14:22:37] | stuarta: | exactly, usleep defined so use it |
[14:24:18] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[14:24:18] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[14:25:18] | hampton: | The "using namespace std;" line in mythcommandlineparser.cpp should go away. Add "std::" to the functions that need it so its explicitly obvious where those functions are coming from. (I'm curious to know which functions those are, since I did those changes in the past.) |
[14:26:55] | stuarta: | i'm pretty sure i also saw code just commented out, which to be fair markspeith did request in the associated ticket |
[14:27:06] | stuarta: | s/request/suggest |
[14:28:03] | ** hampton wonders if there's a standard library equivalent of strcasestr ** | |
[14:33:28] | hampton: | mythdialogbox.h should include mythuiexp.h instead of redefining MUI_PUBLIC. Not sure why mingw isn't already pulling in that file. |
[14:34:01] | stuarta: | it looks like a good starting point, but needs work |
[14:36:51] | hampton: | Wow. Looks like he's building a windows executable while using an Ubuntu system. |
[14:37:04] | stuarta: | yeah, cross building |
[14:37:17] | stuarta: | which we should in theory be able to stick on a builder |
[14:37:35] | hampton: | yep |
[14:38:10] | stuarta: | basically the guts of the build script becomes the build recipie |
[14:38:16] | stuarta: | *recipe |
[14:49:08] | hampton: | Apparently there's still some C code when building for windows? I thought I eliminated all of that, so that Myth (with the exception of the external directory) was all C++. |
[14:52:00] | stuarta: | not a clue |
[15:03:45] | TechMonk (TechMonk!~TechMonk@173.241.20.60) has joined #mythtv | |
[15:43:47] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[16:29:20] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has joined #mythtv | |
[16:56:17] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[16:56:17] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[16:56:45] | ooshlablu (ooshlablu!~ooshlablu@2601:18d:4600:43f0:a038:14ff:fe50:8510) has quit (Quit: Leaving) | |
[16:57:45] | ooshlablu (ooshlablu!~ooshlablu@2601:18d:4600:43f0:a038:14ff:fe50:8510) has joined #mythtv | |
[17:02:08] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[17:08:27] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[17:08:28] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[17:21:19] | MythBuild_ (MythBuild_!~MythBuild@mizar.mythtv.org) has quit (Ping timeout: 258 seconds) | |
[17:21:27] | MythBuild (MythBuild!~MythBuild@mizar.mythtv.org) has joined #mythtv | |
[17:29:47] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[18:08:57] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[18:08:57] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[18:22:50] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Quit: ZNC 1.8.2 - https://znc.in) | |
[19:20:34] | DevMythNotifyBot: | COMMIT: linuxdude42 pushed 5 commit(s) to branch master: https://github.com/MythTV/mythtv/compare/f8a4 . . . 8233fe0f3f96 |
[19:49:31] | MythBuild: | Build [#1300](https://code.mythtv.org/buildbot/#builders/76/builds/1300) of `master-osx-64bit` 4failed. |
[19:52:27] | ** hampton sighs ** | |
[19:52:38] | hampton: | I wonder if I can downgrade the pcre on my osx builder |
[20:18:45] | gigem (gigem!~david@47.189.184.10) has quit (Quit: WeeChat 3.0) | |
[20:19:35] | gigem (gigem!~david@47.189.184.10) has joined #mythtv | |
[20:23:10] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[20:24:25] | MythBuild: | Build [#1301](https://code.mythtv.org/buildbot/#builders/76/builds/1301) of `master-osx-64bit` 3completed successfully. |
[20:45:54] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[20:45:54] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett | |
[20:48:49] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6ea1:20d:5872:d872) has quit (Quit: Konversation terminated!) | |
[22:06:11] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[22:15:59] | amessina (amessina!~amessina@user/amessina) has joined #mythtv | |
[22:16:21] | amessina (amessina!~amessina@user/amessina) has quit (Client Quit) | |
[22:20:42] | amessina (amessina!~amessina@user/amessina) has joined #mythtv | |
[22:54:07] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has quit (Read error: Connection reset by peer) | |
[22:54:23] | DevMythNotifyBot (DevMythNotifyBot!~nodebot@cust32-dsl91-135-4.idnet.net) has joined #mythtv | |
[23:03:44] | MythBuild: | Build [#221](https://code.mythtv.org/buildbot/#builders/204/builds/221) of `clazy-master` 3completed successfully. |
[23:56:15] | peterbennett (peterbennett!~peter@mythtv/developer/peterbennett) has joined #mythtv | |
[23:56:15] | Mode for #mythtv by ChanServ!ChanServ@services.libera.chat : +v peterbennett |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.