| Saturday, May 9th, 2020, 00:06 UTC | ||
| [00:06:47] | markspieth2 (markspieth2!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [00:06:48] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth2 | |
| [00:10:28] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 276 seconds) | |
| [02:58:52] | MythBuild: | Build [#10](https://code.mythtv.org/buildbot/#builders/188/builds/10) of `tidy-master` failed. |
| [03:08:49] | hampton: | /mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp:738:9: warning: use range-based for loop instead [modernize-loop-convert] |
| [04:18:27] | RokLobsta (RokLobsta!~Dirkka@121-200-12-5.79c80c.mel.nbn.aussiebb.net) has quit (Remote host closed the connection) | |
| [04:58:51] | hampton: | For anyone interested... a book on the Wayland display-server protocol. https://wayland-book.com/ |
| [06:19:04] | RokLobsta (RokLobsta!~Dirkka@121-200-12-5.79c80c.mel.nbn.aussiebb.net) has joined #mythtv | |
| [06:43:19] | SteveGoodey (SteveGoodey!~steve@host86-138-103-159.range86-138.btcentralplus.com) has joined #mythtv | |
| [06:43:20] | Mode for #mythtv by ChanServ!ChanServ@services. : +v SteveGoodey | |
| [06:58:13] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [06:58:14] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [07:18:05] | markspieth2 (markspieth2!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 245 seconds) | |
| [07:33:37] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [07:33:37] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [07:40:55] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 276 seconds) | |
| [08:05:07] | Simon-- (Simon--!~sim@2606:6a00:0:28:5604:a6ff:fe02:702b) has joined #mythtv | |
| [08:20:51] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [08:20:51] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [10:16:49] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [10:19:09] | SteveGoodey (SteveGoodey!~steve@host86-138-103-159.range86-138.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [10:55:37] | Simon-- (Simon--!~sim@2606:6a00:0:28:5604:a6ff:fe02:702b) has quit (Ping timeout: 260 seconds) | |
| [11:20:58] | Simon-- (Simon--!~sim@2606:6a00:0:28:5604:a6ff:fe02:702b) has joined #mythtv | |
| [12:19:13] | KdW (KdW!~klaas@217-62-120-70.cable.dynamic.v4.ziggo.nl) has joined #mythtv | |
| [12:20:44] | KdW: | hampton: for me and for gcc channelscan_sm.cpp:738:9 is OK. has been like this for ages, is tried&proven&tested code so I do not feel the need to change this. |
| [12:28:45] | KdW: | any change in software can create bugs and that is why I only change things if I have the intention of also test and debug it |
| [12:35:32] | KdW: | and that is IMHO even more so when actually modifying the behavior of the code, such as replacing iteration over a list with iteration over a copy of that list. |
| [12:39:34] | KdW: | and I think it extremely bad practice that it is apparently needed now to add comments above the code if you want to prevent the code being modified into something else. |
| [12:43:04] | KdW: | for me code is perfect when it does what it should do and never ever crashes. |
| [12:43:58] | KdW: | but opinions might differ on this, maybe users are completely happy with a crashing system if they know the code uses exclusively modernized language constructs. |
| [13:28:18] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has joined #mythtv | |
| [13:28:19] | Mode for #mythtv by ChanServ!ChanServ@services. : +v Steve-Goodey | |
| [14:48:35] | SteveGoodey (SteveGoodey!~steve@host86-138-103-159.range86-138.btcentralplus.com) has joined #mythtv | |
| [14:48:36] | Mode for #mythtv by ChanServ!ChanServ@services. : +v SteveGoodey | |
| [15:05:36] | KdW (KdW!~klaas@217-62-120-70.cable.dynamic.v4.ziggo.nl) has quit (Quit: Leaving) | |
| [15:18:16] | peterbennett (peterbennett!~pi@mythtv/developer/peterbennett) has joined #mythtv | |
| [15:18:17] | Mode for #mythtv by ChanServ!ChanServ@services. : +v peterbennett | |
| [15:56:14] | jpabq: | I have to agree with KdW on this point. Especially if the change incorporates the use of 'auto'. |
| [17:13:17] | paul-h (paul-h!~paul@cpc112433-pres20-2-0-cust645.18-3.cable.virginm.net) has joined #mythtv | |
| [17:13:18] | Mode for #mythtv by ChanServ!ChanServ@services. : +v paul-h | |
| [17:30:53] | warpme_ (warpme_!uid391875@gateway/web/irccloud.com/x-qvqwfnfxturruvox) has joined #mythtv | |
| [17:43:47] | warpme_: | jpabq: gcc 9.3.1? hmm – interesting: https://gcc.gnu.org/gcc-9/ Are you using fork of gcc9? |
| [17:44:45] | warpme_: | my backend is on gcc5.3 – so probably segfaults issue isn't by gcc... |
| [17:57:35] | jpabq: | warpme_: I am on Fedora 30, with the latest package provided by them. |
| [17:58:52] | Simon-- (Simon--!~sim@2606:6a00:0:28:5604:a6ff:fe02:702b) has quit (Ping timeout: 265 seconds) | |
| [18:08:30] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 245 seconds) | |
| [18:09:52] | warpme_: | ah ok! |
| [18:11:09] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [18:11:09] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [18:37:12] | paul-h (paul-h!~paul@cpc112433-pres20-2-0-cust645.18-3.cable.virginm.net) has quit (Quit: Konversation terminated!) | |
| [19:15:53] | markk__ (markk__!~mark@host86-134-226-91.range86-134.btcentralplus.com) has joined #mythtv | |
| [19:24:33] | markk__ (markk__!~mark@host86-134-226-91.range86-134.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [19:38:10] | markk__ (markk__!~mark@host86-134-226-91.range86-134.btcentralplus.com) has joined #mythtv | |
| [19:38:25] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [19:42:52] | markk__: | KdW, jpabq: Honestly, I find those comments slightly depressing. Code is never perfect and the world moves on. Whilst not as important as functionality and stability – readability, maintainability and consistency (across the wider code base) are important factors – especially with a project as large as mythtv. I see no reason why a modern range based loop could not be used in this particular case – and I don't see what the |
| [19:42:53] | markk__: | issue is with 'a copy of a list'. There is no need or requirement to copy it. As for the use of auto – I find it (as for the range based loops) makes code simpler and easier to undertand. For anyone worried about obfuscating code – then look at the hundreds of pointless typedefs littered throughout our codebase. Please understand I am not looking to make an issue of it – but scuppering hampton's considerable effort at |
| [19:42:55] | markk__: | improving and modernising the code is frustrating. I too was skeptical a few months ago – but honestly have come to appreciate the benefits. |
| [19:44:40] | markk__: | FWIW – the recent issue with the auto/range based loop breaking the UI for plugins – I actually believe that highlighted a serous flaw in the code. Just didn't have time to investigate – and of course we blame the change that highlighted it. |
| [19:48:38] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [20:01:11] | jpabq: | markk__: My issue with auto, is when it is used as a parameter to a function, that I am trying to read. Instead of just being able to tell what variable type or class is being passed in instantly, I have to keep digging and find where the function is being called from, just to know what that type is. When auto is used 'locally' I am okay with it, because then its true type is easy to find. |
| [20:02:25] | jpabq: | I have become so frustraited trying to read code written with auto, that I have become quite jaded against it, even when its use makes some sense. |
| [20:04:29] | jpabq: | Are others using some IDE which shows the type of an AUTO paramater when you hover the mouse over it, or something? |
| [20:09:34] | markk__ (markk__!~mark@host86-134-226-91.range86-134.btcentralplus.com) has quit (Ping timeout: 240 seconds) | |
| [20:16:22] | hampton: | jpabq: I agree that auto should never be used as a parameter to a function. The changes I have been committing should all be local changes similar to "blahblah::iterator & x = some_container.begin()" becoming "auto & x = some_container.begin()" or "someStruct * x = new someStruct()" becoming "auto * x = new someStruct()". |
| [20:46:03] | eharris (eharris!~eharris@unaffiliated/eharris) has quit (Remote host closed the connection) | |
| [21:09:48] | Steve-Goodey (Steve-Goodey!~steve@2a00:23c5:7d83:6501:6032:9caa:16d4:6ffa) has quit (Quit: Konversation terminated!) | |
| [21:24:12] | SteveGoodey (SteveGoodey!~steve@host86-138-103-159.range86-138.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [21:37:54] | jpabq: | I am trying to run mythfrontend on a new box with Intel UHD 630 graphics. I am being bit by Intel's DPST, though. Does anyone know how to turn that off? I can throw an nVidia card in, if I have to, but with all of markk's work, I figured the Intel graphics should look good... |
| [21:49:45] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has quit (Ping timeout: 245 seconds) | |
| [21:51:26] | markspieth (markspieth!~yaaic@mythtv/developer/markspieth) has joined #mythtv | |
| [21:51:26] | Mode for #mythtv by ChanServ!ChanServ@services. : +v markspieth | |
| [22:35:05] | ramshadow (ramshadow!ramshadow@dotlan.net) has quit (Ping timeout: 272 seconds) | |
| [22:38:59] | ramshadow (ramshadow!ramshadow@dotlan.net) has joined #mythtv | |
| [23:35:44] | peterben1 (peterben1!~pi@2601:183:100:2ab8:a9ab:da32:28d5:ec0a) has joined #mythtv | |
| [23:37:32] | peterbennett (peterbennett!~pi@mythtv/developer/peterbennett) has quit (Ping timeout: 246 seconds) | |
| [23:55:55] | IonTau (IonTau!~IonTau@124-171-136-14.dyn.iinet.net.au) has joined #mythtv | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.