Saturday, September 23rd, 2017, 00:32 UTC | ||
[00:32:33] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 252 seconds) | |
[00:33:28] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
[01:34:58] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
[02:12:47] | peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 248 seconds) | |
[02:18:22] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
[02:48:45] | markspieth (markspieth!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has joined #mythtv | |
[02:48:54] | markspieth|2 (markspieth|2!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has quit (Ping timeout: 240 seconds) | |
[03:23:42] | markspieth (markspieth!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has quit (Read error: Connection reset by peer) | |
[03:24:09] | markspieth (markspieth!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has joined #mythtv | |
[04:21:25] | markspieth|2 (markspieth|2!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has joined #mythtv | |
[04:23:42] | markspieth (markspieth!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has quit (Ping timeout: 240 seconds) | |
[04:39:19] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Quit: Konversation terminated!) | |
[05:46:15] | markspieth (markspieth!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has joined #mythtv | |
[05:48:06] | markspieth|2 (markspieth|2!~markspiet@CPE-124-188-72-98.facz1.ken.bigpond.net.au) has quit (Ping timeout: 240 seconds) | |
[06:22:14] | _charly_ (_charly_!~kroseneg@sunrise.schmidham.net) has quit (Quit: _charly_) | |
[06:23:30] | _charly_ (_charly_!~kroseneg@sunrise.schmidham.net) has joined #mythtv | |
[07:22:46] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has quit (Ping timeout: 240 seconds) | |
[07:50:45] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BCB9B000A606EFFFE4490F9.dip0.t-ipconnect.de) has quit (Remote host closed the connection) | |
[08:01:33] | Warped (Warped!~Warped@unaffiliated/warped) has quit (Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]) | |
[08:05:47] | SteveGoodey (SteveGoodey!~steve@host86-151-149-106.range86-151.btcentralplus.com) has joined #mythtv | |
[08:29:54] | Warped (Warped!~Warped@unaffiliated/warped) has joined #mythtv | |
[09:57:47] | Chutt_ (Chutt_!~ijr@2605:a000:1208:c115:c457:ef1d:60fd:2177) has joined #mythtv | |
[10:01:05] | Chutt (Chutt!~ijr@cpe-24-166-106-174.neo.res.rr.com) has quit (Ping timeout: 248 seconds) | |
[11:46:31] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has joined #mythtv | |
[13:53:46] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has quit (Ping timeout: 240 seconds) | |
[15:04:16] | ijc: | Would anyone be willing to apply the patch from https://code.mythtv.org/trac/ticket/12950 (and ideally backport to fixes/29). It's assigned to wagnerrp but, assuming that is Raymond Wagner, he doesn't seem to have been active since 2004. |
[15:04:16] | ijc: | I would cc Bill Meek or Peter Bennett who have touched the code recently but they aren't only. (@markspieth has but only the ttvdb stuff not the Myth API bindings) |
[15:04:16] | ijc: | Not entirely sure if I should be making a GH PR these days, https://www.mythtv.org/wiki/Submitting_Bug_Fixes doesn't say to but it looks like people do... |
[15:18:14] | peterbennett (peterbennett!~Peter@mythtv/developer/peterbennett) has joined #mythtv | |
[15:20:59] | peterbennett: | ijc: I will take a look at your patch, although mythmusic is not an area I have used |
[15:21:37] | peterbennett: | ijc: I prefer a patch to a pull request |
[15:24:35] | ijc: | @peterbennet: Thanks, I appreciate it! Hopefully the explanation is pretty convincing even if you are familiar with the area. |
[15:24:35] | ijc: | While I'm here I think https://code.mythtv.org/trac/ticket/13130 (which I just filed) might be something in your wheelhouse given your involvement in https://code.mythtv.org/trac/ticket/13084? (also /cc @markspieth) |
[15:30:23] | peterbennett: | ijc: I see you are patching the test cases. Does that replace or mesh with the patch in faginbagin's githib repo that she had recommended? |
[15:34:10] | ijc: | peterbennett: I wasn't aware of faginbagin's change, so neither I suppose :-( |
[15:35:35] | peterbennett: | ijc: It is mentioned in the same ticket, and it fixes a test that is around the eclipse program so I guess you duplicated her work. |
[15:37:07] | peterbennett: | ijc: Any reason you did not use a single patch file for all the patches? |
[15:37:22] | ijc: | So I see, I hadn't made the link for some reason. |
[15:37:22] | ijc: | Fix in https://github.com/faginbagin/mythtv/commit/0 . . . f5dc73123447 looks different to mine though, I know mine works so maybe things have changed again. |
[15:37:41] | ijc: | I thought best practice was one change per patch/commit, I could collapse it if you prefer. |
[15:38:09] | peterbennett: | I think you should be able to commit them all at once? |
[15:39:49] | peterbennett: | Unless they address separate issues or there may be a reason for including some patches without the others. |
[15:40:57] | ijc: | First two fix two individual test cases, the next three are three independent issues but cumulatively they fix the test case added by the final patch. |
[15:40:57] | ijc: | I'm happy to squash if that is how things are done in MythTV (in the Linux kernel workflow I'd get shouted at for collapsing them) |
[15:41:58] | peterbennett: | No its fine I see you have them all nicely named for what they do. |
[15:42:42] | peterbennett: | So you work on the Linux kernel? |
[15:43:26] | ijc: | Not so much in the last couple of years, but in my last job I working on the Xen hypervisor and associated Linux support. |
[15:44:50] | peterbennett: | OK I will take a look at it. There are a few incompatibilities with the new ttvdb and it would be good to straighten them out. Thanks. |
[15:45:18] | ijc: | Thanks! |
[15:51:57] | peterbennett (peterbennett!~Peter@mythtv/developer/peterbennett) has quit (Quit: Leaving.) | |
[15:53:59] | peterbennett (peterbennett!~peter@2601:183:100:764c:d151:ea8b:a42:3941) has joined #mythtv | |
[16:56:52] | peterbennett (peterbennett!~peter@2601:183:100:764c:d151:ea8b:a42:3941) has quit (Quit: Leaving.) | |
[18:43:49] | SteveGoodey: | !seen stuarta |
[18:43:50] | MythLogBot: | stuarta was last seen 2 days 2 hours 31 minutes 28 seconds ago |
[18:47:29] | SteveGoodey: | stuarta: Looks like smolt is out to lunch again. |
[20:30:56] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has joined #mythtv | |
[21:14:56] | SteveGoodey (SteveGoodey!~steve@host86-151-149-106.range86-151.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
[23:14:32] | markspieth: | ijc: looks good. |
[23:15:22] | markspieth: | I got a hauppauge quadhd 885 (not the one supported in linuxtv) |
[23:15:44] | markspieth: | fixed the driver if anyone cares |
[23:16:40] | markspieth: | there will be some myth patches coming for this as well as there is no support for these multi standar dcards and drivers which dont support legacy ioctls like get signal strength |
[23:18:22] | Hydr0p0nX (Hydr0p0nX!~hydr@66-191-154-200.dhcp.mtgm.al.charter.com) has quit (Ping timeout: 260 seconds) |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.