| Tuesday, July 25th, 2017, 00:10 UTC | ||
| [00:10:43] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [00:11:09] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [00:14:51] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
| [00:16:05] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 240 seconds) | |
| [01:23:13] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [01:23:38] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [01:37:28] | BLZbubba (BLZbubba!~mark@pdpc/supporter/professional/blzbubba) has joined #mythtv | |
| [02:59:40] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [03:00:09] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [05:05:17] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Quit: Konversation terminated!) | |
| [06:41:26] | dekarl1 is now known as dekarl | |
| [07:06:32] | SteveGoodey (SteveGoodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has joined #mythtv | |
| [07:54:57] | frobnic (frobnic!fb@b2b-130-180-11-14.unitymedia.biz) has quit (Ping timeout: 240 seconds) | |
| [07:59:25] | willcooke (willcooke!~willcooke@host-92-6-128-128.as43234.net) has joined #mythtv | |
| [07:59:25] | willcooke (willcooke!~willcooke@host-92-6-128-128.as43234.net) has quit (Changing host) | |
| [07:59:25] | willcooke (willcooke!~willcooke@ubuntu/member/willcooke) has joined #mythtv | |
| [08:03:03] | Merlin83b (Merlin83b!~Daniel@2a00:1ee0:3:1337:65ef:2f21:76b3:d72c) has joined #mythtv | |
| [08:13:33] | sdrik (sdrik!~sdrik@sdrik.gabriello.fr) has quit (Quit: leaving) | |
| [08:23:10] | willcooke (willcooke!~willcooke@ubuntu/member/willcooke) has quit (Read error: Connection reset by peer) | |
| [08:24:51] | willcooke (willcooke!~willcooke@host-92-6-128-128.as43234.net) has joined #mythtv | |
| [08:24:51] | willcooke (willcooke!~willcooke@host-92-6-128-128.as43234.net) has quit (Changing host) | |
| [08:24:51] | willcooke (willcooke!~willcooke@ubuntu/member/willcooke) has joined #mythtv | |
| [09:13:09] | Warped (Warped!~Warped@unaffiliated/warped) has quit (Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]) | |
| [09:14:50] | Warped (Warped!~Warped@unaffiliated/warped) has joined #mythtv | |
| [09:25:16] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BC68B000A606EFFFE4490F9.dip0.t-ipconnect.de) has quit (Ping timeout: 276 seconds) | |
| [09:59:17] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [10:00:04] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BC68B000A606EFFFE4490F9.dip0.t-ipconnect.de) has joined #mythtv | |
| [10:01:24] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has quit (Max SendQ exceeded) | |
| [10:03:11] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [10:07:49] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has quit (Excess Flood) | |
| [10:10:08] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [10:14:16] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has quit (Max SendQ exceeded) | |
| [10:16:31] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [10:21:08] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has quit (Excess Flood) | |
| [10:23:39] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [10:53:24] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has joined #mythtv | |
| [11:06:08] | stuarta: | must be about time to cut the branch |
| [12:54:03] | Jordack (Jordack!~Jordack@75-151-31-172-Michigan.hfc.comcastbusiness.net) has joined #mythtv | |
| [13:04:37] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has quit (Ping timeout: 255 seconds) | |
| [13:11:30] | stuarta (stuarta!~stuarta@mythtv/developer/stuarta) has joined #mythtv | |
| [14:00:26] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has quit (Quit: Leaving) | |
| [14:30:15] | gregl (gregl!~greg@cpe-66-67-122-101.nycap.res.rr.com) has quit (Quit: Leaving) | |
| [15:04:44] | peterbennett (peterbennett!~peter@2601:183:100:764c:d151:ea8b:a42:3941) has joined #mythtv | |
| [15:08:34] | ** stuarta waves to peterbennett ** | |
| [15:21:47] | peterbennett: | stuarta: Hi there. |
| [15:24:57] | peterbennett: | What is the point of TransMythUIComboBoxSetting ? It is derived from MythUIComboBoxSetting and overrides nothing, adds nothing. |
| [15:31:33] | stuarta: | gbee: any idea ^^^ |
| [15:33:19] | peterbennett: | It is in the new settings stuff in standardsettings.cpp, and used a lot. |
| [15:38:14] | peterbennett: | Also TransMythUICheckBoxSetting, TransMythUISpinBoxSetting |
| [15:38:53] | gbee: | stuarta: no, seems like it was added purely for the new settings, so it was post my involvement |
| [15:39:45] | peterbennett: | Actually others also like HostSpinBoxSetting: public MythUISpinBoxSetting and many others that as the same thing. |
| [15:41:10] | gbee: | seems like it might have been transitional, the old UI had lots of stuff like 'Host{widget}' which were only different in so far as they saved settings for that host only and not global settings |
| [15:41:59] | gbee: | it was a real mess, and my best guess is that whoever worked on the new stuff stubbed out some new classes to mirror the old ones and maybe later realised that they weren't necessary |
| [15:42:20] | peterbennett: | My guess is they defined multiple sets of each class thinking they may have different needs but did not. |
| [15:42:43] | gbee: | yes |
| [15:42:52] | gbee is now known as stuartm | |
| [15:44:01] | stuartm: | the old stuff was not a model I would have copied, it was a viper's nest. I would not be at all suprised that it caused some confusion for whoever worked on the new implementation |
| [15:45:08] | peterbennett: | It was Xavier Hervy and Jonatan Lindblad |
| [15:45:51] | peterbennett: | Anyway I was just wondering it I was missing something important but I guess not. |
| [15:46:09] | stuartm: | right, thank you, my memory isn't what it used to be. I knew Jonatan had finished it off, and Xavier had started it, wasn't sure if someone else had also contributed |
| [15:46:40] | stuartm: | peterbennett: I can take a look, but I don't expect I'll see something there that you missed |
| [15:49:16] | peterbennett: | It looks like we could remove a bunch of class definitions and replace with things like #define TransMythUIComboBoxSetting MythUIComboBoxSetting |
| [15:49:30] | peterbennett: | I dont know if that would save any space |
| [15:50:11] | stuarta: | peterbennett: if you have some more code incoming, i'll hold off branching fixes/29 |
| [15:50:12] | stuartm: | I'd probably go further and just do a search/replace to remove all mentions of those classes |
| [15:50:27] | stuartm: | keeping them around would just add to confusion |
| [15:52:26] | peterbennett: | stuarta: I am working on #13061 , I would not suggest holding it up for that - |
| [15:52:26] | ** MythLogBot http://code.mythtv.org/trac/ticket/13061 ** | |
| [15:52:48] | stuarta: | peterbennett: okay, if i do branch, you'll have to cherry-pick across |
| [15:53:29] | peterbennett: | Cleaning up those classes maybe we do later, i should discuss it with Jonatan first. |
| [15:53:37] | stuartm: | where are those classes defined? |
| [15:53:59] | stuartm: | I'm looking at github and can't seem to find them |
| [15:54:02] | peterbennett: | libs/libmyth/standardsettings.h |
| [15:54:12] | peterbennett: | Only in master |
| [15:54:22] | stuartm: | eww, libmyth, that will be why |
| [15:54:50] | peterbennett: | Something special about libmyth ? |
| [15:54:56] | stuarta: | = old |
| [15:55:37] | stuartm: | peterbennett: well were (I) was trying to get rid of it, it was a dumping ground for a whole bunch of unrelated things and caused some circular linking |
| [15:56:53] | stuartm: | I spent a couple of years slowly teasing it all apart, creating new libs like libmythbase and others to house everything in a more logical fashion |
| [15:58:16] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has joined #mythtv | |
| [15:58:37] | stuartm: | as stuarta noted, a lot of stuff in libmyth was also obsolete |
| [15:59:38] | hampton: | There are a number of duplicated *UISpinBoxSetting classes as well. The only thing they do is modify the first parameter to the underlying class. |
| [15:59:45] | peterbennett: | I would guess there is obsolete stuff around from the old settings, which we probably should get rid of after tit is in place |
| [16:02:08] | peterbennett: | s/tit/it/ |
| [16:05:20] | hampton: | The MythUISpinBoxSetting class also has a allow_single_step boolean parameter that never gets used. (And 20 or so calls to construct objects split evenly across both states.) Any idea whether that is relevant in the new system? Wondering if I should add a patch to remove it, or learn enough about the gui widgets to add support (whatever that means). |
| [16:07:00] | peterbennett: | hampton: did you pull the latest from master? I just added support for that parameter a coupl of days ago. |
| [16:09:53] | peterbennett: | hampton: see the comment in MythUISpinBoxSetting::MythUISpinBoxSetting |
| [16:10:52] | ikevin (ikevin!~kevin@aye-aye.dedibiz.fr) has quit (Ping timeout: 240 seconds) | |
| [16:12:52] | ikevin (ikevin!~kevin@aye-aye.dedibiz.fr) has joined #mythtv | |
| [16:21:25] | hampton: | I just checked. I'm 29 commits behind, so about a month. I'd been holding off on rebasing hoping some of the cleanup patches on my pull request might go in. |
| [16:22:01] | hampton: | I had mostly finished with gcc6 errors, and recently switched to clang and gcc7. I think it was clang that complained about that parameter. |
| [16:22:04] | hampton: | I'll rebase tonight. |
| [16:24:26] | peterbennett (peterbennett!~peter@2601:183:100:764c:d151:ea8b:a42:3941) has quit (Quit: Leaving.) | |
| [16:27:06] | peterbennett (peterbennett!~peter@c-75-67-203-208.hsd1.ma.comcast.net) has joined #mythtv | |
| [16:27:49] | stuarta: | hampton: probably need to get some of those in |
| [16:29:27] | gbee (gbee!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [16:29:47] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has quit (Remote host closed the connection) | |
| [16:30:28] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [16:30:58] | gregl (gregl!~greg@cpe-66-67-122-101.nycap.res.rr.com) has joined #mythtv | |
| [16:36:43] | sphery (sphery!~mdean@mythtv/developer/sphery) has quit (Ping timeout: 260 seconds) | |
| [16:36:58] | sphery (sphery!~mdean@mythtv/developer/sphery) has joined #mythtv | |
| [16:42:51] | hampton: | If you're looking at the unused parameter patches in pull request 134, I started by looking at general classes of issues. As I got more familiar with the code and with git tools, the commit messages in later patches of the series point to a particular commit where a variable became unused. If any of the fixees need to be reworked, just let me know. |
| [16:48:35] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has quit (Ping timeout: 240 seconds) | |
| [16:55:23] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has joined #mythtv | |
| [16:57:05] | Merlin83b (Merlin83b!~Daniel@2a00:1ee0:3:1337:65ef:2f21:76b3:d72c) has quit (Quit: Leaving) | |
| [17:01:56] | peterbennett (peterbennett!~peter@c-75-67-203-208.hsd1.ma.comcast.net) has quit (Quit: Leaving.) | |
| [17:09:17] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has quit (Ping timeout: 260 seconds) | |
| [17:09:23] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BC68B000A606EFFFE4490F9.dip0.t-ipconnect.de) has quit (Ping timeout: 246 seconds) | |
| [17:11:00] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BC68B000A606EFFFE4490F9.dip0.t-ipconnect.de) has joined #mythtv | |
| [18:22:46] | stuartm (stuartm!~stuartm@cpc95496-derb17-2-0-cust390.8-3.cable.virginm.net) has joined #mythtv | |
| [18:22:46] | stuartm (stuartm!~stuartm@cpc95496-derb17-2-0-cust390.8-3.cable.virginm.net) has quit (Changing host) | |
| [18:22:46] | stuartm (stuartm!~stuartm@mythtv/developer/stuartm) has joined #mythtv | |
| [18:23:10] | gbee (gbee!~stuartm@mythtv/developer/stuartm) has quit (Ping timeout: 240 seconds) | |
| [18:37:24] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has joined #mythtv | |
| [19:03:52] | KooeeeeennN (KooeeeeennN!~koen@145.129.50.182) has quit (Ping timeout: 240 seconds) | |
| [19:08:31] | KooeeeeennN (KooeeeeennN!~koen@145.129.50.182) has joined #mythtv | |
| [19:09:29] | peterbennett (peterbennett!~Peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [19:17:59] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BC68B000A606EFFFE4490F9.dip0.t-ipconnect.de) has quit (Ping timeout: 255 seconds) | |
| [19:31:37] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [19:32:03] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [19:43:35] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has quit (Ping timeout: 240 seconds) | |
| [19:45:53] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has joined #mythtv | |
| [19:51:04] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [19:51:26] | gigem: | peterbennett: git annotate can often help decipher unusual code. It gives the most recent commit id for each line of code. Once you've got the ids, you can look up the commit messages and hopefully see what the committer was thinking at the time. |
| [19:51:32] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [19:51:59] | peterbennett: | gigem: yes sure |
| [19:53:02] | peterbennett: | I think I have it figured out |
| [19:59:26] | willcooke_ (willcooke_!~willcooke@host-92-6-128-128.as43234.net) has joined #mythtv | |
| [20:02:03] | peterbennett: | I have another problem , giving me trouble – I added a new method to ProfileItem and the linker cannot find it undefined reference to `ProfileItem::checkRange(QString, float, bool*) const |
| [20:02:16] | willcooke (willcooke!~willcooke@ubuntu/member/willcooke) has quit (Ping timeout: 276 seconds) | |
| [20:02:56] | peterbennett: | It is there and finds it for calls within the same module |
| [20:04:31] | hampton: | You need to find the right macro (like MBASE_PUBLIC) to mark the function as exported. |
| [20:05:46] | peterbennett: | Oh, hmmm |
| [20:06:07] | hampton: | I differs depending on the directory/library that your function is in. |
| [20:06:11] | hampton: | It.. |
| [20:06:38] | peterbennett: | strangely, some methods are found and others not although none have that |
| [20:07:32] | peterbennett: | MTV_PUBLIC on the class, maybe |
| [20:07:47] | hampton: | Not sure then. I had a similar problem and the missing macro fixed it for me. |
| [20:07:50] | peterbennett: | Yes that fixed it |
| [20:08:21] | peterbennett: | But I dont understand why other methods on the class were working .. anyway thanks.. |
| [20:12:57] | peterbennett (peterbennett!~Peter@mythtv/developer/peterbennett) has left #mythtv () | |
| [20:56:51] | Roklobster (Roklobster!~Dirkka@119-18-8-177.cust.aussiebb.net) has joined #mythtv | |
| [21:02:43] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has quit (Ping timeout: 276 seconds) | |
| [21:05:50] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [21:12:43] | Steve-Goodey (Steve-Goodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [21:19:13] | willcooke_ (willcooke_!~willcooke@host-92-6-128-128.as43234.net) has quit (Quit: Do your hobbies) | |
| [21:20:37] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [21:21:06] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [21:30:44] | Vollstrecker (Vollstrecker!~vollstrec@p200300E19BC68B000A606EFFFE4490F9.dip0.t-ipconnect.de) has joined #mythtv | |
| [21:35:41] | Jordack (Jordack!~Jordack@75-151-31-172-Michigan.hfc.comcastbusiness.net) has quit () | |
| [21:36:07] | SteveGoodey (SteveGoodey!~steve@host86-138-103-133.range86-138.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [22:22:21] | gregl (gregl!~greg@cpe-66-67-122-101.nycap.res.rr.com) has quit (Remote host closed the connection) | |
| [22:31:06] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [22:31:32] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [22:40:33] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [22:40:59] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [22:47:09] | gregl (gregl!~greg@cpe-66-67-122-101.nycap.res.rr.com) has joined #mythtv | |
| [23:18:02] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Remote host closed the connection) | |
| [23:18:30] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [23:51:54] | deep-book-gk_ (deep-book-gk_!~1wm_su@101-170.furanet.com) has joined #mythtv | |
| [23:52:57] | deep-book-gk_ (deep-book-gk_!~1wm_su@101-170.furanet.com) has left #mythtv () | |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.