| Saturday, November 19th, 2016, 00:02 UTC | ||
| [00:02:58] | zZap-X (zZap-X!~zZap-X@gateway/vpn/privateinternetaccess/zzap-x) has left #mythtv () | |
| [00:54:07] | Warped_ (Warped_!~Warped@108.85.160.119) has joined #mythtv | |
| [00:55:14] | Warped (Warped!~Warped@unaffiliated/warped) has quit (Ping timeout: 258 seconds) | |
| [01:14:42] | Warped_ (Warped_!~Warped@108.85.160.119) has quit (Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]) | |
| [01:15:45] | Warped (Warped!~Warped@unaffiliated/warped) has joined #mythtv | |
| [03:09:48] | SteveGoodey (SteveGoodey!~steve@host86-154-46-109.range86-154.btcentralplus.com) has joined #mythtv | |
| [03:18:29] | joki (joki!~joki@p54861A6B.dip0.t-ipconnect.de) has quit (Ping timeout: 244 seconds) | |
| [03:53:35] | SteveGoodey (SteveGoodey!~steve@host86-154-46-109.range86-154.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [04:06:45] | MythBuild: | build #198 of master-ubuntu-testing-64bit is complete: Failure [4failed unit test core] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/198 blamelist: Jean-Yves Avenard <jyavenard@mozilla.com > |
| [04:22:24] | amessina (amessina!~amessina@unaffiliated/amessina) has quit (Quit: Konversation terminated!) | |
| [04:30:59] | dekarl1 (dekarl1!~dekarl@mythtv/developer/dekarl) has joined #mythtv | |
| [04:31:35] | dekarl (dekarl!~dekarl@mythtv/developer/dekarl) has quit (Ping timeout: 268 seconds) | |
| [05:22:21] | Roklobster (Roklobster!~Dirkka@ppp118-209-57-1.lns20.mel4.internode.on.net) has quit (Remote host closed the connection) | |
| [06:02:18] | tgm4883 (tgm4883!uid23806@ubuntu/member/tgm4883) has quit (Quit: Connection closed for inactivity) | |
| [06:03:23] | Chutt_ (Chutt_!~ijr@2605:a000:1208:c087:e871:eb7b:97d2:3fde) has joined #mythtv | |
| [06:07:16] | Chutt (Chutt!~ijr@2605:a000:1208:c087:d412:fc3:b237:ce67) has quit (Ping timeout: 258 seconds) | |
| [07:50:09] | Tobbe5178 (Tobbe5178!~asdf@81-235-209-146-no62.tbcn.telia.com) has quit (Read error: Connection reset by peer) | |
| [07:55:27] | SteveGoodey (SteveGoodey!~steve@host86-154-46-109.range86-154.btcentralplus.com) has joined #mythtv | |
| [07:56:50] | Tobbe5178 (Tobbe5178!~asdf@2001:2002:51eb:d192:a9ab:93:7d2c:dba1) has joined #mythtv | |
| [07:59:59] | Roklobster (Roklobster!~Dirkka@ppp118-209-57-1.lns20.mel4.internode.on.net) has joined #mythtv | |
| [09:02:16] | dekarl1 is now known as dekarl | |
| [09:30:53] | mad_enz (mad_enz!~mad_enz@2607:f090:488d:2ab:89ed:30fe:7671:35fc) has quit (Ping timeout: 245 seconds) | |
| [09:44:03] | mad_enz (mad_enz!~mad_enz@2607:f090:488d:2ab:c56c:b071:5a13:eb9a) has joined #mythtv | |
| [12:25:47] | Roklobster (Roklobster!~Dirkka@ppp118-209-57-1.lns20.mel4.internode.on.net) has quit (Remote host closed the connection) | |
| [14:28:11] | amessina (amessina!~amessina@unaffiliated/amessina) has joined #mythtv | |
| [15:30:32] | joki- (joki-!~joki@p548607E8.dip0.t-ipconnect.de) has joined #mythtv | |
| [15:42:33] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has quit (Quit: Leaving) | |
| [15:50:21] | pppingme (pppingme!~pppingme@unaffiliated/pppingme) has joined #mythtv | |
| [15:58:30] | tgm4883 (tgm4883!uid23806@ubuntu/member/tgm4883) has joined #mythtv | |
| [16:24:02] | peper03 (peper03!~peper03@mythtv/developer/peper03) has joined #mythtv | |
| [16:49:21] | joki- (joki-!~joki@p548607E8.dip0.t-ipconnect.de) has quit (Ping timeout: 258 seconds) | |
| [17:00:32] | joki- (joki-!~joki@p548607E8.dip0.t-ipconnect.de) has joined #mythtv | |
| [18:36:34] | MythBuild: | build #199 of master-ubuntu-testing-64bit is complete: Success [3build successful] Build details are at http://code.mythtv.org/buildbot/builders/mast . . . t/builds/199 |
| [22:16:14] | SteveGoodey (SteveGoodey!~steve@host86-154-46-109.range86-154.btcentralplus.com) has quit (Quit: Konversation terminated!) | |
| [22:19:34] | rich0_ (rich0_!~quassel@gentoo/developer/rich0) has joined #mythtv | |
| [22:21:37] | rich0 (rich0!~quassel@gentoo/developer/rich0) has quit (Ping timeout: 240 seconds) | |
| [22:49:21] | joki- (joki-!~joki@p548607E8.dip0.t-ipconnect.de) has quit (Ping timeout: 260 seconds) | |
| [23:42:50] | peterbennett (peterbennett!~Peter@mythtv/developer/peterbennett) has joined #mythtv | |
| [23:46:36] | peterbennett: | jya: Good morning |
| [23:47:02] | jya: | peterbennett: hi |
| [23:47:20] | peterbennett: | setConfiguration(const QNetworkConfiguration &config) |
| [23:48:17] | peterbennett: | jya: Pass value by reference, I am not an expert, i thought that was similar to passing by pointer – that the original object is passed not a copy of it |
| [23:48:37] | jya: | It isn't in usage. |
| [23:49:32] | peterbennett: | jya: Yes the usage is different but I think the effect is the same. You pass an object instead of a pointer but under the covers it garbs the object. |
| [23:49:37] | jya: | The object is const& it can only be copied from that point on. As there's no guarantee the object will still be live by the time the caller continue |
| [23:49:53] | jya: | Define garbs |
| [23:50:06] | peterbennett: | Sorry grabs |
| [23:50:27] | jya: | It can't. |
| [23:50:33] | jya: | Imagine doing this: |
| [23:50:38] | jya: | { |
| [23:51:05] | jya: | QNetworkConfiguration blah; |
| [23:51:23] | jya: | setConfiguration(blah); |
| [23:51:26] | jya: | } |
| [23:51:50] | jya: | If it had "grabbed" the data. Blah went out of scope. |
| [23:52:08] | jya: | If you were to continue using it; that UAF (use after free) |
| [23:52:27] | peterbennett: | Yes that would cause a problem unless the setConfiguration made a copy I think. |
| [23:52:41] | jya: | Exactly, it makes a copy |
| [23:52:54] | jya: | so right now you allocate on the heap |
| [23:53:32] | jya: | But never delete it. So setConfiguration made a copy, and the original is now in limbo. Will no longer be used and never be deleted |
| [23:53:35] | jya: | That's a leak |
| [23:54:15] | jya: | I'm on my phone. Son not the best place to type. |
| [23:55:07] | jya: | Passing by const reference, is like passing by value without the memory copy. It's aim for methods that will not need to use the argument once they exit. |
| [23:56:23] | jya: | If you want to keep it, you must copy it. If you kept a pointer to the object; or a reference to it: it would be very bad. It's actually a security risk now as you allow your code to read data that has been freed and is no longer referenced. |
| [23:57:25] | peterbennett: | Is it possible that this bad thing is what QT is doing? |
| [23:59:38] | peterbennett: | Or at least in the default case where you do not set it, maybe it is sharing one configuration object between multiple instances of QNetworkAccessManager |
| [23:59:51] | peterbennett: | I suppose I need to look at QT source |
IRC Logs collected by
BeirdoBot.
Please use the above link to report any bugs.