MythLogBot@irc.freenode.net :: #mythtv-theming

Daily chat history

Current users (13):

brfransen, Captain_Murdoch, jpabq, mrand, MythLogBot, PatrickDickey, peper03, skd5aner, sphery, stuartm, tgm4883, tonsofpcs, wagnerrp
Sunday, September 29th, 2013, 02:05 UTC
[02:05:28] peper03_ (peper03_!~peper03@mythtv/developer/peper03) has joined #mythtv-theming
[02:08:27] peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 248 seconds)
[02:08:27] peper03_ is now known as peper03
[08:40:39] PatrickDickey (PatrickDickey!~quassel@2001:470:1f11:830:78b1:a68d:f5f5:ea68) has joined #mythtv-theming
[09:46:11] paul-h (paul-h!~Paul@90.216.186.38) has joined #mythtv-theming
[10:01:31] peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 248 seconds)
[10:01:39] peper03_ (peper03_!~peper03@mythtv/developer/peper03) has joined #mythtv-theming
[10:01:41] peper03_ is now known as peper03
[17:42:58] tgm4883: where does the terra theme pull it's group text from in the recordings screen?
[17:45:19] tgm4883: nm, this is all kinds of screwed up
[17:49:55] stuartm: tgm4883: it should not be resized twice, I couldn't begin to explain what you are seeing
[17:53:17] natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has joined #mythtv-theming
[17:53:19] stuartm: the group info is pretty screwed up, it re-uses the same textareas as the recording info, which is just wrong but not something that can be fixed in older releases without breaking existing themes (if I remember then it will get fixed for 0.28)
[17:55:51] peper03_ (peper03_!~peper03@mythtv/developer/peper03) has joined #mythtv-theming
[17:59:23] peper03 (peper03!~peper03@mythtv/developer/peper03) has quit (Ping timeout: 248 seconds)
[17:59:23] peper03_ is now known as peper03
[18:15:59] tgm4883: stuartm, ah ok, that is probably what I'm seeing then
[18:16:17] tgm4883: stuartm, I'm not sure what is going on then with the fanart then
[18:16:45] tgm4883: like I said, I'm guessing on it being resized twice. It's definitely doing something to the artwork and looks very bad
[18:24:25] stuartm: tgm4883: what resolution is the image in the themecache e.g. for an artwork which was originally 1920x1080?
[18:25:06] stuartm: it definitely doesn't scale images twice, but there may be some issue with the size it's scaling them to
[18:25:22] tgm4883: stuartm, let me check
[18:26:52] stuartm: tgm4883: are you specifying a size component in the <area> of 1920,1080 ? I.e. instead of 7680x4320?
[18:27:21] tgm4883: no, i'm doing 100%
[18:30:02] tgm4883: stuartm, so I just pulled the same image from the themecache for the 1280x720 vs the 7680x4320 themes. Both pulled from my frontend serving a 1920x1080 TV
[18:30:15] tgm4883: Both images are 1920x1080 resolution
[18:30:26] tgm4883: but one is quite a bit less quality
[18:30:32] tgm4883: I can imagebin if you want to see them
[18:30:43] stuartm: can't hurt
[18:31:19] stuartm: can you try replacing the 100% with a pixel size?
[18:31:50] tgm4883: 1280 theme http://imagebin.org/272294
[18:32:15] tgm4883: 8k theme http://imagebin.org/272295
[18:32:25] tgm4883: both images were resized to 1920x1080
[18:32:57] tgm4883: stuartm, I can try using a pixelsize instead of 100%, but I'd have to use the full 7680x4320 since it's suppose to cover the full background
[18:34:07] stuartm: tgm4883: that's what I meant, I want to see if somehow it's mishandling the percentage
[18:34:15] tgm4883: ok, let me do that
[18:35:23] stuartm: is the imagetype inherited?
[18:37:49] tgm4883: stuartm, just tried it. Looks the same (bad)
[18:37:58] tgm4883: here is the top of my recordings file http://pastebin.ubuntu.com/6172404/
[18:38:06] tgm4883: so not inherited
[19:23:40] natanojl: stuartm, tgm4883 : I couldn't resist looking into this ;) I think this section is the problem, http://code.mythtv.org/cgit/mythtv/tree/mytht . . . er.cpp#n1369
[19:33:50] stuartm: natanojl: yeah that's certainly not right any more, assumes that all images loaded are theme images and must be scaled according to the multipliers
[19:34:28] stuartm: I'd forgotten that code was still used, wanted rid of it years ago!
[19:35:57] tgm4883: This is why I'm thankful you guys are around. I'm not entirely sure what I'm looking at. Now if it was Python, I'd at least have a chance
[19:37:40] stuartm: natanojl: hence the comment at line 319 of mythimage.cpp – "// FIXME: Get rid of LoadScaleImage"
[19:43:58] natanojl: stuartm: hehe
[19:46:53] stuartm: I still have a feeling that this was somehow broken more recently, although I suspect that's just wishful thinking and that it was in fact an oversight
[19:47:30] stuartm: it's fairly obvious now that we _are_ double scaling and that it's completely broken :(
[19:55:02] stuartm: OK, guess it's time to ditch LoadScaleImage :)
[20:20:05] PatrickDickey (PatrickDickey!~quassel@2001:470:1f11:830:78b1:a68d:f5f5:ea68) has quit (Remote host closed the connection)
[20:22:35] PatrickDickey (PatrickDickey!~quassel@2001:470:1f11:830:78b1:a68d:f5f5:ea68) has joined #mythtv-theming
[22:01:49] stuartm: tgm4883: I have a patch you can try for the scaling issue, it's experimental and it could take a while to uncover any breakage
[22:02:08] stuartm: natanojl: you're welcome to try it too, the more testing it gets the better
[22:03:08] stuartm: http://pastebin.com/erRpm60j
[22:09:52] natanojl: stuartm: I'll give it a spin tomorrow, it's time to sleep now
[22:17:16] natanojl (natanojl!~jonatan@mythtv/developer/natanojl) has quit (Ping timeout: 256 seconds)
[22:27:17] paul-h (paul-h!~Paul@90.216.186.38) has quit (Quit: Konversation terminated!)

IRC Logs collected by BeirdoBot.
Please use the above link to report any bugs.